| *** narispo has quit IRC | 00:16 | |
| *** narispo has joined #buildstream | 00:16 | |
| *** narispo has quit IRC | 00:19 | |
| *** narispo has joined #buildstream | 00:19 | |
| *** narispo has quit IRC | 00:32 | |
| *** narispo has joined #buildstream | 00:33 | |
| *** narispo has quit IRC | 02:23 | |
| *** narispo has joined #buildstream | 02:28 | |
| *** narispo has quit IRC | 02:41 | |
| *** narispo has joined #buildstream | 02:41 | |
| *** narispo has quit IRC | 04:03 | |
| *** narispo has joined #buildstream | 04:04 | |
| *** narispo has quit IRC | 04:46 | |
| *** narispo has joined #buildstream | 04:48 | |
| *** narispo has quit IRC | 05:08 | |
| *** narispo has joined #buildstream | 05:09 | |
| *** narispo has quit IRC | 05:28 | |
| *** narispo has joined #buildstream | 05:28 | |
| *** narispo has quit IRC | 05:33 | |
| *** narispo has joined #buildstream | 05:34 | |
| *** akvilebirgelyte has joined #buildstream | 07:41 | |
| *** traveltissues has joined #buildstream | 07:55 | |
| *** bochecha has joined #buildstream | 08:08 | |
| *** ikerperez has joined #buildstream | 08:12 | |
| *** traveltissues has quit IRC | 08:32 | |
| *** tiagogomes has joined #buildstream | 08:38 | |
| *** adds68 has joined #buildstream | 08:42 | |
| *** santi has joined #buildstream | 08:50 | |
| *** qinusty has joined #buildstream | 08:50 | |
| *** jonathanmaw has joined #buildstream | 09:04 | |
| *** rdale has quit IRC | 09:19 | |
| *** rdale has joined #buildstream | 09:22 | |
| *** lachlan has joined #buildstream | 09:30 | |
| juergbi | test suite with buildbox-run: 1401 passed, 14 skipped, 4 xfailed, 32 warnings in 294.22s (0:04:54) | 10:40 |
|---|---|---|
| tlater[m] | juergbi: Do you happen to know why we need to `__update_cache_keys()` after `__update_source-state()`? | 10:49 |
| * tlater[m] feels like those two would be mostly independent | 10:49 | |
| juergbi | tlater[m]: the source keys are part of the element cache key calculation | 10:49 |
| tlater[m] | Ah | 10:49 |
| tlater[m] | That's a good point | 10:49 |
| benschubert | juergbi: using the bwrap thing around it? | 11:07 |
| juergbi | benschubert: yes | 11:07 |
| benschubert | awesome! | 11:07 |
| juergbi | so not testing userchroot itself yet but all of the rest | 11:07 |
| juergbi | benschubert: btw: userchroot complains if it's owned by group root | 11:09 |
| juergbi | what group is it commonly assigned to? | 11:09 |
| benschubert | juergbi: did you setgid it? It should not, it should only be setuid :) | 11:09 |
| juergbi | no, I used your docker file and got that error message | 11:10 |
| benschubert | oh interesting | 11:10 |
| benschubert | I didn't get that | 11:10 |
| benschubert | are you calling it with user root? | 11:10 |
| juergbi | ah, I might have as I was just testing from docker | 11:10 |
| juergbi | that explains it. the error message is a bit confusing, though | 11:11 |
| benschubert | agreed | 11:11 |
| benschubert | their error messages are really bad :) | 11:11 |
| *** traveltissues has joined #buildstream | 11:12 | |
| juergbi | benschubert: have you had a chance to test freedesktop-sdk bst show with the FetchTree branch? #1126 | 11:59 |
| gitlab-br-bot | Issue #1126: Cache resolution is slow https://gitlab.com/BuildStream/buildstream/issues/1126 | 11:59 |
| *** santi has quit IRC | 12:13 | |
| *** santi has joined #buildstream | 12:24 | |
| benschubert | sadly not, I'll do this by the end of the week :) | 12:35 |
| juergbi | ta | 12:43 |
| gitlab-br-bot | tlater opened (was WIP) MR !1660 (tlater/annihilate_update_state->master: Remove update_state) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1660 | 13:03 |
| *** traveltissues has quit IRC | 13:09 | |
| *** phildawson_ has quit IRC | 13:44 | |
| *** phildawson_ has joined #buildstream | 13:44 | |
| *** lachlan has quit IRC | 13:47 | |
| *** lachlan has joined #buildstream | 13:55 | |
| * tpollard realises that Resolved Key Summary is no longer shown after bst build | 13:59 | |
| tpollard | seemingly for a long long time | 14:01 |
| tlater[m] | juergbi: Looks like we don't need to initialize there, I wonder how I got that idea | 14:01 |
| tlater[m] | Looks like the if was just a noop | 14:01 |
| tlater[m] | Good catch, ta! | 14:01 |
| juergbi | tlater[m]: great. I think there are multiple rdep initialize state cases. is this true for all? | 14:02 |
| tlater[m] | Two of them so far | 14:02 |
| tlater[m] | I think | 14:03 |
| tlater[m] | Halfway through testing the second | 14:03 |
| tlater[m] | I think the others will still need to initialize, simply because the elements are actually initialized in those cases. | 14:03 |
| gitlab-br-bot | tpollard opened issue #1180 (Resolved Key Summary is not displayed in the end summary) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1180 | 14:09 |
| benschubert | tpollard: isn't that normally only when new keys are discovered? That is when a track is involved? | 14:09 |
| tpollard | or if the source is changed? | 14:14 |
| benschubert | the source changed? | 14:14 |
| tpollard | maybe I've got some odd behaviour going on here.... | 14:16 |
| gitlab-br-bot | tpollard closed issue #1180 (Resolved Key Summary is not displayed in the end summary) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1180 | 14:17 |
| benschubert | I'm not sure what's the correct behavior there, but it seems sensible to me not to show it if nothing has changed (no --track) | 14:19 |
| tpollard | yeh I think we must have actively decided that since 1.1 at some point | 14:20 |
| tpollard | makes sense to me | 14:20 |
| gitlab-br-bot | aevri opened (was WIP) MR !1657 (aevri/enable_spawn_ci_5->master: job pickling: also pickle global state in node.pyx) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1657 | 14:56 |
| *** bochecha has quit IRC | 15:15 | |
| *** lachlan has quit IRC | 15:17 | |
| tlater[m] | juergbi: Do you expect there to be any other things that interact with the old workspace handling? | 15:28 |
| * tlater[m] has looked through, and tested removing the occasional workspace reference, but it doesn't look like it | 15:28 | |
| juergbi | tlater[m]: I've noted the 3 things that I saw so far, but I will have to do some more reviewing | 15:31 |
| tlater[m] | Ok | 15:31 |
| tlater[m] | Thanks a lot for looking through this :) | 15:31 |
| *** santi has quit IRC | 15:41 | |
| gitlab-br-bot | juergbi opened MR !1667 (juerg/casd-connect->master: cascache.py: Defer attempt to connect to casd until socket file exists) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1667 | 15:57 |
| *** santi has joined #buildstream | 16:03 | |
| *** lachlan has joined #buildstream | 16:04 | |
| juergbi | tlater[m]: that link in the commit just shows me the whole diff. you probably wanted to point to a line but that doesn't seem to work | 16:05 |
| tlater[m] | Oh, grmbl | 16:05 |
| tlater[m] | juergbi: This link should work: https://gitlab.com/BuildStream/buildstream/merge_requests/1645/diffs#d10b1e972922f297b08c3c672d861e73ef4e75f1_50_265 | 16:06 |
| tlater[m] | If not, casserver.py:265 | 16:06 |
| juergbi | still didn't work, even tried in firefox and chrome | 16:06 |
| juergbi | ok | 16:06 |
| juergbi | maybe because the file was automatically collapsed | 16:07 |
| * tlater[m] thinks it's probably because that diff is collapsed and gitlab screws up | 16:07 | |
| tpollard | the best feature.... | 16:07 |
| juergbi | tlater[m]: resolve_digest() is independent of refs, though, isn't it? | 16:07 |
| tlater[m] | snappish | 16:07 |
| tlater[m] | juergbi: I was mostly leaving that for reference, tbf, once I replace that with FetchTree it's a moot point | 16:08 |
| juergbi | true | 16:08 |
| tlater[m] | No, it uses object_path | 16:09 |
| tlater[m] | I could have duplicated the logic, but I didn't want to :) | 16:09 |
| *** santi has quit IRC | 17:01 | |
| *** lachlan has quit IRC | 17:07 | |
| *** narispo has quit IRC | 17:08 | |
| *** narispo has joined #buildstream | 17:08 | |
| *** tiagogomes has quit IRC | 17:15 | |
| *** jonathanmaw has quit IRC | 17:51 | |
| *** narispo has quit IRC | 18:22 | |
| *** narispo has joined #buildstream | 18:24 | |
| *** slaf has quit IRC | 18:27 | |
| *** slaf_ has joined #buildstream | 18:27 | |
| *** slaf has joined #buildstream | 18:27 | |
| *** slaf has joined #buildstream | 18:27 | |
| *** slaf has joined #buildstream | 18:27 | |
| *** slaf has joined #buildstream | 18:28 | |
| *** slaf has joined #buildstream | 18:28 | |
| *** slaf has joined #buildstream | 18:28 | |
| *** slaf has joined #buildstream | 18:28 | |
| *** narispo has quit IRC | 21:53 | |
| *** narispo has joined #buildstream | 21:53 | |
| *** slaf has quit IRC | 22:13 | |
| *** slaf has joined #buildstream | 22:13 | |
| *** slaf has joined #buildstream | 22:13 | |
| *** slaf has joined #buildstream | 22:13 | |
| *** slaf has joined #buildstream | 22:14 | |
| *** slaf has joined #buildstream | 22:14 | |
| *** slaf has joined #buildstream | 22:14 | |
| *** slaf has joined #buildstream | 22:14 | |
| *** slaf has joined #buildstream | 22:15 | |
| *** slaf has joined #buildstream | 22:15 | |
| *** slaf has joined #buildstream | 22:15 | |
| *** slaf has joined #buildstream | 22:15 | |
| *** slaf has joined #buildstream | 22:16 | |
| *** slaf has joined #buildstream | 22:16 | |
| *** slaf has joined #buildstream | 22:16 | |
| *** slaf has joined #buildstream | 22:17 | |
| *** slaf has joined #buildstream | 22:17 | |
| *** slaf has joined #buildstream | 22:17 | |
| *** slaf has joined #buildstream | 22:18 | |
| *** slaf has joined #buildstream | 22:18 | |
| *** slaf has joined #buildstream | 22:18 | |
| *** slaf has joined #buildstream | 22:18 | |
| *** slaf has joined #buildstream | 22:19 | |
| *** narispo has quit IRC | 22:24 | |
| *** narispo has joined #buildstream | 22:24 | |
| *** narispo has quit IRC | 23:25 | |
| *** narispo has joined #buildstream | 23:25 | |
| *** narispo has quit IRC | 23:48 | |
| *** narispo has joined #buildstream | 23:48 | |
| *** narispo has quit IRC | 23:51 | |
| *** narispo has joined #buildstream | 23:51 | |
| *** narispo has quit IRC | 23:57 | |
| *** narispo has joined #buildstream | 23:57 | |
| *** narispo has quit IRC | 23:59 | |
| *** narispo has joined #buildstream | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!