| *** toscalix has joined #buildstream | 00:29 | |
| *** narispo has quit IRC | 01:20 | |
| *** narispo has joined #buildstream | 01:20 | |
| *** narispo has quit IRC | 03:21 | |
| *** narispo has joined #buildstream | 03:21 | |
| *** tristan has joined #buildstream | 04:38 | |
| *** traveltissues has joined #buildstream | 07:37 | |
| *** slaf has quit IRC | 07:44 | |
| *** slaf has joined #buildstream | 07:45 | |
| *** slaf has joined #buildstream | 07:45 | |
| *** slaf has joined #buildstream | 07:45 | |
| *** slaf has joined #buildstream | 07:45 | |
| *** slaf has joined #buildstream | 07:46 | |
| *** slaf has quit IRC | 07:46 | |
| *** slaf has joined #buildstream | 07:46 | |
| *** slaf has joined #buildstream | 07:46 | |
| *** slaf has joined #buildstream | 07:46 | |
| *** slaf has joined #buildstream | 07:47 | |
| *** slaf has joined #buildstream | 07:47 | |
| *** slaf has joined #buildstream | 07:47 | |
| *** slaf has joined #buildstream | 07:47 | |
| *** slaf has joined #buildstream | 07:48 | |
| *** slaf has joined #buildstream | 07:48 | |
| *** slaf has joined #buildstream | 07:48 | |
| *** slaf has joined #buildstream | 07:49 | |
| *** slaf has joined #buildstream | 07:49 | |
| *** slaf has joined #buildstream | 07:49 | |
| *** slaf has joined #buildstream | 07:49 | |
| *** slaf has joined #buildstream | 07:50 | |
| *** slaf has quit IRC | 07:50 | |
| *** slaf has joined #buildstream | 07:50 | |
| *** slaf has joined #buildstream | 07:50 | |
| benschubert | traveltissues: impressive optimisation on the bst show cached side :) | 08:23 |
|---|---|---|
| traveltissues | thanks, i'm glad it seems to be a bit faster now | 08:24 |
| *** tiagogomes has joined #buildstream | 08:33 | |
| benschubert | juergbi: I'm fixing the bug for the empty build trees (!1145). What do you think is best for fixing? Not generate a build tree if it only contains directories? Or if only one empty dir/ | 08:35 |
| benschubert | ? | 08:35 |
| *** tpollard has joined #buildstream | 08:37 | |
| benschubert | juergbi: sorry I meant, let's just not push it if it's just a directory? | 08:40 |
| juergbi | benschubert: I wouldn't block pushing, as it could still be useful for debugging (as the logs would still be pushed) | 08:41 |
| benschubert | good point | 08:42 |
| benschubert | so just yield 0 files then | 08:42 |
| juergbi | benschubert: the direct issue that triggers the exceptions is that the build tree digest is an empty string and we treat it as valid digest, right? | 08:42 |
| benschubert | https://gitlab.com/BuildStream/buildstream/-/jobs/312260834 here is a stack trace | 08:42 |
| juergbi | hm, here the issue happens with artifact_proto.files, though | 08:43 |
| benschubert | so I guess that is correct, we are treating it as a valid string | 08:43 |
| juergbi | not the build tree | 08:43 |
| benschubert | oh | 08:43 |
| juergbi | yes, I think we should simply make this conditional on 'files' being valid / not empty | 08:44 |
| benschubert | and I guess it also happens for the artifact proto since we haven't pushed anything? But we do already have empty artifacts no? | 08:44 |
| juergbi | I thought 'files' is always empty on failed build | 08:45 |
| juergbi | not sure why existing tests are not catching that, or what's different | 08:46 |
| benschubert | good point, so did I miss something in my tests? | 08:46 |
| juergbi | ah, I think we normally create the output directory before the command actually runs | 08:48 |
| juergbi | so we would normally capture an empty directory even if the command fails | 08:49 |
| juergbi | however, if it fails before even attempting to execute the command (because 'sh' is missing), we might not have created that directory yet | 08:49 |
| benschubert | ah Is ee | 08:49 |
| benschubert | which means we are missing a test for the missing shell with cached build trees | 08:50 |
| juergbi | sounds like it | 08:50 |
| benschubert | ok I'll add this then | 08:50 |
| benschubert | and then I'll look into whether we are correct for empty build trees or not :) | 08:51 |
| benschubert | juergbi: by the way if you have time, I'd appreciate your review on !1621 and !1620 | 08:51 |
| gitlab-br-bot | MR !1621: Propagate buildstream's log level to buildbox-casd https://gitlab.com/BuildStream/buildstream/merge_requests/1621 | 08:51 |
| gitlab-br-bot | MR !1620: Listen for casd failures and abort the run when they happen https://gitlab.com/BuildStream/buildstream/merge_requests/1620 | 08:51 |
| juergbi | I was just about to look at these :) | 08:52 |
| *** bochecha has joined #buildstream | 08:53 | |
| benschubert | awesome thanks :D | 08:53 |
| *** tiagogomes has quit IRC | 08:53 | |
| gitlab-br-bot | traveltissues approved MR !1621 (bschubert/propagate-log-level-to-casd->master: Propagate buildstream's log level to buildbox-casd) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1621 | 08:54 |
| *** tiagogomes has joined #buildstream | 08:55 | |
| juergbi | traveltissues: do you know why test_workspace_visible fails now? is this covered by an open issue? | 09:00 |
| *** jonathanmaw has joined #buildstream | 09:02 | |
| *** narispo has quit IRC | 09:06 | |
| *** narispo has joined #buildstream | 09:07 | |
| *** lachlan has joined #buildstream | 09:08 | |
| *** lachlan has quit IRC | 09:24 | |
| traveltissues | juergbi, i thought i had opened an issue for that, i will open one now | 09:27 |
| *** tristan has quit IRC | 09:27 | |
| traveltissues | it fails since the state of source caching for open workspaces has changed | 09:27 |
| traveltissues | it's a strict xfail atm | 09:27 |
| *** lachlan has joined #buildstream | 09:28 | |
| gitlab-br-bot | traveltissues opened issue #1159 (Follow-up from "element.py: remove call to _source_cached()" -- test_workspace_visible changed to XFAIL) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1159 | 09:30 |
| *** slaf has quit IRC | 09:49 | |
| *** slaf has joined #buildstream | 09:54 | |
| *** slaf has joined #buildstream | 09:54 | |
| *** slaf has joined #buildstream | 09:54 | |
| *** slaf has joined #buildstream | 09:54 | |
| *** slaf has joined #buildstream | 09:55 | |
| *** slaf has joined #buildstream | 09:55 | |
| *** slaf has joined #buildstream | 09:55 | |
| *** lachlan has quit IRC | 09:58 | |
| gitlab-br-bot | chiaratolentino opened MR !1626 (chiaratolentino/fix-docs->master: Chiaratolentino/fix docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 09:58 |
| *** lachlan has joined #buildstream | 10:00 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1626 (chiaratolentino/fix-docs->master: Fix incorrectly displaying bst output in docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 10:14 |
| *** narispo has quit IRC | 10:45 | |
| *** narispo has joined #buildstream | 10:46 | |
| *** traveltissues has quit IRC | 10:46 | |
| *** traveltissues has joined #buildstream | 10:46 | |
| *** lachlan has quit IRC | 10:54 | |
| *** lachlan has joined #buildstream | 10:55 | |
| *** lachlan has quit IRC | 11:06 | |
| *** lachlan has joined #buildstream | 11:12 | |
| *** lachlan has quit IRC | 11:39 | |
| *** lachlan has joined #buildstream | 11:41 | |
| *** narispo has quit IRC | 11:57 | |
| *** narispo has joined #buildstream | 11:57 | |
| *** lachlan has quit IRC | 12:15 | |
| *** tristan has joined #buildstream | 12:49 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1627 (bschubert/fix-xdg-temppaths->master: setup.cfg: Fix xdg env vars to not affect the host) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1627 | 12:57 |
| benschubert | tristan: ^ mind taking a look? | 12:57 |
| *** lachlan has joined #buildstream | 13:21 | |
| gitlab-br-bot | tpollard opened issue #1160 (Investigate what is needed to support 'spawning' the scheduler as a subprocess) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1160 | 13:36 |
| *** lachlan has quit IRC | 14:02 | |
| *** lachlan has joined #buildstream | 14:04 | |
| *** lachlan has quit IRC | 14:08 | |
| *** lachlan has joined #buildstream | 14:08 | |
| gitlab-br-bot | tlater approved MR !1626 (chiaratolentino/fix-docs->master: Fix incorrectly displaying bst output in docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 14:19 |
| traveltissues | benschubert, are you seeing wsl failures on master for tests/integration/compose-symlinks.py? | 14:23 |
| benschubert | traveltissues: do we run integration tests on WSL? Oo | 14:24 |
| traveltissues | no on non-master branches | 14:24 |
| traveltissues | not* | 14:24 |
| traveltissues | most are skipped | 14:25 |
| benschubert | I mean, I know we are running unit tests | 14:25 |
| benschubert | but I thought we were skipping integration ones since they need a sandbox? | 14:25 |
| benschubert | All our runners for the nightly tests are down? | 14:25 |
| *** tlater has joined #buildstream | 14:26 | |
| tpollard | hmm the nightly instance on DO id showing as alive | 14:27 |
| traveltissues | those are failing on my local wsl following !1611 | 14:27 |
| gitlab-br-bot | MR !1611: Use buildbox-casd CaptureTree() to import directories https://gitlab.com/BuildStream/buildstream/merge_requests/1611 | 14:28 |
| traveltissues | maybe i have the wrong version of casd | 14:28 |
| benschubert | tpollard: oh they seem back up. Thanks :) | 14:28 |
| benschubert | traveltissues: yeah you need at least tag 0.0.3 | 14:28 |
| gitlab-br-bot | BenjaminSchubert approved MR !1626 (chiaratolentino/fix-docs->master: Fix incorrectly displaying bst output in docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 14:30 |
| traveltissues | that was it | 14:31 |
| traveltissues | good | 14:31 |
| gitlab-br-bot | traveltissues opened (was WIP) MR !1628 (traveltissues/1159->master: Defer workspace source commits) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1628 | 14:31 |
| benschubert | traveltissues: ^ I dislike the idea of having a setter for the key a low | 14:33 |
| benschubert | *a lot | 14:33 |
| benschubert | I'm also not sure of what's happening there, mind explaining? :) | 14:33 |
| traveltissues | the key needs to be set before the commit to source cache so that it can be correctly associated with the current srcfiles | 14:35 |
| traveltissues | i need to go for a bit but we can discuss on the mr or later on | 14:36 |
| benschubert | ok thanks | 14:36 |
| *** lachlan has quit IRC | 14:56 | |
| *** narispo has quit IRC | 14:59 | |
| *** lachlan has joined #buildstream | 15:03 | |
| *** narispo has joined #buildstream | 15:04 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1629 (bschubert/fix-windows-symlink->master: tests/frontend/buildcheckout.py: Create required symlinks on the fly) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1629 | 15:05 |
| benschubert | jjardon: hey, would you have any idea by chance what version of mesa this is https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-19.08.3/elements/extensions/mesa-aco/mesa.bst ? the ref doesn't exist on the git repository and I thus can't fix the nightly tests. I tried the 17.3.0 and 17.3.3 tags but the subsequent patches don't apply | 15:25 |
| *** lachlan has quit IRC | 15:29 | |
| *** narispo has quit IRC | 15:37 | |
| *** narispo has joined #buildstream | 15:42 | |
| tpollard | benschubert: have you tried the 17.3-branchpoint tag? | 15:45 |
| benschubert | tpollard: I haven't, let me try that | 15:49 |
| benschubert | tpollard: actually is this just tracking master but using a very old tag? | 15:50 |
| tpollard | that's how I'm reading it | 15:50 |
| benschubert | ok thanks! | 15:51 |
| tpollard | nice to see that the time for show dropped down again on the weekly benchmarks | 15:54 |
| tlater | Interesting that showing takes longer for cached than un-cached elements though | 15:55 |
| benschubert | tlater[m]: we need to go through all elements's blobs to see if the cas has them | 15:58 |
| tpollard | and the pipeline widget has no do more work if we're not incosistent | 15:59 |
| tpollard | s/no/to | 15:59 |
| *** tpollard has quit IRC | 16:04 | |
| benschubert | valentind: actually, since you made the PR: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/1833 what commit should I pin given that the commit doesn't exist anymore? | 16:05 |
| *** narispo has quit IRC | 16:09 | |
| *** narispo has joined #buildstream | 16:09 | |
| *** lachlan has joined #buildstream | 16:10 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1626 (chiaratolentino/fix-docs->master: Fix incorrectly displaying bst output in docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 16:22 |
| *** lachlan has quit IRC | 16:26 | |
| valentind | benschubert, just track it. | 16:27 |
| *** lachlan has joined #buildstream | 16:27 | |
| benschubert | ok | 16:28 |
| gitlab-br-bot | BenjaminSchubert approved MR !1628 (traveltissues/1159->master: Defer workspace source commits) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1628 | 16:34 |
| *** lachlan has quit IRC | 16:35 | |
| *** lachlan has joined #buildstream | 16:36 | |
| gitlab-br-bot | marge-bot123 closed issue #1141 (Freedesktop SDK example in documentation is broken on master) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1141 | 16:37 |
| gitlab-br-bot | marge-bot123 merged MR !1626 (chiaratolentino/fix-docs->master: Fix incorrectly displaying bst output in docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1626 | 16:37 |
| * tlater wants to add some info about marge to https://wiki.gnome.org/action/login/Projects/BuildStream/Infrastructure | 16:43 | |
| tlater | How would I do that? | 16:43 |
| *** lachlan has quit IRC | 16:48 | |
| *** lachlan has joined #buildstream | 16:49 | |
| gitlab-br-bot | traveltissues opened issue #1161 (Follow-up from "Defer workspace source commits") on buildstream https://gitlab.com/BuildStream/buildstream/issues/1161 | 17:00 |
| *** lachlan has quit IRC | 17:13 | |
| *** lachlan has joined #buildstream | 17:23 | |
| *** jonathanmaw has quit IRC | 17:24 | |
| *** lachlan has quit IRC | 17:24 | |
| *** tlater has quit IRC | 17:31 | |
| gitlab-br-bot | marge-bot123 closed issue #1155 (Support buildbox-casd log levels) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1155 | 17:49 |
| gitlab-br-bot | marge-bot123 merged MR !1621 (bschubert/propagate-log-level-to-casd->master: Propagate buildstream's log level to buildbox-casd) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1621 | 17:49 |
| *** traveltissues has quit IRC | 17:55 | |
| *** milloni has quit IRC | 18:32 | |
| *** milloni has joined #buildstream | 18:33 | |
| *** milloni has quit IRC | 18:34 | |
| *** milloni has joined #buildstream | 18:39 | |
| *** milloni has joined #buildstream | 18:42 | |
| *** milloni has joined #buildstream | 18:45 | |
| *** milloni has quit IRC | 18:52 | |
| *** milloni has joined #buildstream | 18:58 | |
| *** milloni has quit IRC | 19:05 | |
| *** milloni has joined #buildstream | 19:06 | |
| *** milloni has joined #buildstream | 19:08 | |
| *** lachlan has joined #buildstream | 19:10 | |
| *** milloni has quit IRC | 19:11 | |
| *** milloni has joined #buildstream | 19:15 | |
| *** lachlan has quit IRC | 19:35 | |
| *** lachlan has joined #buildstream | 19:36 | |
| *** lachlan has quit IRC | 20:32 | |
| jjardon | benschubert: sorry about that; fix coming here: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/1918 | 23:31 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!