*** mattiasb has quit IRC | 01:10 | |
*** connorshea[m] has quit IRC | 01:10 | |
*** gimpnet-irc[m] has quit IRC | 01:10 | |
*** Demos[m] has quit IRC | 01:10 | |
*** segfault3[m] has quit IRC | 01:10 | |
*** mrmcq2u[m] has quit IRC | 01:10 | |
*** mattiasb has joined #buildstream | 01:19 | |
*** connorshea[m] has joined #buildstream | 01:20 | |
*** gimpnet-irc[m] has joined #buildstream | 01:31 | |
*** Demos[m] has joined #buildstream | 01:51 | |
*** segfault3[m] has joined #buildstream | 02:02 | |
*** mrmcq2u[m] has joined #buildstream | 02:12 | |
*** narispo has quit IRC | 06:53 | |
*** narispo has joined #buildstream | 06:54 | |
laurence | juergbi, we discussed yesterday about BazelCon. The registration page is https://blog.bazel.build/2019/09/30/bazelcon-update.html | 07:56 |
---|---|---|
*** tpollard has joined #buildstream | 08:29 | |
*** jonathanmaw has joined #buildstream | 08:57 | |
*** tiagogomes has joined #buildstream | 09:03 | |
ikerperez | I am trying to create a freedesktop-sdk junctiom from an specific branch instead of frpm 19.. | 09:19 |
ikerperez | 09 | 09:19 |
ikerperez | I am having a problem when building about a missing module " The following submodules exist but are not specified in the source description | 09:19 |
ikerperez | 09:19 | |
ikerperez | Submodule URL 'https://gitlab.com/freedesktop-sdk/buildstream-abi-checker.git' at path 'utils/buildstream-abi-checker' | 09:19 |
ikerperez | " | 09:19 |
ikerperez | So I added like this: https://paste.gnome.org/p5dzs2uhj | 09:21 |
ikerperez | Any clue about how to solve this? | 09:21 |
*** bochecha has joined #buildstream | 09:30 | |
*** lachlan has joined #buildstream | 09:31 | |
*** traveltissues has quit IRC | 09:31 | |
*** narispo has quit IRC | 09:33 | |
*** narispo has joined #buildstream | 09:33 | |
*** lachlan has quit IRC | 09:44 | |
*** lachlan has joined #buildstream | 09:49 | |
*** segfault3[m] has quit IRC | 10:07 | |
*** Demos[m] has quit IRC | 10:07 | |
*** paulsherwood has quit IRC | 10:07 | |
*** benschubert has quit IRC | 10:07 | |
*** Kinnison has quit IRC | 10:07 | |
*** raoul has quit IRC | 10:07 | |
*** narispo has quit IRC | 10:07 | |
*** bochecha has quit IRC | 10:07 | |
*** qinusty has quit IRC | 10:07 | |
*** ikerperez has quit IRC | 10:07 | |
*** adds68 has quit IRC | 10:07 | |
*** jward has quit IRC | 10:07 | |
*** rdale has quit IRC | 10:07 | |
*** phil has quit IRC | 10:07 | |
*** mohan43u has quit IRC | 10:07 | |
*** SotK has quit IRC | 10:07 | |
*** hergertme has quit IRC | 10:07 | |
*** lantw44 has quit IRC | 10:07 | |
*** gitlab-br-bot has quit IRC | 10:07 | |
*** Trevinho has quit IRC | 10:07 | |
*** lachlan has quit IRC | 10:07 | |
*** tiagogomes has quit IRC | 10:07 | |
*** jonathanmaw has quit IRC | 10:07 | |
*** mrmcq2u[m] has quit IRC | 10:07 | |
*** gimpnet-irc[m] has quit IRC | 10:07 | |
*** connorshea[m] has quit IRC | 10:07 | |
*** mattiasb has quit IRC | 10:07 | |
*** coldtom has quit IRC | 10:07 | |
*** WSalmon has quit IRC | 10:07 | |
*** valentind has quit IRC | 10:07 | |
*** slaf has quit IRC | 10:07 | |
*** jswagner has quit IRC | 10:07 | |
*** dineshdb[m] has quit IRC | 10:07 | |
*** verdre[m] has quit IRC | 10:07 | |
*** waltervargas[m] has quit IRC | 10:07 | |
*** rafaelff[m] has quit IRC | 10:07 | |
*** dbuch has quit IRC | 10:07 | |
*** asingh_[m] has quit IRC | 10:07 | |
*** Trevinho[m] has quit IRC | 10:07 | |
*** skullone[m] has quit IRC | 10:07 | |
*** kailueke[m] has quit IRC | 10:07 | |
*** theawless[m] has quit IRC | 10:07 | |
*** reuben640[m] has quit IRC | 10:07 | |
*** swick has quit IRC | 10:07 | |
*** flatmush has quit IRC | 10:07 | |
*** juergbi has quit IRC | 10:07 | |
*** benbrown has quit IRC | 10:07 | |
*** kapip has quit IRC | 10:07 | |
*** aevri has quit IRC | 10:07 | |
*** krichter[m] has quit IRC | 10:07 | |
*** albfan[m] has quit IRC | 10:07 | |
*** tlater[m] has quit IRC | 10:07 | |
*** cgmcintyre[m] has quit IRC | 10:07 | |
*** nielsdg has quit IRC | 10:07 | |
*** doras has quit IRC | 10:07 | |
*** awacheux[m] has quit IRC | 10:07 | |
*** jjardon[m] has quit IRC | 10:07 | |
*** m_22[m] has quit IRC | 10:07 | |
*** abderrahim[m] has quit IRC | 10:07 | |
*** pro[m] has quit IRC | 10:07 | |
*** ssssam[m] has quit IRC | 10:07 | |
*** tchaik[m] has quit IRC | 10:07 | |
*** jjardon has quit IRC | 10:07 | |
*** lchlan has quit IRC | 10:07 | |
*** persia has quit IRC | 10:07 | |
*** ironfoot has quit IRC | 10:07 | |
*** Kinnison has joined #buildstream | 10:07 | |
*** lachlan has joined #buildstream | 10:07 | |
*** narispo has joined #buildstream | 10:07 | |
*** bochecha has joined #buildstream | 10:07 | |
*** tiagogomes has joined #buildstream | 10:07 | |
*** jonathanmaw has joined #buildstream | 10:07 | |
*** mrmcq2u[m] has joined #buildstream | 10:07 | |
*** segfault3[m] has joined #buildstream | 10:07 | |
*** Demos[m] has joined #buildstream | 10:07 | |
*** gimpnet-irc[m] has joined #buildstream | 10:07 | |
*** connorshea[m] has joined #buildstream | 10:07 | |
*** mattiasb has joined #buildstream | 10:07 | |
*** coldtom has joined #buildstream | 10:07 | |
*** qinusty has joined #buildstream | 10:07 | |
*** paulsherwood has joined #buildstream | 10:07 | |
*** ikerperez has joined #buildstream | 10:07 | |
*** adds68 has joined #buildstream | 10:07 | |
*** jward has joined #buildstream | 10:07 | |
*** WSalmon has joined #buildstream | 10:07 | |
*** valentind has joined #buildstream | 10:07 | |
*** benschubert has joined #buildstream | 10:07 | |
*** slaf has joined #buildstream | 10:07 | |
*** rdale has joined #buildstream | 10:07 | |
*** phil has joined #buildstream | 10:07 | |
*** jswagner has joined #buildstream | 10:07 | |
*** mohan43u has joined #buildstream | 10:07 | |
*** raoul has joined #buildstream | 10:07 | |
*** SotK has joined #buildstream | 10:07 | |
*** ironfoot has joined #buildstream | 10:07 | |
*** persia has joined #buildstream | 10:07 | |
*** lchlan has joined #buildstream | 10:07 | |
*** jjardon has joined #buildstream | 10:07 | |
*** tchaik[m] has joined #buildstream | 10:07 | |
*** ssssam[m] has joined #buildstream | 10:07 | |
*** pro[m] has joined #buildstream | 10:07 | |
*** abderrahim[m] has joined #buildstream | 10:07 | |
*** m_22[m] has joined #buildstream | 10:07 | |
*** jjardon[m] has joined #buildstream | 10:07 | |
*** awacheux[m] has joined #buildstream | 10:07 | |
*** doras has joined #buildstream | 10:07 | |
*** nielsdg has joined #buildstream | 10:07 | |
*** cgmcintyre[m] has joined #buildstream | 10:07 | |
*** tlater[m] has joined #buildstream | 10:07 | |
*** albfan[m] has joined #buildstream | 10:07 | |
*** krichter[m] has joined #buildstream | 10:07 | |
*** aevri has joined #buildstream | 10:07 | |
*** irc.gimp.ca sets mode: +oo ironfoot jjardon | 10:07 | |
*** kapip has joined #buildstream | 10:07 | |
*** benbrown has joined #buildstream | 10:07 | |
*** flatmush has joined #buildstream | 10:07 | |
*** juergbi has joined #buildstream | 10:07 | |
*** swick has joined #buildstream | 10:07 | |
*** reuben640[m] has joined #buildstream | 10:07 | |
*** theawless[m] has joined #buildstream | 10:07 | |
*** kailueke[m] has joined #buildstream | 10:07 | |
*** skullone[m] has joined #buildstream | 10:07 | |
*** Trevinho[m] has joined #buildstream | 10:07 | |
*** asingh_[m] has joined #buildstream | 10:07 | |
*** dbuch has joined #buildstream | 10:07 | |
*** rafaelff[m] has joined #buildstream | 10:07 | |
*** waltervargas[m] has joined #buildstream | 10:07 | |
*** verdre[m] has joined #buildstream | 10:07 | |
*** dineshdb[m] has joined #buildstream | 10:07 | |
*** hergertme has joined #buildstream | 10:07 | |
*** lantw44 has joined #buildstream | 10:07 | |
*** gitlab-br-bot has joined #buildstream | 10:07 | |
*** Trevinho has joined #buildstream | 10:07 | |
ikerperez | https://paste.gnome.org/pestmn1lz | 10:13 |
tlater[m] | ikerperez: Long shot, but maybe make it utils/buildstream-abi-checker? | 10:14 |
tlater[m] | In the submodules: definition | 10:15 |
ikerperez | tlater[m] that fixed error about the submodule, now I have this "Could not find file at /home/ikerpalomar/.cache/buildstream/build/freedesktop-sdk-3ccigvbf/include/build-flags.yml | 10:17 |
ikerperez | " . I thought that buildstream creates those directories for the cache | 10:17 |
ikerperez | I will create a bst file just for the abi-checker | 10:17 |
tlater[m] | ikerperez: That should definitely be created for you. If you're on master, we're having some issues with buildbox-casd occasionally crashing and not picking parts of our artifacts, maybe you're running into that? | 10:18 |
tlater[m] | I'd remove the artifact in question and try again. If that doesn't work, yeah, separate element is probably necessary. | 10:19 |
ikerperez | Maybe, I will try to switch from master | 10:25 |
ikerperez | thanks | 10:25 |
*** lachlan has quit IRC | 10:26 | |
tlater[m] | ikerperez: Sorry about that, fixing the casd issues is pretty high up on our priority list - it's a fairly recent addition | 10:32 |
*** lachlan has joined #buildstream | 10:39 | |
*** lachlan has quit IRC | 10:49 | |
*** lachlan has joined #buildstream | 10:50 | |
ikerperez | tlater[m] it seems that it wasn't related to buildstream but to freedesktop | 10:53 |
tlater[m] | Ah, at least you've figured it out :) | 10:53 |
tlater[m] | Some sort of hardlink? | 10:54 |
benschubert | Hey, I'm trying to get some better error messaging around buildbox-casd. I'd like to have an output with the last X lines (respecting the message-lines flag) and showing the path to the log file. I did it like https://gitlab.com/BuildStream/buildstream/merge_requests/1616/diffs#eee68cb7737cd5a69ac2b8ddcf0119307cf48977_950_983 for now, but that only shows the error message, nothing more. Any ideas how I can get the correct | 11:09 |
benschubert | messaging in place? | 11:09 |
benschubert | ah my bad, I do get the output | 11:15 |
benschubert | not the path to the log file though :/ | 11:15 |
benschubert | and I have my answer, the logfile from 'message' is not used for these code paths. My bad | 11:18 |
tpollard | :S | 11:20 |
gitlab-br-bot | BenjaminSchubert opened (was WIP) MR !1616 (bschubert/casd-logs->master: cascache.py: Save casd logs in a file for retrieval) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1616 | 11:25 |
benschubert | tlater[m]: juergbi ^ the logs we were talking about yesterday :) | 11:25 |
*** lachlan has quit IRC | 11:33 | |
*** lachlan has joined #buildstream | 11:35 | |
*** lachlan has quit IRC | 11:42 | |
*** lachlan has joined #buildstream | 11:49 | |
juergbi | benschubert: great, will take a look, but not sure I can get to it today | 11:51 |
tlater[m] | benschubert: Why cas/logs and not logs/cas? | 11:51 |
tlater[m] | The problem is potential project names, isn't it? | 11:51 |
* tlater[m] isn't sure he likes the location, but it's probably the most sensible | 11:51 | |
*** lachlan has quit IRC | 12:08 | |
benschubert | Yep, we have no guarantees nobody will create a casd project :( | 12:14 |
benschubert | tlater[m]: yep it's quite small :D | 12:36 |
benschubert | I'll be adding two followups MRs for the rest we wanted to do | 12:36 |
tlater[m] | Awesome :) | 12:36 |
benschubert | juergbi: thanks! The MR should be fairly quick anyways :) | 12:37 |
benschubert | tlater[m]: https://gitlab.com/snippets/1901060 autotermination on casd's death :D | 12:55 |
tlater[m] | benschubert: > Exit code: 0 | 12:56 |
benschubert | not entirely good yet | 12:56 |
tlater[m] | I imagine this is you manually killing it or somesuch? | 12:56 |
benschubert | correct | 12:56 |
benschubert | however I realized that if you ctrl +c buildstream then 'continue', casd dies | 12:57 |
tlater[m] | Oh, that's interesting | 12:57 |
benschubert | *sobs* | 12:57 |
tpollard | yep | 12:58 |
tpollard | we can't recover from it | 12:58 |
benschubert | tpollard: did you already open an issue for that by any chance? | 12:58 |
tpollard | probably similar to https://gitlab.com/BuildStream/buildstream/issues/1120 | 12:58 |
tpollard | handling a failed job with the interrupt handle seems to recover though | 12:59 |
tpollard | just not the user SIGINT | 12:59 |
benschubert | yep | 12:59 |
benschubert | I'll look into that today | 12:59 |
*** lachlan has joined #buildstream | 13:27 | |
*** jonathanmaw has quit IRC | 13:27 | |
*** lachlan has quit IRC | 13:34 | |
*** lachlan has joined #buildstream | 13:41 | |
benschubert | https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/43 a bug in the ostree plugin | 13:43 |
tlater[m] | benschubert: `Path` consistency is one of my bigger pet peeves with buildstream's codebase atm, heh | 13:49 |
benschubert | tlater[m]: you mean, let's move everything to Path? :) | 13:49 |
tlater[m] | I'd love that | 13:51 |
tlater[m] | But well, it'd be a pain | 13:51 |
benschubert | yep | 13:51 |
benschubert | what do you prefer for the PR ? | 13:51 |
tlater[m] | I think in that particular case I'd prefer reading the file with `open()` and `.read()` in a separate block. | 13:51 |
tlater[m] | But then the `Path.read_text()` function is so neat here... | 13:51 |
*** lachlan has quit IRC | 13:51 | |
tlater[m] | I think we should stay consistent and stick to `open` if we're not going to use `Path` | 13:52 |
benschubert | Ok, I'll change this | 13:52 |
tlater[m] | But I'm not opinionated enough to say that that's how it should be done - think that's a good general rule of thumb? | 13:52 |
benschubert | Yeah, I'm not sure either | 13:53 |
benschubert | Path is so much simpler and less error prone | 13:53 |
benschubert | but that would require lots of changes on the codebase | 13:53 |
tlater[m] | Oh well, I suppose it's a very minor nit on this particular PR anyway | 13:56 |
tlater[m] | Some day I'll make a big PR and move over everything | 13:56 |
benschubert | tlater[m]: updated! | 13:58 |
tlater[m] | :) | 14:00 |
tlater[m] | benschubert: Oh, you oopsied an unused import into there | 14:02 |
tlater[m] | Pylint will probably complain in a moment... | 14:03 |
benschubert | fixed | 14:03 |
gitlab-br-bot | tlater approved MR !1616 (bschubert/casd-logs->master: cascache.py: Save casd logs in a file for retrieval) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1616 | 14:03 |
benschubert | I'll still wait for a second look from juergbi then I'll hand to marge then :) thanks! | 14:06 |
gitlab-br-bot | BenjaminSchubert opened MR !1620 (bschubert/casd-listen-failures->master: Listen for casd failures and abort the run when they happen) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1620 | 14:06 |
tlater[m] | Oh, is that the other part of this? You're quick, benschubert | 14:07 |
benschubert | wait for it ;) | 14:07 |
gitlab-br-bot | BenjaminSchubert opened MR !1621 (bschubert/propagate-log-level-to-casd->master: Propagate buildstream's log level to buildbox-casd) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1621 | 14:09 |
benschubert | tlater[m]: ^ and here, which means all of what we discussed yesterday :D | 14:10 |
benschubert | Now, the sigint | 14:12 |
*** lachlan has joined #buildstream | 14:17 | |
tlater[m] | benschubert: Actually, looking through those first couple commits again because gitlab puts them in the same diff... | 14:27 |
tlater[m] | Maybe `_get_log_file` should be `_rotate_logfiles` because the former sounds side-effect free | 14:28 |
tlater[m] | While it clearly isn't. Don't want to call it multiple times | 14:29 |
benschubert | fair, I'll change to "rotate_and_get_next_logfile()" ? | 14:29 |
tlater[m] | Maybe make it two functions? | 14:30 |
*** lachlan has quit IRC | 14:30 | |
benschubert | I don't think that is really needed :) | 14:31 |
tlater[m] | Then that's probably fine | 14:31 |
benschubert | wait, I'll just create the filename outside the method | 14:31 |
benschubert | ah, not ideal though | 14:32 |
benschubert | I'll keep the 'rotate_and_get' | 14:32 |
tlater[m] | Yeah, it's an annoying function. You want it to be somewhat atomic and yet it feels like we're doing too much in a single invocation | 14:33 |
tlater[m] | `rotate_and_get` seems fine IMO | 14:33 |
benschubert | that's fine | 14:33 |
benschubert | I've updated it | 14:33 |
*** lachlan has joined #buildstream | 14:35 | |
*** tpollard has quit IRC | 14:36 | |
*** bochecha has quit IRC | 14:47 | |
*** lachlan has quit IRC | 14:48 | |
*** bochecha has joined #buildstream | 14:51 | |
benschubert | tlater[m]: are you familiar with the frontend logging ? :) | 15:03 |
*** lachlan has joined #buildstream | 15:04 | |
tlater[m] | benschubert: I have been, and might be able to spin back up on it - why? | 15:04 |
benschubert | https://gitlab.com/BuildStream/buildstream/merge_requests/1616#note_226164945 I want to have the same output as for a failed task for when buildbox-casd dies | 15:04 |
benschubert | but have been unsuccessful and am not sure what I'm doing wrong | 15:04 |
tlater[m] | benschubert: That should be MessageType.FAIL, no? | 15:07 |
benschubert | doesn't BUG does the same? | 15:08 |
tlater[m] | No | 15:09 |
tlater[m] | Bug is used deliberately for, well, bugs in BuildStream | 15:09 |
tlater[m] | Messages we don't think should happen | 15:09 |
tlater[m] | Which, tbf, I think BUG is correct here | 15:09 |
benschubert | well, buildbox-casd should die no? :) | 15:09 |
tlater[m] | If you want the same behavior as a failed task you need FAIL | 15:09 |
tlater[m] | But I think that buildbox-casd's death is a bug | 15:10 |
benschubert | ah It's https://gitlab.com/BuildStream/buildstream/blob/master/src/buildstream/_frontend/widget.py#L693 correct? | 15:10 |
tlater[m] | But then, I don't think that will be 100% the same either | 15:11 |
tlater[m] | Because it's not a timed task | 15:11 |
tlater[m] | Which buildbox-casd can never be | 15:11 |
tlater[m] | Yup! | 15:11 |
benschubert | gah, seems like super complex to refactor if I want the same behavior | 15:12 |
*** lachlan has quit IRC | 15:12 | |
tlater[m] | benschubert: Do we *expect* buildbox-casd to die? | 15:12 |
benschubert | no | 15:12 |
benschubert | that should _never_ happen | 15:12 |
tlater[m] | I don't think we should change the behavior of BUG | 15:12 |
tlater[m] | We should instead just read the last couple of lines from that file instead | 15:13 |
tlater[m] | BUG deliberately shows the whole trace | 15:13 |
benschubert | fair enough, I don't have a trace there but I'll show the last... 20 lines? | 15:13 |
tlater[m] | Because we don't expect users to ever see it, and we want to see the trace | 15:13 |
tlater[m] | Yeah | 15:13 |
tlater[m] | Just a special case because this particular message is particulalrly big and we can read the log anyway :) | 15:14 |
benschubert | then let's just show the bug with the path to the logs? | 15:14 |
benschubert | reading the last N lines is... unneccessary complex fo rhtis I guess | 15:15 |
*** lachlan has joined #buildstream | 15:15 | |
tlater[m] | Actually, yeah, that's probably fine | 15:15 |
tlater[m] | Although getting the final couple of lines is pretty easy | 15:15 |
tlater[m] | We have a util for that somewhere... | 15:15 |
benschubert | it's in widget.py | 15:16 |
benschubert | that's... not ideal :'D | 15:16 |
tlater[m] | We had a better widget elsewhere | 15:17 |
tlater[m] | Though I can't find it right now | 15:17 |
tlater[m] | Err, util | 15:17 |
tlater[m] | Might have lived in the cross-platform sandbox code for a while | 15:17 |
tlater[m] | Maybe we should add a util that truncates a file/string, add it to util.py and reuse it in widget.py? | 15:18 |
benschubert | let's add it later if we still get many problems? | 15:19 |
benschubert | tlater[m]: would the first iteration like https://gitlab.com/BuildStream/buildstream/merge_requests/1616/diffs be good enough for you then? :) | 15:21 |
*** lachlan has quit IRC | 15:48 | |
gitlab-br-bot | tlater approved MR !1616 (bschubert/casd-logs->master: cascache.py: Save casd logs in a file for retrieval) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1616 | 15:51 |
tlater[m] | benschubert: Yup, sorry, that lgtm | 15:51 |
benschubert | no worries :) | 15:51 |
benschubert | tlater[m]: does https://gitlab.com/BuildStream/buildstream/merge_requests/1621#note_226163916 seems good to you? | 15:51 |
WSalmon | juergbi, valentind i wanted to pull from cache A and checkout then push to cache B some artifacts that were built on a diffrent arch. im using fdsdk so im using 1.2. the issue i have is that i cant push as my artifact never match cache keys. i tried bst --option target_arch aarch64 show freedesktop-sdk.bst:bootstrap/build/base-sdk/image.bst -f "%{name} %{key} %{full-key} %{state} %{config} %{vars}" and i see that there are x86 things leeking in. | 15:54 |
WSalmon | should this work and if so is there a issue that was fixed in master or is outstanding? | 15:54 |
tlater[m] | benschubert: Aren't we just doing the mapping there anyway? | 15:54 |
valentind | WSalmon, yes, because of uname is different. | 15:54 |
valentind | You can trick with a LD_PRELOAD if you want. | 15:54 |
WSalmon | how? | 15:54 |
tlater[m] | Hah | 15:55 |
benschubert | tlater[m]: sure we could, but that means rewriting how --verbose and --debug work :/ | 15:55 |
gitlab-br-bot | marge-bot123 closed issue #1156 (Redirect buildbox-casd log to file) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1156 | 15:55 |
gitlab-br-bot | marge-bot123 merged MR !1616 (bschubert/casd-logs->master: cascache.py: Save casd logs in a file for retrieval) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1616 | 15:55 |
valentind | WSalmon, https://paste.gnome.org/pu7b4juop | 15:56 |
tlater[m] | benschubert: I see what you mean, yeah. | 15:56 |
valentind | I have used that to pull artifacts from other architectures. | 15:56 |
tlater[m] | Eh, just wanted to make sure we're not missing out on a quick improvement. | 15:56 |
tlater[m] | I'll close the discussion, seems good to me, benschubert | 15:56 |
benschubert | tlater[m]: thanks a lot :D | 15:56 |
benschubert | just need to run the benchmarks at home for the scheduler part | 15:57 |
tlater[m] | Ok, I think getting this in today would be wishful thinking anyway ;) | 15:58 |
tlater[m] | WSalmon: I think alternatively you could probably mock your interpreter's os.uname | 15:58 |
tlater[m] | Like modify /usr/bin/bst to first use unittest.mock to change os.uname and then invoke buildstream | 15:59 |
tlater[m] | Overall very hacky, but perhaps a bit less messy | 15:59 |
tlater[m] | Or just write a bst-aarch64, that just mimics what /usr/bin/bst does and overrides os.uname | 15:59 |
tlater[m] | Something something quack | 16:00 |
*** lachlan has joined #buildstream | 16:02 | |
*** bochecha has quit IRC | 16:03 | |
gitlab-br-bot | aevri opened MR !1622 (aevri/job_sort_imports->master: _scheduler/jobs/job.py: sort imports) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1622 | 16:12 |
gitlab-br-bot | aevri opened MR !1623 (aevri/no_win32_fcntl->master: cli.py: no fcntl on Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1623 | 16:15 |
*** lachlan has quit IRC | 16:16 | |
gitlab-br-bot | cs-shadow approved MR !1622 (aevri/job_sort_imports->master: _scheduler/jobs/job.py: sort imports) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1622 | 16:16 |
benschubert | Ok I found out why we have casd failing when we ctrl + c | 16:21 |
benschubert | We are not blocking the signal when we start buildstream | 16:22 |
tlater[m] | Yeah, that'd do it | 16:22 |
tlater[m] | It sounded like it, to be fair | 16:22 |
benschubert | just blocking SIGINT should be enough, correct? | 16:24 |
tlater[m] | benschubert: That's enough to keep C-c from killing buildstream | 16:27 |
tlater[m] | Whether that's what we want is a different question - I think we'll probably accidentally disallow getting into the little abort menu entirely | 16:27 |
tlater[m] | We'll need to use that on specifically the casd subprocess | 16:28 |
tlater[m] | ... But that's probably what you're doing ;p | 16:28 |
benschubert | it is :D | 16:31 |
benschubert | pr almost there ;) | 16:31 |
tlater[m] | benschubert: Do you know if we still have some sort of yaml caching going on? | 16:35 |
benschubert | none :) | 16:35 |
tlater[m] | Grmbl | 16:36 |
*** milloni has quit IRC | 16:36 | |
benschubert | why? | 16:36 |
tlater[m] | I have an exception in the loader that isn't being hit | 16:36 |
*** milloni has joined #buildstream | 16:36 | |
tlater[m] | Guess I'll need to keep digging through the call stack | 16:36 |
gitlab-br-bot | BenjaminSchubert opened MR !1625 (bschubert/casd-sigint->master: Better SIGINT handling for CASD) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1625 | 16:39 |
gitlab-br-bot | tlater approved MR !1625 (bschubert/casd-sigint->master: Better SIGINT handling for CASD) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1625 | 16:41 |
*** lachlan has joined #buildstream | 16:42 | |
tlater[m] | benschubert: You were on a roll today :) | 16:42 |
tlater[m] | Or have been | 16:42 |
tlater[m] | I'm not expecting another MR ;p | 16:42 |
*** lachlan has quit IRC | 16:45 | |
benschubert | there might be one about fixing the overnight tests | 16:47 |
benschubert | but I still need 3h to know if the fix is correct :'D | 16:48 |
benschubert | but yeah, today was a good day for hunting bugs | 16:48 |
*** lachlan has joined #buildstream | 16:52 | |
*** milloni has quit IRC | 16:57 | |
*** milloni has joined #buildstream | 16:57 | |
*** lachlan has quit IRC | 17:19 | |
*** tiagogomes has quit IRC | 17:20 | |
gitlab-br-bot | marge-bot123 merged MR !1622 (aevri/job_sort_imports->master: _scheduler/jobs/job.py: sort imports) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1622 | 17:35 |
*** lachlan has joined #buildstream | 17:42 | |
gitlab-br-bot | marge-bot123 closed issue #1120 (Interrupt handling during a task that involves cascache grpc processes is very flaky) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1120 | 18:22 |
gitlab-br-bot | marge-bot123 merged MR !1625 (bschubert/casd-sigint->master: Better SIGINT handling for CASD) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1625 | 18:22 |
*** narispo has quit IRC | 18:25 | |
*** narispo has joined #buildstream | 18:28 | |
*** phoenix has joined #buildstream | 19:35 | |
*** lachlan has quit IRC | 20:05 | |
*** narispo has quit IRC | 20:17 | |
*** narispo has joined #buildstream | 20:17 | |
*** phoenix has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!