IRC logs for #buildstream for Thursday, 2019-09-26

*** despinosa has quit IRC00:11
*** jswagner has quit IRC01:26
*** mohan43u has quit IRC03:35
*** narispo has quit IRC04:09
*** narispo has joined #buildstream04:09
*** mohan43u has joined #buildstream05:00
*** adds68 has joined #buildstream06:59
*** samkirkham has joined #buildstream07:15
*** SotK has quit IRC07:15
*** SotK has joined #buildstream07:16
*** samkirkham has quit IRC07:16
*** bochecha has joined #buildstream07:56
*** Iker has joined #buildstream08:19
benschuberthttps://gitlab.com/snippets/1898311 anyone has an idea why this would happen? :/08:27
juergbibenschubert: hm, looks like the digest is an empty string08:48
benschubertit was on a build on which I forgot to add a shell as build dependency, so no output artifact at all08:49
juergbihm, so attempt to build an element that will fail and then push that artifact?08:49
juergbisounds something that we anyway should have a test case for (I would have expected that we already have one for buildtree testing)08:50
benschubertI would have too :/08:51
benschubertshould I open an issue? I can't take care of this before next week08:51
juergbiissue would be great so we don't forget about it08:56
juergbimaybe I can take a look later today08:56
benschubertok I'll open an issue :) thanks!08:56
*** raoul has joined #buildstream09:09
*** jonathanmaw has joined #buildstream09:11
*** traveltissues has joined #buildstream09:15
*** lachlan has joined #buildstream09:28
gitlab-br-botBenjaminSchubert opened issue #1144 (bst shell -b ${ELEMENT} throws assertion when source not present) on buildstream https://gitlab.com/BuildStream/buildstream/issues/114409:38
*** lachlan has quit IRC09:52
gitlab-br-botBenjaminSchubert opened issue #1145 (When building an artifact with no build-tree generated, an exception is thrown) on buildstream https://gitlab.com/BuildStream/buildstream/issues/114509:54
*** lachlan has joined #buildstream10:04
*** lachlan has quit IRC10:35
*** lachlan has joined #buildstream11:08
*** bochecha has quit IRC11:14
*** bochecha has joined #buildstream11:14
*** lachlan has quit IRC11:23
*** lachlan has joined #buildstream11:25
*** lachlan has quit IRC11:33
tpollardshould we bump our CentOS target to 8.0?11:43
benschubertI'm not sure, one of the advantage of this Centos 7 is that it allows testing with old-ish software (which uncovered a few bugs in the past)12:26
*** qinusty has joined #buildstream13:05
tpollardam I right in thinking we never want to push to a source cache if the respective element failed to build?13:07
tpollardwe seem to infer that with tests/sourcecache/push.py::test_source_push_build_fail, but it only doesn't get pushed due to external factors, afaict13:08
tpollardif so, I will add to the skip_push conditional to check the buildresult13:12
tpollardjuergbi? ^13:14
juergbitpollard: hm, not sure whether we really want to block this13:15
juergbiespecially given that we allow pushing failed builds (with buildtree)13:15
*** despinosa has joined #buildstream13:15
*** lachlan has joined #buildstream13:16
tpollardnods, the test infers that we don't want to do it due to the nature of handling the build failure (which by default is to quite the scheduler) and as such the source cache queue does not get processed13:17
tpollards/quite/quit13:17
tpollardwhere if that is the intended behaviour, we should forcefully add the check to skip_push, so we never even attempt it13:18
juergbitpollard: reminds me of this: https://gitlab.com/BuildStream/buildstream/issues/53413:18
tpollardI've only discovered it due to timing latencys added with subprocessing bst build, which means the scheduler isn't notified in time to kill the remaining queues13:19
tpollardyep that issue looks similar13:20
tpollardeasily missed as due to the default behaviour of non interactive tests13:20
tpollardI'll add this explicit check to skip_push as a separate commit, from there it be discussed if it is indeed what was originally intended13:21
*** lachlan has quit IRC13:24
*** tme5 has joined #buildstream13:38
*** lachlan has joined #buildstream13:43
*** bochecha has quit IRC13:43
*** bochecha has joined #buildstream13:43
*** tristan has joined #buildstream13:45
*** lachlan has quit IRC13:47
*** bochecha has quit IRC13:56
*** bochecha has joined #buildstream13:56
tme5is there any way to break into the bst shell sandbox from outside?14:03
tme5like, put a file there14:06
tpollardtme5: --mount14:06
tme5ah - missed that - thanks! :)14:08
tpollardnp14:11
*** lachlan has joined #buildstream14:48
*** lachlan has quit IRC14:54
*** lachlan has joined #buildstream14:57
*** lachlan has quit IRC15:00
*** lachlan has joined #buildstream15:15
*** lachlan has quit IRC15:19
*** lachlan has joined #buildstream15:23
*** despinosa has quit IRC15:40
*** lachlan has quit IRC15:51
*** lachlan has joined #buildstream16:14
*** lachlan has quit IRC16:31
*** tme5 has quit IRC16:36
*** lachlan has joined #buildstream16:48
*** lachlan has quit IRC17:14
*** traveltissues has quit IRC17:17
*** traveltissues has joined #buildstream17:20
*** tristan has quit IRC17:21
*** tristan has joined #buildstream17:22
*** traveltissues has quit IRC17:22
*** despinosa has joined #buildstream17:24
*** narispo has quit IRC17:30
*** narispo has joined #buildstream17:31
*** narispo has quit IRC17:52
*** narispo has joined #buildstream17:52
*** slaf has quit IRC18:08
*** slaf has joined #buildstream18:12
*** slaf has joined #buildstream18:12
*** slaf has joined #buildstream18:12
*** slaf has joined #buildstream18:12
*** slaf has joined #buildstream18:13
*** slaf has joined #buildstream18:13
*** slaf has joined #buildstream18:13
*** slaf has joined #buildstream18:14
*** slaf has joined #buildstream18:14
*** slaf has joined #buildstream18:14
*** slaf has joined #buildstream18:14
*** narispo has quit IRC18:49
*** narispo has joined #buildstream18:50
*** narispo has quit IRC19:27
*** narispo has joined #buildstream19:28
*** cs-shadow has quit IRC20:17
*** despinosa has quit IRC20:34
*** despinosa has joined #buildstream21:13
*** despinosa has quit IRC21:27
*** traveltissues has joined #buildstream22:00

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!