*** despinosa has quit IRC | 00:11 | |
*** jswagner has quit IRC | 01:26 | |
*** mohan43u has quit IRC | 03:35 | |
*** narispo has quit IRC | 04:09 | |
*** narispo has joined #buildstream | 04:09 | |
*** mohan43u has joined #buildstream | 05:00 | |
*** adds68 has joined #buildstream | 06:59 | |
*** samkirkham has joined #buildstream | 07:15 | |
*** SotK has quit IRC | 07:15 | |
*** SotK has joined #buildstream | 07:16 | |
*** samkirkham has quit IRC | 07:16 | |
*** bochecha has joined #buildstream | 07:56 | |
*** Iker has joined #buildstream | 08:19 | |
benschubert | https://gitlab.com/snippets/1898311 anyone has an idea why this would happen? :/ | 08:27 |
---|---|---|
juergbi | benschubert: hm, looks like the digest is an empty string | 08:48 |
benschubert | it was on a build on which I forgot to add a shell as build dependency, so no output artifact at all | 08:49 |
juergbi | hm, so attempt to build an element that will fail and then push that artifact? | 08:49 |
juergbi | sounds something that we anyway should have a test case for (I would have expected that we already have one for buildtree testing) | 08:50 |
benschubert | I would have too :/ | 08:51 |
benschubert | should I open an issue? I can't take care of this before next week | 08:51 |
juergbi | issue would be great so we don't forget about it | 08:56 |
juergbi | maybe I can take a look later today | 08:56 |
benschubert | ok I'll open an issue :) thanks! | 08:56 |
*** raoul has joined #buildstream | 09:09 | |
*** jonathanmaw has joined #buildstream | 09:11 | |
*** traveltissues has joined #buildstream | 09:15 | |
*** lachlan has joined #buildstream | 09:28 | |
gitlab-br-bot | BenjaminSchubert opened issue #1144 (bst shell -b ${ELEMENT} throws assertion when source not present) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1144 | 09:38 |
*** lachlan has quit IRC | 09:52 | |
gitlab-br-bot | BenjaminSchubert opened issue #1145 (When building an artifact with no build-tree generated, an exception is thrown) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1145 | 09:54 |
*** lachlan has joined #buildstream | 10:04 | |
*** lachlan has quit IRC | 10:35 | |
*** lachlan has joined #buildstream | 11:08 | |
*** bochecha has quit IRC | 11:14 | |
*** bochecha has joined #buildstream | 11:14 | |
*** lachlan has quit IRC | 11:23 | |
*** lachlan has joined #buildstream | 11:25 | |
*** lachlan has quit IRC | 11:33 | |
tpollard | should we bump our CentOS target to 8.0? | 11:43 |
benschubert | I'm not sure, one of the advantage of this Centos 7 is that it allows testing with old-ish software (which uncovered a few bugs in the past) | 12:26 |
*** qinusty has joined #buildstream | 13:05 | |
tpollard | am I right in thinking we never want to push to a source cache if the respective element failed to build? | 13:07 |
tpollard | we seem to infer that with tests/sourcecache/push.py::test_source_push_build_fail, but it only doesn't get pushed due to external factors, afaict | 13:08 |
tpollard | if so, I will add to the skip_push conditional to check the buildresult | 13:12 |
tpollard | juergbi? ^ | 13:14 |
juergbi | tpollard: hm, not sure whether we really want to block this | 13:15 |
juergbi | especially given that we allow pushing failed builds (with buildtree) | 13:15 |
*** despinosa has joined #buildstream | 13:15 | |
*** lachlan has joined #buildstream | 13:16 | |
tpollard | nods, the test infers that we don't want to do it due to the nature of handling the build failure (which by default is to quite the scheduler) and as such the source cache queue does not get processed | 13:17 |
tpollard | s/quite/quit | 13:17 |
tpollard | where if that is the intended behaviour, we should forcefully add the check to skip_push, so we never even attempt it | 13:18 |
juergbi | tpollard: reminds me of this: https://gitlab.com/BuildStream/buildstream/issues/534 | 13:18 |
tpollard | I've only discovered it due to timing latencys added with subprocessing bst build, which means the scheduler isn't notified in time to kill the remaining queues | 13:19 |
tpollard | yep that issue looks similar | 13:20 |
tpollard | easily missed as due to the default behaviour of non interactive tests | 13:20 |
tpollard | I'll add this explicit check to skip_push as a separate commit, from there it be discussed if it is indeed what was originally intended | 13:21 |
*** lachlan has quit IRC | 13:24 | |
*** tme5 has joined #buildstream | 13:38 | |
*** lachlan has joined #buildstream | 13:43 | |
*** bochecha has quit IRC | 13:43 | |
*** bochecha has joined #buildstream | 13:43 | |
*** tristan has joined #buildstream | 13:45 | |
*** lachlan has quit IRC | 13:47 | |
*** bochecha has quit IRC | 13:56 | |
*** bochecha has joined #buildstream | 13:56 | |
tme5 | is there any way to break into the bst shell sandbox from outside? | 14:03 |
tme5 | like, put a file there | 14:06 |
tpollard | tme5: --mount | 14:06 |
tme5 | ah - missed that - thanks! :) | 14:08 |
tpollard | np | 14:11 |
*** lachlan has joined #buildstream | 14:48 | |
*** lachlan has quit IRC | 14:54 | |
*** lachlan has joined #buildstream | 14:57 | |
*** lachlan has quit IRC | 15:00 | |
*** lachlan has joined #buildstream | 15:15 | |
*** lachlan has quit IRC | 15:19 | |
*** lachlan has joined #buildstream | 15:23 | |
*** despinosa has quit IRC | 15:40 | |
*** lachlan has quit IRC | 15:51 | |
*** lachlan has joined #buildstream | 16:14 | |
*** lachlan has quit IRC | 16:31 | |
*** tme5 has quit IRC | 16:36 | |
*** lachlan has joined #buildstream | 16:48 | |
*** lachlan has quit IRC | 17:14 | |
*** traveltissues has quit IRC | 17:17 | |
*** traveltissues has joined #buildstream | 17:20 | |
*** tristan has quit IRC | 17:21 | |
*** tristan has joined #buildstream | 17:22 | |
*** traveltissues has quit IRC | 17:22 | |
*** despinosa has joined #buildstream | 17:24 | |
*** narispo has quit IRC | 17:30 | |
*** narispo has joined #buildstream | 17:31 | |
*** narispo has quit IRC | 17:52 | |
*** narispo has joined #buildstream | 17:52 | |
*** slaf has quit IRC | 18:08 | |
*** slaf has joined #buildstream | 18:12 | |
*** slaf has joined #buildstream | 18:12 | |
*** slaf has joined #buildstream | 18:12 | |
*** slaf has joined #buildstream | 18:12 | |
*** slaf has joined #buildstream | 18:13 | |
*** slaf has joined #buildstream | 18:13 | |
*** slaf has joined #buildstream | 18:13 | |
*** slaf has joined #buildstream | 18:14 | |
*** slaf has joined #buildstream | 18:14 | |
*** slaf has joined #buildstream | 18:14 | |
*** slaf has joined #buildstream | 18:14 | |
*** narispo has quit IRC | 18:49 | |
*** narispo has joined #buildstream | 18:50 | |
*** narispo has quit IRC | 19:27 | |
*** narispo has joined #buildstream | 19:28 | |
*** cs-shadow has quit IRC | 20:17 | |
*** despinosa has quit IRC | 20:34 | |
*** despinosa has joined #buildstream | 21:13 | |
*** despinosa has quit IRC | 21:27 | |
*** traveltissues has joined #buildstream | 22:00 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!