| *** rdale has joined #buildstream | 08:10 | |
| *** bochecha has joined #buildstream | 08:25 | |
| jennis | Wow, the latest released pylint will complain if it see's an `else` after a `raise`, I don't think this makes the code any better: https://stackoverflow.com/questions/55632832/pylint-r1720-unnecessary-elif-after-raise-no-else-raise | 08:50 |
|---|---|---|
| jennis | We have 25 occurrences of this in our codebase | 08:51 |
| jennis | Actually, perhaps it does | 08:54 |
| *** tpollard has quit IRC | 09:04 | |
| *** tpollard has joined #buildstream | 09:05 | |
| *** traveltissues has joined #buildstream | 09:31 | |
| tlater[m] | jennis: Just seeing that here too | 09:49 |
| tlater[m] | It's a little annoying because I now get lots of errors offline in code I didn't write :D | 09:50 |
| *** rdale has quit IRC | 09:59 | |
| *** rdale has joined #buildstream | 10:00 | |
| jennis | tlater[m], fixes pushed: https://gitlab.com/BuildStream/buildstream/commits/jennis/update_python_deps | 10:23 |
| jennis | the first (of two) commits | 10:24 |
| tlater[m] | And MRd? | 10:24 |
| jennis | Not yet, will see if everything passes | 10:24 |
| jennis | On all tested platforms | 10:24 |
| tlater[m] | Tell me when it's there, I'll practically insta-marge ;p | 10:24 |
| Kinnison | tlater[m]: Are you close to 1540 working yet? | 10:24 |
| jennis | Well this MR is for updating all Python deps, I'm not sure what the policy is here... | 10:24 |
| tlater[m] | Kinnison: close, with any luck... 3 more edit-test cycles | 10:25 |
| Kinnison | Hmm :D | 10:25 |
| tlater[m] | jennis: Make it up as you go - I don't think there's a policy | 10:25 |
| tlater[m] | Although cs-shadow may have an opinion on that | 10:25 |
| tlater[m] | Honestly, I think it'd be best if you do those two things as separate MRs | 10:26 |
| jennis | Yeah I'll do that | 10:26 |
| jennis | some magit practise ;) | 10:27 |
| tlater[m] | Hehe | 10:27 |
| *** benschubert_ has quit IRC | 10:30 | |
| *** benschubert_ has joined #buildstream | 10:31 | |
| gitlab-br-bot | jennis opened MR !1586 (jennis/pylint_no_else_raise->master: Address pylint 2.3.x's no-else-raise warning) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1586 | 10:32 |
| jennis | tlater[m] ^ | 10:32 |
| gitlab-br-bot | tlater approved MR !1586 (jennis/pylint_no_else_raise->master: Address pylint 2.3.x's no-else-raise warning) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1586 | 10:34 |
| jennis | tlater[m], you've set to automatic merge | 10:35 |
| * tlater[m] actually quite likes that lint, it somehow just takes less mental effort to read if/else constructs :) | 10:35 | |
| jennis | Totally blindsided marge | 10:35 |
| tlater[m] | Oh, damnit | 10:35 |
| tlater[m] | Merge trains, please gitlab! | 10:35 |
| jennis | hehe | 10:35 |
| *** narispo has quit IRC | 10:50 | |
| *** narispo has joined #buildstream | 10:51 | |
| gitlab-br-bot | traveltissues approved MR !1586 (jennis/pylint_no_else_raise->master: Address pylint 2.3.x's no-else-raise warning) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1586 | 10:55 |
| cs-shadow | jennis: tlater[m]: sorry, I'm a bit lost. What am I supposed to have an opinion about? :) | 11:07 |
| tlater[m] | cs-shadow: We noticed some warnings about abc deprecation and a nonexistent setup.py option that we'd set | 11:18 |
| tlater[m] | Turns out those were caused by our use of fairly old dependencies | 11:18 |
| tlater[m] | jennis updated those, and is now thinking about whether we have a policy for updating pip dependencies. | 11:18 |
| tlater[m] | And I thought you'd be someone with an opinion on that, cs-shadow :) | 11:19 |
| cs-shadow | ah! thanks for the explanation. I don't think we have a policy as such | 11:20 |
| cs-shadow | although I don't see why we wouldn't update to a newer version if it fixes some warnings, and doesn't cause any breakages | 11:20 |
| tlater[m] | Yup, pretty much my opinion. Running the test suite for different distros atm, we'll see in a bit :) | 11:23 |
| gitlab-br-bot | marge-bot123 merged MR !1586 (jennis/pylint_no_else_raise->master: Address pylint 2.3.x's no-else-raise warning) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1586 | 11:24 |
| tlater[m] | Kinnison: it took 5 edit-test cycles in the end, but I'd appreciate review (post your lunch/talk, obviously) | 11:27 |
| traveltissues | i have a preference for constraint over pins | 11:28 |
| traveltissues | but it's not always possible | 11:28 |
| traveltissues | re: dependencies | 11:28 |
| *** rdale has quit IRC | 11:37 | |
| *** rdale has joined #buildstream | 12:00 | |
| *** rdale has quit IRC | 12:21 | |
| *** rdale has joined #buildstream | 12:25 | |
| jjardon | Can I have a review to this trivial patch please? https://gitlab.com/BuildStream/website/merge_requests/126 | 12:41 |
| *** rdale has quit IRC | 13:01 | |
| *** rdale has joined #buildstream | 13:03 | |
| jennis | cs-shadow, for more context, I saw a problem with pluginbase (we were getting a DeprecationWarning when we ran tests), I noticed the latest version of pluginbase addresses this, but, in our CONTRIBUTING, it just says "here's how you update Python deps", which updates all of our deps | 13:04 |
| jennis | However, I'll put an MR up with the full update and see what people think | 13:04 |
| jennis | s/full update/all the updates | 13:05 |
| cs-shadow | jennis: that line is about updating the *.txt from *.in files | 13:05 |
| cs-shadow | *.in files have to be modified be hand (to change a constraint, for example) | 13:06 |
| jennis | cs-shadow, we're talking about this: https://buildstream.gitlab.io/buildstream/CONTRIBUTING.html#updating-buildstream-s-python-dependencies right? I just did the `make -C requirements`, this updates everything | 13:07 |
| cs-shadow | yeah, it'll update everything to latest based on the constraints in *.in files | 13:11 |
| cs-shadow | if you want to change the constraint, you'll have to edit *.in by hand | 13:12 |
| Kinnison | tlater[m]: I'll try and take a look over it now | 13:14 |
| tlater[m] | jennis: I still get no-else-raises in _sandboxremote.py | 13:29 |
| gitlab-br-bot | tlater opened (was WIP) MR !1540 (tlater/cache-endpoints->master: Support separate end points for artifact caches) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1540 | 13:33 |
| jennis | tlater[m], oh dear, I'll have a look | 13:35 |
| jennis | tlater[m], I don't... | 13:40 |
| tlater[m] | jennis: Nevermind, it's gone here too now | 13:41 |
| * tlater[m] wonders if he accidentally opened an old version of the file somehow | 13:41 | |
| tlater[m] | Sorry for the noise! | 13:41 |
| jennis | No worries | 13:42 |
| *** jonathanmaw has quit IRC | 14:08 | |
| gitlab-br-bot | traveltissues reopened issue #1110 (use `show_default` for Click.options) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1110 | 14:12 |
| *** narispo has quit IRC | 14:26 | |
| *** narispo has joined #buildstream | 14:26 | |
| *** narispo has quit IRC | 14:32 | |
| *** narispo has joined #buildstream | 14:33 | |
| *** benschubert_ is now known as benschubert | 14:46 | |
| benschubert | juergbi: is it possible to statically link libprotobuf with buildbox-casd by any chance? | 14:46 |
| juergbi | benschubert: yes, the binary I uploaded is even fully static. however, I had to apply an ugly patch to CMakeLists.txt | 14:48 |
| juergbi | might be simpler if you only want to statically link libprotobuf | 14:48 |
| juergbi | benschubert: bst-1 project that builds fully static buildbox-casd: https://gitlab.com/BuildGrid/buildbox/buildbox-integration | 14:48 |
| juergbi | if you know how CMakeLists.txt can be fixed upstream to not require such a patch, MR welcome :) | 14:49 |
| juergbi | (cmake always seems way too painful with libraries) | 14:49 |
| benschubert | I'm not sure I know enough about CMake for this :) so Just applying https://gitlab.com/BuildGrid/buildbox/buildbox-integration/blob/master/patches/buildbox-casd-static.patch would be enough correct? | 14:50 |
| juergbi | you might also need these cmake options: https://gitlab.com/BuildGrid/buildbox/buildbox-integration/blob/master/elements/buildbox-casd.bst | 14:52 |
| benschubert | ah correct, thanks a lot! | 14:52 |
| juergbi | and that's for a fully static build. if you want to keep linking dynamically to libc etc., you may have to tweak it | 14:52 |
| benschubert | I'm fine with a fully static :) | 14:57 |
| benschubert | juergbi: | 15:12 |
| benschubert | In file included from /build/buildbox-casd/buildboxcasd/buildboxcasd_daemon.cpp:17:0: | 15:12 |
| benschubert | /build/buildbox-casd/buildboxcasd/buildboxcasd_daemon.h:22:10: fatal error: buildboxcommon_connectionoptions.h: No such file or directory | 15:12 |
| benschubert | #include <buildboxcommon_connectionoptions.h> | 15:12 |
| benschubert | Seems like I have something slightly different that makes your patch break :( | 15:12 |
| juergbi | benschubert: did you install buildbox-common into /usr? | 15:13 |
| benschubert | cmake -DBUILD_TESTING=OFF . -Bbuild && make -C build -j $(nproc) && make -C build install | 15:13 |
| benschubert | that's my command after cloning buildbox-common | 15:13 |
| juergbi | that's /usr/local by default, iirc | 15:13 |
| juergbi | in which case you'd have to change the patch to use /usr/local for the include path | 15:14 |
| benschubert | ah! Thanks that makes sense | 15:14 |
| gitlab-br-bot | jennis opened MR !1587 (jennis/update_python_deps->master: Update all Python dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1587 | 15:16 |
| jennis | cs-shadow, tlater[m], I've opened an MR which updates Python dependencies, let me know what you think :) | 15:18 |
| tlater[m] | jennis: Hm, I wonder if it'd make more sense only to update the offending dependencies | 15:20 |
| jennis | This is what I was getting at earlier ¬.¬ | 15:20 |
| tlater[m] | I think a benchmarking run might also be appropriate | 15:21 |
| jennis | Ah, definitely! | 15:21 |
| * tlater[m] didn't think that far until he saw the diff, sorry jennis D: | 15:21 | |
| gitlab-br-bot | cs-shadow approved MR !1587 (jennis/update_python_deps->master: Update all Python dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1587 | 15:25 |
| *** tiagogomes_ has quit IRC | 15:50 | |
| *** tiagogomes has joined #buildstream | 15:53 | |
| gitlab-br-bot | marge-bot123 closed issue #1041 (Support separate end points for artifact caches) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1041 | 16:03 |
| gitlab-br-bot | marge-bot123 merged MR !1540 (tlater/cache-endpoints->master: Support separate end points for artifact caches) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1540 | 16:03 |
| tpollard | \o/ | 16:03 |
| tlater[m] | \o/ | 16:03 |
| *** bochecha has quit IRC | 16:09 | |
| jennis | nice one tlater[m] | 16:23 |
| benschubert | tlater[m]: oh great :D just in time o/ | 16:23 |
| tlater[m] | hehe | 16:24 |
| * tlater[m] is glad that one's over and done with | 16:24 | |
| *** mohan43u has quit IRC | 16:25 | |
| *** narispo has quit IRC | 16:27 | |
| *** narispo has joined #buildstream | 16:27 | |
| jjardon | tlater[m]: nice!! | 16:28 |
| tlater[m] | qinusty: will probably appreciate that too | 16:28 |
| jjardon | tlater[m]: is this something we can consider to backport or it does require too many changes? | 16:29 |
| tlater[m] | Hm, that's a good question | 16:30 |
| gitlab-br-bot | traveltissues opened issue #1122 (Follow-up from "Stream - Scheduler notification handler") on buildstream https://gitlab.com/BuildStream/buildstream/issues/1122 | 16:30 |
| tlater[m] | I don't think it should be too bad, jjardon. | 16:30 |
| tlater[m] | Although it's been a while since I looked at bst 1 | 16:30 |
| tpollard | bst 1 doesn't have proto based artifacts | 16:31 |
| tlater[m] | I don't think that should matter. | 16:31 |
| tlater[m] | But it will probably make rebasing quite horrible | 16:32 |
| *** bochecha has joined #buildstream | 16:42 | |
| *** tpollard has quit IRC | 16:49 | |
| *** narispo has quit IRC | 16:59 | |
| *** narispo has joined #buildstream | 16:59 | |
| gitlab-br-bot | traveltissues opened MR !1588 (traveltissues/1110->master: Traveltissues/1110) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1588 | 17:00 |
| *** narispo has quit IRC | 17:22 | |
| *** narispo has joined #buildstream | 17:23 | |
| gitlab-br-bot | traveltissues opened (was WIP) MR !1588 (traveltissues/1110->master: use show_default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1588 | 18:12 |
| gitlab-br-bot | traveltissues opened issue #1123 (test failures on wsl) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1123 | 18:32 |
| *** traveltissues has quit IRC | 18:36 | |
| *** shash has quit IRC | 19:10 | |
| *** rdale has quit IRC | 19:46 | |
| *** cs-shadow has quit IRC | 20:24 | |
| *** bochecha has quit IRC | 22:57 | |
| *** narispo has quit IRC | 23:07 | |
| *** narispo has joined #buildstream | 23:07 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!