IRC logs for #buildstream for Tuesday, 2019-08-27

« Monday, 2019-08-26 Index Wednesday, 2019-08-28 »
*** narispo has quit IRC00:59
*** narispo has joined #buildstream01:00
*** narispo has quit IRC01:30
*** narispo has joined #buildstream01:31
*** narispo has quit IRC02:01
*** narispo has joined #buildstream02:01
*** narispo has quit IRC02:45
*** narispo has joined #buildstream02:45
*** narispo has quit IRC02:46
*** narispo has joined #buildstream02:46
*** narispo has quit IRC04:26
*** narispo has joined #buildstream04:26
*** narispo has quit IRC04:57
*** narispo has joined #buildstream04:57
*** narispo has quit IRC05:27
*** narispo has joined #buildstream05:27
*** narispo has quit IRC06:00
*** narispo has joined #buildstream06:00
*** narispo has quit IRC06:28
*** narispo has joined #buildstream06:28
*** phoenix has joined #buildstream06:32
*** phoenix has quit IRC06:40
*** narispo has quit IRC06:58
*** narispo has joined #buildstream06:59
*** narispo has quit IRC07:30
*** narispo has joined #buildstream07:30
*** narispo has quit IRC07:59
*** narispo has joined #buildstream08:00
*** rdale has joined #buildstream08:00
gitlab-br-botBenjaminSchubert opened (was WIP) MR !1537 (bschubert/register-sources-on-test->master: testing/sources: Automatically register plugin sources) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153708:36
*** Becky has joined #buildstream08:38
gitlab-br-botjennis approved MR !1537 (bschubert/register-sources-on-test->master: testing/sources: Automatically register plugin sources) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153708:58
*** slaf has quit IRC08:59
*** narispo has quit IRC08:59
*** slaf has joined #buildstream08:59
*** narispo has joined #buildstream08:59
*** jonathanmaw has joined #buildstream09:01
*** tpollard has joined #buildstream09:06
*** traveltissues has joined #buildstream09:21
*** narispo has quit IRC09:30
*** narispo has joined #buildstream09:30
*** lachlan has joined #buildstream09:35
*** lachlan has quit IRC09:45
gitlab-br-botcs-shadow approved MR !1537 (bschubert/register-sources-on-test->master: testing/sources: Automatically register plugin sources) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153709:50
gitlab-br-botmarge-bot123 merged MR !1537 (bschubert/register-sources-on-test->master: testing/sources: Automatically register plugin sources) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153709:52
*** tme5 has joined #buildstream09:53
tme5i'm running `tox -- tests/artifactcache/pull.py` and it's only showing coverage on two files, both in src/buildstream/_cas09:54
tme5is that normal? because i'm sure far more is being run, project/app initialisation, etc09:55
juergbitme5: I see coveraqe in various files with that command09:57
juergbimaybe an issue with a particular version of the test tooling?09:58
tme5well i'm using tox so everything should be the same right?09:59
tme5what version of python are you using?09:59
*** lachlan has joined #buildstream10:00
tlater[m]tme5: The same as you if you're running tox ;)10:03
tlater[m]It'll go through all installed python versions, and we're checking this in CI as well10:04
juergbiI'm on 3.710:08
tme5i'm only doing 3.510:09
tpollardanyone against me marging this? https://gitlab.com/BuildStream/buildstream/merge_requests/155910:12
tme5"Coverage.py warning: No data was collected. (no-data-collected)"10:16
traveltissuestpollard, i'll skim it10:20
juergbitpollard: I'm surprised that we don't have proper test for --all (just as a side effect of the non-strict pull test). that said, the change looks straight forward, so I don't see a real issue10:20
traveltissuescommented10:23
juergbitpollard: although, the implementation conflicts with the issue with regards to 'plan' vs. 'build'10:23
juergbieh, 'plan' vs. 'run'10:23
juergbi'plan' is essentially 'run' + indirect build dependencies as needed10:26
juergbiwe might not want to expose this difference to the user and thus, simply call the option 'run'10:26
tpollardthat seems pretty valid10:27
juergbi(and in the future we could decide to also support 'none' but with build dependencies as needed)10:27
juergbi(this would also use the planner)10:27
tme5that is what I filed #1105 for10:27
gitlab-br-botIssue #1105: Dependency selection is inconsistent across commands https://gitlab.com/BuildStream/buildstream/issues/110510:27
juergbiah, we already expose 'plan' for a couple other commands10:28
*** narispo has quit IRC10:28
*** narispo has joined #buildstream10:29
*** lachlan has quit IRC10:47
tme5i think coverage may be "broken" on python 3.510:52
tme5actually ignore me for now. i'll dig more10:54
gitlab-br-bottlater approved MR !1553 (jennis/load_artifact_dependencies->master: Add the ability to load (build) deps from an artifact ref) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/155310:58
*** phildawson_ has quit IRC11:00
*** phil has joined #buildstream11:00
*** lachlan has joined #buildstream11:01
jennisthanks tlater[m], I'll add that upstream issue in a comment and then hand to marge11:15
tlater[m]Cool :)11:15
jennisthanks for the review11:16
*** narispo has quit IRC11:24
*** narispo has joined #buildstream11:24
*** CTtpollard has joined #buildstream11:32
*** tpollard has quit IRC11:32
gitlab-br-botmarge-bot123 merged MR !1553 (jennis/load_artifact_dependencies->master: Add the ability to load (build) deps from an artifact ref) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/155312:02
*** phil has quit IRC12:13
*** phil has joined #buildstream13:05
benschubertjennis (and others): I would appreciate CRs on  https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/22 if someone has time, it's fixing the tests and moving the plugins that are tested to the recent BuildStream APIs13:21
*** phoenix has joined #buildstream13:23
jennisbenschubert, will take a look13:26
tme5how are the nocover and external tox environments specified?13:45
tme5like in `py{35,36,37}-!external-!nocover: pytest ...`13:45
benschuberttme5: not sure I understand the question, you mean how to run a non-external-no-coverage test?13:52
benschubertif so, tox -e py37-nocover13:53
*** narispo has quit IRC13:53
benschubertor tox -e py37-external-nocover13:53
tme5oh, the envs don't need to be specified in envlist, that's my misunderstanding13:54
*** narispo has joined #buildstream13:54
tme5i'm just getting very frustrated as to why me running a single test module with tox only shows two buildstream source files as being run13:54
benschubertenvlist is for when you run "tox", it will run everything in the envlist13:55
*** lachlan has quit IRC13:59
tme5alright, thanks :)14:03
*** phoenix has quit IRC14:07
tlater[m]juergbi: Do we also store artifacts/sources in casd?14:09
tlater[m]i.e., their protos?14:09
juergbitlater[m]: no, casd is a pure CAS and thus, casd doesn't support storing references14:10
Kinnisontlater[m]: the artifact protos and sourcecache protos are not stored within the CAS as blobs, no14:11
KinnisonIIRC, the blobs in the CAS are either file content, or CAS directory objects.  We *might* store action/command protos there too temporarily; bicbw14:11
tlater[m]Cool, ta14:11
tlater[m]Well, since it's our de-facto cache now I wondered if we maybe serialized our protos into files and stored those in there14:13
tlater[m]But we don't, so I don't need to work with API for that :)14:13
tlater[m]This also explains why the rebase is going so smoothly14:14
Kinnisonheh14:14
Kinnison"...this is going suspiciously smoothly..." eh?14:15
tlater[m]Yep ;)14:15
*** lachlan has joined #buildstream14:42
jennistraveltissues, I've responded to all of your review comments on !1560, please leave the one regarding multiple states open14:42
gitlab-br-botMR !1560: Introduce `bst artifact show` https://gitlab.com/BuildStream/buildstream/merge_requests/156014:42
jennisAnd thank you for the thorough review :D14:43
jennistlater[m], shource push?14:45
jennisSounds fun14:45
tlater[m]Well14:45
tlater[m]Not fun enough that I can be bothered to write tests for it14:45
jennisCan we have sauce push too14:45
tlater[m]'[14:45
tlater[m]Oh, wait, it's in the MR title14:46
tlater[m]Heh14:46
jennishehe14:46
* tlater[m] wondered how he'd managed to type shource enough times for it to work14:46
*** narispo has quit IRC14:53
*** narispo has joined #buildstream14:54
traveltissuesjennis, i'll look15:01
tme5sorry that my testing MR hasnt landed yet tlater[m], been having some issues with it but now just waiting for review15:03
tlater[m]tme5: np, I know you have ;)15:04
*** lachlan has quit IRC15:11
*** lachlan has joined #buildstream15:16
*** narispo has quit IRC15:24
*** narispo has joined #buildstream15:24
*** lachlan has quit IRC15:25
*** phildawson_ has joined #buildstream15:29
*** phil has quit IRC15:30
*** lachlan has joined #buildstream15:40
*** lachlan has quit IRC15:46
tme5traveltissues, thank you for your comments on both my open MRs, I'm a bit unsure of the details of what you asked and have replied to you15:46
*** lachlan has joined #buildstream15:49
gitlab-br-bottraveltissues approved MR !1555 (becky/list_contents_long_option->master: Addition of --long option to list-contents) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/155516:03
*** lachlan has quit IRC16:04
gitlab-br-bottraveltissues approved MR !1559 (tmewett/build-deps-cli->master: Remove build --all flag in favour of --deps all/plan) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/155916:06
traveltissuestme5, i've responded16:08
*** CTtpollard is now known as tpollard16:08
*** lachlan has joined #buildstream16:16
tme5thanks traveltissues16:16
*** narispo has quit IRC16:18
*** narispo has joined #buildstream16:18
*** tme5 has quit IRC16:34
*** phildawson_ has quit IRC16:39
gitlab-br-bottraveltissues approved MR !1560 (jennis/bst_artifact_show->master: Introduce `bst artifact show`) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/156016:47
*** lachlan has quit IRC16:48
*** lachlan has joined #buildstream16:49
*** lachlan has quit IRC16:57
*** lachlan has joined #buildstream17:00
*** jonathanmaw has quit IRC17:05
*** narispo has quit IRC17:12
*** narispo has joined #buildstream17:12
*** lachlan has quit IRC17:16
*** lachlan has joined #buildstream17:26
*** lachlan has quit IRC17:26
benschubertjennis: still around? I've addressed everything at https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/22 I think17:31
benschubertcould you confirm?17:31
*** narispo has quit IRC17:48
*** narispo has joined #buildstream17:48
traveltissuesi don't see them benschubert18:04
*** traveltissues has quit IRC18:08
*** bochecha has joined #buildstream18:36
*** narispo has quit IRC18:45
*** narispo has joined #buildstream18:46
*** narispo has quit IRC19:16
*** narispo has joined #buildstream19:16
*** narispo has quit IRC19:47
*** narispo has joined #buildstream19:47
*** narispo has quit IRC20:42
*** narispo has joined #buildstream20:42
*** narispo has quit IRC23:11
*** narispo has joined #buildstream23:11
« Monday, 2019-08-26 Index Wednesday, 2019-08-28 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!