IRC logs for #buildstream for Monday, 2019-08-12

*** tristan_ has joined #buildstream04:11
*** tristan_ has quit IRC04:12
*** tristan_ has joined #buildstream04:12
*** tristan_ has quit IRC04:14
*** tristan_ has joined #buildstream04:14
*** tristan_ has quit IRC04:16
*** tristan_ has joined #buildstream04:16
*** tristan_ has quit IRC04:18
*** tristan_ has joined #buildstream04:21
*** tristan_ has quit IRC04:22
*** tristan_ has joined #buildstream04:22
*** tristan_ has quit IRC04:23
*** tristan_ has joined #buildstream04:24
*** tristan_ has quit IRC04:25
*** tristan_ has joined #buildstream04:26
*** tristan_ has quit IRC04:27
*** tristan_ has joined #buildstream04:31
*** tristan_ has quit IRC04:32
*** tristan_ has joined #buildstream04:32
*** tristan_ has quit IRC05:37
*** tristan_ has joined #buildstream05:38
*** tristan_ has quit IRC05:42
*** tristan_ has joined #buildstream05:43
*** tristan_ has quit IRC05:50
*** tristan_ has joined #buildstream05:50
*** tristan_ has quit IRC05:51
*** tristan_ has joined #buildstream05:52
*** tristan_ has quit IRC05:57
*** tristan_ has joined #buildstream05:59
*** tristan_ has quit IRC06:00
*** tristan_ has joined #buildstream06:01
*** tristan_ has quit IRC06:02
*** tristan_ has joined #buildstream06:03
*** tristan_ has quit IRC06:04
*** tristan_ has joined #buildstream06:05
*** tristan_ has quit IRC06:06
*** tristan_ has joined #buildstream06:07
*** tristan_ has quit IRC06:08
*** tristan_ has joined #buildstream06:09
*** tristan_ has quit IRC06:10
*** tristan_ has joined #buildstream06:11
*** tristan_ has quit IRC06:12
*** tristan_ has joined #buildstream06:13
*** tristan_ has quit IRC06:16
*** tristan_ has joined #buildstream06:17
*** tristan_ has quit IRC06:18
*** tristan_ has joined #buildstream06:19
*** tristan_ has quit IRC06:20
*** tristan_ has joined #buildstream06:21
*** tristan_ has quit IRC06:22
*** tristan_ has joined #buildstream06:23
*** tristan_ has quit IRC06:24
*** tristan_ has joined #buildstream06:27
*** tristan_ has quit IRC06:28
*** tristan_ has joined #buildstream06:36
*** tristan_ has quit IRC06:39
gitlab-br-botcoldtom opened MR !1538 (coldtom/move-makemaker->master: Move makemaker plugin to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153807:06
*** bochecha has joined #buildstream07:47
gitlab-br-botmarge-bot123 merged MR !1538 (coldtom/move-makemaker->master: Move makemaker plugin to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153808:31
*** tme5 has joined #buildstream08:35
*** tiagogomes has quit IRC08:38
gitlab-br-botcoldtom opened MR !1539 (coldtom/move-modulebuild->master: Move modulebuild plugin to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153908:48
*** tiagogomes has joined #buildstream08:48
*** traveltissues has joined #buildstream08:58
*** tpollard has joined #buildstream08:58
*** jonathanmaw has joined #buildstream08:59
*** tpollard has quit IRC08:59
*** tpollard has joined #buildstream09:01
*** phildawson_ has joined #buildstream09:06
*** juergbi has quit IRC09:07
*** juergbi has joined #buildstream09:12
tme5is the wildcard expansion that bst does documented anywhere? eg bst show '*.bst'09:12
qinustyI'd assume it's just a standard glob? bst commands work on files within the root element directory which is defined in the project.conf09:22
*** lachlan has joined #buildstream09:22
Kinnisonif you quote the glob, the glob is passed to buildstream09:23
Kinnisonrather than being shell expanded09:23
jennistme5, I know that it's documented in `artifact log` and `artifact delete`09:24
jennisBut perhaps it should be implemented at a higher level, as it works for element names as well as artifact refs09:24
tme5ahh, brilliant thanks09:25
jennishttps://buildstream.gitlab.io/buildstream/using_commands.html#bst-artifact-log09:25
jennistme5 ^09:25
tme5it is in fact implemented at a higher level09:25
tme5and this bug is a result of that https://gitlab.com/BuildStream/buildstream/issues/95909:25
tme5well, i guess it's not technically a bug09:25
tme5but thank you for pointing me to the docs. Do you think it would be a good idea to make it more clear where this expansion happens, and to document it more generally?09:26
jennisYes definitely09:27
jennisAnd I think that issue is correct09:27
jennisbst show * shouldn't error out like that, because we do support element names09:28
jennisIn short, I think `bst show *` == `bst show *.bst` behaviour-wise09:28
jennisWhich is also equivalent to the currently supported `bst show` IIRC09:28
tme5so there should be two types of wildcard expansion?09:29
tme5most shells could do `bst show **.bst`, right?09:30
tme5I feel like it's clearer behaviour to have bst do only artifact ref expansion, where applicable09:31
jennisIt seems that the two types are alrady kind of supported09:32
Kinnisontme5: ** implies an understanding of a structure on the filesystem -- buildstream's elements are a flat namespace that happens to contain slashes as valid characters in a limited fashion09:32
tme5so there are use cases where elements do not come from files?09:33
*** lachlan has quit IRC09:56
*** lachlan has joined #buildstream10:00
*** phoenix has joined #buildstream10:07
*** phoenix has quit IRC10:13
*** phoenix has joined #buildstream10:14
*** phoenix has quit IRC10:18
*** phoenix has joined #buildstream10:20
*** phoenix has quit IRC10:22
*** phoenix_ has joined #buildstream10:23
*** phoenix_ is now known as phoenix10:23
jjardonqinusty: hey, I've heard you were recollecting what is remaining from buildstream to supporting remote-execution API's; did you have a chance to write that somewhere?10:31
qinustyjjardon partially, there appears to be two main issues, caching which is a discussion you were involved in and support of sandboxed environments from RE server implementations10:32
*** phoenix has quit IRC10:32
qinustyI'll tidy up what I've got and let you know10:33
adds68Does anyone know if there is an endpoint you can query in the artifact-cache that will give a reliable "health status"?10:33
adds68i can curl 1101 and 1102, but they return an empty response, which is an error =/10:33
jjardonqinusty: cool, I was thinking maybe we can use https://gitlab.com/BuildStream/buildstream/issues/1050 for the remote caching and then we can open a new one for the remote execution part, as probably is more complicated?10:34
*** lachlan has quit IRC10:35
qinustyYes that issue encapsulates basically everything I know about the caching issue so it can primarily reside there. I think the issues with sandboxing can be addressed in a single issue detailing each client. I haven't looked into buildfarm as an option yet though10:37
*** lachlan has joined #buildstream10:39
*** phoenix has joined #buildstream10:47
*** phoenix has quit IRC10:54
*** lachlan has quit IRC11:07
*** lachlan has joined #buildstream11:11
*** lachlan has quit IRC11:14
*** phoenix has joined #buildstream11:18
*** phoenix has quit IRC11:19
gitlab-br-bottraveltissues approved MR !1146 (valentindavid/local-cache-exec-leak->master: Deduplicate files in local cache with or without exec rights) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/114611:22
*** jonathanmaw has quit IRC11:23
*** jonathanmaw has joined #buildstream11:23
*** phoenix has joined #buildstream11:26
*** lachlan has joined #buildstream11:31
jennisjuergbi, are there installation instructions for bb-casd?11:33
tlater[m]adds68: This is for bst 1.2, right?11:34
juergbijennis: not yet but this may help: https://gitlab.com/BuildStream/buildstream-docker-images/commit/57ce3e339bca3839ab52598121fdcc2702c5cdb4#7c1688a0c480b7b1d571df7be349080b1122e04111:35
tlater[m]It's a little complicated because it uses grpc. I'm not 100% sure what http calls those things turn into.11:35
tlater[m]juergbi: Any idea?11:35
jennisthanks juergbi11:36
tlater[m]There is StatusRequest, but well, it's grpc :)11:36
tlater[m]adds68: Looks like you'd need to do something along these lines: https://medium.com/google-cloud/grpc-with-curl-a65d879a18f711:40
tlater[m]Not nice, to say the least11:40
tlater[m]It's probably easiest to write a tiny python script that uses grpc to make a StatusRequest11:41
* tlater[m] is a little annoyed at this11:41
*** phoenix has quit IRC11:41
*** lachlan has quit IRC11:42
*** phoenix has joined #buildstream11:48
*** phoenix has quit IRC11:50
*** lachlan has joined #buildstream11:51
jennisjuergbi, after your branch lands, we will no longer be supporting old style bst-artifact-server, correct?11:51
jennisIf I've understood the changes to casremote.py correctly11:51
juergbijennis: as a client? that's not supported in master either11:52
jennisThought it currently was11:52
jennisjuergbi, for the remotes ^11:53
juergbino, the server still supports older clients but the new bst client never checks non-proto artifacts on the remote11:53
juergbicache keys are anyway different, so there isn't really a point11:53
jennisyeah sorry. Will the server still be supporting older clients?11:53
jennisAfter your MR lands11:53
juergbiyes, that should still be the case11:53
juergbialthough, it might not be covered by CI11:54
juergbido you see a reason why the MR would break that?11:54
jennisok, so we still need all the "CASCache.contains(), CASCache.resolve_ref()" stuff in CASCache11:54
*** lachlan has quit IRC11:54
gitlab-br-bottraveltissues approved MR !1536 (jennis/fix_failed_workspaces->master: Don't reset a failed (but cached) workspaced Element) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153611:54
jennisNo I don't11:54
juergbiyes11:54
*** phoenix has joined #buildstream12:01
*** phoenix has quit IRC12:05
gitlab-br-bottlater opened MR !1540 (tlater/cache-endpoints->master: Tlater/cache endpoints) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/154012:09
gitlab-br-botmarge-bot123 merged MR !1531 (tmewett/report-weird-return-codes->master: Report error when job process unexpectedly dies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/153112:18
gitlab-br-botmarge-bot123 closed issue #1089 (Reporting of unexpected deaths of worker processes could be better) on buildstream https://gitlab.com/BuildStream/buildstream/issues/108912:18
adds68tlater[m], i ended up working with ironfoot to make a little one liner shell command to make the empty response truthy12:45
adds68tlater[m], should i open an issue for this? ;D12:45
tlater[m]adds68: Yeah, sure. It probably won't see much traction for a while, but it's stupid that we can't see if our server is alive.12:46
adds68cool12:46
* adds68 adds to list of TODOs12:46
tlater[m]Once is enough12:46
tlater[m]Don't need 68 of them ;p12:46
adds68tlater[m] haha!12:47
ironfootthis ideally can be added into the Dockerfile12:48
ironfootI think it's possible to use curl to fake a grpc call, but won't look good12:48
tlater[m]ironfoot: I wouldn't like it if it were a docker-only feature12:53
tlater[m]IMO it should be added to bst-artifact-server, perhaps as a custom little http server thing that relays everything to GRPC except a specific curl request.12:54
ironfootyes, that would be the ideal solution12:58
tpollard+112:58
*** lachlan has joined #buildstream13:04
*** traveltissues has quit IRC13:05
*** traveltissues has joined #buildstream13:06
*** narispo has quit IRC13:24
*** narispo has joined #buildstream13:24
*** lachlan has quit IRC13:46
*** lachlan has joined #buildstream13:55
*** lachlan has quit IRC13:58
*** lachlan has joined #buildstream14:07
*** lachlan has quit IRC14:13
tlater[m]Is there something like `bst source push`?14:33
tlater[m]I feel like I got rid of it accidentally somehow14:33
*** lachlan has joined #buildstream14:34
tpollardI dont think so tlater14:34
tpollardafaik only bst build makes a SourcePush queue14:35
tlater[m]That seems a little odd14:35
*** narispo has quit IRC14:37
tpollardI tend to agree14:37
*** narispo has joined #buildstream14:37
tlater[m]Well, I suppose I'm in the best position to figure out how to change that.14:38
* tlater[m] digs into the frontend14:38
*** lachlan has quit IRC14:44
*** lachlan has joined #buildstream14:51
tme5i'm noticing, especially in bst artifact subcommand help text, that "artifact" and "element" are often used interchangably14:56
*** lachlan has quit IRC14:57
tme5i'm working on making more of a distinction, is that useful?15:03
tme5especially with the fact the commands take elements and artifact refs interchangably15:07
*** lachlan has joined #buildstream15:10
*** tristan_ has joined #buildstream15:14
tpollardtme5: I think it's useful15:15
jennisyeah tme5, that will be more useful15:15
tpollardespecially as internally the distinction of element-artifact is now more abstracted in the classes15:16
*** lachlan has quit IRC15:17
*** lachlan has joined #buildstream15:31
*** traveltissues has quit IRC15:36
*** phildawson_ has quit IRC15:36
*** phildawson_ has joined #buildstream15:37
*** tristan_ has quit IRC15:38
*** tristan_ has joined #buildstream15:39
*** lachlan has quit IRC15:44
*** lachlan has joined #buildstream15:48
tlater[m]Hrm, I just realized that we have a source-servers and an artifacts configuration setting in project.conf15:51
tlater[m]I wonder if it'd make more sense to name that "thing" remotes and distinguish between source and artifact remotes under that key15:52
tlater[m]It would resolve the inconsistency in their naming and make it more obvious what they do15:53
tlater[m]I should say, remote-caches15:53
*** lachlan has quit IRC16:03
jennisand also aliases for remotes? :D16:09
*** bochecha has quit IRC16:11
*** lachlan has joined #buildstream16:16
tlater[m]jennis: Honestly, I think that'd be awesome16:20
tlater[m]Would make error messages more informative and --remote easier to use.16:21
tlater[m]Maybe...16:21
* tlater[m] sent a long message: < https://gnome.modular.im/_matrix/media/v1/download/gnome.org/hRIIbjgmwVNcgPccmMlVPocp >16:23
tlater[m]And then add cas/meta split to the individual caches :)16:23
tlater[m]Hell, you could define them at the root level and then tell them to be source/artifact caches with the alias.16:25
*** lachlan has quit IRC16:28
*** lachlan has joined #buildstream16:32
*** tristan_ has quit IRC16:38
gitlab-br-bottmewett opened MR !1541 (tmewett/artifact-help->master: Clarify bst artifact subcommand help text) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/154116:41
*** lachlan has quit IRC16:42
*** tme5 has quit IRC16:44
*** tristan_ has joined #buildstream17:04
adds68I'm seeing "task: non-zero exit (1)" returned from the bst-artifact-cache docker images17:06
adds68Would anyone have any idea what could cause that?17:06
*** lachlan has joined #buildstream17:13
*** lachlan has quit IRC17:19
*** lachlan has joined #buildstream17:27
*** jonathanmaw has quit IRC17:34
*** tristan_ has quit IRC17:38
*** lachlan has quit IRC18:02
*** lachlan has joined #buildstream18:22
*** tristan_ has joined #buildstream18:36
*** tristan_ has quit IRC18:37
*** dftxbs3e has quit IRC19:23
*** tristan_ has joined #buildstream19:36
*** tristan_ has quit IRC19:38
*** lachlan has quit IRC19:59
*** tristan_ has joined #buildstream20:31
*** cs-shadow has quit IRC20:36
*** tristan_ has quit IRC20:38
*** tristan_ has joined #buildstream20:39
gitlab-br-bottristanvb opened MR !1542 (tristan/strict-rebuild->master: Support strict build dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/154220:57
*** ChanServ sets mode: +o tristan20:59
tristanjuergbi, I was thinking the above might be nice to have in 1.4, as we're using non-strict in CI now... any thoughts ?20:59
* tristan thinks it feels silent today, like I didnt get the memo that it was actually a second sunday in a row :-/20:59
*** tristan_ has quit IRC21:38
*** tristan_ has joined #buildstream21:38
*** tristan_ has quit IRC21:40
*** tristan_ has joined #buildstream21:40
*** tristan_ has quit IRC21:43
*** tristan_ has joined #buildstream21:44
*** tristan_ has quit IRC21:45
*** tristan_ has joined #buildstream21:45
*** tristan_ has quit IRC21:47
*** tristan_ has joined #buildstream22:36
*** tristan_ has quit IRC22:38
*** tristan_ has joined #buildstream23:36
*** tristan_ has quit IRC23:38

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!