IRC logs for #buildstream for Wednesday, 2019-07-31

*** phoenix has quit IRC00:14
*** tristan has joined #buildstream03:39
*** kapip has joined #buildstream03:57
*** kapip has quit IRC05:19
*** flatmush has quit IRC05:19
*** tpollard has quit IRC05:19
*** ironfoot has quit IRC05:19
*** slaf has quit IRC05:19
*** valentind has quit IRC05:19
*** pro[m] has quit IRC05:19
*** dineshdb[m] has quit IRC05:19
*** abderrahim[m] has quit IRC05:19
*** awacheux[m] has quit IRC05:19
*** albfan[m] has quit IRC05:19
*** gimpnet-irc[m] has quit IRC05:19
*** Demos[m] has quit IRC05:20
*** ssssam[m] has quit IRC05:20
*** doras has quit IRC05:20
*** waltervargas[m] has quit IRC05:20
*** verdre[m] has quit IRC05:20
*** jjardon has quit IRC05:20
*** aevri has quit IRC05:20
*** kapip has joined #buildstream05:20
*** flatmush has joined #buildstream05:20
*** tpollard has joined #buildstream05:20
*** ironfoot has joined #buildstream05:20
*** slaf has joined #buildstream05:20
*** valentind has joined #buildstream05:20
*** verdre[m] has joined #buildstream05:20
*** waltervargas[m] has joined #buildstream05:20
*** ssssam[m] has joined #buildstream05:20
*** pro[m] has joined #buildstream05:20
*** gimpnet-irc[m] has joined #buildstream05:20
*** dineshdb[m] has joined #buildstream05:20
*** doras has joined #buildstream05:20
*** Demos[m] has joined #buildstream05:20
*** albfan[m] has joined #buildstream05:20
*** abderrahim[m] has joined #buildstream05:20
*** awacheux[m] has joined #buildstream05:20
*** jjardon has joined #buildstream05:20
*** aevri has joined #buildstream05:20
*** irc.poop.nl sets mode: +oo ironfoot jjardon05:20
*** narispo has joined #buildstream06:02
*** kapip has quit IRC06:16
Kinnisonvalentind, tristan: Is there anything particular blocking https://gitlab.com/BuildStream/buildstream/merge_requests/1146 from merging (other than needing another potentially non-trivial rebase) ?06:51
*** samkirkham has joined #buildstream07:21
*** benschubert has joined #buildstream08:29
*** narispo has quit IRC08:48
*** narispo has joined #buildstream08:49
*** phil has joined #buildstream08:54
*** jonathanmaw has joined #buildstream09:45
tlater[m]jennis: regarding completion of artifacts, we can't make those args strings because we use the type of the arg to figure out how to complete it09:52
tlater[m]And we don't want *every* string to be completed as an artifact ;)09:53
jennisYes, just processed that09:53
tlater[m]So yeah, small custom type that maybe does a little bit of validation and extends click.Path09:53
jennisI agree, we could add a new Click param type here and have autocomplete for it. Then the result is that we have a list of strings which is passed into Stream09:53
laurencetlater[m], genuine question: re #1091, do we need a separate ticket for that? Or should it not fall under #773 ?09:53
gitlab-br-botIssue #1091: Create a custom artifact-ref click parameter type https://gitlab.com/BuildStream/buildstream/issues/109109:53
gitlab-br-botIssue #773: The command-line should provide access to artifacts https://gitlab.com/BuildStream/buildstream/issues/77309:53
laurencenot urgent09:53
tlater[m]laurence: yeah, I ummed and ahd about that for a good 5 minutes09:54
tlater[m]I ended up going with a separate ticket because gitlab made one for me, and it technically is a bug. Could probably be captured under 773 though.09:55
tlater[m]It's very *technically* a bug, and one we can't even hit yet.09:57
laurenceok, sure :)09:57
laurenceis there one one of the bullet points in particular we could link out to the the new issue from?09:58
laurencei guess the one on tab completion?09:58
tlater[m]Maybe, though the new issue is generally valid. I'd probably make it a new bullet point.09:58
laurenceok09:59
laurencethanks09:59
jennistlater[m], are you in agreement with my interpretation?  <jennis> I agree, we could add a new Click param type here and have autocomplete for it. Then the result is that we have a list of strings which is passed into Stream09:59
tlater[m]A new bullet point next to tab completion that is :)09:59
tlater[m]jennis: yep 100%09:59
jenniscool, alexandrufazakas ^ let us know if you're unclear :)10:00
alexandrufazakasjennis: I'm not sure how what you suggested is different to the approach tlater[m] described in #77310:01
jennisI didn't suggest a different approach, just mentioned that it's already implemented and how we have implemented it10:01
jennisWe can consider the issue as two tasks (the tick boxes), the second is already done10:02
alexandrufazakasjennis: Is it ok if I come over for a second?10:03
jennisSure10:03
laurencetlater[m] Kinnison - I really have to agree with Sander wrt the committers automation10:16
laurenceshould be a simple script10:16
Kinnison?10:16
laurencelet's focus on getting something over the line that works10:16
* Kinnison remains in the dark as to what laurence is referring to10:17
laurenceKinnison, i just wonder if we're letting perfect get in the way of good with the reviews there10:17
laurencesorry for my previous lack of context10:17
laurencejust don't want things to get 'bogged down'10:17
jennistlater[m], I'm not sure we actually need an extra click param10:20
alexandrufazakasKinnison: I think laurence refers to this comment https://gitlab.com/BuildStream/buildstream/merge_requests/1505#note_19814916010:21
*** traveltissues has joined #buildstream10:21
tlater[m]laurence: Yeah, I think that was the goal anyway. That MR is practically ready, not sure why we haven't landed it yet10:21
*** traveltissues has quit IRC10:21
jennisHaving looked at cli.py's override_completions(), which calls cli.py's complete_artifacts(), this loads the context and then uses ArtifactCache.list_artifacts()10:21
tlater[m]I think alexandrufazakas has been juggling things, so it took a little longer (:10:21
laurencetlater[m], ok thanks that's exactly what i thought10:22
jennisThis lists artifacts by calling BaseCache._list_refs_mtimes() which uses os.path.join...10:22
jennisSo I think we'l always get the appropriate string back10:22
alexandrufazakasI've pushed my changes fixing everything other than the whitespaces10:23
alexandrufazakasWhich I can't figure how to do for my life for some reason10:23
tlater[m]jennis: Surely all we need to do then is link that up to the stuff that's not completed yet?10:23
tlater[m]And combine it with something that also does bst file completion?10:24
Kinnisonalexandrufazakas: just trim those hunks from your commits?10:24
tlater[m]alexandrufazakas: Hah, my guess is you made git ignore whitespace between when you made the commits and now, so it won't commit new changes since then.10:25
alexandrufazakasKinnison: sorry, it's now clear to me what you mean10:25
alexandrufazakasWhat I tried is pasting *only* the text changes10:25
alexandrufazakasAnd the white space ones still show up10:25
alexandrufazakastlater[m]: I don't think I've done any such configs at all tbh10:25
Kinnisonalexandrufazakas: want me to fix your branch?10:26
alexandrufazakasI used the original CONTRIBUTING.rst and didn't touch these blocks and they're still there somhow :/10:26
alexandrufazakasKinnison: that'd be great, yes10:26
alexandrufazakasSo at least I know how to do it myself next time this happens :/10:26
KinnisonThe whitespace cockup is in the commit from laurence10:27
* Kinnison cleans up10:27
alexandrufazakasYeah, I know haha10:27
* tlater[m] shakes a fist at laurence for delaying our merge!10:28
jennistlater[m], that is what cli's complete_artifact() does, first it calls complete_target() (which handles the element) and then extends the list with ArtifactCache.list_artifacts()10:28
tlater[m]Ahhh10:28
tlater[m]Right, that's pretty nice then10:28
tlater[m]Odd, I guess I didn't read the right path then. Anyway, should be easy to hook up to a custom type then.10:29
jennisBut I don't think we need the custom type?10:30
Kinnisonalexandrufazakas: I think that's done it, please check10:30
tlater[m]click.Path will still do validation that might break artifacts10:30
* alexandrufazakas checks10:30
tlater[m]That's the bug we can't hit yet I'm talking about10:31
jennisRightly so, though?10:31
alexandrufazakasKinnison: looks fine now. thank you!10:31
Kinnisonnp10:31
KinnisonI'll look at the discussion points in a few minutes10:31
alexandrufazakasWhat did you do to them?10:31
jennisIf someone on Windows, for example, tried `bst artifact log autotools/he` **autocomplete** then we should expect an error?10:31
tlater[m]jennis: Um, why? Should all artifacts have names that can be stored as filenames, and is that psrt of the spec?10:32
jennisI would have though Click.path and os.path would handle this10:32
laurencethanks for pushing it, Kinnison, tlater[m], alexandrufazakas10:32
jennisyes, the ref (artifact name) should always be a file in your cache (or not, if it doesn't exist)10:33
tlater[m]My concern is that we might have an artifact key that isn't a valid path name, jennis10:33
tlater[m]Which should currently be impossible10:33
tlater[m]Because of that :)10:33
jennisI.e. a path that doesn't exist?10:34
tlater[m]But if the key contains a \, this will change the moment we get native windows support10:34
tlater[m]Nah, not nonexistent, but different on a different OS10:34
tlater[m]But still valid as a key10:34
jennisYeah ok, I think would still be handled10:36
Kinnisonalexandrufazakas: looks like it's all resolved10:36
tlater[m]jennis: that said, what needs to be done to resolve artifact completion then?10:36
tlater[m]Surely this means it'd been implemented before alexandrufazakas told me he was working on it?10:37
jennisNothing, AFAICT10:37
jennisYes, I think there may have been a misunderstanding10:37
alexandrufazakasworking is a big word there to be fair10:37
tlater[m]Heh10:38
alexandrufazakasI'm mostly trying to understand most of the bst's itnernals10:38
jennisBut, from a discussion at the last mini gathering, it was decided we'd like to introduce *more* artifact subcommands10:38
jennislist, list contends, diff IIRC10:38
tlater[m]alexandrufazakas you could do me a massive favor if you could test the artifact completion actually works :)10:38
tlater[m]And then tick that mark on the issue10:38
tlater[m]jennis: Yeah, that's also being worked on10:39
alexandrufazakasI think jennis has just done that with me earlier on his system, but I can try sure10:39
alexandrufazakastlater[m] ^10:39
tlater[m]Becky is looking at one of those, for example10:39
jennistlater[m], it doesn't work for `bst artifact push/pull/checkout` because they do not support the handling of artifact refs10:39
jennisHowever, it does for log and delete, and I'd expect it to be enabled for diff/list/list-contents10:39
tlater[m]Any chance we could make it work for push/pull/checkout?10:40
jennisWe could enable autocompletetion for these very easily with s/elements/artifacts in the click.argument10:40
tlater[m]That'd be a massive win, since 99% of the time I want to do something with an artifact it's those commands.10:41
jennisHowever, until these commands actually support the handling of artifact refs, I don't see why we would do that?10:41
tlater[m]Oh, right, they don't, nvm10:41
jennisAnd these commands don't support artifact refs because we can't reconstruct the dependency graph from an artifact ref10:41
tlater[m]Yeah10:42
tlater[m]Dw, I misread what you said10:42
tlater[m]Cool, I suppose we can tick that completion thing off for free then :)10:42
jennisIdeally, I'd like a Windows user to try and autocomplete, aevri??10:42
tlater[m]jennis: You're being very hopeful there, haha10:43
jennisWould have to be with a project that only contains import elements (which we have :))10:43
tlater[m]Well, yeah, but it'd also need to run bash10:44
jennisoh yeah10:45
jennisd'oh10:45
* jennis forgot about the ~/.bashrc snippet10:45
benschubertjennis: click has a click-completions package that would also work with powershell if that's what you are after, I would not spend time on this now though :)10:47
jennisoh cool10:48
jennisCould be useful sometime10:48
benschubertiff we start supporting windows yep :)10:49
jennisyes, that time :P10:49
tpollardshould the hello-junction.bst example be buildable in master/10:58
tpollard?10:58
alexandrufazakasDoes `tests/artifactcache/expiry.py::test_never_delete_required_track ` fail sometimes? Apparently it's just failed on my MR which doesn't touch any src/ or the test itself11:03
benschubertalexandrufazakas: sadly too often. Just rerun the pipeline :)11:05
alexandrufazakasbenschubert: Yep, I've just told gitlab to rerun that job. thanks :)11:05
jennistpollard, I've just built it with master11:19
* jennis wonders whether you're trying to build the junction element 11:22
*** kapip has joined #buildstream11:32
aevrijennis - yup win32 autocomplete will be cool, I'll look some time after we've got win32 anything landed :)11:36
*** rdale has quit IRC11:41
KinnisonJust be warned12:12
Kinnisonwin32 users do not expect CLIs to behave like *nix users do12:12
KinnisonWe (Rustup) have a patch sat for powershell support for rustup-init because there's unresolved discussion around whether it should behave like rustup-init does everywhere else, or if it should be Windowsy instead12:13
*** tpollard has quit IRC12:15
tlater[m]Kinnison mind linking that patch? For future reference, whenever I inevitably need to have an opinion on aevri's patch ;)12:34
Kinnisonhttps://github.com/rust-lang/rustup.rs/pull/187812:35
benschuberthttps://gitlab.com/BuildStream/buildstream/blame/master/src/buildstream/_artifact.py#L311 'artifact' can be None here, and therefore BuildStream fails. Does someone has better knowledge of why this is important and how that should be patched?12:35
gitlab-br-botBenjaminSchubert opened MR !1509 (bschubert/small-fixes->master: job: fix exception caught from enum translation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/150912:50
*** tpollard has joined #buildstream12:57
tpollard'pip3 install --user -e .' doesn't work for me anymore, --user not recognised?13:02
* Kinnison just uses pip3 install -e .13:02
* tpollard boggles, as it still says --user is not recognised13:05
Kinnisonalias ?13:05
Kinnisonshell function?13:05
tpollardhttps://paste.gnome.org/psefdywhd13:06
KinnisonHow odd13:08
tpollard--user without -e works for me, but then it obviously doesn't track the source changes13:09
juergbitpollard: I think I saw this issue as well at some point. was an issue with a particular version of pip or a dependency, iirc13:18
juergbiare you using a venv?13:19
benschuberttpollard: the problem is that pip never actually supported "--editable" with "--target (or --user)", and with the new PEP 517 for isolated build, they explicitely broke it when doing such builds13:21
*** phoenix has joined #buildstream13:22
*** phoenix has quit IRC13:36
gitlab-br-botBenjaminSchubert opened issue #1095 (BuildStream crashes when trying to push a non-build artifact) on buildstream https://gitlab.com/BuildStream/buildstream/issues/109513:39
alexandrufazakasHow do we generate the buildstream documentation? is it not `make --directory=doc/ html` and I end up with https://paste.codethink.co.uk/?641313:41
benschubertalexandrufazakas: a gitlab snippet might be easier :) we don't all ahve access to codethink's pastebin. To build the docs: tox -e docs13:42
Kinnison`tox -e docs`13:43
Kinnisonoh benschubert beat me to it13:43
alexandrufazakasbenschubert: will keep that in mind, sorry13:43
benschubertno worries, just helps to get help from others ;)13:43
alexandrufazakasHmm13:43
alexandrufazakasI wanted to replicate the way we do it on buildstream13:43
alexandrufazakasIn order to generate the documentatio for docs-website13:43
alexandrufazakasBut using tox might be a bit too much13:44
alexandrufazakasthanks btw benschubert Kinnison13:44
gitlab-br-botmarge-bot123 merged MR !1509 (bschubert/small-fixes->master: job: fix exception caught from enum translation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/150914:04
alexandrufazakasCan anyone help me do this https://gitlab.com/BuildStream/docs-website/merge_requests/2#note_197811567 please? I'm trying to understand sphinx/.rst but nothing works14:19
alexandrufazakasI've created a small project using `sphinx-quickstart` but I can't add anything to its index.rst so that it's rendered in the generated html14:20
jjardontpollard: About what we were talking before; I think the page https://wiki.gnome.org/Projects/BuildStream/Infrastructure is up-to-date? please feel free to update it if not14:41
alexandrufazakaslaurence: Hey, regarding this https://gitlab.com/BuildStream/docs-website/merge_requests/2#note_197616156 can you please tell me exactly which versions we'd want to have up there?14:57
*** bochecha_ has joined #buildstream15:03
laurencemy opinion is latest stable and current master15:04
laurencebut honestly don't block on it15:04
laurencewe can change that easily later15:04
*** bochecha has quit IRC15:04
*** bochecha_ is now known as bochecha15:04
laurencealexandrufazakas ^15:04
alexandrufazakaslaurence: Yeah, that's true. I'm kind of blocked on what tristan suggested tbh so I thought I could fix these in the meantime15:05
laurencewhich suggestion?15:06
alexandrufazakasUsing a sphinx template to generate the files15:06
laurencehave you made my suggested wording changes?15:06
laurencechanges/ additions?15:06
alexandrufazakaslaurence: No, but I can do that too sure15:06
laurenceIt would be best to have just a sphinx "from scratch" project there to generate the main index page with, rather than to use BuildStream's.15:08
laurencewhat's blocking?15:08
alexandrufazakasI don't understand sphinx or restructuredtext at all, I'm trying to follow examples but nothing works15:09
alexandrufazakasI juts need to know how to add an index.rst from a bst artifact to the main index.rst15:09
alexandrufazakasAnd everything should go alright afterwards I think15:09
laurenceright15:12
laurenceso maybe we can fix that outside of this15:13
alexandrufazakasSure15:13
laurencein the meantime, what's the story with the auto committers?15:13
laurencejust needs an approval and merge? If so, tlater[m] is on a plane right now, he can do it when he lands though15:14
alexandrufazakaslaurence: Yep, everything is resolved on the MR15:14
alexandrufazakasAnother review should do15:14
alexandrufazakasIn case anyone else can have a look over it, it's about !150515:16
gitlab-br-botMR !1505: Automatically build a list of committers https://gitlab.com/BuildStream/buildstream/merge_requests/150515:16
benschubertIs there any reasons we would not be able to get the logs from a workspaced build in BuildStream?15:18
benschubertjuergbi, jennis, Kinnison ^ ?15:18
benschubertI mean a technical reason, not a bug :)15:18
juergbiI can't think of one15:20
laurenceI reviewed it and spotted some typos, alexandrufazakas15:22
alexandrufazakaslaurence: Can you point them out to me, please?15:23
alexandrufazakasOh, you posted them on the Mr15:23
alexandrufazakaseven better, cheers15:23
alexandrufazakasI'll skim through CONTRIBUTING.rst once more as well to make sure it's alright15:26
laurencegood idea15:26
benschubertjuergbi: thanks! That was my understanding too15:26
*** bochecha_ has joined #buildstream15:36
*** bochecha has quit IRC15:38
*** bochecha_ is now known as bochecha15:38
*** phildawson_ has joined #buildstream15:41
*** phil has quit IRC15:43
*** phildawson_ has quit IRC16:00
*** phildawson has joined #buildstream16:11
*** bochecha has quit IRC16:35
*** tpollard has quit IRC16:37
*** tpollard has joined #buildstream16:45
gitlab-br-bottpollard opened (was WIP) MR !1500 (tpollard/messageobject->master: Message rework) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/150016:46
benschubertjuergbi: Am I missing something or should https://gitlab.com/BuildStream/buildstream/commit/df50bf766070449211540d69c851aad18e868847 work ? (just to make sure I'm not forgetting something and that it is indeed a bug)16:46
*** adds68 has quit IRC17:01
*** ikerperez has quit IRC17:01
*** alexandrufazakas has quit IRC17:01
*** Becky has quit IRC17:01
*** samkirkham has quit IRC17:01
gitlab-br-botmarge-bot123 closed issue #1071 (Committers list should align with Gitlab users and permissions and be fully automated) on buildstream https://gitlab.com/BuildStream/buildstream/issues/107117:13
gitlab-br-botmarge-bot123 merged MR !1505 (alexfazakas/fetch-committers->master: Automatically build a list of committers) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/150517:13
*** alexandrufazakas has joined #buildstream17:13
gitlab-br-botBenjaminSchubert opened issue #1096 (BuildStream cannot show logs of a workspaced build) on buildstream https://gitlab.com/BuildStream/buildstream/issues/109617:28
*** phildawson has quit IRC17:32
*** tiagogomes has quit IRC17:35
*** tiagogomes has joined #buildstream17:35
*** jonathanmaw has quit IRC18:07
*** kapip has quit IRC18:26
*** phoenix has joined #buildstream18:35
*** flatmush has quit IRC18:40
*** flatmush has joined #buildstream18:41
*** flatmush has quit IRC18:44
*** flatmush has joined #buildstream18:45
*** bochecha has joined #buildstream18:59
*** flatmush has quit IRC19:06
*** flatmush has joined #buildstream19:07
*** narispo has quit IRC20:00
*** narispo has joined #buildstream20:01
*** bochecha has quit IRC21:22
*** phoenix has quit IRC21:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!