| *** tristan has quit IRC | 04:56 | |
| *** mohan43u has joined #buildstream | 06:09 | |
| *** tristan has joined #buildstream | 06:38 | |
| *** benschubert has joined #buildstream | 07:50 | |
| *** alexandrufazakas has joined #buildstream | 08:07 | |
| gitlab-br-bot | jjardon opened (was WIP) MR !1327 (jjardon/aarch64_fedora30->master: .gitlab-ci.yml: Use fedora30 for aarch64 overnigth tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1327 | 08:11 |
|---|---|---|
| gitlab-br-bot | aevri opened (was WIP) MR !1455 (aevri/vulture->master: Remove some unused code) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1455 | 08:22 |
| gitlab-br-bot | aevri opened (was WIP) MR !1454 (aevri/rm_artifacts->master: _artifact: rm unused _artifacts member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1454 | 08:23 |
| *** mohan43u has quit IRC | 08:23 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1454 (aevri/rm_artifacts->master: _artifact: rm unused _artifacts member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1454 | 08:30 |
| *** bochecha has joined #buildstream | 08:33 | |
| *** bochecha has quit IRC | 08:52 | |
| *** bochecha has joined #buildstream | 08:53 | |
| gitlab-br-bot | jennis approved MR !1454 (aevri/rm_artifacts->master: _artifact: rm unused _artifacts member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1454 | 09:04 |
| *** jonathanmaw has joined #buildstream | 09:05 | |
| jennis | Wow aevri, that's a lot of unused code! | 09:17 |
| aevri | Hehe yeah, that's not even all of it :) | 09:18 |
| aevri | I'm suspecting that Marge may be asleep. | 09:22 |
| *** lachlan has joined #buildstream | 09:23 | |
| * jennis investigates | 09:28 | |
| jennis | aevri, apparently she's not asleep :/ | 09:35 |
| aevri | Thanks for looking! I can see she's done something just now | 09:37 |
| Kinnison | Perhaps she only just had her coffee? | 09:37 |
| * tpollard imagines Marge on Squishee | 09:42 | |
| *** bochecha has quit IRC | 09:42 | |
| *** bochecha has joined #buildstream | 09:43 | |
| gitlab-br-bot | BenjaminSchubert merged MR !1456 (bschubert/node-provenance->bschubert/new-node-api: Yaml improvements around provenance) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1456 | 09:51 |
| gitlab-br-bot | juergbi opened issue #1070 (Reset global _yaml state between tests) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1070 | 10:05 |
| *** lachlan has quit IRC | 10:12 | |
| alexandrufazakas | Is there anywhere BST checks the dependencies' versions? | 10:45 |
| *** lachlan has joined #buildstream | 10:50 | |
| tlater[m] | alexandrufazakas: What do you mean by dependencies in this context? | 10:52 |
| alexandrufazakas | tlater: Uhh, plugins I guess? I was looking at https://gitlab.com/BuildStream/buildstream/issues/903 | 10:52 |
| tlater[m] | Right, so this is a bit more nuanced : | 10:53 |
| tlater[m] | ostree is a dependency of some plugins for buildstream | 10:53 |
| tlater[m] | Originally we used to check when buildstream was installed whether ostree was installed with the right version | 10:54 |
| tlater[m] | And not allow people to install buildstream if it wasn't | 10:54 |
| tlater[m] | My guess is that over updates and such those checks didn't work | 10:54 |
| tlater[m] | In any case, in the mean time, ostree has moved out of the default plugins | 10:55 |
| tlater[m] | This means that we'll really need to make that check happen somewhere in the plugin | 10:55 |
| tlater[m] | alexandrufazakas: Have you tried reproducing that first? I suspect it might not even be an issue anymore. | 10:56 |
| alexandrufazakas | tlater: No, I actually didn't know how to do that | 10:56 |
| tlater[m] | alexandrufazakas: Looking at the issue, this is actually an issue for buildstream 1.2.3 | 10:57 |
| tlater[m] | So you'll need to use the old BuildStream version | 10:57 |
| tlater[m] | And write a bugfix for that :) | 10:57 |
| alexandrufazakas | tlater: I see, aight | 10:57 |
| alexandrufazakas | Thank you :D | 10:57 |
| tlater[m] | To reproduce that bug, grab this repository: https://gitlab.com/freedesktop-sdk/freedesktop-sdk | 10:58 |
| tlater[m] | And build what jjardon built in the issue | 10:58 |
| tlater[m] | At that point it will basically just be looking into the plugin code and adding a check for that ostree version :) | 10:58 |
| *** lachlan has quit IRC | 11:02 | |
| alexandrufazakas | tlater: Are you sure that's the right repo? | 11:03 |
| tlater[m] | alexandrufazakas: honestly, no, but it's an educated guess | 11:03 |
| tlater[m] | You might have to use a different branch from that repo | 11:03 |
| tlater[m] | Ah, alexandrufazakas, it's this: https://github.com/GNOME/gnome-build-meta | 11:05 |
| alexandrufazakas | Yep | 11:05 |
| alexandrufazakas | I've just cloned that one haha | 11:05 |
| tlater[m] | Or rather, this: https://gitlab.gnome.org/GNOME/gnome-build-meta/ | 11:05 |
| alexandrufazakas | Yeah, this one I cloned ^ | 11:05 |
| alexandrufazakas | `Failed to load Source plugin 'git_tag': The 'buildstream-external' distribution was not found and is required by the application` is what I get when doing the same thing | 11:06 |
| tlater[m] | alexandrufazakas: You need to install the plugins, too | 11:07 |
| tlater[m] | https://gitlab.com/BuildStream/bst-external | 11:08 |
| alexandrufazakas | Makes sense. Thank you tlater | 11:08 |
| tlater[m] | ^ Those are additional plugins you need for some things | 11:08 |
| tlater[m] | alexandrufazakas: While you're at it, mind jotting down notes about everything you stumble over? | 11:08 |
| * tlater[m] wants to see how newcomers experience building a new project for UX reasons | 11:09 | |
| alexandrufazakas | tlater: Notes regarding what exactly? Getting the plugins was fairly straight forward and I think I get the same stacktrace with gnome-build-meta now | 11:10 |
| tlater[m] | alexandrufazakas: Every little stumbling stone like "oh, wait, it's not working, what do I do now?" | 11:10 |
| alexandrufazakas | Or not | 11:10 |
| alexandrufazakas | tlater: Sure | 11:10 |
| tlater[m] | It's important to get that newcomer experience as seamless as possible | 11:10 |
| tlater[m] | :) | 11:11 |
| *** lachlan has joined #buildstream | 11:17 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1460 (bschubert/node-provenance-2->bschubert/new-node-api: Replace 'node_get_provenance' by method on 'Node') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1460 | 11:19 |
| *** ChanServ sets mode: +o tristan | 11:20 | |
| tristan | tlater[m], I've been wondering if `utils.get_host_tool()` should have more parameters | 11:20 |
| tristan | One option might be just a string... describing what to do to install that plugin's dependencies | 11:21 |
| tristan | Another option might be a dictionary, with the ID from /etc/os-release as keys, and strings explaining what specifically to do to install that dependency on your distro (with a default just explaining what is missing) | 11:22 |
| tlater[m] | Oh, I like that | 11:22 |
| tlater[m] | It'd be horribly messy to get cross-distro instructions | 11:22 |
| tlater[m] | But a nice hint that points to the repository or something would be cool | 11:22 |
| tristan | if we had a dict then we could say "apt-get install git" on debian based distros, like that | 11:23 |
| tristan | and default to some explanation when you are somewhere like windows | 11:23 |
| tristan | Possibly also have a similar function to just explicitly raise an appropriate error | 11:24 |
| tristan | if for instance, importing the ostree gir bindings doesnt work | 11:24 |
| gitlab-br-bot | LaurenceUrhegyi opened issue #1071 (Committers list should align with Gitlab users and permissions and be fully automated) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1071 | 11:35 |
| *** lachlan has quit IRC | 11:38 | |
| aevri | I take it back, I think the Marge activity I saw was really my own. She's not merging this one, even though it's ready: https://gitlab.com/BuildStream/buildstream/merge_requests/1440 | 11:47 |
| tpollard | no activity for 16 hours | 11:47 |
| *** lachlan has joined #buildstream | 11:51 | |
| * tlater[m] ponders if writing a regex for rst to avoid dependencies is a good idea | 11:52 | |
| *** lachlan has quit IRC | 12:02 | |
| WSalmon | Hi benschubert I was wondering if you would have a chance to have another look at my feedback to you points on https://gitlab.com/BuildStream/buildstream/merge_requests/1429 some time soon? just so long as its some were on your todo :) thanks | 12:03 |
| gitlab-br-bot | aevri opened issue #1072 (Add 'Vulture' to our automated testing) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1072 | 12:16 |
| aevri | 3 things from me waiting on Marge | 12:22 |
| tristan | It really takes time and effort to maintain that hair do | 12:24 |
| benschubert | WSalmon: I'll look at it in the afternoon | 12:37 |
| WSalmon | thanks benschubert | 12:41 |
| laurence | nb all - monthly irc team meeting will begin in 58 minutes, over on #buildstream-meetings | 13:02 |
| *** lachlan has joined #buildstream | 13:26 | |
| jonathanmaw | tristan: I've made the requested changes to !1409 | 13:27 |
| gitlab-br-bot | MR !1409: Separate frontend state handling from core state https://gitlab.com/BuildStream/buildstream/merge_requests/1409 | 13:28 |
| *** lachlan has quit IRC | 13:31 | |
| jonathanmaw | I got slightly peeved about some CI failures, but I either fixed it and forgot about it, or rebasing against master made it disappear | 13:31 |
| jennis | aevri, i'll see if anything can be done about that | 13:39 |
| aevri | jennis, thanks! | 13:40 |
| benschubert | hey tristan should I split the yaml stuff between node.py (public) and _yaml.py (private), and keep the yaml stuff cleanly separate from the nodes? | 13:54 |
| tristan | benschubert, I'm a bit ambivalent, it seems to me that the remaining yaml stuff is very small, perhaps mostly can live as private function in node.py ? | 13:59 |
| tristan | I say that without looking at the branch, though | 14:00 |
| laurence | monthly irc team meeting will begin in 1 minute, over in #buildstream-meetings | 14:00 |
| benschubert | tristan: remaining yaml is roughly 3-400 lines of code. I'm happy to keep everything in one file, but might be slightly more confusing :) | 14:01 |
| tristan | benschubert, in general, if it is really not much left, it would be better to move it to node.py as private functions (or Node classmethods ?) | 14:01 |
| tristan | that sounds like a significant amount | 14:01 |
| tristan | then maybe keep it in _yaml indeed - point was mostly lets not make things harder to find | 14:02 |
| gitlab-br-bot | marge-bot123 merged MR !1327 (jjardon/aarch64_fedora30->master: .gitlab-ci.yml: Use fedora30 for aarch64 overnigth tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1327 | 14:29 |
| jennis | \o/ | 14:29 |
| jennis | Ok found the problem... | 14:30 |
| jennis | So !1327 was assigned to both Marge *and* to Javier, and from the looks of the debug data, she was looking at the first MR for buildstream, !1327, failing because herself and Javier were assigned, and then skipping to the next repo | 14:31 |
| jennis | aevri ^ | 14:31 |
| jennis | Unassigning Javier "just worked" | 14:31 |
| aevri | Aha, good to know, thanks! | 14:32 |
| aevri | I wonder if she can be coaxed to comment in that situation | 14:32 |
| * tlater[m] has seen this on one of his branches before, too | 14:33 | |
| *** lachlan has joined #buildstream | 14:34 | |
| jennis | I've filed an upstream issue for now: https://github.com/smarkets/marge-bot/issues/214 | 14:46 |
| gitlab-br-bot | tlater opened MR !1461 (tlater/auto-committers->master: Add a script to automatically update committers) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1461 | 14:59 |
| *** lachlan has quit IRC | 15:04 | |
| *** alexandrufazakas has quit IRC | 15:06 | |
| *** alexandrufazakas has joined #buildstream | 15:06 | |
| *** tristan has quit IRC | 15:14 | |
| *** tristan has joined #buildstream | 15:26 | |
| *** lachlan has joined #buildstream | 15:26 | |
| *** lachlan has quit IRC | 15:47 | |
| gitlab-br-bot | marge-bot123 merged MR !1440 (aevri/win32_tempfilename->master: _artifact: use win32-compatible named temp file) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1440 | 15:48 |
| *** lachlan has joined #buildstream | 15:54 | |
| *** lachlan has quit IRC | 15:58 | |
| *** lachlan has joined #buildstream | 16:02 | |
| *** bochecha has quit IRC | 16:05 | |
| *** lachlan has quit IRC | 16:08 | |
| gitlab-br-bot | marge-bot123 merged MR !1454 (aevri/rm_artifacts->master: _artifact: rm unused _artifacts member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1454 | 16:19 |
| *** lachlan has joined #buildstream | 16:26 | |
| *** lachlan has quit IRC | 16:31 | |
| *** alexandrufazakas has quit IRC | 16:34 | |
| *** lachlan has joined #buildstream | 16:46 | |
| *** lachlan has quit IRC | 17:04 | |
| *** jonathanmaw has quit IRC | 17:14 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1462 (bschubert/node-cleanup->bschubert/new-node-api: _yaml: Remove code duplication on '_new_node_from_*') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1462 | 17:15 |
| *** lachlan has joined #buildstream | 17:18 | |
| *** lachlan has quit IRC | 17:19 | |
| gitlab-br-bot | marge-bot123 merged MR !1409 (jonathan/frontend-separation->master: Separate frontend state handling from core state) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1409 | 17:24 |
| gitlab-br-bot | marge-bot123 merged MR !1455 (aevri/vulture->master: Remove some unused code) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1455 | 21:16 |
| *** dftxbs3e has quit IRC | 21:50 | |
| *** dftxbs3e has joined #buildstream | 21:59 | |
| *** dftxbs3e has quit IRC | 22:28 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!