IRC logs for #buildstream for Friday, 2019-07-05

*** lantw44 has quit IRC04:24
*** lantw44 has joined #buildstream04:26
*** lantw44 has quit IRC04:33
*** lantw44 has joined #buildstream04:33
*** lantw44 has quit IRC04:51
*** lantw44 has joined #buildstream04:52
*** lantw44 has quit IRC04:55
*** lantw44 has joined #buildstream04:59
*** alexandrufazakas has joined #buildstream08:03
*** tpollard has joined #buildstream08:34
*** jonathanmaw has joined #buildstream08:35
Kinnisonaevri: 👍08:38
jonathanmawtristan: morning! I managed to find a cause for duplicate elements being pushed into a queue while debugging yesterday, and sorted that out08:44
jonathanmawso !1409 is ready for review now, unless you'd rather I separate the fixes into separate commits (I got lazy yesterday and just did `git commit --amend`)08:45
gitlab-br-botMR !1409: Separate frontend state handling from core state https://gitlab.com/BuildStream/buildstream/merge_requests/140908:45
*** ChanServ sets mode: +o tristan08:46
tristanjonathanmaw, I don't quite understand from that sentence... you found a cause... is it somehow a valid one ?08:46
tristanor you "fixed" it so it wouldnt happen anymore ?08:46
jonathanmawtristan: fixed so it wouldn't happen any more.08:47
tristan:)08:47
jonathanmawin `bst show` there was a point where we had the same element twice in the list of elements pushed into the queue08:47
tristanI'll take a look... sounds like it's orthogonal to the operation and separate commits would be desirable indeed08:49
jonathanmawokay, I'll see if I have time to sort that out today08:53
*** traveltissues has joined #buildstream09:00
*** benschubert has joined #buildstream09:06
gitlab-br-botBenjaminSchubert opened MR !1453 (bschubert/node-api-private->bschubert/new-node-api: Make Node attributes c-only accessible and optimize node creation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/145309:10
*** tristan has quit IRC09:21
*** tristan has joined #buildstream09:25
*** ChanServ sets mode: +o tristan09:27
tristanjonathanmaw, So while I'm looking... can you point me to the part of !1409 which fixes double queuing of the same element ?09:27
jonathanmaw_stream.py, line 18909:29
tristanAhhhhh09:34
tristan[element] + missing_deps09:34
tristanjonathanmaw, nice catch, yeah that we should really split out into a separate commit placed in advance of this refactor09:34
tristanjonathanmaw, I wonder if we could make that intersection of lists (like add two list while excluding duplicates) more elegant than a loop09:36
tristanjonathanmaw, Maybe either python has a nicer way to express this, or we could add a Pipeline function like the existing Pipeline.subtract_elements() ?09:36
*** lachlan has joined #buildstream09:39
* tristan adds comment there09:39
*** lachlan has quit IRC09:47
gitlab-br-botjuergbi opened issue #1064 (Proxy process for artifact and source services) on buildstream https://gitlab.com/BuildStream/buildstream/issues/106409:47
jonathanmawthanks, tristan. Hopefully I'll have time to fix that today, most likely I'll have to look at it on Monday.09:59
*** tristan has quit IRC10:16
*** tristan has joined #buildstream10:18
gitlab-br-botmarge-bot123 merged MR !1445 (aevri/messenger->master: Extract 'Messenger' from 'Context' and use directly) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/144510:20
*** tristan has quit IRC10:21
*** lachlan has joined #buildstream10:23
Kinnisonaevri: Would https://techcommunity.microsoft.com/t5/Windows-Kernel-Internals/Windows-Sandbox/ba-p/301849 potentially be of interest in sandboxing builds on Windows?10:24
aevri👍 I think that's going to be very interesting!10:27
*** lachlan has quit IRC10:27
*** lachlan has joined #buildstream10:32
*** tristan has joined #buildstream10:36
*** lachlan has quit IRC10:38
gitlab-br-bottlater opened issue #1065 (Supply options to turn off networking features) on buildstream https://gitlab.com/BuildStream/buildstream/issues/106510:49
valentindjonathanmaw, just something quick. If fixed your comments on https://gitlab.com/BuildStream/bst-external/merge_requests/89 Maybe you can have a quick look to verify and resolve the threads.11:01
* jonathanmaw has a poke11:03
jonathanmawsorted11:05
valentindjonathanmaw, thank you.11:05
*** lachlan has joined #buildstream11:15
*** lachlan has quit IRC11:20
*** tristan has quit IRC11:24
*** lachlan has joined #buildstream11:52
*** lachlan has quit IRC11:58
jjardonjonathanmaw: can you make a new take of bst-external please?12:04
jonathanmawjjardon: okie doke12:19
gitlab-br-botBenjaminSchubert merged MR !1453 (bschubert/node-api-private->bschubert/new-node-api: Make Node attributes c-only accessible and optimize node creation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/145312:21
jonathanmawjjardon: tag 0.15.0 pushed12:21
gitlab-br-botraoul.hidalgocharman opened (was WIP) MR !1452 (raoul/994-further-re-testing->master: Further RE testing) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/145212:40
gitlab-br-botraoul.hidalgocharman opened issue #1066 (Incomplete sources with remote execution) on buildstream https://gitlab.com/BuildStream/buildstream/issues/106613:00
traveltissueswill one of the owners please give @traveltissues dev access, I have a branch I'd like to push13:13
*** traveltissues has quit IRC13:16
*** traveltissues has joined #buildstream13:16
traveltissuesjjardon? ^13:20
laurencevalentind, can you do this also maybe?13:20
valentindI can do that.13:22
jjardonjonathanmaw: thanks!13:22
valentindlaurence, Added traveltissues as dev.13:22
traveltissuesthanks valentind13:22
*** lachlan has joined #buildstream13:43
*** lachlan has quit IRC13:46
laurencethank you !13:49
*** lachlan has joined #buildstream14:22
*** lachlan has quit IRC14:26
*** dftxbs3e has quit IRC14:45
*** cs-shadow has joined #buildstream14:48
*** bochecha has quit IRC15:06
gitlab-br-bottlater opened issue #1067 (bst artifact/source checkout UI should be made consistent with workspace checkout) on buildstream https://gitlab.com/BuildStream/buildstream/issues/106715:26
gitlab-br-bottlater opened issue #1068 (Collective UI/UX rework/standardization tracking issue) on buildstream https://gitlab.com/BuildStream/buildstream/issues/106815:28
*** jonathanmaw has quit IRC15:38
*** traveltissues has quit IRC15:40
*** tpollard has quit IRC15:42
*** lachlan has joined #buildstream16:00
*** lachlan has quit IRC16:04
gitlab-br-botaevri opened (was WIP) MR !1440 (aevri/win32_tempfilename->master: _artifact: use win32-compatible named temp file) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/144016:29
*** lachlan has joined #buildstream16:30
*** lachlan has quit IRC16:33
*** alexandrufazakas has quit IRC16:42
*** lachlan has joined #buildstream17:00
*** dftxbs3e has joined #buildstream17:03
*** lachlan has quit IRC17:03
gitlab-br-botBenjaminSchubert opened MR !1456 (bschubert/node-provenance->bschubert/new-node-api: Yaml improvements around provenance) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/145617:05
*** cs-shadow has quit IRC17:36
*** lachlan has joined #buildstream17:42
*** lachlan has quit IRC17:52
*** lachlan has joined #buildstream18:24
*** lachlan has quit IRC18:27
*** tristan has joined #buildstream19:26
*** lachlan has joined #buildstream19:35
*** tristan has quit IRC19:38
*** lachlan has quit IRC19:39
*** dftxbs3e has quit IRC19:40
*** lachlan has joined #buildstream19:41
*** dftxbs3e has joined #buildstream19:41
*** lachlan has quit IRC19:44
*** traveltissues has joined #buildstream19:54
*** tristan has joined #buildstream20:06
*** traveltissues has quit IRC20:07
*** benschubert has quit IRC20:22
*** dftxbs3e has quit IRC20:37
*** dftxbs3e has joined #buildstream20:37
*** slaf has quit IRC21:24
*** slaf has joined #buildstream21:24
*** slaf has joined #buildstream21:24
*** slaf has joined #buildstream21:25
*** slaf has joined #buildstream21:25

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!