*** lantw44 has quit IRC | 04:24 | |
*** lantw44 has joined #buildstream | 04:26 | |
*** lantw44 has quit IRC | 04:33 | |
*** lantw44 has joined #buildstream | 04:33 | |
*** lantw44 has quit IRC | 04:51 | |
*** lantw44 has joined #buildstream | 04:52 | |
*** lantw44 has quit IRC | 04:55 | |
*** lantw44 has joined #buildstream | 04:59 | |
*** alexandrufazakas has joined #buildstream | 08:03 | |
*** tpollard has joined #buildstream | 08:34 | |
*** jonathanmaw has joined #buildstream | 08:35 | |
Kinnison | aevri: 👍 | 08:38 |
---|---|---|
jonathanmaw | tristan: morning! I managed to find a cause for duplicate elements being pushed into a queue while debugging yesterday, and sorted that out | 08:44 |
jonathanmaw | so !1409 is ready for review now, unless you'd rather I separate the fixes into separate commits (I got lazy yesterday and just did `git commit --amend`) | 08:45 |
gitlab-br-bot | MR !1409: Separate frontend state handling from core state https://gitlab.com/BuildStream/buildstream/merge_requests/1409 | 08:45 |
*** ChanServ sets mode: +o tristan | 08:46 | |
tristan | jonathanmaw, I don't quite understand from that sentence... you found a cause... is it somehow a valid one ? | 08:46 |
tristan | or you "fixed" it so it wouldnt happen anymore ? | 08:46 |
jonathanmaw | tristan: fixed so it wouldn't happen any more. | 08:47 |
tristan | :) | 08:47 |
jonathanmaw | in `bst show` there was a point where we had the same element twice in the list of elements pushed into the queue | 08:47 |
tristan | I'll take a look... sounds like it's orthogonal to the operation and separate commits would be desirable indeed | 08:49 |
jonathanmaw | okay, I'll see if I have time to sort that out today | 08:53 |
*** traveltissues has joined #buildstream | 09:00 | |
*** benschubert has joined #buildstream | 09:06 | |
gitlab-br-bot | BenjaminSchubert opened MR !1453 (bschubert/node-api-private->bschubert/new-node-api: Make Node attributes c-only accessible and optimize node creation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1453 | 09:10 |
*** tristan has quit IRC | 09:21 | |
*** tristan has joined #buildstream | 09:25 | |
*** ChanServ sets mode: +o tristan | 09:27 | |
tristan | jonathanmaw, So while I'm looking... can you point me to the part of !1409 which fixes double queuing of the same element ? | 09:27 |
jonathanmaw | _stream.py, line 189 | 09:29 |
tristan | Ahhhhh | 09:34 |
tristan | [element] + missing_deps | 09:34 |
tristan | jonathanmaw, nice catch, yeah that we should really split out into a separate commit placed in advance of this refactor | 09:34 |
tristan | jonathanmaw, I wonder if we could make that intersection of lists (like add two list while excluding duplicates) more elegant than a loop | 09:36 |
tristan | jonathanmaw, Maybe either python has a nicer way to express this, or we could add a Pipeline function like the existing Pipeline.subtract_elements() ? | 09:36 |
*** lachlan has joined #buildstream | 09:39 | |
* tristan adds comment there | 09:39 | |
*** lachlan has quit IRC | 09:47 | |
gitlab-br-bot | juergbi opened issue #1064 (Proxy process for artifact and source services) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1064 | 09:47 |
jonathanmaw | thanks, tristan. Hopefully I'll have time to fix that today, most likely I'll have to look at it on Monday. | 09:59 |
*** tristan has quit IRC | 10:16 | |
*** tristan has joined #buildstream | 10:18 | |
gitlab-br-bot | marge-bot123 merged MR !1445 (aevri/messenger->master: Extract 'Messenger' from 'Context' and use directly) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1445 | 10:20 |
*** tristan has quit IRC | 10:21 | |
*** lachlan has joined #buildstream | 10:23 | |
Kinnison | aevri: Would https://techcommunity.microsoft.com/t5/Windows-Kernel-Internals/Windows-Sandbox/ba-p/301849 potentially be of interest in sandboxing builds on Windows? | 10:24 |
aevri | 👍 I think that's going to be very interesting! | 10:27 |
*** lachlan has quit IRC | 10:27 | |
*** lachlan has joined #buildstream | 10:32 | |
*** tristan has joined #buildstream | 10:36 | |
*** lachlan has quit IRC | 10:38 | |
gitlab-br-bot | tlater opened issue #1065 (Supply options to turn off networking features) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1065 | 10:49 |
valentind | jonathanmaw, just something quick. If fixed your comments on https://gitlab.com/BuildStream/bst-external/merge_requests/89 Maybe you can have a quick look to verify and resolve the threads. | 11:01 |
* jonathanmaw has a poke | 11:03 | |
jonathanmaw | sorted | 11:05 |
valentind | jonathanmaw, thank you. | 11:05 |
*** lachlan has joined #buildstream | 11:15 | |
*** lachlan has quit IRC | 11:20 | |
*** tristan has quit IRC | 11:24 | |
*** lachlan has joined #buildstream | 11:52 | |
*** lachlan has quit IRC | 11:58 | |
jjardon | jonathanmaw: can you make a new take of bst-external please? | 12:04 |
jonathanmaw | jjardon: okie doke | 12:19 |
gitlab-br-bot | BenjaminSchubert merged MR !1453 (bschubert/node-api-private->bschubert/new-node-api: Make Node attributes c-only accessible and optimize node creation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1453 | 12:21 |
jonathanmaw | jjardon: tag 0.15.0 pushed | 12:21 |
gitlab-br-bot | raoul.hidalgocharman opened (was WIP) MR !1452 (raoul/994-further-re-testing->master: Further RE testing) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1452 | 12:40 |
gitlab-br-bot | raoul.hidalgocharman opened issue #1066 (Incomplete sources with remote execution) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1066 | 13:00 |
traveltissues | will one of the owners please give @traveltissues dev access, I have a branch I'd like to push | 13:13 |
*** traveltissues has quit IRC | 13:16 | |
*** traveltissues has joined #buildstream | 13:16 | |
traveltissues | jjardon? ^ | 13:20 |
laurence | valentind, can you do this also maybe? | 13:20 |
valentind | I can do that. | 13:22 |
jjardon | jonathanmaw: thanks! | 13:22 |
valentind | laurence, Added traveltissues as dev. | 13:22 |
traveltissues | thanks valentind | 13:22 |
*** lachlan has joined #buildstream | 13:43 | |
*** lachlan has quit IRC | 13:46 | |
laurence | thank you ! | 13:49 |
*** lachlan has joined #buildstream | 14:22 | |
*** lachlan has quit IRC | 14:26 | |
*** dftxbs3e has quit IRC | 14:45 | |
*** cs-shadow has joined #buildstream | 14:48 | |
*** bochecha has quit IRC | 15:06 | |
gitlab-br-bot | tlater opened issue #1067 (bst artifact/source checkout UI should be made consistent with workspace checkout) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1067 | 15:26 |
gitlab-br-bot | tlater opened issue #1068 (Collective UI/UX rework/standardization tracking issue) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1068 | 15:28 |
*** jonathanmaw has quit IRC | 15:38 | |
*** traveltissues has quit IRC | 15:40 | |
*** tpollard has quit IRC | 15:42 | |
*** lachlan has joined #buildstream | 16:00 | |
*** lachlan has quit IRC | 16:04 | |
gitlab-br-bot | aevri opened (was WIP) MR !1440 (aevri/win32_tempfilename->master: _artifact: use win32-compatible named temp file) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1440 | 16:29 |
*** lachlan has joined #buildstream | 16:30 | |
*** lachlan has quit IRC | 16:33 | |
*** alexandrufazakas has quit IRC | 16:42 | |
*** lachlan has joined #buildstream | 17:00 | |
*** dftxbs3e has joined #buildstream | 17:03 | |
*** lachlan has quit IRC | 17:03 | |
gitlab-br-bot | BenjaminSchubert opened MR !1456 (bschubert/node-provenance->bschubert/new-node-api: Yaml improvements around provenance) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1456 | 17:05 |
*** cs-shadow has quit IRC | 17:36 | |
*** lachlan has joined #buildstream | 17:42 | |
*** lachlan has quit IRC | 17:52 | |
*** lachlan has joined #buildstream | 18:24 | |
*** lachlan has quit IRC | 18:27 | |
*** tristan has joined #buildstream | 19:26 | |
*** lachlan has joined #buildstream | 19:35 | |
*** tristan has quit IRC | 19:38 | |
*** lachlan has quit IRC | 19:39 | |
*** dftxbs3e has quit IRC | 19:40 | |
*** lachlan has joined #buildstream | 19:41 | |
*** dftxbs3e has joined #buildstream | 19:41 | |
*** lachlan has quit IRC | 19:44 | |
*** traveltissues has joined #buildstream | 19:54 | |
*** tristan has joined #buildstream | 20:06 | |
*** traveltissues has quit IRC | 20:07 | |
*** benschubert has quit IRC | 20:22 | |
*** dftxbs3e has quit IRC | 20:37 | |
*** dftxbs3e has joined #buildstream | 20:37 | |
*** slaf has quit IRC | 21:24 | |
*** slaf has joined #buildstream | 21:24 | |
*** slaf has joined #buildstream | 21:24 | |
*** slaf has joined #buildstream | 21:25 | |
*** slaf has joined #buildstream | 21:25 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!