| gitlab-br-bot | jjardon closed issue #1046 (overnigth test are failing: "Value of 'submodules' is not of the expected type 'Mapping'") on buildstream https://gitlab.com/BuildStream/buildstream/issues/1046 | 05:30 |
|---|---|---|
| *** tristan has quit IRC | 06:48 | |
| *** tristan has joined #buildstream | 07:12 | |
| *** bochecha has joined #buildstream | 08:05 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1412 (bschubert/remove-useless-sanitize->master: _yaml: Remove useless calls to '_yaml.node_sanitize') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1412 | 08:23 |
| *** raoul has joined #buildstream | 08:51 | |
| *** ChanServ sets mode: +o tristan | 08:52 | |
| tristan | benschubert, I put a bunch of comments there as you noticed, I think I wont comment on the discussion we had yesterday for now, let's leave that some time to digest and reconsider | 08:52 |
| tristan | I had a tentative thought that we could place "sanitizers" or "constraints" on Nodes in advance of extracting values... like Node.add_constraint(ProjectPathConstraint())... or such | 08:53 |
| tristan | probably there are few creative ideas we can come up with for that to make it nice | 08:54 |
| tristan | benschubert, But I am entertaining some codethings which came to Seoul | 08:55 |
| tristan | (Awesome !) ... so I wont be around to discuss more today unfortunately... I better go shave and not look like a barbarian... | 08:56 |
| benschubert | tristan: Sure, I agree, it will be easier to reason about it with a clearer API in mind. Just one comment though, adding contraints beforehand like that might slow down the code parsing, as more thigns would need to be done | 08:56 |
| benschubert | I don't think we can afford having that there | 08:56 |
| benschubert | but we can definitely discuss it later on | 08:57 |
| raoul | juergbi, have you had a chance to look at my changes to !1402 for your points? Realise you wont get a chance to look till Monday now | 09:01 |
| gitlab-br-bot | MR !1402: Configuration option for disabling blob fetching with RE https://gitlab.com/BuildStream/buildstream/merge_requests/1402 | 09:01 |
| *** tristan has quit IRC | 09:02 | |
| juergbi | raoul: no, sorry, missed your updates somehow. maybe I can take a quick look this afternoon | 09:04 |
| jennis | raoul, perhaps this hardcoded shasum is ok, I feel as if any workarounds we come up with are going to be just as ugly | 09:04 |
| raoul | cool thanks juergbi | 09:04 |
| raoul | yeah I thought I'd been clever with the shell command, but couldn't get it to work | 09:05 |
| raoul | though I think variable expansion should probably work in shell commands so I'll have a bit more of a look and raise an issue | 09:06 |
| jennis | Ok cool | 09:06 |
| *** jonathanmaw has joined #buildstream | 09:14 | |
| *** tristan has joined #buildstream | 09:22 | |
| *** lachlan has joined #buildstream | 10:05 | |
| *** lachlan has quit IRC | 10:27 | |
| *** lachlan has joined #buildstream | 10:35 | |
| *** lachlan has quit IRC | 10:44 | |
| *** lachlan has joined #buildstream | 11:02 | |
| * tlater[m] is midldly annoyed that he has to manually compress the output of `bst artifact checkout --tar` | 11:10 | |
| tlater[m] | Is there a reason for that? I suppose the correct thing to do would be to run whatever compression in BuildStream and actually just output a tarball in a `--directory`, but this saves me writing another element - I just need a wrapper script to compress now |: | 11:11 |
| *** lachlan has quit IRC | 11:20 | |
| jennis | uhh that is annoying | 11:39 |
| jennis | But I think you've found another newcomer bug :D | 11:39 |
| jennis | ah yeah, `bst artifact checkout hello.bst --tar here` just gives you a tar file called "here" | 11:40 |
| *** lachlan has joined #buildstream | 11:44 | |
| gitlab-br-bot | jennis approved MR !1412 (bschubert/remove-useless-sanitize->master: _yaml: Remove useless calls to '_yaml.node_sanitize') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1412 | 11:45 |
| gitlab-br-bot | jennis opened (was WIP) MR !1403 (jennis/junctions_and_remotes->master: Do not (optionally) remotely cache junctioned elements in parent project remotes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1403 | 11:48 |
| *** lachlan has quit IRC | 12:04 | |
| tlater[m] | jennis: My problem is that here.tar.gz doesn't give you a gzipped tarball - I think it's fine if it uses the file name you ask it to use. The current behavior might even be alright, it's just annoying that there's no way to also compress your tarball without writing a whole BuildStream element. | 12:19 |
| jennis | Yep, I think it'd be nice to parse the string and do the appropriate compression | 13:11 |
| *** lachlan has joined #buildstream | 13:12 | |
| *** lachlan has quit IRC | 13:31 | |
| *** lachlan has joined #buildstream | 13:41 | |
| *** lachlan has quit IRC | 13:57 | |
| *** lachlan has joined #buildstream | 14:21 | |
| *** lachlan has quit IRC | 14:25 | |
| jennis | Hi all, I've recently unwipped: https://gitlab.com/BuildStream/buildstream/merge_requests/1403 I would appreciate if anyone could take the time to review :) | 14:34 |
| juergbi | raoul: I've added a couple of comments | 14:38 |
| raoul | ta juergbi | 14:38 |
| *** lachlan has joined #buildstream | 14:46 | |
| gitlab-br-bot | tlater opened issue #1048 (`bst artifact checkout --tar` should allow compression) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1048 | 15:08 |
| tlater[m] | jennis: ^ if you're interested (: | 15:09 |
| * tlater[m] hopes this isn't controversial | 15:09 | |
| gitlab-br-bot | tlater opened MR !1413 (tlater/freedesktop->master: Use a freedesktop-sdk tar as a base image) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1413 | 15:30 |
| jennis | tlater[m], thanks for filing that | 15:46 |
| jennis | juergbi, I've responded to your comments on !1406 (benschubert, I know you also reviewed and were in agreement with juergbi) and posted the latest benchmarks, we've retained a similar speedup | 15:50 |
| gitlab-br-bot | MR !1406: WIP: Notify direct reverse dependencies when an Element becomes ready for runtime and cached https://gitlab.com/BuildStream/buildstream/merge_requests/1406 | 15:50 |
| jennis | :) | 15:51 |
| gitlab-br-bot | jennis opened (was WIP) MR !1406 (jennis/notify_reverse_deps->master: Notify direct reverse dependencies when an Element becomes ready for runtime and cached) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1406 | 15:51 |
| *** lachlan has quit IRC | 15:55 | |
| *** lachlan has joined #buildstream | 15:56 | |
| *** bochecha has quit IRC | 15:59 | |
| *** lachlan has quit IRC | 16:28 | |
| *** raoul has quit IRC | 16:31 | |
| *** lachlan has joined #buildstream | 16:37 | |
| *** dftxbs3e has quit IRC | 16:41 | |
| *** lachlan has quit IRC | 16:41 | |
| *** dftxbs3e has joined #buildstream | 16:43 | |
| *** dftxbs3e has joined #buildstream | 16:45 | |
| *** lachlan has joined #buildstream | 16:49 | |
| *** rdale has quit IRC | 16:51 | |
| *** jonathanmaw has quit IRC | 17:07 | |
| *** bochecha has joined #buildstream | 17:32 | |
| *** lachlan has quit IRC | 18:03 | |
| *** lachlan has joined #buildstream | 18:13 | |
| *** lachlan has quit IRC | 18:21 | |
| *** lachlan has joined #buildstream | 18:30 | |
| *** lachlan has quit IRC | 18:39 | |
| *** lachlan has joined #buildstream | 18:47 | |
| *** lachlan has quit IRC | 19:40 | |
| *** cs-shadow has quit IRC | 21:00 | |
| *** bochecha has quit IRC | 21:34 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!