| *** rdale has quit IRC | 03:41 | |
| *** rdale has joined #buildstream | 03:41 | |
| *** xjuan has quit IRC | 05:36 | |
| *** xjuan has joined #buildstream | 05:36 | |
| *** rdale_ct has joined #buildstream | 05:45 | |
| *** rdale has quit IRC | 05:46 | |
| *** tristan has quit IRC | 06:59 | |
| *** tristan has joined #buildstream | 07:23 | |
| *** rdale_ct has quit IRC | 07:39 | |
| *** rdale has joined #buildstream | 07:39 | |
| *** rdale has quit IRC | 07:49 | |
| *** rdale has joined #buildstream | 07:49 | |
| *** rdale has quit IRC | 07:56 | |
| *** rdale has joined #buildstream | 07:56 | |
| *** rdale has quit IRC | 07:59 | |
| *** rdale has joined #buildstream | 07:59 | |
| *** rdale has quit IRC | 08:05 | |
| *** rdale has joined #buildstream | 08:10 | |
| jennis | tristan, would you be able to spare some time to address your review comments on: https://gitlab.com/BuildStream/buildstream/merge_requests/1344, please? | 08:12 |
|---|---|---|
| *** rdale_ct has joined #buildstream | 08:13 | |
| *** bochecha has joined #buildstream | 08:13 | |
| *** rdale has quit IRC | 08:14 | |
| *** rdale_ct has quit IRC | 08:40 | |
| *** ChanServ sets mode: +o tristan | 08:41 | |
| tristan | jennis, Right I don't expect to have any objections, I was just pointing out missing comments | 08:41 |
| tristan | I'll take a gander | 08:41 |
| tristan | Or a goose | 08:41 |
| jennis | tristan thanks! | 08:46 |
| tristan | geese are tasty :) | 08:48 |
| *** rdale has joined #buildstream | 08:54 | |
| * tristan has been doing a lot of email and has become sloppy | 08:55 | |
| tristan | apologies for bad grammer an hurried replies - I think the messages get across though :) | 08:55 |
| *** tristan has quit IRC | 08:59 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1384 (bschubert/stricter-node-api->master: Make the Node api stricter, by only accepting nodes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1384 | 09:07 |
| *** jonathanmaw has joined #buildstream | 09:18 | |
| gitlab-br-bot | danielsilverstone-ct approved MR !1384 (bschubert/stricter-node-api->master: Make the Node api stricter, by only accepting nodes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1384 | 09:30 |
| *** tristan has joined #buildstream | 09:43 | |
| *** lachlan has joined #buildstream | 09:45 | |
| tpollard | hmm. can't run the tests on a fresh clone & install | 10:07 |
| tpollard | https://paste.gnome.org/pnc3eiuy7 | 10:08 |
| *** ChanServ sets mode: +o tristan | 10:13 | |
| tristan | tpollard, Maybe has to do with benschubert's changes to _site.py... looks like | 10:13 |
| benschubert | wait wut, how did that break whithout caught in the tests? oO I'll have a look | 10:14 |
| tpollard | BZR is not set if it's not found | 10:17 |
| tpollard | works if I set it to None in the exception handle | 10:17 |
| tpollard | to match GIT | 10:19 |
| tpollard | I can quickly push that change if you want | 10:19 |
| benschubert | tpollard: oh please do | 10:26 |
| benschubert | really sorry about that, Don't know how I ate it | 10:26 |
| benschubert | fedora missing-deps should have caught that :/ | 10:26 |
| benschubert | is ... marge sleeping again? | 10:27 |
| tpollard | benschubert: sure :) | 10:27 |
| gitlab-br-bot | tpollard opened MR !1385 (tpollard/bzrfix->master: testing/_utils/site.py: Fix missing BZR assignment) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1385 | 10:34 |
| gitlab-br-bot | BenjaminSchubert approved MR !1385 (tpollard/bzrfix->master: testing/_utils/site.py: Fix missing BZR assignment) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1385 | 10:35 |
| *** tpollard has quit IRC | 10:52 | |
| *** tpollard has joined #buildstream | 10:52 | |
| *** pointswaves has joined #buildstream | 11:48 | |
| tlater[m] | Is there any way to use `bst artifact delete` recursively? | 11:58 |
| tlater[m] | i.e., given an element I just built, can I remove its artifacts and any artifacts of its dependencies? | 11:58 |
| tpollard | don't think so but that sounds like a nice flag to have | 12:02 |
| tristan | tpollard, Maybe reply to my recent summary email and add that note, the original discussion didnt include `bst artifact delete`, but the summary indicates that all artifact commands should probably support --deps for consistency | 12:07 |
| tristan | tpollard, further, note that this falls under the category of things which can only be done once we have a way to reconstruct the dependency tree from loaded artifacts | 12:07 |
| tristan | tpollard, i.e. `bst artifact checkout --deps all` (or --deps run) is still lacking in that regard, and only works when element names are given | 12:08 |
| tristan | ArtifactElement is intended to cover a part of that (loading symbolic/incomplete elements from artifacts so we can manipulate them in a pseudo/"not fully loaded" data model) | 12:09 |
| tpollard | tristan: we store the builddeps on the artifacts proto, could that not be used in this scenario? | 12:11 |
| tristan | tpollard, We store the deps in artifact metadata also | 12:12 |
| tristan | of course this could have been used, it just simply never was yet | 12:12 |
| tristan | so we don't have a way to reconstruct the data model just from the artifacts | 12:12 |
| tristan | tpollard, probably better to start with supporting it with `bst artifact checkout` | 12:13 |
| tristan | that's important I think | 12:13 |
| tpollard | hmm, we have api to query the proto for a dict of dependencies and keys (get_metadata_dependencies) | 12:14 |
| tpollard | I have no arguments on --deps across the artifact subgroup either way | 12:19 |
| tristan | Right, what we don't have is a way to construct a build graph of ArtifactElement instances | 12:20 |
| tristan | Without loading project data of course, project data can be ignored for loading from artifacts | 12:21 |
| benschubert | Could someone wake marge up? there's 2 PRs waiting for more than 2 hours :( | 12:35 |
| tpollard | I've reported it internally here | 12:36 |
| benschubert | thanks! | 12:43 |
| *** tpollard has quit IRC | 13:03 | |
| *** phildawson_ has quit IRC | 13:04 | |
| *** tristan has quit IRC | 13:05 | |
| *** tpollard has joined #buildstream | 13:09 | |
| *** phildawson_ has joined #buildstream | 13:27 | |
| *** phildawson_ has quit IRC | 13:32 | |
| *** phildawson_ has joined #buildstream | 13:32 | |
| gitlab-br-bot | jennis opened (was WIP) MR !1344 (jennis/push_based_pipeline->master: Push based pipeline) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1344 | 13:45 |
| *** phildawson_ has quit IRC | 14:00 | |
| *** lachlan has quit IRC | 14:01 | |
| *** phildawson_ has joined #buildstream | 14:01 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1344 (jennis/push_based_pipeline->master: Push based pipeline) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1344 | 14:07 |
| *** lachlan has joined #buildstream | 14:13 | |
| gitlab-br-bot | BenjaminSchubert opened (was WIP) MR !1384 (bschubert/stricter-node-api->master: Make the Node api stricter, by only accepting nodes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1384 | 14:28 |
| benschubert | tpollard: any news on marge? | 14:44 |
| Kinnison | Not yet | 14:45 |
| *** phildawson_ has quit IRC | 14:51 | |
| *** tristan has joined #buildstream | 14:53 | |
| *** phildawson_ has joined #buildstream | 14:54 | |
| gitlab-br-bot | marge-bot123 closed issue #1002 (Push-based scheduler optimization) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1002 | 15:05 |
| gitlab-br-bot | marge-bot123 closed issue #943 (BuildStream gets slower with a high number of runners) on buildstream https://gitlab.com/BuildStream/buildstream/issues/943 | 15:05 |
| gitlab-br-bot | marge-bot123 merged MR !1344 (jennis/push_based_pipeline->master: Push based pipeline) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1344 | 15:05 |
| benschubert | o/ | 15:07 |
| benschubert | thanks jennis ! | 15:07 |
| jennis | \o/ | 15:13 |
| benschubert | now: make buildstream faster with more workers | 15:14 |
| jennis | :D | 15:34 |
| gitlab-br-bot | danielsilverstone-ct opened MR !1386 (danielsilverstone-ct/microopts->master: Just a couple of microoptimisations) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1386 | 15:43 |
| gitlab-br-bot | marge-bot123 merged MR !1385 (tpollard/bzrfix->master: testing/_utils/site.py: Fix missing BZR assignment) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1385 | 15:47 |
| *** phil has joined #buildstream | 16:00 | |
| *** bochecha has quit IRC | 16:00 | |
| *** phildawson_ has quit IRC | 16:01 | |
| *** bochecha has joined #buildstream | 16:03 | |
| *** rdale has quit IRC | 16:05 | |
| *** tpollard has quit IRC | 16:30 | |
| *** bochecha has quit IRC | 16:33 | |
| *** xjuan has quit IRC | 16:38 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1386 (danielsilverstone-ct/microopts->master: Just a couple of microoptimisations) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1386 | 16:39 |
| *** Kinnison has left #buildstream | 16:42 | |
| *** lachlan has quit IRC | 16:56 | |
| *** phil has quit IRC | 17:00 | |
| *** jonathanmaw has quit IRC | 17:13 | |
| *** pointswaves has quit IRC | 17:23 | |
| gitlab-br-bot | marge-bot123 merged MR !1384 (bschubert/stricter-node-api->master: Make the Node api stricter, by only accepting nodes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1384 | 17:25 |
| *** xjuan has joined #buildstream | 17:38 | |
| *** pointswaves has joined #buildstream | 17:52 | |
| gitlab-br-bot | marge-bot123 merged MR !1383 (bschubert/optimize-extract-depends-node->master: rewrite _extract_depends_from_node in Cython and optimize) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1383 | 18:05 |
| *** bochecha has joined #buildstream | 18:14 | |
| *** pointswaves has quit IRC | 18:15 | |
| *** xjuan has quit IRC | 19:07 | |
| *** lantw44 has quit IRC | 19:38 | |
| *** lantw44 has joined #buildstream | 19:38 | |
| *** bochecha has quit IRC | 20:00 | |
| *** xjuan has joined #buildstream | 20:14 | |
| *** slaf has quit IRC | 20:14 | |
| *** slaf has joined #buildstream | 21:20 | |
| *** slaf has joined #buildstream | 21:20 | |
| *** slaf has joined #buildstream | 21:20 | |
| *** slaf has joined #buildstream | 21:20 | |
| *** slaf has joined #buildstream | 21:21 | |
| *** slaf has joined #buildstream | 21:21 | |
| *** slaf has joined #buildstream | 21:21 | |
| *** slaf has joined #buildstream | 21:21 | |
| *** slaf has joined #buildstream | 21:22 | |
| *** slaf has joined #buildstream | 21:22 | |
| *** slaf has joined #buildstream | 21:22 | |
| *** slaf has joined #buildstream | 21:23 | |
| *** slaf has joined #buildstream | 21:23 | |
| *** slaf has joined #buildstream | 21:23 | |
| *** slaf has joined #buildstream | 21:24 | |
| *** slaf has joined #buildstream | 21:24 | |
| *** slaf has joined #buildstream | 21:24 | |
| *** slaf has joined #buildstream | 21:24 | |
| *** slaf has joined #buildstream | 21:25 | |
| *** slaf has joined #buildstream | 21:25 | |
| *** slaf has joined #buildstream | 21:25 | |
| *** slaf has joined #buildstream | 21:25 | |
| *** slaf has joined #buildstream | 21:26 | |
| *** slaf has joined #buildstream | 21:26 | |
| *** slaf has joined #buildstream | 21:26 | |
| *** slaf has quit IRC | 21:36 | |
| *** slaf has joined #buildstream | 21:49 | |
| *** slaf has joined #buildstream | 21:49 | |
| *** slaf has joined #buildstream | 21:50 | |
| *** slaf has joined #buildstream | 21:50 | |
| *** slaf has joined #buildstream | 21:50 | |
| *** slaf has joined #buildstream | 21:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!