IRC logs for #buildstream for Thursday, 2019-05-09

*** nimish2711 has joined #buildstream03:14
*** nimish2711 has quit IRC03:35
*** tristan has quit IRC05:43
*** tristan has joined #buildstream06:11
gitlab-br-bottristanvb closed issue #1018 (BuildStream crashes on junctions in non-strict mode) on buildstream https://gitlab.com/BuildStream/buildstream/issues/101806:31
gitlab-br-bottristanvb merged MR !1333 (tristan/fix-no-strict-junctions->master: Fix no strict junctions) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/133306:31
*** toscalix has joined #buildstream06:40
*** toscalix has joined #buildstream06:41
gitlab-br-bottristanvb opened issue #1020 (Invalid "Ignoring redundant source references" warnings for git sources) on buildstream https://gitlab.com/BuildStream/buildstream/issues/102006:55
*** toscalix has quit IRC07:00
*** nimish2711 has joined #buildstream07:24
*** toscalix has joined #buildstream08:00
*** ChanServ sets mode: +o tristan08:31
tristanMRs !1331 and !1332 have a fix for #1014 ! \o/08:31
gitlab-br-botMR !1331: WIP: Fix build track all no strict 1.2 https://gitlab.com/BuildStream/buildstream/merge_requests/133108:31
gitlab-br-botMR !1332: WIP: Fix build track all no strict https://gitlab.com/BuildStream/buildstream/merge_requests/133208:31
gitlab-br-botIssue #1014: bst build --track-all doesn't build anything https://gitlab.com/BuildStream/buildstream/issues/101408:31
*** rdale has joined #buildstream08:38
*** raoul has joined #buildstream08:41
*** jonathanmaw has joined #buildstream08:57
gitlab-br-bottristanvb opened (was WIP) MR !1332 (tristan/fix-build-track-all-no-strict->master: Fix build track all no strict) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/133209:06
gitlab-br-bottristanvb opened (was WIP) MR !1331 (tristan/fix-build-track-all-no-strict-1.2->bst-1.2: Fix build track all no strict 1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/133109:06
*** phildawson_ has joined #buildstream09:07
*** nimish2711_ has joined #buildstream09:24
*** nimish2711 has quit IRC09:24
*** nimish2711_ is now known as nimish271109:25
jonathanmawjuergbi: I've made changes in line with your comments to !1323, can you check that the resolve them to your satisfaction?09:26
gitlab-br-botMR !1323: Delegate cache key calculation to CacheKeyController objects https://gitlab.com/BuildStream/buildstream/merge_requests/132309:26
*** tristan has quit IRC09:29
*** lachlan has joined #buildstream09:44
*** alatiera has joined #buildstream09:47
*** tristan has joined #buildstream09:50
*** lachlan has quit IRC09:52
*** lachlan has joined #buildstream09:53
*** nimish2711 has quit IRC09:55
*** lachlan has quit IRC10:02
*** lachlan has joined #buildstream10:09
*** nimish2711 has joined #buildstream10:23
*** lachlan has quit IRC10:30
*** lachlan has joined #buildstream10:34
*** lachlan has quit IRC10:40
*** alatiera has quit IRC10:43
*** alatiera has joined #buildstream10:45
*** alatiera_ has joined #buildstream10:49
*** alatiera has quit IRC10:49
*** alatiera_ is now known as alatiera10:50
*** nimish2711 has quit IRC11:05
*** nimish2711 has joined #buildstream11:09
*** lachlan has joined #buildstream11:19
tpollardjennis: how do I go about getting a branch performance tested?11:22
*** lachlan has quit IRC11:24
*** kapil___ has joined #buildstream11:36
*** kapil___ is now known as kapip11:36
*** alatiera has quit IRC11:37
*** lachlan has joined #buildstream11:49
*** lachlan has quit IRC11:55
gitlab-br-botaevri opened issue #1021 (Native bst support on Windows (not WSL)) on buildstream https://gitlab.com/BuildStream/buildstream/issues/102112:54
jennistpollard, benschubert and I have written some ad hoc scripts that do this, we're waiting for lachlan's work to be completed for the more 'official' way to do this13:19
jennisin the meantime: https://gitlab.com/snippets/185470813:19
jennisyou'll need to clone this: https://gitlab.com/jennis/debian-stretch-bst.git if you want to use that script with the debian project (although it can be used with any)13:20
tpollardcheers jennis13:21
benschubertjennis: ping me when your script is to be merged somewhere, I'm not sure about part of it13:22
jennisbenschubert, not sure it's going to be merged anywhere. I think yours is a bit more robust as it handles the installation of buildstream into a venv13:23
benschubertjennis: exactly one of the points :D13:23
jennisThis was just a quick one I cooked up13:23
benschubertOk, I'll clean it up in the near future :)13:23
benschubertagreed, I really need to make mine nicer13:23
jennisbenschubert, cool, thanks!13:24
jennisFWIW, I think the default behaviour should be 2 measurements (+ 1 kernel warm up) for the following: show, build (4 builders), show (cached)13:25
jennisThen, at least for the debian project, this takes a "not annoyingly long" amount of time :p13:25
*** lachlan has joined #buildstream13:37
benschubertjennis: I was planning in making a few different "profiles" (quick, small, normal, thorough) with various options13:42
benschubertand stop allowing to specify everything manually13:42
jennisoh, nice idea13:42
gitlab-br-botcoldtom opened MR !1338 (coldtom/backport-MR792->bst-1.2: Backport !792 to bst-1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/133813:47
jonathanmawjuergbi: do you have time to look at whether I've resolved your comments on https://gitlab.com/BuildStream/buildstream/merge_requests/1323 to your satisfaction?13:47
juergbiyes, will take a look now13:47
jonathanmawta juergbi13:48
*** alatiera has joined #buildstream13:48
*** lachlan has quit IRC13:51
*** alatiera_ has joined #buildstream14:05
*** alatiera has quit IRC14:05
*** alatiera_ is now known as alatiera14:06
*** lachlan has joined #buildstream14:08
*** tpollard has quit IRC14:10
aevriDoes marge still work? It looks like Tristan was having trouble earlier with !1333, and she's not doing anything with my !133514:10
gitlab-br-botMR !1333: Fix no strict junctions https://gitlab.com/BuildStream/buildstream/merge_requests/133314:10
gitlab-br-botMR !1335: jobs/job.py: refactor, rm redundant _retry_flag https://gitlab.com/BuildStream/buildstream/merge_requests/133514:10
*** lachlan has quit IRC14:12
*** tpollard has joined #buildstream14:12
KinnisonIs she broken inside?14:13
*** lachlan has joined #buildstream14:28
*** lachlan has quit IRC14:31
*** lachlan has joined #buildstream14:53
adds68if i junction a project and change the build flags for something inside the junction in my new project.conf, will those be applied to things that i have junctioned?14:58
*** lachlan has quit IRC15:13
adds68juergbi ^ any idea? :)15:34
juergbiadds68: do you mean a change in project.conf of the subproject or in project.conf of the top-level/outer project?15:35
adds68juergbi, i want to overide the subproject variables, but still use the same sources/element files, if that makes sense?15:36
juergbiadds68: the only way to override is via project options15:37
adds68juergbi, i want to override the variables defined in freedesktop-sdk here: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/project.conf#L48 in a project that junctions freedesktop-sdk15:37
juergbii.e., the subproject needs to make this configurable via project option15:37
juergbiand then you can set it in your junction .bst15:37
juergbistrictly speaking there is an alternative, you could also patch the subproject, of course (via git branch or via 'patch' source in the junction)15:38
adds68juergbi, hmm yes maybe a branch would be easier and switch to that branch15:39
adds68juergbi i tried adding "variables" to the project options in my junction file, but it failed15:39
juergbiit depends on what you want to change and how that aligns with the upstream project15:39
juergbiyes, that's not supported15:39
juergbiin a way a junction is identical to first building the junctioned project and then using those artifacts as dependencies15:40
adds68Yea i assumed that would be the case, i was just making sure there was no project.conf magic i could use instead15:40
juergbiit's by design not more flexible than that, otherwise there would likely be issues on subproject changes etc.15:41
*** ChanServ sets mode: +o tristan15:49
tristanaevri, I think marge doesnt wanna do any house work today15:49
tristanbetter to assign merge requests to homer15:49
tpollardjennis: think about it, it might be better if you can run the benchmark on this existing machine, then there's some relevant historical data to compare against? There's not a huge rush though, the mr still needs approval15:49
jennisThe script runs your branch against master15:50
jennisBut what's the branch? I'll run it now15:50
Kinnisonjennis: Do you know anything about why marge might be not acting?15:52
Kinnisontpollard: ^^ or you?15:52
tpollardYeh I've managed to run it, just thought two data points would be a bit weak15:52
jennisahh cool, that's all I would have done on the benchmarks machine, the default behaviour is that it takes 3 measurements and a mean15:52
tpollardthe branch is raoul/974-Artifact-Rework15:53
* tpollard looks at marge15:53
jennisKinnison, I've not looked, although I'd take a guess that it's the hanging test again15:53
*** nimish2711 has quit IRC15:54
tpollardI can't see why it's not merge https://gitlab.com/BuildStream/buildstream/merge_requests/1336 or not complained/re-assigned to someone15:55
tpollardor attempted a rebase15:55
*** nimish2711 has joined #buildstream15:57
* tpollard reassigns15:58
tpollardno activity log for 3 days15:59
tpollardwho has access to where it's running?16:02
*** toscalix has quit IRC16:14
*** alatiera has quit IRC16:50
*** lachlan has joined #buildstream17:09
*** jonathanmaw has quit IRC17:19
*** nanonyme has left #buildstream17:21
*** nimish2711 has quit IRC17:25
*** lachlan has quit IRC17:25
*** nimish2711 has joined #buildstream17:39
*** tristan has quit IRC17:48
*** nimish2711 has quit IRC18:26
*** nimish2711 has joined #buildstream18:32
*** slaf has quit IRC18:47
*** slaf has joined #buildstream18:48
*** slaf has joined #buildstream18:48
*** slaf has joined #buildstream18:49
*** slaf has joined #buildstream18:49
*** admin has left #buildstream19:11
*** nimish2711 has quit IRC20:07
*** slaf has quit IRC20:33
*** nimish2711 has joined #buildstream20:34
*** nimish2711 has quit IRC21:08
*** nimish2711 has joined #buildstream21:08
*** nimish2711 has quit IRC21:22
*** rdale has quit IRC21:40
*** nimish2711 has joined #buildstream21:46
*** nimish2711 has quit IRC21:57
*** slaf has joined #buildstream22:18
*** slaf has joined #buildstream22:18
*** kapip has quit IRC23:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!