*** nimish2711 has joined #buildstream | 03:14 | |
*** nimish2711 has quit IRC | 03:35 | |
*** tristan has quit IRC | 05:43 | |
*** tristan has joined #buildstream | 06:11 | |
gitlab-br-bot | tristanvb closed issue #1018 (BuildStream crashes on junctions in non-strict mode) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1018 | 06:31 |
---|---|---|
gitlab-br-bot | tristanvb merged MR !1333 (tristan/fix-no-strict-junctions->master: Fix no strict junctions) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1333 | 06:31 |
*** toscalix has joined #buildstream | 06:40 | |
*** toscalix has joined #buildstream | 06:41 | |
gitlab-br-bot | tristanvb opened issue #1020 (Invalid "Ignoring redundant source references" warnings for git sources) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1020 | 06:55 |
*** toscalix has quit IRC | 07:00 | |
*** nimish2711 has joined #buildstream | 07:24 | |
*** toscalix has joined #buildstream | 08:00 | |
*** ChanServ sets mode: +o tristan | 08:31 | |
tristan | MRs !1331 and !1332 have a fix for #1014 ! \o/ | 08:31 |
gitlab-br-bot | MR !1331: WIP: Fix build track all no strict 1.2 https://gitlab.com/BuildStream/buildstream/merge_requests/1331 | 08:31 |
gitlab-br-bot | MR !1332: WIP: Fix build track all no strict https://gitlab.com/BuildStream/buildstream/merge_requests/1332 | 08:31 |
gitlab-br-bot | Issue #1014: bst build --track-all doesn't build anything https://gitlab.com/BuildStream/buildstream/issues/1014 | 08:31 |
*** rdale has joined #buildstream | 08:38 | |
*** raoul has joined #buildstream | 08:41 | |
*** jonathanmaw has joined #buildstream | 08:57 | |
gitlab-br-bot | tristanvb opened (was WIP) MR !1332 (tristan/fix-build-track-all-no-strict->master: Fix build track all no strict) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1332 | 09:06 |
gitlab-br-bot | tristanvb opened (was WIP) MR !1331 (tristan/fix-build-track-all-no-strict-1.2->bst-1.2: Fix build track all no strict 1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1331 | 09:06 |
*** phildawson_ has joined #buildstream | 09:07 | |
*** nimish2711_ has joined #buildstream | 09:24 | |
*** nimish2711 has quit IRC | 09:24 | |
*** nimish2711_ is now known as nimish2711 | 09:25 | |
jonathanmaw | juergbi: I've made changes in line with your comments to !1323, can you check that the resolve them to your satisfaction? | 09:26 |
gitlab-br-bot | MR !1323: Delegate cache key calculation to CacheKeyController objects https://gitlab.com/BuildStream/buildstream/merge_requests/1323 | 09:26 |
*** tristan has quit IRC | 09:29 | |
*** lachlan has joined #buildstream | 09:44 | |
*** alatiera has joined #buildstream | 09:47 | |
*** tristan has joined #buildstream | 09:50 | |
*** lachlan has quit IRC | 09:52 | |
*** lachlan has joined #buildstream | 09:53 | |
*** nimish2711 has quit IRC | 09:55 | |
*** lachlan has quit IRC | 10:02 | |
*** lachlan has joined #buildstream | 10:09 | |
*** nimish2711 has joined #buildstream | 10:23 | |
*** lachlan has quit IRC | 10:30 | |
*** lachlan has joined #buildstream | 10:34 | |
*** lachlan has quit IRC | 10:40 | |
*** alatiera has quit IRC | 10:43 | |
*** alatiera has joined #buildstream | 10:45 | |
*** alatiera_ has joined #buildstream | 10:49 | |
*** alatiera has quit IRC | 10:49 | |
*** alatiera_ is now known as alatiera | 10:50 | |
*** nimish2711 has quit IRC | 11:05 | |
*** nimish2711 has joined #buildstream | 11:09 | |
*** lachlan has joined #buildstream | 11:19 | |
tpollard | jennis: how do I go about getting a branch performance tested? | 11:22 |
*** lachlan has quit IRC | 11:24 | |
*** kapil___ has joined #buildstream | 11:36 | |
*** kapil___ is now known as kapip | 11:36 | |
*** alatiera has quit IRC | 11:37 | |
*** lachlan has joined #buildstream | 11:49 | |
*** lachlan has quit IRC | 11:55 | |
gitlab-br-bot | aevri opened issue #1021 (Native bst support on Windows (not WSL)) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1021 | 12:54 |
jennis | tpollard, benschubert and I have written some ad hoc scripts that do this, we're waiting for lachlan's work to be completed for the more 'official' way to do this | 13:19 |
jennis | in the meantime: https://gitlab.com/snippets/1854708 | 13:19 |
jennis | you'll need to clone this: https://gitlab.com/jennis/debian-stretch-bst.git if you want to use that script with the debian project (although it can be used with any) | 13:20 |
tpollard | cheers jennis | 13:21 |
benschubert | jennis: ping me when your script is to be merged somewhere, I'm not sure about part of it | 13:22 |
jennis | benschubert, not sure it's going to be merged anywhere. I think yours is a bit more robust as it handles the installation of buildstream into a venv | 13:23 |
benschubert | jennis: exactly one of the points :D | 13:23 |
jennis | This was just a quick one I cooked up | 13:23 |
benschubert | Ok, I'll clean it up in the near future :) | 13:23 |
benschubert | agreed, I really need to make mine nicer | 13:23 |
jennis | benschubert, cool, thanks! | 13:24 |
jennis | FWIW, I think the default behaviour should be 2 measurements (+ 1 kernel warm up) for the following: show, build (4 builders), show (cached) | 13:25 |
jennis | Then, at least for the debian project, this takes a "not annoyingly long" amount of time :p | 13:25 |
*** lachlan has joined #buildstream | 13:37 | |
benschubert | jennis: I was planning in making a few different "profiles" (quick, small, normal, thorough) with various options | 13:42 |
benschubert | and stop allowing to specify everything manually | 13:42 |
jennis | oh, nice idea | 13:42 |
gitlab-br-bot | coldtom opened MR !1338 (coldtom/backport-MR792->bst-1.2: Backport !792 to bst-1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1338 | 13:47 |
jonathanmaw | juergbi: do you have time to look at whether I've resolved your comments on https://gitlab.com/BuildStream/buildstream/merge_requests/1323 to your satisfaction? | 13:47 |
juergbi | yes, will take a look now | 13:47 |
jonathanmaw | ta juergbi | 13:48 |
*** alatiera has joined #buildstream | 13:48 | |
*** lachlan has quit IRC | 13:51 | |
*** alatiera_ has joined #buildstream | 14:05 | |
*** alatiera has quit IRC | 14:05 | |
*** alatiera_ is now known as alatiera | 14:06 | |
*** lachlan has joined #buildstream | 14:08 | |
*** tpollard has quit IRC | 14:10 | |
aevri | Does marge still work? It looks like Tristan was having trouble earlier with !1333, and she's not doing anything with my !1335 | 14:10 |
gitlab-br-bot | MR !1333: Fix no strict junctions https://gitlab.com/BuildStream/buildstream/merge_requests/1333 | 14:10 |
gitlab-br-bot | MR !1335: jobs/job.py: refactor, rm redundant _retry_flag https://gitlab.com/BuildStream/buildstream/merge_requests/1335 | 14:10 |
*** lachlan has quit IRC | 14:12 | |
*** tpollard has joined #buildstream | 14:12 | |
Kinnison | Is she broken inside? | 14:13 |
*** lachlan has joined #buildstream | 14:28 | |
*** lachlan has quit IRC | 14:31 | |
*** lachlan has joined #buildstream | 14:53 | |
adds68 | if i junction a project and change the build flags for something inside the junction in my new project.conf, will those be applied to things that i have junctioned? | 14:58 |
*** lachlan has quit IRC | 15:13 | |
adds68 | juergbi ^ any idea? :) | 15:34 |
juergbi | adds68: do you mean a change in project.conf of the subproject or in project.conf of the top-level/outer project? | 15:35 |
adds68 | juergbi, i want to overide the subproject variables, but still use the same sources/element files, if that makes sense? | 15:36 |
juergbi | adds68: the only way to override is via project options | 15:37 |
adds68 | juergbi, i want to override the variables defined in freedesktop-sdk here: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/project.conf#L48 in a project that junctions freedesktop-sdk | 15:37 |
juergbi | i.e., the subproject needs to make this configurable via project option | 15:37 |
juergbi | and then you can set it in your junction .bst | 15:37 |
juergbi | strictly speaking there is an alternative, you could also patch the subproject, of course (via git branch or via 'patch' source in the junction) | 15:38 |
adds68 | juergbi, hmm yes maybe a branch would be easier and switch to that branch | 15:39 |
adds68 | juergbi i tried adding "variables" to the project options in my junction file, but it failed | 15:39 |
juergbi | it depends on what you want to change and how that aligns with the upstream project | 15:39 |
juergbi | yes, that's not supported | 15:39 |
juergbi | in a way a junction is identical to first building the junctioned project and then using those artifacts as dependencies | 15:40 |
adds68 | Yea i assumed that would be the case, i was just making sure there was no project.conf magic i could use instead | 15:40 |
juergbi | it's by design not more flexible than that, otherwise there would likely be issues on subproject changes etc. | 15:41 |
*** ChanServ sets mode: +o tristan | 15:49 | |
tristan | aevri, I think marge doesnt wanna do any house work today | 15:49 |
tristan | better to assign merge requests to homer | 15:49 |
tpollard | jennis: think about it, it might be better if you can run the benchmark on this existing machine, then there's some relevant historical data to compare against? There's not a huge rush though, the mr still needs approval | 15:49 |
jennis | The script runs your branch against master | 15:50 |
jennis | But what's the branch? I'll run it now | 15:50 |
Kinnison | jennis: Do you know anything about why marge might be not acting? | 15:52 |
Kinnison | tpollard: ^^ or you? | 15:52 |
tpollard | Yeh I've managed to run it, just thought two data points would be a bit weak | 15:52 |
jennis | ahh cool, that's all I would have done on the benchmarks machine, the default behaviour is that it takes 3 measurements and a mean | 15:52 |
tpollard | the branch is raoul/974-Artifact-Rework | 15:53 |
* tpollard looks at marge | 15:53 | |
jennis | Kinnison, I've not looked, although I'd take a guess that it's the hanging test again | 15:53 |
*** nimish2711 has quit IRC | 15:54 | |
tpollard | I can't see why it's not merge https://gitlab.com/BuildStream/buildstream/merge_requests/1336 or not complained/re-assigned to someone | 15:55 |
tpollard | or attempted a rebase | 15:55 |
*** nimish2711 has joined #buildstream | 15:57 | |
* tpollard reassigns | 15:58 | |
tpollard | no activity log for 3 days | 15:59 |
tpollard | who has access to where it's running? | 16:02 |
*** toscalix has quit IRC | 16:14 | |
*** alatiera has quit IRC | 16:50 | |
*** lachlan has joined #buildstream | 17:09 | |
*** jonathanmaw has quit IRC | 17:19 | |
*** nanonyme has left #buildstream | 17:21 | |
*** nimish2711 has quit IRC | 17:25 | |
*** lachlan has quit IRC | 17:25 | |
*** nimish2711 has joined #buildstream | 17:39 | |
*** tristan has quit IRC | 17:48 | |
*** nimish2711 has quit IRC | 18:26 | |
*** nimish2711 has joined #buildstream | 18:32 | |
*** slaf has quit IRC | 18:47 | |
*** slaf has joined #buildstream | 18:48 | |
*** slaf has joined #buildstream | 18:48 | |
*** slaf has joined #buildstream | 18:49 | |
*** slaf has joined #buildstream | 18:49 | |
*** admin has left #buildstream | 19:11 | |
*** nimish2711 has quit IRC | 20:07 | |
*** slaf has quit IRC | 20:33 | |
*** nimish2711 has joined #buildstream | 20:34 | |
*** nimish2711 has quit IRC | 21:08 | |
*** nimish2711 has joined #buildstream | 21:08 | |
*** nimish2711 has quit IRC | 21:22 | |
*** rdale has quit IRC | 21:40 | |
*** nimish2711 has joined #buildstream | 21:46 | |
*** nimish2711 has quit IRC | 21:57 | |
*** slaf has joined #buildstream | 22:18 | |
*** slaf has joined #buildstream | 22:18 | |
*** kapip has quit IRC | 23:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!