| *** tristan has joined #buildstream | 01:20 | |
| *** nimish2711 has joined #buildstream | 02:54 | |
| *** tristan has quit IRC | 02:59 | |
| *** alatiera has joined #buildstream | 03:14 | |
| gitlab-br-bot | marge-bot123 merged MR !1291 (phil/rename-plugintestutils->master: Rename 'plugintestutils' package to 'testing') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1291 | 03:18 |
|---|---|---|
| *** tristan has joined #buildstream | 03:30 | |
| *** kapil___ has joined #buildstream | 05:54 | |
| coldtom | hi, is it possible to create subdomains for split rules? e.g. a large domain for static libraries, with subdomains for a whitelist and blacklist for static libraries in a final artifact? | 07:02 |
| *** ChanServ sets mode: +o tristan | 07:18 | |
| tristan | coldtom, not with any kind of semantics that appear to be nested in yaml or anything like that, but in practice: yes | 07:18 |
| tristan | coldtom, it however comes down to *how* you actually use the domains | 07:19 |
| tristan | coldtom, i.e. domains can certainly overlap | 07:19 |
| tristan | A split rule basically "paints a collection of files in the output with a domain name" | 07:19 |
| tristan | Then an element later, like a compose element, might decide to include only specific domains, or exclude specific domains | 07:20 |
| tristan | I believe that one can also do both (include some domains, creating a base list, and exclude some domains; subtracting those files from the same base list) | 07:20 |
| coldtom | essentially I wanted to reduce duplication in the yaml, but i just realised that this is still possible by adding a global rule for the large domain and per-element rules on the subdomains | 07:24 |
| coldtom | thanks tristan | 07:24 |
| tristan | coldtom, Also could be done with includes ? | 07:30 |
| *** nimish2711 has quit IRC | 07:43 | |
| gitlab-br-bot | juergbi closed issue #832 (Partial, file-free local CAS) on buildstream https://gitlab.com/BuildStream/buildstream/issues/832 | 07:44 |
| *** toscalix has joined #buildstream | 07:48 | |
| *** toscalix has joined #buildstream | 07:50 | |
| gitlab-br-bot | juergbi opened issue #1002 (Push-based scheduler optimization) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1002 | 08:16 |
| *** alatiera_ has joined #buildstream | 08:29 | |
| *** alatiera has quit IRC | 08:29 | |
| *** alatiera_ is now known as alatiera | 08:30 | |
| *** abderrahim has joined #buildstream | 08:33 | |
| *** tpollard has joined #buildstream | 08:38 | |
| *** alatiera_ has joined #buildstream | 08:58 | |
| *** alatiera has quit IRC | 08:58 | |
| *** alatiera_ is now known as alatiera | 08:58 | |
| *** ahmed89 has joined #buildstream | 08:59 | |
| juergbi | tpollard: I've pushed a few commits on top of your branch to juerg/955 | 09:00 |
| juergbi | I think something along these lines would be a better match to the behavior in master | 09:00 |
| juergbi | what are your thoughts on these changes? maybe it requires some further tweaking but it passes all tests locally | 09:04 |
| *** lachlan has joined #buildstream | 09:04 | |
| *** tristan has quit IRC | 09:05 | |
| * tpollard will take a look | 09:05 | |
| benschubert | tpollard: since your branch is touching update_state quite a lot, would you mind runnning the benchmarks once your are done with the reviews, to make sure nothing unexpected happens? | 09:10 |
| *** tristan has joined #buildstream | 09:22 | |
| tpollard | juergbi: I think the dual artifact approach works | 09:32 |
| *** jonathanmaw has joined #buildstream | 09:33 | |
| tpollard | having the artifact defined by context at the update_state level that is | 09:38 |
| tpollard | although maybe it's a little harder to follow, but it certainly remedies some of the corner cases | 09:43 |
| phildawson | could someone with write access to bst-plugins-container merge this please: https://gitlab.com/BuildStream/bst-plugins-container/merge_requests/34 | 09:58 |
| tpollard | juergbi: just two comments I've made around __strong_cached | 10:03 |
| tpollard | juergbi: it might be irrelevant, if so I'm happy to incorporate the tweaks | 10:05 |
| *** lachlan has quit IRC | 10:10 | |
| *** lachlan has joined #buildstream | 10:18 | |
| tpollard | benschubert: I think jennis is going to run it on the benchmark machine? | 10:18 |
| jennis | tpollard, I am just doing it locally | 10:21 |
| jennis | (on my laptop) | 10:21 |
| tpollard | ah ok! | 10:25 |
| juergbi | tpollard: ok, thanks for reviewing. I added a comment regarding `__strong_key` | 10:29 |
| juergbi | please incorporate my changes into your branch, then (my commits should likely all be squashed into corresponding commits from your branch) | 10:29 |
| tpollard | Yes I was planning to squash them into the relevant commits, thanks! | 10:30 |
| *** phildawson has quit IRC | 10:37 | |
| *** phildawson has joined #buildstream | 10:44 | |
| *** lachlan has quit IRC | 10:45 | |
| jennis | tpollard, benschubert, I'm not seeing any distinct differences in master and juerg/955 | 10:50 |
| juergbi | ta | 10:50 |
| jennis | benchmarking: show build (4 builders) show for the debian-like project | 10:50 |
| *** lachlan has joined #buildstream | 10:55 | |
| benschubert | jennis: thanks a lot! | 10:59 |
| *** lachlan has quit IRC | 11:02 | |
| *** ahmed89 has quit IRC | 11:09 | |
| *** kapil___ has quit IRC | 12:31 | |
| *** nimish2711 has joined #buildstream | 12:32 | |
| *** toscalix has quit IRC | 13:22 | |
| *** lachlan has joined #buildstream | 13:38 | |
| gitlab-br-bot | phildawson opened MR !1297 (phil/fixup-templated-test-collection->master: Ensure templated source tests aren't collected unconditionally) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1297 | 13:49 |
| *** alatiera has quit IRC | 14:07 | |
| *** alatiera has joined #buildstream | 14:07 | |
| *** abderrahim has quit IRC | 14:38 | |
| *** abderrahim has joined #buildstream | 14:52 | |
| *** phildawson_ has joined #buildstream | 15:08 | |
| *** phildawson has quit IRC | 15:09 | |
| tpollard | juergbi: hopefully I've applied your changes in a sane enough order, I've ensured the each commit passes tests policy etc. !1271 might be ready to go | 15:16 |
| gitlab-br-bot | MR !1271: Follow-up from "Artifact 'abstraction' class" https://gitlab.com/BuildStream/buildstream/merge_requests/1271 | 15:16 |
| juergbi | great, will take another look | 15:16 |
| tpollard | cheers! | 15:31 |
| *** nielsdg has quit IRC | 15:34 | |
| *** nimish2711 has quit IRC | 15:37 | |
| *** nimish2711 has joined #buildstream | 15:38 | |
| *** nimish2711 has quit IRC | 15:52 | |
| gitlab-br-bot | juergbi approved MR !1271 (tpollard/955->master: Follow-up from "Artifact 'abstraction' class") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1271 | 15:55 |
| *** nimish2711 has joined #buildstream | 15:58 | |
| *** nimish2711 has quit IRC | 16:00 | |
| *** nimish2711 has joined #buildstream | 16:00 | |
| *** phil has joined #buildstream | 16:24 | |
| *** phildawson_ has quit IRC | 16:25 | |
| *** abderrahim has quit IRC | 16:55 | |
| *** nimish2711 has quit IRC | 17:01 | |
| *** tpollard has quit IRC | 17:03 | |
| *** nimish2711 has joined #buildstream | 17:03 | |
| gitlab-br-bot | marge-bot123 closed issue #955 (Follow-up from "Artifact 'abstraction' class") on buildstream https://gitlab.com/BuildStream/buildstream/issues/955 | 17:05 |
| gitlab-br-bot | marge-bot123 merged MR !1271 (tpollard/955->master: Follow-up from "Artifact 'abstraction' class") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1271 | 17:05 |
| jonathanmaw | tristan: when you have time, can you give !1299 a brief look. It's partially-implemented, but it's working at the moment, and should be able to give a good idea of what the full implementation would look like. | 17:08 |
| gitlab-br-bot | MR !1299: WIP: Replace _update_state with various methods in various CacheKey implementations https://gitlab.com/BuildStream/buildstream/merge_requests/1299 | 17:08 |
| jonathanmaw | hmm, it'll probably not work correctly now that !1271's been merged. I'll have to take a look at that tomorrow | 17:11 |
| *** ikerperez has quit IRC | 17:12 | |
| *** jennis has quit IRC | 17:12 | |
| *** adds68 has quit IRC | 17:12 | |
| *** alatiera_ has joined #buildstream | 17:24 | |
| *** alatiera has quit IRC | 17:24 | |
| *** alatiera_ is now known as alatiera | 17:24 | |
| *** adds68 has joined #buildstream | 17:35 | |
| *** phil has quit IRC | 17:41 | |
| *** jonathanmaw has quit IRC | 18:02 | |
| *** lachlan has quit IRC | 18:03 | |
| *** lachlan has joined #buildstream | 18:27 | |
| *** lachlan has quit IRC | 18:46 | |
| *** nimish2711 has quit IRC | 18:52 | |
| *** nimish2711 has joined #buildstream | 19:17 | |
| *** mohan43u has quit IRC | 20:18 | |
| *** mohan43u has joined #buildstream | 20:42 | |
| *** alatiera has quit IRC | 21:06 | |
| *** rdale has quit IRC | 22:28 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!