| *** nimish2711 has joined #buildstream | 01:56 | |
| *** nimish2711 has quit IRC | 03:38 | |
| *** rdale has quit IRC | 04:58 | |
| *** tristan has quit IRC | 05:07 | |
| *** tristan has joined #buildstream | 05:21 | |
| *** alatiera has joined #buildstream | 06:25 | |
| *** abderrahim has quit IRC | 06:27 | |
| *** ChanServ sets mode: +o tristan | 07:38 | |
| *** nielsdg has quit IRC | 08:06 | |
| *** nielsdg has joined #buildstream | 08:07 | |
| *** toscalix has joined #buildstream | 08:20 | |
| *** rdale has joined #buildstream | 08:29 | |
| gitlab-br-bot | marge-bot123 merged MR !1288 (tristan/platform-cache-quota-1.2->bst-1.2: Cache quote related backports) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1288 | 08:45 |
|---|---|---|
| *** tpollard has joined #buildstream | 08:49 | |
| *** alatiera has quit IRC | 08:59 | |
| *** alatiera has joined #buildstream | 09:00 | |
| gitlab-br-bot | marge-bot123 merged MR !1261 (phil/expose-templated-tests->master: Expose templated source tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1261 | 09:00 |
| gitlab-br-bot | tristanvb opened MR !1289 (tristan/fix-non-strict-push-1.2->bst-1.2: Fix non strict push 1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1289 | 09:07 |
| *** jonathanmaw has joined #buildstream | 09:08 | |
| *** raoul has joined #buildstream | 09:10 | |
| *** toscalix has quit IRC | 09:15 | |
| *** toscalix has joined #buildstream | 09:16 | |
| tristan | phildawson, Want to take a look at #995 please ? | 09:31 |
| gitlab-br-bot | Issue #995: Cannot choose what tests to run https://gitlab.com/BuildStream/buildstream/issues/995 | 09:31 |
| * tristan not sure but suspects this regression is from the plugin testing activities | 09:31 | |
| gitlab-br-bot | tristanvb opened issue #995 (Cannot choose what tests to run) on buildstream https://gitlab.com/BuildStream/buildstream/issues/995 | 09:31 |
| * phildawson takes a look | 09:35 | |
| *** lachlan has joined #buildstream | 09:37 | |
| phildawson | tristan, you're correct, that is a regression is from my plugin testing work. | 09:39 |
| tristan | phildawson, I also cannot help thinking... do we really like the name 'plugintestutils' ? | 09:39 |
| tristan | seems like a pretty huge mouthful | 09:40 |
| tristan | maybe something like 'testing' would be good, similar to how click exports their click.testing module | 09:40 |
| phildawson | I personally thing it's fairly descriptive. I'm not overly attached to it though | 09:40 |
| phildawson | think | 09:40 |
| phildawson | I'd also be happy with something like 'testing' if people prefer that. | 09:41 |
| tristan | Like, it's not like anything other than plugins ever uses the BuildStream API | 09:41 |
| phildawson | Ture | 09:41 |
| phildawson | True | 09:41 |
| tristan | :) | 09:41 |
| * phildawson can't type this morning | 09:41 | |
| * phildawson wonders what other people think | 09:41 | |
| tristan | I mean, anyway it's not a huge deal but names will stick, I personally think we should change it before it stick | 09:42 |
| tristan | s | 09:42 |
| tristan | If people really *do* prefer that name I wouldnt complain | 09:42 |
| gitlab-br-bot | tristanvb opened MR !1290 (tristan/fix-non-strict-push->master: Fix non strict push) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1290 | 09:44 |
| tristan | jonathanmaw, already pinged you on #990, do you have an opinion on !1290 ? | 09:45 |
| gitlab-br-bot | Issue #990: BUG in push with non-strict mode https://gitlab.com/BuildStream/buildstream/issues/990 | 09:45 |
| * jonathanmaw has a look | 09:46 | |
| tristan | jonathanmaw, I found it interesting actually, I think just understanding this problem should be helpful for your refactoring work | 09:46 |
| WSalmon | tristan, i am not really fussed what it is called but i am already using the cli tool from the pluging utils public API, i totally get that this is not stable and so i am not going to object to a name change but i would be sad if it change too often | 09:48 |
| tristan | WSalmon, yeah I understand, I just found this name to be unfortunate and probable worth the sedjobs earlier rather than later | 09:49 |
| phildawson | It doensn't look like bst-experimental is using plugintestutils yet, which also makes life slightly easier for the rename :) | 09:49 |
| WSalmon | The plugin i am working on has a nice test sweat and should be made public at some time in the not to distant future | 09:50 |
| raoul | I prefer testing to plugintestutils fwiw, agree it's a bit of a mouthful | 09:51 |
| * phildawson will get on that quickly then | 09:51 | |
| jonathanmaw | tristan: aha, the problem is that in `bst pull --non-strict`, Element._pull_pending assumes there's always going to be a pull. Thanks for pointing out that there's a time when this isn't true | 09:55 |
| gitlab-br-bot | jonathanmaw approved MR !1290 (tristan/fix-non-strict-push->master: Fix non strict push) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1290 | 09:55 |
| tristan | jonathanmaw, `bst push --no-strict` yeah | 09:57 |
| jonathanmaw | ah, yeah | 09:58 |
| tristan | jonathanmaw, note the FIXME comment I added, I'm not fussed if we change the whole paradigm of _schedule_foo()/_foo_done() for something different | 09:58 |
| tristan | But it would be good if whether there is going to be a 'pull' is one of those foos and treated the same way as fetch/assemble/etc | 09:58 |
| *** lachlan has quit IRC | 09:59 | |
| *** lachlan has joined #buildstream | 10:15 | |
| *** lachlan has quit IRC | 10:19 | |
| gitlab-br-bot | phildawson opened MR !1291 (phil/rename-plugintestutils->master: Rename 'plugintestutils' package to 'testing') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1291 | 10:23 |
| tpollard | tristan: looks like there's a test issue on 1290 | 10:24 |
| *** gokcennurlu has joined #buildstream | 10:31 | |
| gitlab-br-bot | BenjaminSchubert opened issue #996 (Cache quota shouldn't be computed until we know we need to write to the cache) on buildstream https://gitlab.com/BuildStream/buildstream/issues/996 | 10:44 |
| tristan | tpollard, Eeek | 11:01 |
| tristan | They are unrelated... do we have that many spurious errors in master now ? | 11:02 |
| tpollard | at least 3 of them had failed on the same test when I looked | 11:02 |
| tpollard | I've not seen that specific one | 11:02 |
| tpollard | got a hit on a bazel issue via google though | 11:03 |
| tristan | ohhh no it seems to be related | 11:04 |
| tristan | this is strange now | 11:04 |
| tristan | bst artifact push --pullbuildtrees | 11:04 |
| tristan | that complicates things | 11:04 |
| tristan | Ok so... we have a case where bst artifact push, also pulls build trees | 11:05 |
| tristan | in that case, I suppose we need to not lie to the elements and tell them they've already been pulled | 11:05 |
| *** nimish2711 has joined #buildstream | 11:10 | |
| tpollard | there's a couple of other instances of no pull commands that can spawns pulls via that option too | 11:10 |
| tpollard | *none pull | 11:10 |
| tpollard | or maybe just the build shell actually, the other one I was thinking about was workspace buildtrees but that's not landed | 11:11 |
| tristan | Ahh, I wonder if bst shell suffers the same issue described in #990 ! | 11:12 |
| gitlab-br-bot | Issue #990: BUG in push with non-strict mode https://gitlab.com/BuildStream/buildstream/issues/990 | 11:12 |
| tristan | I think not, trying it now | 11:15 |
| *** nimish2711 has quit IRC | 11:18 | |
| tristan | Not a problem for shell | 11:18 |
| tristan | I did `bst --no-strict shell core.bst`, and I'm seeing the weak (dark) cache keys related to elements getting staged | 11:19 |
| tristan | So, we've resolved their keys without asking for a pull | 11:19 |
| gitlab-br-bot | marge-bot123 merged MR !1289 (tristan/fix-non-strict-push-1.2->bst-1.2: Fix non strict push 1.2) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1289 | 11:21 |
| *** lachlan has joined #buildstream | 11:36 | |
| *** lachlan has quit IRC | 11:41 | |
| gitlab-br-bot | cs-shadow opened issue #998 (Stack elements output empty "bst" directory) on buildstream https://gitlab.com/BuildStream/buildstream/issues/998 | 11:47 |
| *** lachlan has joined #buildstream | 11:49 | |
| *** lachlan has quit IRC | 11:53 | |
| *** lachlan has joined #buildstream | 11:59 | |
| gitlab-br-bot | marge-bot123 closed issue #990 (BUG in push with non-strict mode) on buildstream https://gitlab.com/BuildStream/buildstream/issues/990 | 12:00 |
| gitlab-br-bot | marge-bot123 merged MR !1290 (tristan/fix-non-strict-push->master: Fix non strict push) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1290 | 12:00 |
| *** lachlan has quit IRC | 12:03 | |
| *** lachlan has joined #buildstream | 12:07 | |
| *** lachlan has quit IRC | 12:17 | |
| gitlab-br-bot | raoul.hidalgocharman opened MR !1292 (raoul/974-Artifact-Rework->master: Artifact as a Proto: rework) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1292 | 12:18 |
| tpollard | \o/ | 12:18 |
| *** tristan has quit IRC | 12:19 | |
| *** tristan has joined #buildstream | 12:28 | |
| *** lachlan has joined #buildstream | 13:19 | |
| *** lachlan has quit IRC | 13:24 | |
| *** lachlan has joined #buildstream | 13:31 | |
| *** lachlan has quit IRC | 13:34 | |
| *** lachlan has joined #buildstream | 13:35 | |
| *** lachlan has quit IRC | 13:44 | |
| *** tpollard has quit IRC | 13:58 | |
| *** raoul_ has joined #buildstream | 14:00 | |
| *** raoul has quit IRC | 14:02 | |
| laurence | is there an monthly irc meeting team tomorrow? | 14:04 |
| laurence | I am quite sure there was one in the calendar - and I even emailed about it - but I can't see it in the calendar now | 14:05 |
| toscalix | laurence: the serie finished on April 15 | 14:06 |
| toscalix | perfect time for you to create the next serie | 14:07 |
| toscalix | so you become the organiser | 14:07 |
| toscalix | I would recommend you create it as an event of the public buildstream calendar | 14:07 |
| laurence | toscalix, ok, thanks for that - i will figure out how to create it in the public calendar | 14:08 |
| toscalix | so anyone can join the invitation in case you need to change the schedule. Also the notifications will provide the contact info | 14:08 |
| toscalix | laurence: first add the buildstream calendar to your calendars.... | 14:09 |
| *** nimish2711 has joined #buildstream | 14:09 | |
| toscalix | calendar ID: codethink.co.uk_mpgah0uj538hnbsf4l7b4rchts@group.calendar.google.com | 14:09 |
| toscalix | Public URL to the calendar: https://calendar.google.com/calendar/embed?src=codethink.co.uk_mpgah0uj538hnbsf4l7b4rchts%40group.calendar.google.com&ctz=Europe%2FMadrid | 14:09 |
| toscalix | for those using iCal format: https://calendar.google.com/calendar/ical/codethink.co.uk_mpgah0uj538hnbsf4l7b4rchts%40group.calendar.google.com/public/basic.ics | 14:09 |
| toscalix | I see your are already in the calendar as manager so you can already add events | 14:10 |
| laurence | yeah i've always had it in my calendar | 14:15 |
| laurence | let's see how to make a new event... | 14:16 |
| *** lachlan has joined #buildstream | 14:17 | |
| laurence | ah, it's a drop down when you create a new event. easy :) | 14:18 |
| *** lachlan has quit IRC | 14:25 | |
| laurence | right that's done | 14:25 |
| laurence | i hope that anyone who is subscribed to the public calendar has now got an invite? | 14:26 |
| *** nimish2711 has quit IRC | 14:27 | |
| laurence | juergbi, are you subscribed to the public calendar? did you get a note? | 14:27 |
| *** nimish2711 has joined #buildstream | 14:27 | |
| juergbi | laurence: I see it in my calendar but didn't get an invite mail | 14:28 |
| laurence | ok great, thank you | 14:29 |
| laurence | that's good enough for me :) | 14:29 |
| laurence | thanks for your help, toscalix | 14:29 |
| *** lachlan has joined #buildstream | 14:40 | |
| jennis | raoul_, do you remember the failing test that was writing files like foo.bst-0? | 14:42 |
| *** raoul_ has quit IRC | 14:43 | |
| *** tpollard has joined #buildstream | 14:44 | |
| *** raoul_ has joined #buildstream | 14:44 | |
| *** raoul_ is now known as raoul | 14:45 | |
| raoul | jennis, yeah think I raised an issue for it | 14:45 |
| raoul | you find out what was causing it? | 14:46 |
| *** nimish2711 has quit IRC | 14:50 | |
| *** nimish2711 has joined #buildstream | 14:50 | |
| tpollard | juergbi: with https://gitlab.com/BuildStream/buildstream/merge_requests/1292/ it introduces direct referencing/logic about buildtrees to _artfiactcache, are you ok with this? I know previously we've aimed to avoid specific content referencing re the buildtree there but removing the subdir/excluded_subdir parameters is a lot nicer imo | 15:06 |
| juergbi | tpollard: I'll have to take a closer look but with the (proto) abstraction this should be much less of an issue | 15:10 |
| tpollard | cool | 15:10 |
| *** nimish2711 has quit IRC | 15:10 | |
| *** nimish2711 has joined #buildstream | 15:11 | |
| *** lachlan has quit IRC | 15:15 | |
| *** lachlan has joined #buildstream | 15:16 | |
| jennis | raoul, no but I'm seeing it elsewhere now | 15:25 |
| *** nimish2711 has quit IRC | 15:26 | |
| raoul | oh, that's worrying | 15:26 |
| raoul | where? | 15:26 |
| *** nimish2711 has joined #buildstream | 15:26 | |
| *** nielsdg has quit IRC | 15:28 | |
| raoul | hmm it looks like on master, if you specify a test it will always run the plugintestutils tests, is this your doing phildawson? | 15:36 |
| *** nimish2711 has quit IRC | 15:41 | |
| *** nimish2711 has joined #buildstream | 15:41 | |
| *** lachlan has quit IRC | 15:44 | |
| *** lachlan has joined #buildstream | 15:48 | |
| *** lachlan has quit IRC | 15:53 | |
| phildawson | raoul, it is. | 15:54 |
| *** ChanServ sets mode: +o tristan | 15:56 | |
| * tristan points raoul at #995 | 15:57 | |
| phildawson | tristan, raoul, I'm working on it. In the mean time, if it helps, you can disable those tests by commenting out this line https://gitlab.com/BuildStream/buildstream/blob/master/tests/conftest.py#L182 | 15:58 |
| *** lachlan has joined #buildstream | 15:58 | |
| raoul | ah that'll be nice for now, ta | 15:59 |
| * phildawson puts that on the issue | 15:59 | |
| gitlab-br-bot | cs-shadow opened (was WIP) MR !1293 (chandan/pseudo-junction->master: Add support for defining target for junction elements) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1293 | 15:59 |
| cs-shadow | juergbi: hi, if you find some time, might be worth having a look at ^ | 16:00 |
| juergbi | will do | 16:00 |
| cs-shadow | thanks! | 16:01 |
| *** nimish2711 has quit IRC | 16:01 | |
| *** nimish2711 has joined #buildstream | 16:02 | |
| tristan | cs-shadow, I don't know if your branch will also intend to make sure we have a warning (or error) when we have out of sync projects | 16:03 |
| tristan | juergbi, cs-shadow; if we can at least agree that that is problematic, I can take care of filing an issue | 16:03 |
| *** lachlan has quit IRC | 16:04 | |
| juergbi | yes, I agree as per our discussion | 16:04 |
| tristan | from what I recall in the thread, the diamond shape dependency graph (of projects) is worrisome, if a highlevel project is going to "decide" which edge to derive the common junction properties from, I think it is an error to blindly force those properties on the adjacent edge | 16:04 |
| cs-shadow | tristan: this branch doesn't at the moment as that's slightly orthogonal. The new method shouldn't allow for any new conflicts, but whatever conflicts were possible already will still be possible. | 16:04 |
| cs-shadow | I do agree that we should raise warnings | 16:04 |
| tristan | cs-shadow, yes I understand it's orthogonal :) | 16:04 |
| tristan | ok so as long as we agree, I'll file an issue first thing tomorrow | 16:05 |
| cs-shadow | +1 | 16:05 |
| * tristan thinks it was a good discussion and a good observation, so doesnt want to leave it to get forgotten :) | 16:05 | |
| juergbi | there should always be a way to override a specific warning/error, though | 16:06 |
| tristan | Also agree | 16:06 |
| *** nimish2711 has quit IRC | 16:07 | |
| tristan | At a high level, my thinking is that when I junction a project I probably use a tag of that project, and I want to have some guarantee that what I'm building is actually what that project advertizes via that tag | 16:07 |
| tristan | anyway, I think we're all on the same page :) | 16:07 |
| *** nimish2711 has joined #buildstream | 16:07 | |
| juergbi | yes, I think we are :) | 16:09 |
| *** toscalix has quit IRC | 16:12 | |
| *** nimish2711 has quit IRC | 16:17 | |
| *** nimish2711 has joined #buildstream | 16:17 | |
| *** nimish2711 has quit IRC | 16:22 | |
| *** nimish2711 has joined #buildstream | 16:23 | |
| *** benschubert has joined #buildstream | 16:40 | |
| *** lachlan has joined #buildstream | 16:44 | |
| *** nimish2711 has quit IRC | 16:48 | |
| *** nimish2711 has joined #buildstream | 16:48 | |
| *** nimish2711 has quit IRC | 16:58 | |
| *** nimish2711 has joined #buildstream | 16:58 | |
| *** nimish2711 has quit IRC | 17:23 | |
| *** nimish2711 has joined #buildstream | 17:24 | |
| *** lachlan has quit IRC | 17:26 | |
| *** raoul has quit IRC | 17:26 | |
| *** nimish2711 has quit IRC | 17:29 | |
| *** nimish2711 has joined #buildstream | 17:29 | |
| *** lachlan has joined #buildstream | 17:31 | |
| *** alatiera has quit IRC | 17:38 | |
| *** nimish2711 has quit IRC | 17:39 | |
| *** nimish2711 has joined #buildstream | 17:39 | |
| *** lachlan has quit IRC | 17:41 | |
| *** jonathanmaw has quit IRC | 17:42 | |
| *** nimish2711 has quit IRC | 17:44 | |
| *** nimish2711 has joined #buildstream | 17:45 | |
| *** lachlan has joined #buildstream | 17:50 | |
| *** nimish2711 has quit IRC | 17:55 | |
| *** nimish2711 has joined #buildstream | 17:55 | |
| *** lachlan has quit IRC | 17:56 | |
| *** lachlan has joined #buildstream | 18:00 | |
| *** nimish2711 has quit IRC | 18:05 | |
| *** nimish2711 has joined #buildstream | 18:05 | |
| *** jonathanmaw has joined #buildstream | 18:07 | |
| *** nimish2711 has quit IRC | 18:20 | |
| *** nimish2711 has joined #buildstream | 18:21 | |
| *** nimish2711 has quit IRC | 18:31 | |
| *** nimish2711 has joined #buildstream | 18:31 | |
| *** nimish2711 has quit IRC | 18:36 | |
| *** nimish2711 has joined #buildstream | 18:37 | |
| *** nimish2711 has quit IRC | 18:46 | |
| *** nimish2711 has joined #buildstream | 18:47 | |
| *** nimish2711 has quit IRC | 18:57 | |
| *** nimish2711 has joined #buildstream | 18:57 | |
| *** nimish2711 has quit IRC | 19:05 | |
| *** lachlan has quit IRC | 19:48 | |
| *** jibade has joined #buildstream | 19:56 | |
| *** jibade has quit IRC | 20:05 | |
| *** jonathanmaw has quit IRC | 20:08 | |
| laurence | tristan, do you have the list moderator password for the list that you could pls email me? I keep getting requests to approve mails but I'm pretty sure I was never given a moderator password (in fact I'm pretty sure I was just added as one and told about it after). | 20:48 |
| laurence | Not that I mind being one | 20:48 |
| laurence | Or you could remove me from being a mod? | 20:48 |
| laurence | again, don't mind either way | 20:48 |
| *** alatiera has joined #buildstream | 22:27 | |
| *** alatiera_ has joined #buildstream | 22:59 | |
| *** alatiera has quit IRC | 22:59 | |
| *** alatiera_ is now known as alatiera | 23:00 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!