| *** nimish2711 has joined #buildstream | 02:20 | |
| *** tristan has quit IRC | 03:32 | |
| *** tristan has joined #buildstream | 03:58 | |
| *** Guest62 has quit IRC | 04:08 | |
| *** nimish2711 has quit IRC | 04:49 | |
| *** nimish2711 has joined #buildstream | 06:25 | |
| *** tristan has quit IRC | 06:36 | |
| *** tpollard has quit IRC | 06:44 | |
| *** tpollard has joined #buildstream | 06:45 | |
| *** Guest62 has joined #buildstream | 06:47 | |
| *** tristan has joined #buildstream | 07:01 | |
| gitlab-br-bot | aevri opened MR !1283 (aevri/rm_unused_member->master: cleanupjob: remove unused '_artifacts' member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1283 | 08:01 |
|---|---|---|
| *** rdale has joined #buildstream | 08:19 | |
| *** phildawson_ has joined #buildstream | 08:25 | |
| *** Guest62 has left #buildstream | 08:29 | |
| *** raoul has joined #buildstream | 08:48 | |
| *** phil has joined #buildstream | 08:57 | |
| *** phildawson_ has quit IRC | 08:57 | |
| *** jonathanmaw has joined #buildstream | 09:13 | |
| *** swick has joined #buildstream | 09:31 | |
| *** lachlan has joined #buildstream | 09:43 | |
| *** Guest62 has joined #buildstream | 09:56 | |
| *** lachlan has quit IRC | 09:57 | |
| *** lachlan has joined #buildstream | 09:58 | |
| tpollard | oh dear, marge is complaining about being broken on the inside again | 10:06 |
| Kinnison | poor dear | 10:06 |
| *** lachlan has quit IRC | 10:08 | |
| *** lachlan has joined #buildstream | 10:13 | |
| *** lachlan has quit IRC | 10:19 | |
| *** lachlan has joined #buildstream | 10:26 | |
| *** Guest62 has quit IRC | 10:29 | |
| *** Guest62 has joined #buildstream | 10:29 | |
| *** lachlan has quit IRC | 10:33 | |
| *** Guest62 has quit IRC | 10:35 | |
| tpollard | benschubert: are you ok with the Artifact member being initialised in update_state in 1271? | 10:36 |
| *** lachlan has joined #buildstream | 10:39 | |
| *** Guest62 has joined #buildstream | 10:42 | |
| *** lachlan has quit IRC | 10:52 | |
| benschubert | tpollard: if it's only temporary, we can live with it, but I would like to make sure that there is a plan to remove it from there. jonathanmaw | 10:54 |
| benschubert | jonathanmaw: sorry, do you think you could take care of removing it afterwards too? What do you think about that? I think you are the one with the most context currently | 10:54 |
| jonathanmaw | sounds like it. one moment while I check what 1271 does | 10:55 |
| tpollard | it makes dealing with the current artifact methods a lot nicer, but having the tradeoff of touching update_state is something I definitely appreciate is not fun | 11:00 |
| benschubert | tpollard: would there be a better place where we know we need the aritfact for the first time and have everything else resolved? | 11:02 |
| jonathanmaw | yeah, I can live with removing it when my changes go through. I have one reservation, which I'll add to the issue. | 11:03 |
| *** lachlan has joined #buildstream | 11:04 | |
| tpollard | benschubert: update_state calls artifact methods, so I'm not sure there's another place to initialise it (without reverting to passing the keys to methods) | 11:06 |
| benschubert | tpollard: ok, as long as jonathanmaw thinks it doesn't prevent him from getting rid of _update_state in its current form I'm fine with it! | 11:07 |
| tpollard | if the initial assignment of the weak/strong key was done outside of update state then that may help | 11:08 |
| benschubert | tpollard: the assignment should only be done once normally | 11:09 |
| benschubert | tpollard: would it be possible then to have it done only once the key has been discovered? | 11:11 |
| *** nimish2711 has quit IRC | 11:11 | |
| *** lachlan has quit IRC | 11:36 | |
| *** tristan has quit IRC | 11:43 | |
| *** lachlan has joined #buildstream | 11:50 | |
| *** lachlan has quit IRC | 11:56 | |
| *** lachlan has joined #buildstream | 11:57 | |
| gitlab-br-bot | abderrahimk opened issue #990 (BUG in push with non-strict mode) on buildstream https://gitlab.com/BuildStream/buildstream/issues/990 | 11:57 |
| *** raoul has quit IRC | 11:59 | |
| tpollard | benschubert: I should think so, that's what it's currently doing but within update_state | 12:01 |
| *** tristan has joined #buildstream | 12:02 | |
| *** lachlan has quit IRC | 12:06 | |
| *** Guest62 has quit IRC | 12:07 | |
| benschubert | oh right my bad | 12:37 |
| tpollard | if the weak key changes, then a new artifact object is loaded | 12:40 |
| *** raoul has joined #buildstream | 12:46 | |
| gitlab-br-bot | marge-bot123 merged MR !1283 (aevri/rm_unused_member->master: cleanupjob: remove unused '_artifacts' member) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1283 | 13:09 |
| *** lachlan has joined #buildstream | 13:14 | |
| gitlab-br-bot | cs-shadow opened issue #992 (Default targets don't work correctly when element-path is ".") on buildstream https://gitlab.com/BuildStream/buildstream/issues/992 | 13:37 |
| gitlab-br-bot | cs-shadow opened MR !1284 (chandan/fix-default-target-junctions->master: _project.py: Do not find default targets in .bst directory) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1284 | 13:46 |
| Kinnison | I am close to being able to release the collated results from the recent performance testing (I've had all the results I was expecting as of this morning) | 13:52 |
| Kinnison | The artifact zip is a bit under 3.5MB which seems a bit much to send to the list | 13:52 |
| Kinnison | is there somewhere suitable under buildstream.build where it could be hosted? | 13:52 |
| *** lachlan has quit IRC | 14:11 | |
| *** Trevinho has quit IRC | 14:45 | |
| *** Trevinho has joined #buildstream | 14:45 | |
| *** Trevinho has quit IRC | 14:46 | |
| *** Trevinho has joined #buildstream | 14:46 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1284 (chandan/fix-default-target-junctions->master: _project.py: Do not find default targets in .bst directory) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1284 | 14:54 |
| *** lachlan has joined #buildstream | 14:54 | |
| gitlab-br-bot | aevri approved MR !1284 (chandan/fix-default-target-junctions->master: _project.py: Do not find default targets in .bst directory) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1284 | 14:58 |
| *** lachlan has quit IRC | 15:00 | |
| *** alatiera has joined #buildstream | 15:13 | |
| *** lachlan has joined #buildstream | 15:15 | |
| *** toscalix has joined #buildstream | 15:36 | |
| *** toscalix has quit IRC | 15:37 | |
| *** toscalix has joined #buildstream | 15:38 | |
| benschubert | Some tests (https://gitlab.com/BuildStream/buildstream/-/jobs/194204152) have been running for 3 times longer than the others, did others encounter this too? | 15:47 |
| tpollard | yep | 15:47 |
| benschubert | Did it solve itself or do I need to restart it? | 15:47 |
| tpollard | https://gitlab.com/BuildStream/buildstream/merge_requests/1283#note_159386265 | 15:48 |
| tpollard | seemed to, but it's a tad worrying | 15:48 |
| benschubert | ok we have the exact same % | 15:49 |
| benschubert | all three are at test_open[zip] | 15:49 |
| *** lachlan has quit IRC | 15:52 | |
| *** lachlan has joined #buildstream | 15:56 | |
| *** lachlan has quit IRC | 16:00 | |
| *** nimish2711 has joined #buildstream | 16:02 | |
| *** lachlan has joined #buildstream | 16:07 | |
| *** tpollard has quit IRC | 16:08 | |
| *** lachlan has quit IRC | 16:17 | |
| gitlab-br-bot | marge-bot123 closed issue #992 (Default targets don't work correctly when element-path is ".") on buildstream https://gitlab.com/BuildStream/buildstream/issues/992 | 16:44 |
| gitlab-br-bot | marge-bot123 merged MR !1284 (chandan/fix-default-target-junctions->master: _project.py: Do not find default targets in .bst directory) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1284 | 16:44 |
| *** raoul has quit IRC | 16:48 | |
| *** lachlan has joined #buildstream | 16:54 | |
| *** alatiera has quit IRC | 16:56 | |
| *** lachlan has quit IRC | 16:58 | |
| *** jonathanmaw has quit IRC | 17:00 | |
| *** toscalix has quit IRC | 17:04 | |
| gitlab-br-bot | cs-shadow opened MR !1285 (chandan/fix-bst-pull-docs->master: test: Fix remaining references to bst push/pull) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1285 | 17:10 |
| *** johnward has quit IRC | 17:15 | |
| *** bethw has quit IRC | 17:15 | |
| *** WSalmon has quit IRC | 17:15 | |
| *** valentind has quit IRC | 17:15 | |
| *** laurence has quit IRC | 17:15 | |
| *** bethw has joined #buildstream | 17:16 | |
| *** laurence has joined #buildstream | 17:17 | |
| *** lachlan has joined #buildstream | 17:19 | |
| *** johnward has joined #buildstream | 17:20 | |
| *** WSalmon has joined #buildstream | 17:20 | |
| *** valentind has joined #buildstream | 17:21 | |
| *** lachlan has quit IRC | 17:26 | |
| *** lachlan has joined #buildstream | 17:30 | |
| *** jennis has quit IRC | 17:37 | |
| *** ikerperez has quit IRC | 17:37 | |
| *** adds68 has quit IRC | 17:37 | |
| *** paulsherwood has quit IRC | 17:42 | |
| *** benbrown has quit IRC | 17:42 | |
| *** jmac has quit IRC | 17:45 | |
| *** johnward has quit IRC | 17:45 | |
| *** WSalmon has quit IRC | 17:45 | |
| *** laurence has quit IRC | 17:46 | |
| *** bethw_ has joined #buildstream | 17:46 | |
| *** bethw has quit IRC | 17:46 | |
| *** valentind has quit IRC | 17:46 | |
| *** laurence has joined #buildstream | 17:47 | |
| *** valentind has joined #buildstream | 17:48 | |
| *** WSalmon has joined #buildstream | 17:50 | |
| *** johnward has joined #buildstream | 17:50 | |
| *** lachlan has quit IRC | 18:16 | |
| *** lachlan has joined #buildstream | 18:17 | |
| *** nimish2711 has quit IRC | 18:35 | |
| *** adds68 has joined #buildstream | 18:47 | |
| *** lachlan has quit IRC | 18:56 | |
| *** nimish2711 has joined #buildstream | 19:13 | |
| *** nimish2711 has quit IRC | 19:31 | |
| *** adds68 has quit IRC | 20:33 | |
| *** rdale has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!