*** nimish2711 has joined #buildstream | 03:29 | |
*** nimish2711 has quit IRC | 03:34 | |
*** nimish2711 has joined #buildstream | 03:54 | |
*** nimish2711 has quit IRC | 04:19 | |
*** nimish2711 has joined #buildstream | 04:20 | |
*** nimish2711 has quit IRC | 04:30 | |
*** nimish2711 has joined #buildstream | 04:30 | |
*** nimish2711 has quit IRC | 04:35 | |
*** nimish2711 has joined #buildstream | 04:36 | |
*** nimish2711 has quit IRC | 04:45 | |
*** nimish2711 has joined #buildstream | 04:46 | |
*** nimish2711 has quit IRC | 04:51 | |
*** nimish2711 has joined #buildstream | 04:51 | |
*** nimish2711 has quit IRC | 05:06 | |
*** nimish2711 has joined #buildstream | 05:07 | |
*** nimish2711 has quit IRC | 05:32 | |
*** nimish2711 has joined #buildstream | 05:32 | |
*** nimish2711 has quit IRC | 05:37 | |
*** nimish2711 has joined #buildstream | 05:37 | |
*** nimish2711 has quit IRC | 05:52 | |
*** nimish2711 has joined #buildstream | 05:53 | |
*** tristan has quit IRC | 06:07 | |
*** nimish2711 has quit IRC | 06:12 | |
*** nimish2711 has joined #buildstream | 06:13 | |
*** nimish2711 has quit IRC | 06:18 | |
*** nimish2711 has joined #buildstream | 06:39 | |
*** tristan has joined #buildstream | 06:41 | |
*** nimish2711 has quit IRC | 06:54 | |
*** toscalix has joined #buildstream | 07:50 | |
*** toscalix_ has joined #buildstream | 07:52 | |
*** toscalix has quit IRC | 07:52 | |
*** toscalix_ has quit IRC | 07:53 | |
*** toscalix has joined #buildstream | 07:55 | |
*** toscalix has quit IRC | 07:58 | |
*** toscalix has joined #buildstream | 07:58 | |
*** toscalix has quit IRC | 08:03 | |
*** toscalix_ has joined #buildstream | 08:03 | |
*** toscalix_ has quit IRC | 08:05 | |
*** toscalix has joined #buildstream | 08:06 | |
*** ikerperez has joined #buildstream | 08:06 | |
*** rdale has joined #buildstream | 08:36 | |
*** raoul has joined #buildstream | 08:49 | |
*** phildawson_ has joined #buildstream | 08:53 | |
*** nimish2711 has joined #buildstream | 08:56 | |
*** jonathanmaw has joined #buildstream | 08:59 | |
*** nimish2711 has quit IRC | 09:07 | |
*** nimish2711 has joined #buildstream | 09:07 | |
*** jennis has joined #buildstream | 09:13 | |
*** nimish2711 has quit IRC | 09:14 | |
*** toscalix has quit IRC | 09:33 | |
*** toscalix has joined #buildstream | 09:36 | |
*** toscalix has joined #buildstream | 09:36 | |
*** lachlan has joined #buildstream | 09:37 | |
*** ChanServ sets mode: +o tristan | 09:45 | |
tristan | How come docs generation currently "works" ? | 09:46 |
---|---|---|
tpollard | ? | 09:46 |
tristan | I am seeing that the examples literalincludes the generated file in doc/examples/first-project/project.conf | 09:46 |
tristan | And that that project.conf is listed in doc/sessions/first-project.run in remove-files | 09:46 |
tristan | Which means that of course, bst2html.py will create the project.conf as part of the process of generating the bst output, but then remove it | 09:47 |
tristan | and later when we try to literalinclude it in the example, it will be missing | 09:47 |
tristan | I think that file is supposed to be committed to the repo, and annoyingly needs to be updated with format-version bumps | 09:48 |
tristan | As I recall, it is the only thing which annoyingly changes | 09:48 |
tristan | but it got removed ? | 09:49 |
tristan | Hmmm, weird, it is there, but gets removed as a result of building the docs | 09:53 |
*** lachlan has quit IRC | 09:55 | |
tristan | Ahhh, the remove-files are removed *first*, before running commands | 10:01 |
tristan | So it is *supposed* to work | 10:01 |
Kinnison | Always nice | 10:01 |
tristan | Aha! | 10:04 |
tristan | I think I found my missing piece | 10:04 |
*** lachlan has joined #buildstream | 10:12 | |
*** lachlan has quit IRC | 10:17 | |
*** toscalix has quit IRC | 10:17 | |
*** lachlan has joined #buildstream | 10:19 | |
*** lachlan has quit IRC | 10:38 | |
Kinnison | tpollard: thank you for your profile results | 10:42 |
gitlab-br-bot | marge-bot123 merged MR !1274 (danielsilverstone-ct/more-yaml-cleanups->master: _yaml.py: Add node_keys()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1274 | 10:43 |
tpollard | Kinnison: np, saddens me that the build on your machine is under half the time of mine though.... | 10:48 |
Kinnison | tpollard: to be fair, my machine is a monster and probably never touched disk the entire time thanks to RAMs up the wazoo | 10:48 |
Kinnison | tpollard: and my machine is regularly trounced by juergbi or valentind | 10:48 |
Kinnison | Python style and long-string question | 10:49 |
Kinnison | If I have a long string, which is started several indents in, is it correct style to have all the lines indented to match, or should they be left-margin-aligned? | 10:50 |
*** lachlan has joined #buildstream | 10:50 | |
Kinnison | (both pass tox -e lint) | 10:52 |
tpollard | I prefer the latter as a personal preference | 10:54 |
*** lachlan has quit IRC | 10:55 | |
phildawson_ | I tend to indent subsequent lines to match, but I'm not sure that it's *the* correct way. | 10:56 |
Kinnison | I think indented is nicer too - but I wondered if there was a "right" way as far as this project was concerned | 10:57 |
*** tristan has quit IRC | 10:59 | |
benschubert | I usually wrap the string in () and align once more the string after the (, but that's me | 11:00 |
*** adds68 has quit IRC | 11:06 | |
*** ikerperez has quit IRC | 11:06 | |
*** jennis has quit IRC | 11:06 | |
*** jennis has joined #buildstream | 11:06 | |
*** toscalix has joined #buildstream | 11:08 | |
*** lachlan has joined #buildstream | 11:10 | |
*** toscalix has quit IRC | 11:11 | |
*** tpollard has quit IRC | 11:11 | |
*** toscalix has joined #buildstream | 11:11 | |
*** tpollard has joined #buildstream | 11:11 | |
*** ikerperez has joined #buildstream | 11:16 | |
*** tristan has joined #buildstream | 11:26 | |
jennis | aevri, I've managed to retain the interactivity with mybinder :) https://mybinder.org/v2/gh/james-ennis/bst-benchmarks-notebooks/master?filepath=all_results.ipynb | 11:34 |
aevri | jennis, cool, looking good! :) | 11:37 |
jennis | The interactivity is a bit clunky, but I'm not sure what I can do about that | 11:38 |
aevri | Yeah I don't have experience with interactivity in notebooks unf. | 11:39 |
aevri | For me the main thing is being able to change the analysis code and see results, providing mybinder links makes that much easier. | 11:41 |
*** nimish2711 has joined #buildstream | 11:43 | |
jennis | i.e. 'zoom' into a set of commits? | 11:43 |
*** nimish2711 has quit IRC | 12:15 | |
*** adds68 has joined #buildstream | 12:36 | |
gitlab-br-bot | jjardon closed issue #986 ([1.2] CI is unable to build docs) on buildstream https://gitlab.com/BuildStream/buildstream/issues/986 | 12:57 |
*** toscalix has quit IRC | 13:09 | |
*** toscalix has joined #buildstream | 13:09 | |
gitlab-br-bot | danielsilverstone-ct opened MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1280 | 13:11 |
jjardon | Hey, someone here using fedora 29 and bst-1.2? Do you have any problems? Seems test are failing when trying to add it to the CI: https://gitlab.com/BuildStream/buildstream/-/jobs/189898595 | 13:11 |
tpollard | jjardon: I think you need to bump typed-ast in dev-requirements.txt to typed-ast==1.3.1 | 13:20 |
tpollard | 1.2.0 seems to be too old for the version of pylint it's using? | 13:21 |
benschubert | tpollard: typed-ast is not compatible with python 3.7 before 1.3.0 if I remember well | 13:21 |
tpollard | ok then, did fedora 29 bump to python 3.7+ then? | 13:22 |
benschubert | yep | 13:23 |
benschubert | so jjardon would need to indeed bump typed-ast and potentially pylint :) | 13:23 |
*** lachlan has quit IRC | 13:32 | |
*** lachlan has joined #buildstream | 13:48 | |
jjardon | tpollard: benschubert thanks, I will try that | 13:49 |
gitlab-br-bot | jennis approved MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1280 | 13:53 |
jonathanmaw | hmm, do I understand correctly that the difference between weak/strong/strict cache keys is: a weak key refers only to a build-dependency's name, a strict key uses the contents of the build-dependency's element file, and the strong key can use a previous build's strong cache key provided the weak cache key hasn't changed. | 13:54 |
jonathanmaw | so if we have two elements, A, which has config with "foo=bar", and B, which build-depends on A | 13:54 |
jonathanmaw | if we build B, then change A to "foo=baz" | 13:54 |
jonathanmaw | then on subsequent builds, B's weak cache key is based on "depends on an element named A", its strict cache key is based on "depends on an element named A with foo=baz", and its strong cache key will be based on "depends on an element named A with foo=bar"? | 13:56 |
gitlab-br-bot | jjardon opened (was WIP) MR !1276 (jjardon/bst_1_2_fedora_29->bst-1.2: [1.2] .gitlab-ci.yml: Remove deprecated fedora-27 and add current stable fedora-29) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1276 | 14:04 |
jjardon | bah, now everything breaks but Fedora 29: https://gitlab.com/BuildStream/buildstream/-/jobs/190733609 (we were already using the latest pylint) | 14:12 |
Kinnison | Does anyone know what might cause https://gitlab.com/BuildStream/buildstream/-/jobs/190730007 ? | 14:50 |
Kinnison | (a failure in the cache size related tests) | 14:51 |
Kinnison | things like: | 14:56 |
Kinnison | FAILURE Directory not found in local cache: [Errno 2] No such file or directory: '/builds/BuildStream/buildstream/.tox/py37/tmp/popen-gw1/test_never_delete_required_tra0/cache/cas/objects/d4/009ed554ee0612830ef17e61a9be3e3b150907ef91f92897f6027dfdad21f3' | 14:56 |
raoul | the previous lines saying that it freed sources of 78B and then 15.26M don't look right, but the fact it's only on the one fedora image is strange | 14:58 |
raoul | it looks like it might be something to do with the reachable refs dir method, but dunno how only this image would be affected | 14:59 |
Kinnison | Or why it's affected when I've done nothing to change stuff around the cache :D | 14:59 |
Kinnison | Shall I retry that pipeline? | 14:59 |
raoul | yeah, might be one of those temperamental bugs | 15:00 |
Kinnison | Ugh | 15:00 |
* Kinnison pushes retry and crosses his fingers | 15:00 | |
Kinnison | We need to resolve what is causing this, if it's unpredictability in the way we deal with caching, either the test needs to be fixed or our cache cleanup does | 15:01 |
*** lachlan has quit IRC | 15:08 | |
*** lachlan has joined #buildstream | 15:09 | |
*** lachlan has quit IRC | 15:16 | |
*** lachlan has joined #buildstream | 15:21 | |
*** nimish2711 has joined #buildstream | 15:22 | |
gitlab-br-bot | marge-bot123 merged MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1280 | 15:23 |
*** lachlan has quit IRC | 15:34 | |
*** lachlan has joined #buildstream | 15:51 | |
*** lachlan has quit IRC | 15:58 | |
gitlab-br-bot | jjardon merged MR !1276 (jjardon/bst_1_2_fedora_29->bst-1.2: [1.2] .gitlab-ci.yml: Remove deprecated fedora-27 and add current stable fedora-29) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1276 | 15:58 |
*** lachlan has joined #buildstream | 16:31 | |
*** tpollard has quit IRC | 16:38 | |
*** raoul has quit IRC | 16:43 | |
*** alatiera has joined #buildstream | 17:13 | |
*** lachlan has quit IRC | 17:27 | |
*** jonathanmaw has quit IRC | 17:31 | |
*** toscalix has quit IRC | 18:14 | |
*** nimish2711 has quit IRC | 18:44 | |
*** nimish2711 has joined #buildstream | 19:09 | |
*** nimish2711 has quit IRC | 19:50 | |
*** tristan has quit IRC | 20:43 | |
*** rdale has quit IRC | 21:51 | |
*** alatiera has quit IRC | 23:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!