IRC logs for #buildstream for Thursday, 2019-04-04

*** nimish2711 has joined #buildstream03:29
*** nimish2711 has quit IRC03:34
*** nimish2711 has joined #buildstream03:54
*** nimish2711 has quit IRC04:19
*** nimish2711 has joined #buildstream04:20
*** nimish2711 has quit IRC04:30
*** nimish2711 has joined #buildstream04:30
*** nimish2711 has quit IRC04:35
*** nimish2711 has joined #buildstream04:36
*** nimish2711 has quit IRC04:45
*** nimish2711 has joined #buildstream04:46
*** nimish2711 has quit IRC04:51
*** nimish2711 has joined #buildstream04:51
*** nimish2711 has quit IRC05:06
*** nimish2711 has joined #buildstream05:07
*** nimish2711 has quit IRC05:32
*** nimish2711 has joined #buildstream05:32
*** nimish2711 has quit IRC05:37
*** nimish2711 has joined #buildstream05:37
*** nimish2711 has quit IRC05:52
*** nimish2711 has joined #buildstream05:53
*** tristan has quit IRC06:07
*** nimish2711 has quit IRC06:12
*** nimish2711 has joined #buildstream06:13
*** nimish2711 has quit IRC06:18
*** nimish2711 has joined #buildstream06:39
*** tristan has joined #buildstream06:41
*** nimish2711 has quit IRC06:54
*** toscalix has joined #buildstream07:50
*** toscalix_ has joined #buildstream07:52
*** toscalix has quit IRC07:52
*** toscalix_ has quit IRC07:53
*** toscalix has joined #buildstream07:55
*** toscalix has quit IRC07:58
*** toscalix has joined #buildstream07:58
*** toscalix has quit IRC08:03
*** toscalix_ has joined #buildstream08:03
*** toscalix_ has quit IRC08:05
*** toscalix has joined #buildstream08:06
*** ikerperez has joined #buildstream08:06
*** rdale has joined #buildstream08:36
*** raoul has joined #buildstream08:49
*** phildawson_ has joined #buildstream08:53
*** nimish2711 has joined #buildstream08:56
*** jonathanmaw has joined #buildstream08:59
*** nimish2711 has quit IRC09:07
*** nimish2711 has joined #buildstream09:07
*** jennis has joined #buildstream09:13
*** nimish2711 has quit IRC09:14
*** toscalix has quit IRC09:33
*** toscalix has joined #buildstream09:36
*** toscalix has joined #buildstream09:36
*** lachlan has joined #buildstream09:37
*** ChanServ sets mode: +o tristan09:45
tristanHow come docs generation currently "works" ?09:46
tpollard?09:46
tristanI am seeing that the examples literalincludes the generated file in doc/examples/first-project/project.conf09:46
tristanAnd that that project.conf is listed in doc/sessions/first-project.run in remove-files09:46
tristanWhich means that of course, bst2html.py will create the project.conf as part of the process of generating the bst output, but then remove it09:47
tristanand later when we try to literalinclude it in the example, it will be missing09:47
tristanI think that file is supposed to be committed to the repo, and annoyingly needs to be updated with format-version bumps09:48
tristanAs I recall, it is the only thing which annoyingly changes09:48
tristanbut it got removed ?09:49
tristanHmmm, weird, it is there, but gets removed as a result of building the docs09:53
*** lachlan has quit IRC09:55
tristanAhhh, the remove-files are removed *first*, before running commands10:01
tristanSo it is *supposed* to work10:01
KinnisonAlways nice10:01
tristanAha!10:04
tristanI think I found my missing piece10:04
*** lachlan has joined #buildstream10:12
*** lachlan has quit IRC10:17
*** toscalix has quit IRC10:17
*** lachlan has joined #buildstream10:19
*** lachlan has quit IRC10:38
Kinnisontpollard: thank you for your profile results10:42
gitlab-br-botmarge-bot123 merged MR !1274 (danielsilverstone-ct/more-yaml-cleanups->master: _yaml.py: Add node_keys()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/127410:43
tpollardKinnison: np, saddens me that the build on your machine is under half the time of mine though....10:48
Kinnisontpollard: to be fair, my machine is a monster and probably never touched disk the entire time thanks to RAMs up the wazoo10:48
Kinnisontpollard: and my machine is regularly trounced by juergbi or valentind10:48
KinnisonPython style and long-string question10:49
KinnisonIf I have a long string, which is started several indents in, is it correct style to have all the lines indented to match, or should they be left-margin-aligned?10:50
*** lachlan has joined #buildstream10:50
Kinnison(both pass tox -e lint)10:52
tpollardI prefer the latter as a personal preference10:54
*** lachlan has quit IRC10:55
phildawson_I tend to indent subsequent lines to match, but I'm not sure that it's *the* correct way.10:56
KinnisonI think indented is nicer too - but I wondered if there was a "right" way as far as this project was concerned10:57
*** tristan has quit IRC10:59
benschubertI usually wrap the string in () and align once more the string after the (, but that's me11:00
*** adds68 has quit IRC11:06
*** ikerperez has quit IRC11:06
*** jennis has quit IRC11:06
*** jennis has joined #buildstream11:06
*** toscalix has joined #buildstream11:08
*** lachlan has joined #buildstream11:10
*** toscalix has quit IRC11:11
*** tpollard has quit IRC11:11
*** toscalix has joined #buildstream11:11
*** tpollard has joined #buildstream11:11
*** ikerperez has joined #buildstream11:16
*** tristan has joined #buildstream11:26
jennisaevri, I've managed to retain the interactivity with mybinder :)  https://mybinder.org/v2/gh/james-ennis/bst-benchmarks-notebooks/master?filepath=all_results.ipynb11:34
aevrijennis, cool, looking good! :)11:37
jennisThe interactivity is a bit clunky, but I'm not sure what I can do about that11:38
aevriYeah I don't have experience with interactivity in notebooks unf.11:39
aevriFor me the main thing is being able to change the analysis code and see results, providing mybinder links makes that much easier.11:41
*** nimish2711 has joined #buildstream11:43
jennisi.e.  'zoom' into a set of commits?11:43
*** nimish2711 has quit IRC12:15
*** adds68 has joined #buildstream12:36
gitlab-br-botjjardon closed issue #986 ([1.2] CI is unable to build docs) on buildstream https://gitlab.com/BuildStream/buildstream/issues/98612:57
*** toscalix has quit IRC13:09
*** toscalix has joined #buildstream13:09
gitlab-br-botdanielsilverstone-ct opened MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/128013:11
jjardonHey, someone here using fedora 29 and bst-1.2? Do you have any problems? Seems test are failing when trying to add it to the CI: https://gitlab.com/BuildStream/buildstream/-/jobs/18989859513:11
tpollardjjardon: I think you need to bump typed-ast in dev-requirements.txt to typed-ast==1.3.113:20
tpollard1.2.0 seems to be too old for the version of pylint it's using?13:21
benschuberttpollard: typed-ast is not compatible with python 3.7 before 1.3.0 if I remember well13:21
tpollardok then, did fedora 29 bump to python 3.7+ then?13:22
benschubertyep13:23
benschubertso jjardon would need to indeed bump typed-ast and potentially pylint :)13:23
*** lachlan has quit IRC13:32
*** lachlan has joined #buildstream13:48
jjardontpollard: benschubert thanks, I will try that13:49
gitlab-br-botjennis approved MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/128013:53
jonathanmawhmm, do I understand correctly that the difference between weak/strong/strict cache keys is: a weak key refers only to a build-dependency's name, a strict key uses the contents of the build-dependency's element file, and the strong key can use a previous build's strong cache key provided the weak cache key hasn't changed.13:54
jonathanmawso if we have two elements, A, which has config with "foo=bar", and B, which build-depends on A13:54
jonathanmawif we build B, then change A to "foo=baz"13:54
jonathanmawthen on subsequent builds, B's weak cache key is based on "depends on an element named A", its strict cache key is based on "depends on an element named A with foo=baz", and its strong cache key will be based on "depends on an element named A with foo=bar"?13:56
gitlab-br-botjjardon opened (was WIP) MR !1276 (jjardon/bst_1_2_fedora_29->bst-1.2: [1.2] .gitlab-ci.yml: Remove deprecated fedora-27 and add current stable fedora-29) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/127614:04
jjardonbah, now everything breaks but Fedora 29: https://gitlab.com/BuildStream/buildstream/-/jobs/190733609 (we were already using the latest pylint)14:12
KinnisonDoes anyone know what might cause https://gitlab.com/BuildStream/buildstream/-/jobs/190730007 ?14:50
Kinnison(a failure in the cache size related tests)14:51
Kinnisonthings like:14:56
KinnisonFAILURE Directory not found in local cache: [Errno 2] No such file or directory: '/builds/BuildStream/buildstream/.tox/py37/tmp/popen-gw1/test_never_delete_required_tra0/cache/cas/objects/d4/009ed554ee0612830ef17e61a9be3e3b150907ef91f92897f6027dfdad21f3'14:56
raoulthe previous lines saying that it freed sources of 78B and then 15.26M don't look right, but the fact it's only on the one fedora image is strange14:58
raoulit looks like it might be something to do with the reachable refs dir method, but dunno how only this image would be affected14:59
KinnisonOr why it's affected when I've done nothing to change stuff around the cache :D14:59
KinnisonShall I retry that pipeline?14:59
raoulyeah, might be one of those temperamental bugs15:00
KinnisonUgh15:00
* Kinnison pushes retry and crosses his fingers15:00
KinnisonWe need to resolve what is causing this, if it's unpredictability in the way we deal with caching, either the test needs to be fixed or our cache cleanup does15:01
*** lachlan has quit IRC15:08
*** lachlan has joined #buildstream15:09
*** lachlan has quit IRC15:16
*** lachlan has joined #buildstream15:21
*** nimish2711 has joined #buildstream15:22
gitlab-br-botmarge-bot123 merged MR !1280 (danielsilverstone-ct/reenable-key-in-node->master: Re-enable `key in somenode` construct after YAML new world order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/128015:23
*** lachlan has quit IRC15:34
*** lachlan has joined #buildstream15:51
*** lachlan has quit IRC15:58
gitlab-br-botjjardon merged MR !1276 (jjardon/bst_1_2_fedora_29->bst-1.2: [1.2] .gitlab-ci.yml: Remove deprecated fedora-27 and add current stable fedora-29) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/127615:58
*** lachlan has joined #buildstream16:31
*** tpollard has quit IRC16:38
*** raoul has quit IRC16:43
*** alatiera has joined #buildstream17:13
*** lachlan has quit IRC17:27
*** jonathanmaw has quit IRC17:31
*** toscalix has quit IRC18:14
*** nimish2711 has quit IRC18:44
*** nimish2711 has joined #buildstream19:09
*** nimish2711 has quit IRC19:50
*** tristan has quit IRC20:43
*** rdale has quit IRC21:51
*** alatiera has quit IRC23:43

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!