*** nimish2711 has quit IRC | 02:08 | |
*** nimish2711 has joined #buildstream | 02:14 | |
*** nimish2711 has quit IRC | 02:33 | |
*** nimish2711 has joined #buildstream | 04:34 | |
*** nimish2711 has quit IRC | 04:43 | |
*** tristan has quit IRC | 06:29 | |
*** tristan has joined #buildstream | 07:03 | |
*** nimish2711 has joined #buildstream | 07:16 | |
*** nimish2711 has quit IRC | 07:30 | |
*** toscalix has joined #buildstream | 07:49 | |
gitlab-br-bot | tristanvb opened issue #981 (Improve messaging about unknown artifact refs) on buildstream https://gitlab.com/BuildStream/buildstream/issues/981 | 08:06 |
---|---|---|
Kinnison | tristan: phew | 08:15 |
*** nimish2711 has joined #buildstream | 08:17 | |
*** nimish2711 has quit IRC | 08:23 | |
*** nimish2711 has joined #buildstream | 08:23 | |
*** rdale has joined #buildstream | 08:24 | |
*** ChanServ sets mode: +o tristan | 08:29 | |
tristan | Kinnison, I *must* have hallucinated that | 08:29 |
tristan | :) | 08:29 |
Kinnison | tristan: at least you found out we weren't fundamentally broken | 08:29 |
tristan | No, it wouldnt have made any sense | 08:30 |
*** nimish2711 has quit IRC | 08:30 | |
tristan | Like, there is this: https://gitlab.gnome.org/GNOME/gnome-build-meta/merge_requests/262 | 08:30 |
tristan | A whole branch based on updating the ref to the freedesktop-sdk junction | 08:30 |
tristan | That makes sense :) | 08:30 |
Kinnison | heh | 08:31 |
*** benschubert has joined #buildstream | 08:38 | |
*** alatiera has joined #buildstream | 08:50 | |
*** raoul has joined #buildstream | 08:56 | |
*** tpollard has joined #buildstream | 08:58 | |
*** alatiera_ has joined #buildstream | 09:08 | |
*** alatiera has quit IRC | 09:08 | |
*** alatiera_ is now known as alatiera | 09:09 | |
*** jonathanmaw has joined #buildstream | 09:18 | |
*** cs-shadow has joined #buildstream | 10:16 | |
*** nimish2711 has joined #buildstream | 10:23 | |
*** nimish2711 has quit IRC | 10:33 | |
*** nimish2711 has joined #buildstream | 10:34 | |
*** nimish2711 has quit IRC | 10:48 | |
*** nimish2711 has joined #buildstream | 10:49 | |
benschubert | tristan: hey, would you have time to check if the changes I did in !1250 are good to you? Specifically https://gitlab.com/BuildStream/buildstream/merge_requests/1250#note_153970875 ? I'll rebase and fix last errors after that, so we can finally merge it! | 10:52 |
gitlab-br-bot | MR !1250: lint: Fix or silence 'cyclic-import' errors and enable pylint for it https://gitlab.com/BuildStream/buildstream/merge_requests/1250 | 10:52 |
tristan | Oh this still open ! | 10:53 |
tristan | Sorry | 10:53 |
benschubert | No worries :) whenever you have time, would be good to finish it :D | 10:53 |
tristan | That was my only comment I believe, yes it is fine ! | 10:53 |
benschubert | thanks! | 10:54 |
tristan | It was orthogonal to your cyclic-import changes, but thanks for making that import consistent while we're at it :) | 10:54 |
benschubert | no problem, I'm glad to have finished this first cycle of cleaning up the code base :) | 10:55 |
*** nimish2711 has quit IRC | 11:19 | |
*** nimish2711 has joined #buildstream | 11:19 | |
*** nimish2711 has quit IRC | 11:39 | |
*** nimish2711 has joined #buildstream | 11:40 | |
gitlab-br-bot | marge-bot123 merged MR !1250 (bschubert/lint/cyclic-import->master: lint: Fix or silence 'cyclic-import' errors and enable pylint for it) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1250 | 11:52 |
*** nimish2711 has quit IRC | 12:02 | |
*** nimish2711 has joined #buildstream | 12:20 | |
*** nimish2711 has quit IRC | 12:45 | |
*** nimish2711 has joined #buildstream | 12:46 | |
*** nimish2711 has quit IRC | 12:51 | |
*** nimish2711 has joined #buildstream | 12:51 | |
Kinnison | The J's have it this time | 12:54 |
Kinnison | juergbi and jennis have responded first to the profile requests :D | 12:54 |
*** tristan has quit IRC | 13:11 | |
*** nimish2711 has quit IRC | 13:26 | |
*** nimish2711 has joined #buildstream | 13:26 | |
*** tristan has joined #buildstream | 13:34 | |
*** nimish2711 has quit IRC | 13:41 | |
*** nimish2711 has joined #buildstream | 13:42 | |
*** nimish2711 has quit IRC | 13:52 | |
*** nimish2711 has joined #buildstream | 13:52 | |
*** nimish2711 has quit IRC | 14:04 | |
gitlab-br-bot | danielsilverstone-ct opened MR !1272 (kinnison/cleanups->master: Some small cleanups) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1272 | 14:24 |
*** nimish2711 has joined #buildstream | 14:31 | |
*** nimish2711 has quit IRC | 14:34 | |
*** nimish2711 has joined #buildstream | 14:34 | |
jonathanmaw | tristan: would you mind looking at my Element._update_state() proposal E-mail (https://mail.gnome.org/archives/buildstream-list/2019-April/msg00000.html) when you have time? | 14:43 |
*** nimish2711 has quit IRC | 14:44 | |
*** nimish2711 has joined #buildstream | 14:45 | |
jonathanmaw | I'd like to know whether you object to my general approach before I get elbow-deep in making the changes | 14:50 |
Kinnison | For anyone looking to do a trivial review, 1272 should have nothing controversial in it | 15:01 |
*** ChanServ sets mode: +o tristan | 15:02 | |
tristan | jonathanmaw, I already bookmarked it for tomorrow morning :) | 15:02 |
jonathanmaw | :) | 15:02 |
jonathanmaw | thanks, tristan | 15:02 |
tristan | orthogonal to the proposal but sort of related, I'd really like us to start identifying what workloads are linear in cost and what are exponential or quadratic | 15:04 |
tristan | whenever I hear something like "it took 20% of the time", I wonder if that is something to be concerned about or not, and I think we don't really know | 15:04 |
* Kinnison nods tristan | 15:05 | |
*** nimish2711 has quit IRC | 15:09 | |
*** nimish2711 has joined #buildstream | 15:10 | |
*** nimish2711 has quit IRC | 15:25 | |
*** nimish2711 has joined #buildstream | 15:25 | |
Kinnison | Nice report, thanks jennis | 15:33 |
* Kinnison hopes others find it useful/interesting | 15:33 | |
*** nimish2711 has quit IRC | 15:45 | |
*** nimish2711 has joined #buildstream | 15:46 | |
*** nimish2711 has quit IRC | 15:56 | |
*** nimish2711 has joined #buildstream | 15:56 | |
*** nimish2711 has quit IRC | 16:01 | |
*** nimish2711 has joined #buildstream | 16:01 | |
*** nimish2711 has quit IRC | 16:11 | |
*** nimish2711 has joined #buildstream | 16:12 | |
gitlab-br-bot | tpollard approved MR !1272 (kinnison/cleanups->master: Some small cleanups) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1272 | 16:20 |
*** nimish2711 has quit IRC | 16:27 | |
*** nimish2711 has joined #buildstream | 16:27 | |
*** nimish2711 has quit IRC | 16:57 | |
*** nimish2711 has joined #buildstream | 16:57 | |
*** toscalix has quit IRC | 17:07 | |
*** raoul has quit IRC | 17:08 | |
*** nimish2711 has quit IRC | 17:17 | |
*** nimish2711 has joined #buildstream | 17:18 | |
*** nimish2711 has quit IRC | 17:23 | |
*** nimish2711 has joined #buildstream | 17:23 | |
*** nimish2711 has quit IRC | 17:40 | |
*** nimish2711 has joined #buildstream | 17:42 | |
*** nimish2711 has quit IRC | 18:12 | |
*** nimish2711_ has joined #buildstream | 18:13 | |
*** nimish2711_ has quit IRC | 18:17 | |
*** nimish2711_ has joined #buildstream | 18:18 | |
*** nimish2711_ has quit IRC | 18:33 | |
*** nimish2711_ has joined #buildstream | 18:33 | |
*** nimish2711_ has quit IRC | 18:48 | |
*** alatiera has left #buildstream | 19:05 | |
*** alatiera has joined #buildstream | 19:22 | |
*** jonathanmaw has quit IRC | 20:12 | |
*** cs-shadow has quit IRC | 21:16 | |
*** alatiera has quit IRC | 23:15 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!