IRC logs for #buildstream for Friday, 2019-03-29

*** hatifnatt has joined #buildstream00:09
*** gvhoecke_ has joined #buildstream00:28
*** lpin has joined #buildstream00:35
*** farseerfc has joined #buildstream00:38
*** Sebastinas has joined #buildstream00:41
*** Simon-- has joined #buildstream01:06
*** northcode has joined #buildstream01:16
*** cs-shadow has quit IRC01:24
*** kapil___ has quit IRC01:28
*** slaf has quit IRC01:29
*** Adie has joined #buildstream01:33
*** lanceball has joined #buildstream01:35
*** slaf has joined #buildstream01:35
*** slaf has joined #buildstream01:35
*** slaf has joined #buildstream01:36
*** slaf has joined #buildstream01:37
*** slaf has joined #buildstream01:37
*** slaf has joined #buildstream01:39
*** slaf has joined #buildstream01:42
*** slaf has joined #buildstream01:42
*** slaf has joined #buildstream01:43
*** slaf has joined #buildstream01:43
*** slaf has joined #buildstream01:44
*** slaf has joined #buildstream01:44
*** slaf has joined #buildstream01:44
*** slaf has joined #buildstream01:44
*** slaf has joined #buildstream01:47
*** slaf has joined #buildstream01:47
*** slaf has joined #buildstream01:48
*** slaf has joined #buildstream01:49
*** slaf has joined #buildstream01:49
*** slaf has joined #buildstream01:49
*** slaf has joined #buildstream01:50
*** slaf has joined #buildstream01:50
*** slaf_ has joined #buildstream01:50
*** slaf has joined #buildstream01:51
*** slaf has joined #buildstream01:51
*** slaf has joined #buildstream01:52
*** slaf has joined #buildstream01:53
*** slaf has joined #buildstream01:53
*** slaf has joined #buildstream01:53
*** slaf has joined #buildstream01:55
*** slaf has joined #buildstream01:55
*** slaf has joined #buildstream01:56
*** slaf has joined #buildstream01:56
*** slaf has joined #buildstream01:57
*** slaf has joined #buildstream01:58
*** slaf has joined #buildstream01:58
*** slaf has joined #buildstream01:58
*** slaf has joined #buildstream01:59
*** nimish2711 has quit IRC01:59
*** slaf_ has joined #buildstream01:59
*** slaf has joined #buildstream02:01
*** slaf has joined #buildstream02:01
*** slaf has joined #buildstream02:03
*** slaf has joined #buildstream02:04
*** slaf has joined #buildstream02:04
*** slaf has joined #buildstream02:05
*** slaf has joined #buildstream02:07
*** slaf has joined #buildstream02:08
*** slaf has joined #buildstream02:08
*** slaf has joined #buildstream02:08
*** ramindia has joined #buildstream02:10
*** slaf has joined #buildstream02:11
*** slaf has joined #buildstream02:11
*** slaf has joined #buildstream02:12
*** slaf has joined #buildstream02:12
*** slaf has joined #buildstream02:12
*** slaf has joined #buildstream02:13
*** slaf has joined #buildstream02:14
*** slaf has joined #buildstream02:14
*** slaf has joined #buildstream02:15
*** slaf has joined #buildstream02:16
*** slaf_ has joined #buildstream02:17
*** slaf has joined #buildstream02:17
*** slaf has joined #buildstream02:17
*** slaf has joined #buildstream02:18
*** slaf has joined #buildstream02:19
*** slaf has joined #buildstream02:21
*** PeterRabbit1 has joined #buildstream02:23
*** slaf has joined #buildstream02:24
*** slaf has joined #buildstream02:24
*** slaf has joined #buildstream02:25
*** slaf has joined #buildstream02:26
*** slaf has joined #buildstream02:26
*** slaf has joined #buildstream02:27
*** slaf has joined #buildstream02:29
*** slaf has joined #buildstream02:30
*** petterw has joined #buildstream02:31
*** slaf has joined #buildstream02:31
*** slaf has joined #buildstream02:31
*** slaf_ has joined #buildstream02:31
*** slaf has joined #buildstream02:32
*** slaf has joined #buildstream02:33
*** slaf has joined #buildstream02:34
*** slaf has joined #buildstream02:34
*** slaf has joined #buildstream02:35
*** slaf has joined #buildstream02:35
*** slaf has joined #buildstream02:36
*** slaf has joined #buildstream02:36
*** slaf has joined #buildstream02:36
*** slaf has joined #buildstream02:36
*** slaf has joined #buildstream02:37
*** slaf has quit IRC02:37
*** slaf_ has joined #buildstream02:37
*** slaf has joined #buildstream02:38
*** slaf has joined #buildstream02:38
*** slaf has joined #buildstream02:39
*** slaf has joined #buildstream02:40
*** slaf has joined #buildstream02:40
*** slaf has joined #buildstream02:40
*** slaf has joined #buildstream02:41
*** slaf has joined #buildstream02:41
*** slaf has joined #buildstream02:42
*** slaf has joined #buildstream02:42
*** slaf has joined #buildstream02:43
*** slaf has joined #buildstream02:43
*** slaf has joined #buildstream02:45
*** slaf has joined #buildstream02:46
*** slaf has joined #buildstream02:46
*** slaf has joined #buildstream02:48
*** slaf has joined #buildstream02:50
*** stalker314314 has joined #buildstream03:10
*** Pidgeotto has joined #buildstream03:23
*** Reina14 has joined #buildstream03:54
*** tristan has quit IRC05:53
*** tristan has joined #buildstream06:16
*** nimish2711 has joined #buildstream06:51
*** nimish2711 has quit IRC07:49
*** ChanServ sets mode: +o tristan08:06
gitlab-br-botdanielsilverstone-ct closed issue #927 ('true' by itself is parsed as 'True' in .bst files) on buildstream https://gitlab.com/BuildStream/buildstream/issues/92708:08
gitlab-br-botdanielsilverstone-ct closed issue #950 (Things to think about when redesigning YAML) on buildstream https://gitlab.com/BuildStream/buildstream/issues/95008:10
gitlab-br-bottristanvb opened issue #978 (Incorrect ref used in junctions) on buildstream https://gitlab.com/BuildStream/buildstream/issues/97808:14
tristanCould be I have some local debris causing #978 to happen I dont know, but if I'm right #978 is basically the end of days08:15
* tristan will try to fix this weekend08:15
Kinnisontristan: 978 does look nasty08:16
* tristan hopes he is hallucinating this somehow08:16
Kinnisontristan: Is there any chance you can construct a test case which demonstrates it, to put in tests/ ?08:16
Kinnisontristan: at least then you could push the test case and see if the branch pipeline fails08:16
tristanKinnison, that is the first part of fixing it naturally08:16
tristanand yeah, I put a comment that that is next thing I will do08:17
* Kinnison was terrified for a moment that 1257 caused this, but then read that you'd reproduced in bst 1.2 as well08:17
tristanYeah that means it's even worse08:17
KinnisonCertainly somewhat more systemic yes :(08:18
tristanpeople are relying on this to work in production and if it's pulling the wrong stuff, then downstream runtimes could be pulling in upstream 18.08 without intentionally tracking08:18
tristanI have a feeling that if I were to wipe ~/.cache/buildstream/sources it might fix it, for instance08:19
tristanmaybe it works first time08:19
tristanI dont know08:19
Kinnisoneasy test, mv it out of the way, if it happens then we have something more systemic, if it doesn't then it's a caching bug08:19
tristan(anyway I'm sure that any test case I write will fail equally locally and in CI)08:19
KinnisonBut either way you still have your cache to put back08:19
tristandoesnt change anything08:21
* tristan just tried08:21
tristanI'll have to have a thorough look which wont happen today08:22
* Kinnison nods, I'm not au-fait with that part of the code so can't easily look on your behalf sadly08:22
tristanIt's juergbi's territory but should be fixable by anyone - first thing is a test really08:23
KinnisonRe #971 (your comment about asserts) I was raising Exception("BUG: blahblah") in 1257 until we were almost ready to merge where we changed to assert False, "message"08:23
gitlab-br-botIssue #971: BuildStream doesn't behave correctly with assertions disabled https://gitlab.com/BuildStream/buildstream/issues/97108:23
Kinnisonso I wholly approve the idea of a Bug() exception08:23
tristanYeah it's a change in strategy08:24
tristanI'm not concerned too much since benschubert said that it's not the kind of thing that a system can (or would) configure08:24
tristanAnd we ship our script entry point, so there is not really a way for users to disable assertions08:24
tristanKinnison, note that there is no reason to say "BUG", that is already in the log for any unhandled exception :)08:25
KinnisonI think Debian packages by default produce .pyc with -O08:25
tristanreally ?08:25
tristanouch08:25
KinnisonI think so, lemme chcek08:25
tristanWell then maybe we should prioritize that more if that is the case08:25
tristanI would do a backport of that to make sure next one that ships doesnt disable important assertions08:26
tristanKinnison, re #927, are we loading boolean values as strings now ?08:28
gitlab-br-botIssue #927: 'true' by itself is parsed as 'True' in .bst files https://gitlab.com/BuildStream/buildstream/issues/92708:28
tristanWe were doing that for ints08:28
tristannumbers08:28
tristanbut not for booleans08:28
KinnisonI wrote an entire replacement representer working from the baseloader's event stream08:28
Kinnisonwe load *all* scalars as strings08:28
tristanNice :)08:28
KinnisonI also wrote a roundtripping test case as part of 125708:28
KinnisonAll of this works: https://gitlab.com/BuildStream/buildstream/blob/master/tests/internals/yaml/roundtrip-test.yaml08:29
tristanAhhh right08:29
tristanThat proves it :)08:29
KinnisonAnd the test proves that everything loaded as strings: https://gitlab.com/BuildStream/buildstream/blob/master/tests/internals/yaml.py#L45908:30
juergbitristan: in master we should actually switch to using CAS-based source cache for subprojects08:30
tristanjuergbi, I'm pretty sure if there is a bug, it is unrelated to whether there is a local SourceCache in between the sources and the staging or not08:31
juergbiyes, might indeed be orthogonal08:32
juergbiespecially given that 1.2 is affected08:32
gitlab-br-botdanielsilverstone-ct closed issue #891 (YamlCache reads the entire file's contents to see if the file is in the cache) on buildstream https://gitlab.com/BuildStream/buildstream/issues/89108:33
*** nimish2711 has joined #buildstream08:34
*** tristan has quit IRC08:35
*** tristan has joined #buildstream08:41
gitlab-br-botdanielsilverstone-ct closed issue #570 (Pylint issues arise on python 3.5.3) on buildstream https://gitlab.com/BuildStream/buildstream/issues/57008:52
Kinnisontristan: Do you think #519 might be related to #978?08:54
gitlab-br-botIssue #519: Issue with refs accros junctions https://gitlab.com/BuildStream/buildstream/issues/51908:54
gitlab-br-botIssue #978: Incorrect ref used in junctions https://gitlab.com/BuildStream/buildstream/issues/97808:54
gitlab-br-botdanielsilverstone-ct closed issue #514 (BuildStream CI is not configured to perform any system level testing) on buildstream https://gitlab.com/BuildStream/buildstream/issues/51408:55
gitlab-br-botdanielsilverstone-ct closed issue #317 (New deb source arpy dependency is too hard) on buildstream https://gitlab.com/BuildStream/buildstream/issues/31708:58
*** ChanServ sets mode: +o tristan09:00
tristanKinnison, thanks for raising it, I suspect not; I think that is more to do with tarball tracking which is a bit weird09:00
tristanbut I'll keep it in mind and check out the test in more detail09:00
KinnisonCoolio09:00
* Kinnison finishes his basic sweep of issues for today09:00
* Kinnison hunts the rare and delicious teapot09:01
*** nimish2711 has quit IRC09:02
*** tpollard has quit IRC09:03
*** tpollard has joined #buildstream09:03
benschuberttristan: actually fedora optimizes it too https://src.fedoraproject.org/fork/churchyard/rpms/python-rpm-macros/blob/f5439cfbbc60d319330ef848cb975a0ed81d1962/f/macros.pybytecompile#_20 :/09:12
benschubertsorry https://src.fedoraproject.org/rpms/python-rpm-macros/blob/master/f/macros.pybytecompile real link09:14
tpollardAny idea what to do here? https://gitlab.com/BuildStream/buildstream/-/jobs/186608325 I can't get an MR merged because of it09:16
benschuberttristan: we could fallback to have 1) raise AssertionError explicitely, 2) a error() or abort() function that behave like our assert, none of those two should be hard to implement09:17
Kinnisontpollard: Is that a dependency you've added?09:17
tpollardnafaik09:17
Kinnisonif you ask the step to re-run does it fail the same way?09:19
tpollardYep, 3 times09:20
tpollardThe CI in general yesterday was acting really strange09:20
* Kinnison asks it to retry once more09:21
KinnisonYeppers, still that oddness09:24
Kinnisoncan you run the docs command locally?09:24
KinnisonBingo worked it out09:26
KinnisonSphinx 1.8.5 works09:26
KinnisonSphinx 2.0.0 doesn't09:26
Kinnisoncritical difference - sphinx.apidoc has moved to sphinx.ext.apidoc09:26
tpollardWoo...09:26
KinnisonWe either need to lock sphinx version down, or we need to alter our tox09:26
Kinnisontox.ini09:26
KinnisonOpinions anyone?09:26
benschubertwhat would be the "fix" on the tox.ini?09:27
*** rdale has joined #buildstream09:27
Kinnisonpython3 -m sphinx.ext.apidoc09:27
KinnisonOh no, that's in a Makefile09:27
Kinnisonsorry, my bad09:27
KinnisonAlthough that'll raise other issues, having tried it09:28
Kinnisonbetter to lock sphinx down to 1.8.5 until someone can fix the other issues09:28
Kinnisonfr.ex.09:28
KinnisonException occurred:09:28
Kinnison  File "/home/danielsilverstone/buildstream/.tox/docs/lib/python3.5/site-packages/sphinx/ext/napoleon/docstring.py", line 703, in _parse_raises_section09:28
Kinnison    m = self._name_rgx.match(_type).groupdict()09:28
KinnisonAttributeError: 'NoneType' object has no attribute 'groupdict'09:28
tpollard+1 to pin it for now09:30
Kinnisonpinning would be in tox.ini09:30
Kinnisonin [testenv:docs]09:31
tpollardOk09:32
* tristan has not yet tried docs generation through tox09:33
tristanbut pinning that in tox sounds like exactly the right thing09:33
tristanneeds a new separate requirements.in/.txt file09:33
Kinnisontox just has a deps thing for [testenv:docs]09:34
tristanKinnison, right and the normal way we specify the deps is with the -rfoo.txt, and we update foo.txt with the makefile in requirements/09:35
* Kinnison shrugs, I'm not sure what the "right" answer here is and will leave it to more pythonic humans09:35
tristanthe remaining manually specified deps are just remnants I think09:35
tristanbetter we make things uniform right ?09:35
tpollardI can't provide it with 1.8.5 (Ubuntu 18.04), no releases between 1.4.1 & 2.0.0 available09:36
tpollardwait, I think it's just tox being odd09:36
Kinnisontpollard: pipypypippipipip should deal with it09:36
tristanyeah, if its by tox and pinned, then we dont care what is on the docker09:37
tristanall venv09:37
* tristan out09:37
benschuberttristan: could you have a look at https://gitlab.com/BuildStream/buildstream/merge_requests/1250#note_153970875 so that we can merge this? I will rebase and fix any arrising issues before submitting to marge09:40
gitlab-br-botaevri opened MR !1266 (aevri/depency->master: app.py: fix spelling 'depency' -> 'dependency') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126609:43
gitlab-br-bottpollard opened MR !1267 (tpollard/pin-sphinx->master: tox.ini: pin [testenv:docs] sphinx dependency to 1.8.5) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126709:44
tpollardThanks for finding the issue Kinnison09:46
Kinnisonyw tpollard09:48
*** raoul has joined #buildstream09:54
gitlab-br-botBenjaminSchubert opened (was WIP) MR !1255 (bschubert/profiler-as-cm->master: Cleanup profiler and make is as a context manager) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/125510:01
benschubert^ also allows running BST_PROFILE=ALL and not profiling the profiler :D10:01
KinnisonErk! Quis custodiet ipsos custodes?10:03
aevrikinnison: police-police police police, police-police-police police police-police.10:10
*** jonathanmaw has joined #buildstream10:10
* Kinnison buffalos aevri10:10
aevrihehe10:11
*** nimish2711 has joined #buildstream10:16
tpollardhmm10:19
gitlab-br-botBenjaminSchubert approved MR !1267 (tpollard/pin-sphinx->master: tox.ini: pin [testenv:docs] sphinx dependency to 1.8.5) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126710:33
gitlab-br-botmarge-bot123 merged MR !1267 (tpollard/pin-sphinx->master: tox.ini: pin [testenv:docs] sphinx dependency to 1.8.5) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126710:37
*** lachlan has joined #buildstream10:40
gitlab-br-botjennis approved MR !1255 (bschubert/profiler-as-cm->master: Cleanup profiler and make is as a context manager) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/125510:41
*** lachlan has quit IRC10:51
gitlab-br-botmarge-bot123 closed issue #945 (Create initial Artifact 'abstractions' and preparations in testutils) on buildstream https://gitlab.com/BuildStream/buildstream/issues/94511:18
gitlab-br-botmarge-bot123 merged MR !1252 (tpollard/945->master: Add initial TestArtifact() abstraction class to testutils) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/125211:18
*** cs-shadow has joined #buildstream11:30
*** lachlan has joined #buildstream11:37
gitlab-br-botjennis opened MR !1268 (jennis/tweak_node_get->master: FOLLOWUP: Tweak node_get so it can handle indices=[]) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126812:14
*** alatiera has joined #buildstream12:16
*** alatiera_ has joined #buildstream13:45
*** alatiera has quit IRC13:46
*** alatiera_ is now known as alatiera13:46
gitlab-br-botBenjaminSchubert opened MR !1269 (bschubert/cache-project-path->master: _project.py: cache full project path for quicker lookup) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126913:50
gitlab-br-botjennis closed MR !1268 (jennis/tweak_node_get->master: FOLLOWUP: Tweak node_get so it can handle indices=[]) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126814:04
*** gokcennurlu has quit IRC14:08
gitlab-br-botmarge-bot123 closed issue #877 (Profiling - 'all' option does not produce complete profiles for all topics) on buildstream https://gitlab.com/BuildStream/buildstream/issues/87714:24
gitlab-br-botmarge-bot123 closed issue #876 (Profiling - topics 'load-loader' and 'show' are not actually profiled) on buildstream https://gitlab.com/BuildStream/buildstream/issues/87614:24
gitlab-br-botmarge-bot123 merged MR !1255 (bschubert/profiler-as-cm->master: Cleanup profiler and make is as a context manager) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/125514:24
gitlab-br-botjennis approved MR !1269 (bschubert/cache-project-path->master: _project.py: cache full project path for quicker lookup) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126914:42
*** lachlan has quit IRC14:46
gitlab-br-botBenjaminSchubert opened MR !1270 (bschubert/fix-typos->master: typo: writtent -> written) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/127014:48
*** jonathanmaw has quit IRC15:01
*** jonathanmaw has joined #buildstream15:02
*** lachlan has joined #buildstream15:09
gitlab-br-botcs-shadow approved MR !1270 (bschubert/fix-typos->master: typo: writtent -> written) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/127015:11
*** lachlan has quit IRC15:13
*** jonathanmaw has quit IRC15:34
*** jonathanmaw has joined #buildstream15:34
*** lachlan has joined #buildstream15:35
*** lachlan has quit IRC15:41
*** lachlan has joined #buildstream15:54
gitlab-br-botBenjaminSchubert closed issue #853 (BUG hit: "no module named 'grpc.framework') on buildstream https://gitlab.com/BuildStream/buildstream/issues/85315:54
*** lachlan has quit IRC16:02
*** lachlan has joined #buildstream16:09
*** lachlan has quit IRC16:13
valentindHey. It seems gitlab does not want to disable "force HTTPS". So will remove the certificates for a short time to force it to allow it. So if you see the website is not working, I am working on it.16:15
gitlab-br-botmarge-bot123 merged MR !1269 (bschubert/cache-project-path->master: _project.py: cache full project path for quicker lookup) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126916:26
valentindCertificate renewal done.16:31
gitlab-br-botvalentindavid closed issue #683 (Let's Encrypt certificate needs to be renewed) on buildstream https://gitlab.com/BuildStream/buildstream/issues/68316:32
*** lachlan has joined #buildstream16:52
*** tpollard has quit IRC16:54
*** lachlan has quit IRC16:56
*** lachlan has joined #buildstream17:10
*** alatiera_ has joined #buildstream17:12
*** alatiera has quit IRC17:12
*** alatiera_ is now known as alatiera17:12
gitlab-br-botmarge-bot123 merged MR !1266 (aevri/depency->master: app.py: fix spelling 'depency' -> 'dependency') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126617:12
*** raoul has quit IRC17:47
*** laurence has left #buildstream17:53
*** laurence has joined #buildstream17:53
gitlab-br-botmarge-bot123 merged MR !1264 (jennis/add_NEWS_entry->master: FOLLOW UP: Add NEWS entry for YAML New World Order) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/126417:56
*** jonathanmaw has quit IRC18:36
*** alatiera has quit IRC18:58
*** alatiera has joined #buildstream19:01
*** lachlan has quit IRC19:29
*** lachlan has joined #buildstream19:31
*** lachlan has quit IRC19:34
*** lachlan has joined #buildstream19:35
*** lachlan has quit IRC20:01
*** lachlan has joined #buildstream20:05
*** lachlan has quit IRC20:12
*** lachlan has joined #buildstream20:22
*** lachlan has quit IRC20:27
*** lachlan has joined #buildstream20:29
*** nimish2711 has quit IRC20:40
*** nimish2711 has joined #buildstream20:45
*** alatiera has quit IRC21:11
*** alatiera has joined #buildstream21:12
*** cs-shadow has quit IRC21:18
*** nimish2711_ has joined #buildstream21:27
*** nimish2711 has quit IRC21:27
*** nimish2711_ is now known as nimish271121:27
*** lachlan has quit IRC21:30
*** alatiera has quit IRC21:49

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!