| *** nimish2711 has joined #buildstream | 00:53 | |
| *** nimish2711 has quit IRC | 02:38 | |
| *** nimish2711_ has joined #buildstream | 02:38 | |
| *** nimish2711_ is now known as nimish2711 | 02:39 | |
| *** swick has quit IRC | 02:40 | |
| *** nimish2711 has quit IRC | 02:45 | |
| *** swick has joined #buildstream | 06:11 | |
| *** tristan has quit IRC | 06:39 | |
| *** tristan has joined #buildstream | 07:01 | |
| *** toscalix has joined #buildstream | 08:28 | |
| *** raoul has joined #buildstream | 10:01 | |
| *** jonathanmaw has joined #buildstream | 10:18 | |
| *** tristan has quit IRC | 10:18 | |
| *** tristan has joined #buildstream | 10:18 | |
| *** nimish2711 has joined #buildstream | 10:23 | |
| *** lachlan has joined #buildstream | 10:43 | |
| benschubert | With BuildStream master, I'm doing a "bst source fetch my_junction". My junction is a GitSourceElement. I get a PermissionsDeined when moving from the tmpfile to the real directory on WSL (works on linux) Any idea? | 10:44 |
|---|---|---|
| *** lachlan has joined #buildstream | 10:44 | |
| *** lachlan has quit IRC | 10:44 | |
| *** lachlan has joined #buildstream | 10:46 | |
| juergbi | benschubert: is it possible that source and destination are on different mount points? | 10:48 |
| juergbi | (although that should result in EXDEV but maybe not on WSL) | 10:48 |
| benschubert | juergbi: no, both are in ~/.cache/sources/git/ | 10:49 |
| benschubert | and it's moved to next to the directory | 10:49 |
| benschubert | cloning manually and then moving works without error | 10:49 |
| benschubert | juergbi: seems to be a problem with move_atomic again :/ Don't we have tests for this on WSL? | 10:54 |
| benschubert | we seem to have :/ | 10:54 |
| juergbi | there are tests for move_atomic() and they should also run on WSL | 10:54 |
| benschubert | juergbi: ok I'll dig more into that :/ thanks! | 10:58 |
| *** lachlan has quit IRC | 11:21 | |
| *** lachlan has joined #buildstream | 11:23 | |
| *** alatiera has joined #buildstream | 11:26 | |
| *** lachlan has quit IRC | 11:33 | |
| Kinnison | juergbi: thanks for that spot on 1257, currently trying to work out how that got past me | 11:33 |
| juergbi | reduced diff is helping :) | 11:38 |
| *** nimish2711 has quit IRC | 11:39 | |
| Kinnison | juergbi: Yeah. I think what you hilighted is actually us clarifying a thing where _plugincontext.py's inputs vary from _project.py's | 11:40 |
| * Kinnison has responded on-thread | 11:40 | |
| juergbi | ah, missed that this is an internal test | 11:42 |
| Kinnison | It took me re-reading all the code to remember :D | 11:42 |
| juergbi | ok, so it should be correct but also somewhat an orthogonal cleanup | 11:45 |
| *** lachlan has joined #buildstream | 11:49 | |
| Kinnison | the cleanup happened by dint of the fact that we had to change the code reading the content to be typesafe :D | 11:50 |
| Kinnison | juergbi: will you resolve that comment if you're satisfied? | 11:50 |
| jjardon | jonathanmaw: hi, when you have some time, would it be possible to have another release of bst-external? | 12:04 |
| jonathanmaw | jjardon: yarp | 12:22 |
| SotK | jonathanmaw: what are the chances of getting https://gitlab.com/BuildStream/bst-external/merge_requests/71 merged first so that the release gets uploaded to pypi? | 12:26 |
| jonathanmaw | SotK: I was vacillating about creating a pypi account and using my credentials for that | 12:27 |
| jonathanmaw | it would probably be best to create an account for buildstream and keep those details somewhere | 12:27 |
| jonathanmaw | but I'm not sure who'd be responsible for taking care of that information, and where to put it | 12:27 |
| coldtom | jonathanmaw: would it be possible to get https://gitlab.com/BuildStream/bst-external/merge_requests/70 merged before the release, we need the functionality in freedesktop-sdk | 12:31 |
| SotK | a buildstream account would be my recommendation, it seems gitlab supports setting variables at the group level so unless there's a better idea I'd probably just store it there for now, with the group maintainers responsible | 12:33 |
| * jonathanmaw creates an account for buildstream on pypi | 12:33 | |
| jonathanmaw | and will create an issue that other people should probably add their E-mail addresses to the account | 12:34 |
| *** raoul has quit IRC | 12:35 | |
| jonathanmaw | :/, that's going to be a nuisance, pypi doesn't allow the same E-mail address to be used for multiple pypi users | 12:36 |
| jonathanmaw | and I've already created a pypi account | 12:36 |
| Kinnison | jonathanmaw: use + addressing? | 12:38 |
| jonathanmaw | hm, should work. + addressing isn't just a unique gmail feature | 12:38 |
| Kinnison | It's from long before gmail | 12:39 |
| Kinnison | Loooong before | 12:39 |
| * jonathanmaw waits for pypi's confirmation email | 12:40 | |
| jonathanmaw | hmm, I think I lack sufficient permissions to add the variables at the group level | 12:51 |
| SotK | according to the docs "owner" or "maintainer" permissions are required | 12:52 |
| jonathanmaw | I'm down as a maintainer | 12:54 |
| jonathanmaw | can you point me to the documentation? | 12:54 |
| jonathanmaw | maybe I'm missing the button | 12:54 |
| SotK | ah, maybe at the group level it needs the "Edit group" permission that only owners have | 12:55 |
| SotK | I think I was previously looking at the wrong part of the docs | 12:55 |
| SotK | (variables are mentioned in https://docs.gitlab.com/ee/user/permissions.html#project-members-permissions, and groups in https://docs.gitlab.com/ee/user/permissions.html#group-members-permissions) | 12:56 |
| SotK | the button exists for me in a group that I am owner of (in the same place it is for projects, Settings -> CI/CD) | 12:57 |
| jonathanmaw | ok, I'll add it to the bst-external project for now | 12:57 |
| *** nimish2711 has joined #buildstream | 13:01 | |
| jonathanmaw | SotK: ok, that's the variables set. I've approved https://gitlab.com/BuildStream/bst-external/merge_requests/71 but it needs rebasing | 13:02 |
| * SotK clicks the rebase button | 13:03 | |
| SotK | thanks | 13:03 |
| jonathanmaw | SotK: sorry, it looks like I undid all of your rebasing work by merging https://gitlab.com/BuildStream/bst-external/merge_requests/70 before CI finished for 71 | 13:08 |
| jonathanmaw | by undid I mean it needs to be rebased again because master changed :¬/ | 13:08 |
| * SotK clicks the button again | 13:09 | |
| gitlab-br-bot | jonathanmaw opened issue #973 (Unclear how to handle ownership of a shared pypi account) on buildstream https://gitlab.com/BuildStream/buildstream/issues/973 | 13:22 |
| *** raoul has joined #buildstream | 13:35 | |
| benschubert | jonathanmaw: did you ever got troubles on wsl with "Permission Denied" when doing a source fetch? | 13:49 |
| benschubert | I happen to get one, which can be resolved by having a sleep before doing the rename operation -_-' | 13:50 |
| jonathanmaw | benschubert: hmm, I don't think I've seen that before | 13:51 |
| benschubert | ok | 13:52 |
| benschubert | The only explanation I can find is about https://bytes.com/topic/python/answers/441842-occasional-oserror-errno-13-permission-denied-windows and that's less than ideal | 13:52 |
| jonathanmaw | SotK: tag pushed https://gitlab.com/BuildStream/bst-external/tree/0.11.0 | 14:22 |
| * SotK watches the pipeline | 14:23 | |
| *** lachlan has quit IRC | 14:41 | |
| * SotK successfully does `pip install --user buildstream-external` | 14:45 | |
| SotK | thanks jonathanmaw | 14:45 |
| jonathanmaw | \o/ | 14:45 |
| Kinnison | yay, congrats both | 14:46 |
| *** lachlan has joined #buildstream | 14:50 | |
| alatiera | what's the usecase for tracking multiple branches | 14:51 |
| *** lachlan has quit IRC | 14:55 | |
| Kinnison | Is anyone who has reviewed !1257 prepared to approve it? | 14:55 |
| gitlab-br-bot | MR !1257: YAML New World Order https://gitlab.com/BuildStream/buildstream/merge_requests/1257 | 14:55 |
| *** lachlan has joined #buildstream | 14:55 | |
| *** lachlan has quit IRC | 14:59 | |
| coldtom | alatiera: automatic updates where there is a branch for a stable release and new releases appear on master | 15:04 |
| coldtom | so we can detect minor version bumps and major version bumps | 15:04 |
| benschubert | Kinnison: let me have a last review and I will | 15:05 |
| alatiera | coldtom: oh cool! | 15:06 |
| Kinnison | benschubert: yay | 15:06 |
| *** lachlan has joined #buildstream | 15:13 | |
| *** raoul has quit IRC | 15:32 | |
| *** phildawson_ is now known as phildawson | 15:45 | |
| phildawson | For those who are interested, !1261 is up for making our templated source tests available for plugin authors. It's marked as WIP because there are linting errors I still need to fix, but is otherwise reviewable. | 15:45 |
| gitlab-br-bot | MR !1261: WIP: Expose templated source tests https://gitlab.com/BuildStream/buildstream/merge_requests/1261 | 15:45 |
| *** lachlan has quit IRC | 15:48 | |
| *** raoul has joined #buildstream | 15:49 | |
| *** lachlan has joined #buildstream | 15:55 | |
| *** lachlan has quit IRC | 16:17 | |
| *** lachlan has joined #buildstream | 16:22 | |
| juergbi | Kinnison, jennis: I think there should be a comment explaining why [0] and co. are used and what each index references, possibly right above the Node class. or is this already documented and I missed it? | 16:23 |
| juergbi | also, explain what 'value' and 'file_index' actually mean | 16:24 |
| Kinnison | juergbi: ok, either jennis will do it or I'll get it | 16:25 |
| Kinnison | or I'll get to it tomorrow/thu depending on my travel plans | 16:26 |
| juergbi | shall I open a 'discussion' to keep track of this? | 16:26 |
| Kinnison | please | 16:27 |
| juergbi | done | 16:32 |
| jennis | jonathanmaw, I've done a bit of bst-external cleanup, would you have a chance to review: https://gitlab.com/BuildStream/bst-external/merge_requests/77 ? | 16:46 |
| * jonathanmaw has a poke | 16:47 | |
| jennis | ta | 16:53 |
| *** xjuan has joined #buildstream | 17:01 | |
| jonathanmaw | jennis: reviewed | 17:03 |
| *** toscalix has quit IRC | 17:07 | |
| jonathanmaw | juergbi: ta for having a look at my analysis in #902. Do you have anything else to add or can I assume that you couldn't see anything else in my understanding that was wrong? | 17:13 |
| gitlab-br-bot | Issue #902: Element._update_state() does more stuff than it needs to when it's called https://gitlab.com/BuildStream/buildstream/issues/902 | 17:13 |
| juergbi | jonathanmaw: rest looks correct to me (but I might have missed something) | 17:16 |
| jonathanmaw | ta juergbi | 17:17 |
| *** lachlan has quit IRC | 17:29 | |
| *** lachlan has joined #buildstream | 17:34 | |
| jennis | thanks jonathanmaw | 17:35 |
| *** lachlan has quit IRC | 17:55 | |
| gitlab-br-bot | raoul.hidalgocharman opened issue #974 (AaaP: Rework artifact class to use artifact proto) on buildstream https://gitlab.com/BuildStream/buildstream/issues/974 | 17:59 |
| *** lachlan has joined #buildstream | 18:04 | |
| *** lachlan has quit IRC | 18:08 | |
| *** jonathanmaw has quit IRC | 18:09 | |
| *** raoul has quit IRC | 18:14 | |
| laurence | just closed off 12 MRs that haven't been updated in months | 18:16 |
| laurence | trying to do this piece-meal in order to reduce the email notifications and the noise | 18:17 |
| *** xjuan has quit IRC | 18:27 | |
| *** lachlan has joined #buildstream | 18:31 | |
| *** lachlan has quit IRC | 18:35 | |
| gitlab-br-bot | marge-bot123 merged MR !1237 (aevri/junction_load_provenance->master: loader: provenance in LoadErrors from _get_loader) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1237 | 19:10 |
| *** nimish2711 has quit IRC | 20:00 | |
| *** xjuan has joined #buildstream | 20:07 | |
| gitlab-br-bot | valentindavid opened issue #975 (CI build fails to connect to cache and decides to build everything) on buildstream https://gitlab.com/BuildStream/buildstream/issues/975 | 20:38 |
| *** slaf_ has joined #buildstream | 22:00 | |
| *** slaf_ has joined #buildstream | 22:00 | |
| *** slaf_ has joined #buildstream | 22:01 | |
| *** slaf_ has joined #buildstream | 22:01 | |
| *** slaf_ has joined #buildstream | 22:01 | |
| *** slaf_ has joined #buildstream | 22:02 | |
| *** slaf_ has joined #buildstream | 22:02 | |
| *** slaf_ has joined #buildstream | 22:02 | |
| *** slaf has quit IRC | 22:02 | |
| *** slaf_ is now known as slaf | 22:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!