| *** nimish has quit IRC | 02:14 | |
| *** mohan43u has quit IRC | 02:22 | |
| *** juanalday has quit IRC | 03:06 | |
| *** juanalday has joined #buildstream | 03:10 | |
| *** xjuan has quit IRC | 03:13 | |
| *** juanalday has quit IRC | 03:36 | |
| *** mohan43u has joined #buildstream | 04:38 | |
| gitlab-br-bot | juergbi reopened issue #534 (Failed builds not pushing artifacts on quit) on buildstream https://gitlab.com/BuildStream/buildstream/issues/534 | 06:21 |
|---|---|---|
| gitlab-br-bot | juergbi opened MR !1167 (juerg/cachedfail->master: tests/integration/cachedfail.py: Fix test_push_cached_fail) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1167 | 06:44 |
| gitlab-br-bot | juergbi merged MR !1166 (aevri/doc_arch_tweaks->master: doc/../arch_data_model: minor tweaks) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1166 | 06:54 |
| *** juanalday has joined #buildstream | 07:02 | |
| *** juanalday has quit IRC | 07:32 | |
| gitlab-br-bot | juergbi merged MR !1167 (juerg/cachedfail->master: tests/integration/cachedfail.py: Fix test_push_cached_fail) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1167 | 08:00 |
| laurence | looking into gitlab to see if we could disable notifications for WIP MRs | 09:00 |
| laurence | You can't currently, but there is a patch to turn off all notifications at a group / project level | 09:00 |
| laurence | I commented on the upstream issue - https://gitlab.com/gitlab-org/gitlab-ce/issues/50020 | 09:00 |
| *** toscalix has joined #buildstream | 09:03 | |
| *** bochecha has joined #buildstream | 09:09 | |
| *** phildawson has joined #buildstream | 09:17 | |
| *** tristan has joined #buildstream | 09:24 | |
| adds68 | can i have a review of: https://gitlab.com/BuildStream/website/merge_requests/115, please? | 09:28 |
| *** raoul has joined #buildstream | 09:31 | |
| *** ChanServ sets mode: +o tristan | 09:37 | |
| tristan | adds68, Just did by coincidence :) | 09:37 |
| adds68 | tristan, thanks, i have proposed a solution, i have to go afk for an hour though, so will hopefully be able to fix it when i get back :) | 09:40 |
| laurence | any strong opinions on colours to use? | 09:41 |
| tristan | I don't really, I would avoid florescents ... | 09:42 |
| tristan | And black would suck :) | 09:43 |
| SotK | to stick an oar in, I don't really like how the logo font is different from the rest of the header font in that screenshot | 09:51 |
| tristan | SotK, I think adds68 is going to change that already as per comment https://gitlab.com/BuildStream/website/merge_requests/115#note_143074191 | 09:52 |
| SotK | oh, nice :) | 09:53 |
| *** jonathanmaw has joined #buildstream | 09:54 | |
| gitlab-br-bot | phildawson opened MR !1168 (phil/tox-vev-environment->master: tox.ini: Add 'venv' environment to run arbitrary commands in a venv) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1168 | 10:00 |
| juergbi | tristan: any thoughts on this? https://gitlab.com/BuildStream/buildstream/pipelines/48328026/builds (haven't created an MR yet) | 10:01 |
| juergbi | -n 2 does reduce test time to around 20min for regular Linux, depending on the CI load. on WSL it helps quite a bit, bringing it also down to about 25min | 10:02 |
| juergbi | (tests themselves, runner/job initialization takes quite a long time on WSL) | 10:02 |
| juergbi | the legibility of the test output suffers a bit. I don't see any other downsides right now | 10:03 |
| juergbi | and coverage still looks fine, afaict | 10:04 |
| *** lachlan has joined #buildstream | 10:36 | |
| *** lachlan has quit IRC | 10:40 | |
| *** lachlan has joined #buildstream | 10:46 | |
| *** lachlan has quit IRC | 10:58 | |
| *** lachlan has joined #buildstream | 11:04 | |
| adds68 | laurence, any idea on colour whilst i change the layout? | 11:06 |
| *** alatiera has joined #buildstream | 11:06 | |
| *** lachlan has quit IRC | 11:13 | |
| *** lachlan has joined #buildstream | 11:15 | |
| *** lachlan has quit IRC | 11:18 | |
| phildawson | Does anyone have any opinions on this? https://gitlab.com/BuildStream/buildstream/merge_requests/1057#note_143105504 | 11:27 |
| jmac | Taking a look now, since this is relevant to my interests | 11:28 |
| laurence | adds68, blue for me pls! | 11:29 |
| tristan | juergbi, -n 2 of what ? | 11:32 |
| tristan | juergbi, looks good but I don't know what you did :) | 11:32 |
| tristan | ah to pytest | 11:32 |
| *** lachlan has joined #buildstream | 11:34 | |
| juergbi | yes, sorry, should have mentioned this is about parallel testing | 11:34 |
| juergbi | the runtime seems to vary quite a bit (presumably based on CI load), so it's difficult to provide clear figures for improvement | 11:36 |
| juergbi | however, -n 2 definitely seems to help (especially on WSL but also for the rest), while -n 4 doesn't seem to help that much more | 11:36 |
| juergbi | so I'd be in favor of merging this, unless there is some fundamental concern with running CI tests in parallel | 11:37 |
| juergbi | (with !1167 merged, I'm not aware of any remaining parallel test-specific failures) | 11:38 |
| gitlab-br-bot | MR !1167: tests/integration/cachedfail.py: Fix test_push_cached_fail https://gitlab.com/BuildStream/buildstream/merge_requests/1167 | 11:38 |
| jmac | phildawson: I'm happy with !1057 if the question raoul raised is resolved | 11:38 |
| gitlab-br-bot | MR !1057: plugin.py: Add API to allow plugins to raise deprecation warnings https://gitlab.com/BuildStream/buildstream/merge_requests/1057 | 11:38 |
| gitlab-br-bot | juergbi opened MR !1169 (juerg/ci->master: .gitlab-ci.yml: Enable parallel testing with 2 CPUs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1169 | 11:39 |
| phildawson | jmac, it has been resolved and is marked as such :) | 11:41 |
| phildawson | The specific opinion I was asking for was re juergbi's comment which I linked about the name of the configuration key I added. Sorry, I should have been more precise in my asking. | 11:42 |
| jmac | Ah, yes, I see that now. | 11:43 |
| tristan | juergbi, Well - to be honest I only worry about the pytest layer | 11:45 |
| phildawson | Thanks for the comment jmac. | 11:45 |
| phildawson | juergbi, is the extra opinion enough for you? | 11:45 |
| juergbi | phildawson: yes, I won't block the MR on this | 11:45 |
| tristan | juergbi, and whether we can trust it to not screw up with parallelism and our cli fixture... other than that, parallel testing is an opportunity to uncover legitimate BuildStream issues I guess | 11:45 |
| tristan | Then again, we don't support parallel runs completely so it might still cause issues in integration tests with parallel access to the artifact cache | 11:46 |
| tristan | especially if we have integration tests which end up triggering a cache cleanup | 11:46 |
| juergbi | tristan: I've been using -n 12 here locally for a while and am not aware of any remaining issues | 11:46 |
| juergbi | cachedfail was the only one and that's fixed now | 11:46 |
| tristan | Well lets do it then :) | 11:47 |
| juergbi | cache cleanup etc. shouldn't be an issue as you fixed this to use separate directories for each test session | 11:47 |
| juergbi | i.e., with -n 2 we have 2 sessions | 11:47 |
| phildawson | thanks juergbi | 11:47 |
| * phildawson clicks the button | 11:47 | |
| jmac | woo, thanks phildawson | 11:47 |
| tristan | See what happens, if it causes a bad issue, we'll find out, and if it fails enough to blocking too much CI, we could revert until fixed | 11:47 |
| juergbi | sure, sounds fine, ta | 11:47 |
| tristan | juergbi, Oh we have 2 "sessions" ? that makes more sense then | 11:48 |
| juergbi | yes | 11:48 |
| tristan | that means 2 separate artifact caches and shared source cache | 11:48 |
| juergbi | exactly | 11:48 |
| juergbi | it means that the base import happens twice | 11:48 |
| juergbi | but overall it's still faster, of course | 11:48 |
| tristan | very nice to have CI back to a reasonable timeframe | 11:49 |
| juergbi | yes, it got a bit painful | 11:50 |
| gitlab-br-bot | tristanvb approved MR !1168 (phil/tox-vev-environment->master: tox.ini: Add 'venv' environment to run arbitrary commands in a venv) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1168 | 12:01 |
| *** lachlan has quit IRC | 12:02 | |
| *** lachlan has joined #buildstream | 12:04 | |
| *** lachlan has quit IRC | 12:09 | |
| gitlab-br-bot | phildawson closed issue #848 (Create api for plugins to give deprecation warnings) on buildstream https://gitlab.com/BuildStream/buildstream/issues/848 | 12:09 |
| gitlab-br-bot | phildawson merged MR !1057 (phil/848-plugin-deprecation-warnings->master: plugin.py: Add API to allow plugins to raise deprecation warnings) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1057 | 12:09 |
| *** tristan has quit IRC | 12:18 | |
| *** lachlan has joined #buildstream | 12:26 | |
| *** tristan has joined #buildstream | 12:36 | |
| *** raoul has quit IRC | 12:36 | |
| *** lachlan has quit IRC | 12:44 | |
| gitlab-br-bot | aevri opened MR !1170 (aevri/doc_arch_deps->master: Architecture docs: minor corrections, clarifications, and nitpicks) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1170 | 12:47 |
| *** lachlan has joined #buildstream | 12:52 | |
| *** lachlan has quit IRC | 12:56 | |
| adds68 | tristan, laurence thoughts: https://gitlab.com/BuildStream/website/merge_requests/115 ? | 12:58 |
| adds68 | I hate CSS also | 12:58 |
| laurence | LGTM, cheers | 12:59 |
| adds68 | :) | 13:00 |
| gitlab-br-bot | LaurenceUrhegyi opened MR !1171 (laurence/update-readme->master: Update CONTRIBUTING.rst) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1171 | 13:03 |
| *** ChanServ sets mode: +o tristan | 13:03 | |
| tristan | :-/ | 13:03 |
| tristan | I guess adaptive CSS to make the icon size more reasonable would be overkill, though | 13:03 |
| adds68 | tristan, we can make it smaller if needed, currently 150px X 150px | 13:04 |
| tristan | (Would be cool if the waterwheel were to be the same height as the text) | 13:05 |
| tristan | Yeah but pixel size is kind of meaningless | 13:05 |
| adds68 | Well it would make the logo smaller, we could also make the strapline text smaller | 13:06 |
| adds68 | But we are working inside the constraints of a theme and bootstrap | 13:07 |
| tristan | We use bootstrap ? | 13:07 |
| adds68 | yep | 13:07 |
| tristan | If we use bootstrap, we can definitely use a differently sized icon for different adaptive layouts | 13:07 |
| * tristan recalls also doing really neat stuff with icons based on fonts | 13:07 | |
| adds68 | tristan, i assume there is some fancy way in bootstrap, however the website currently doesent even reduce the navigation to an accordion | 13:08 |
| adds68 | i assume theme has set the text sized to be fixed | 13:09 |
| adds68 | and i can have a play locally | 13:09 |
| tristan | E.g. @media (max-width: 1199) { ... CSS for screen resolutions < 1200px wide ... } | 13:10 |
| tristan | Text size will normally vary depending on resolution I think, but I don't recall completely | 13:10 |
| tristan | Maybe that is not screen resolution either but rather viewport size | 13:12 |
| tristan | adds68, Anyway I think it is not worthwhile to get too deep into that without doing a full site redesign | 13:13 |
| tristan | you will spend too much time in CSS hell | 13:13 |
| tristan | Maybe make the logo smaller, try to avoid the text wrapping of the title, and see what happens ? | 13:13 |
| adds68 | tristan, haha i will try one little thing in bootstrap and also reduce the logo size a little | 13:14 |
| gitlab-br-bot | aevri opened (was WIP) MR !1170 (aevri/doc_arch_deps->master: Architecture docs: minor corrections, clarifications, and nitpicks) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1170 | 13:16 |
| *** raoul has joined #buildstream | 13:19 | |
| adds68 | tristan, using vw just makes the text too small on smaller displays | 13:24 |
| adds68 | i'll scrap this for now | 13:24 |
| *** lachlan has joined #buildstream | 13:24 | |
| laurence | hi all, i'm going through old MRs | 13:24 |
| laurence | can we get some more reviews on this one please https://gitlab.com/BuildStream/buildstream/merge_requests/1002 | 13:24 |
| laurence | Handle grpc errors of type UNAVAILABLE and ABORTED. | 13:24 |
| laurence | would be good to get another approval and merge | 13:25 |
| juergbi | I'll add it to my list | 13:28 |
| *** lachlan has quit IRC | 13:30 | |
| laurence | thanks ! | 13:31 |
| laurence | also wonder if we could merge _sandboxremote.py: Create marked directories before running - https://gitlab.com/BuildStream/buildstream/merge_requests/1056 | 13:31 |
| *** lachlan has joined #buildstream | 13:31 | |
| laurence | the bug reported isn't seen any more but it doesn't seem to be because of those changes... | 13:31 |
| *** lachlan has quit IRC | 13:36 | |
| *** toscalix has quit IRC | 13:37 | |
| *** toscalix has joined #buildstream | 13:41 | |
| gitlab-br-bot | juergbi merged MR !1169 (juerg/ci->master: .gitlab-ci.yml: Enable parallel testing with 2 CPUs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1169 | 13:51 |
| tristan | Eeek, more logging regressions, I have a "Staged files overwrite existing files in staging area:" error which prints thousands of lines, even though I have not made my error-lines unlimited | 13:54 |
| *** nimish has joined #buildstream | 13:54 | |
| juergbi | hm, did anything change in core error handling recently? | 13:54 |
| juergbi | laurence: I've added a comment. except for that it looks good to me. if valentind is happy with it, it's good to merge, imo | 13:55 |
| laurence | juergbi, thank you | 13:56 |
| *** nimish has quit IRC | 13:58 | |
| tristan | Looking at it, it seems it is not a regression but is intentional | 13:58 |
| tristan | But I don't think it should be :-S | 13:59 |
| tristan | Seeing as an overlap error is potentially thousands of lines and is also reachable in the build log | 13:59 |
| tristan | looks disastrous to see them all spewed to the terminal :-S | 13:59 |
| juergbi | that's to motivate you fixing those overlaps ;) | 14:00 |
| tristan | Heh, I think "[5347 lines truncated]" or such is motivation enough :) | 14:01 |
| tristan | Alright, so I fix overlap scenarios this week I guess | 14:09 |
| tristan | First issue, it is seemingly impossible to allow overlaps of files on top of a subproject which has decided that overlaps are not allowed in the subproject | 14:10 |
| tristan | So subprojects are forcing that decision onto consumers, which is hard to work around | 14:10 |
| adds68 | laurence, https://gitlab.com/BuildStream/website/merge_requests/116 last MR, see what you think | 14:11 |
| adds68 | The logo also nee merging tristan | 14:11 |
| adds68 | needs* | 14:11 |
| tristan | I think your after pic is off | 14:13 |
| tristan | (identical to before) | 14:13 |
| tristan | But I can just trust you :) | 14:13 |
| tristan | Or, the logo is so small that I cannot see it :) | 14:13 |
| tristan | oh that is a different mr sorry | 14:14 |
| *** raoul has quit IRC | 14:14 | |
| tristan | adds68, merged logo | 14:15 |
| adds68 | tristan, \o/ woohoo! | 14:15 |
| adds68 | tristan, that second MR is purely just my taste, feel free to close it is it doesn't fly | 14:16 |
| adds68 | tristan, i just think the grey is a bit grim and now we have the blue logo, just having a clean white theme would look a bit better | 14:16 |
| tristan | Heh, I don't particularly like it but not enough to dislike it | 14:16 |
| tristan | Honestly I don't think it's worth the energy to tweak this boring looking site with a 90s feel to it | 14:17 |
| tristan | it needs real design | 14:17 |
| *** raoul has joined #buildstream | 14:17 | |
| adds68 | tristan, true, but i doubt that will happen any time soon, so some tweaks will make it less drab | 14:18 |
| adds68 | it's still used for people to jump to the docs/gitlab | 14:18 |
| *** alatiera has quit IRC | 14:37 | |
| *** alatiera has joined #buildstream | 14:37 | |
| *** adds68 has quit IRC | 14:38 | |
| *** alatiera has quit IRC | 14:40 | |
| *** alatiera has joined #buildstream | 14:59 | |
| gitlab-br-bot | aevri merged MR !1170 (aevri/doc_arch_deps->master: Architecture docs: minor corrections, clarifications, and nitpicks) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1170 | 15:14 |
| laurence | aevri, I wonder where boilerplate text should live | 15:18 |
| laurence | i agree it'd be good :) | 15:18 |
| laurence | not sure it should be in the contributing guide - If I post it to the list it'll be in the archives | 15:18 |
| laurence | but then I wonder if all the clicks to navigate to these places and C+P is the same effort as writing out a quick note | 15:19 |
| aevri | Yeah, I'm not sure either. I think it would be ok to have in the repo in a separate file - since the issue templates are there too, it's not without precedent | 15:19 |
| aevri | I personally find the mental effort of typing such things outweighs the few clicks - I think they're an important PR thing | 15:22 |
| aevri | e.g. I'd be less happy with "1 mo - WIPing" and more happy with "Hi! Thankyou for your contribution, unfortunately this MR is now over a month without an update from the author, as per our policy I'm WIP'ing this to keep our queue tidy. Please do clear the WIP status if you come back to work on it. Cheers!" | 15:24 |
| aevri | Unfortunately saved responses aren't in GitLab yet: https://gitlab.com/gitlab-org/gitlab-ce/issues/14796 | 15:26 |
| laurence | aevri, thanks! I will crib from that and create a new file with this template then :) | 15:26 |
| aevri | Ace, thanks! | 15:26 |
| *** raoul has quit IRC | 15:41 | |
| *** raoul has joined #buildstream | 15:42 | |
| juergbi | maybe we could have a WIP bot, assign the MR to the bot and it will write that comment ;) | 15:45 |
| *** bochecha has quit IRC | 16:09 | |
| gitlab-br-bot | phildawson merged MR !1168 (phil/tox-vev-environment->master: tox.ini: Add 'venv' environment to run arbitrary commands in a venv) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1168 | 16:11 |
| *** nimish has joined #buildstream | 16:19 | |
| *** lachlan has joined #buildstream | 16:32 | |
| *** juanalday has joined #buildstream | 16:34 | |
| *** lachlan has quit IRC | 16:35 | |
| *** lachlan has joined #buildstream | 17:09 | |
| *** lachlan has quit IRC | 17:15 | |
| *** lachlan has joined #buildstream | 17:22 | |
| *** lachlan has quit IRC | 17:34 | |
| *** nimish has quit IRC | 17:34 | |
| *** nimish has joined #buildstream | 17:35 | |
| *** juanalday has quit IRC | 17:40 | |
| *** toscalix has quit IRC | 17:43 | |
| *** juanalday has joined #buildstream | 17:45 | |
| *** jonathanmaw has quit IRC | 17:46 | |
| *** lachlan has joined #buildstream | 17:47 | |
| *** phildawson has quit IRC | 17:49 | |
| *** phildawson has joined #buildstream | 17:49 | |
| *** lachlan has quit IRC | 17:52 | |
| *** lachlan has joined #buildstream | 17:58 | |
| *** nimish has quit IRC | 18:00 | |
| *** lachlan has quit IRC | 18:10 | |
| *** raoul has quit IRC | 18:21 | |
| *** nimish has joined #buildstream | 18:30 | |
| *** xjuan has joined #buildstream | 18:34 | |
| *** phildawson has quit IRC | 18:37 | |
| *** lachlan has joined #buildstream | 18:49 | |
| *** lachlan has quit IRC | 18:54 | |
| *** lachlan has joined #buildstream | 18:58 | |
| *** alatiera has quit IRC | 19:06 | |
| *** nimish has quit IRC | 19:10 | |
| *** lachlan has quit IRC | 19:16 | |
| *** lachlan has joined #buildstream | 19:41 | |
| *** xjuan has quit IRC | 20:01 | |
| *** xjuan has joined #buildstream | 20:04 | |
| *** lachlan has quit IRC | 20:16 | |
| *** xjuan has quit IRC | 21:00 | |
| *** xjuan has joined #buildstream | 21:00 | |
| *** alatiera has joined #buildstream | 21:37 | |
| *** xjuan has quit IRC | 21:39 | |
| *** xjuan has joined #buildstream | 21:55 | |
| *** xjuan has quit IRC | 21:59 | |
| *** xjuan has joined #buildstream | 22:29 | |
| *** xjuan has quit IRC | 22:32 | |
| *** tristan has quit IRC | 22:39 | |
| *** xjuan has joined #buildstream | 22:46 | |
| *** xjuan has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!