IRC logs for #buildstream for Friday, 2019-02-08

*** nimish has joined #buildstream02:06
*** mohan43u has quit IRC02:31
*** mohan43u has joined #buildstream02:35
*** nimish has quit IRC03:18
*** tpollard has joined #buildstream08:40
doras[m]When is 1.2.4 expected?09:02
*** toscalix has joined #buildstream09:43
*** kapil___ has joined #buildstream09:48
*** toscalix has quit IRC10:06
*** toscalix has joined #buildstream10:07
*** toscalix has quit IRC10:15
*** jonathanmaw has joined #buildstream10:17
*** toscalix has joined #buildstream10:19
*** jmac has joined #buildstream10:25
*** toscalix has joined #buildstream10:29
*** lachlan has joined #buildstream10:42
* laurence has only just learnt that you can filter MRs using WIP yes/no10:46
jjardonIt's a recent new feature (2 or 3 releases ago I think)10:48
*** raoul has joined #buildstream10:50
adds68Hi all, i have sent out the final email for the logo, there are now 2 choices, which ever gets the most votes by the end of today (can be longer), i will send over the designer for finalisation10:51
*** toscalix has quit IRC10:55
laurenceadds68, thanks again for pushing this - I hope my intervention wasn't too awkward, but I felt the wheel needed an airing10:59
laurenceand some key contributors seem to agree, which is nice (i think their vote counts for more than folks who don't even have a patch)10:59
*** raoul has quit IRC11:00
adds68laurence, no problem, it's hard to try and please everyone with things like this and i also don't want people to feel left out. I also have to keep the designer happy, so once we have a final version, we can always ask for small revisions/colours as he is happy to do things like that11:00
adds68laurence, and yes agreed :)11:00
*** alatiera has joined #buildstream11:01
doras[m]Should "cleanup" take... minutes?11:04
*** lachlan has quit IRC11:05
doras[m]Looks like "~/.cache/buildstream/artifacts" is 57G, while I set its quota to be 50G. So it does make sense that a cleanup would occur, but it also seems to remove about 4 kilobytes per 5 seconds. That's awfully slow.11:09
*** lachlan has joined #buildstream11:11
gitlab-br-botjmacarthur approved MR !1129 (snakeviz->master: contributing: snakeviz replaces pyflame+flamegraph) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/112911:11
doras[m]Is there a way to trigger cleanup on-demand?11:14
*** lachlan has quit IRC11:18
doras[m]Trying to build again still leaves me with an extremely slow cleanup :\11:23
*** lachlan has joined #buildstream11:28
jjardondoras[m]: 1.2.4 was expected before christmas I think; I guess it will be released soon11:29
jjardondoras[m]: about the cleanup: https://gitlab.com/BuildStream/buildstream/issues/73411:29
*** toscalix has joined #buildstream11:37
doras[m]Thanks for the reference, jjardon. Is there a workaround for this? Can I also delete objects directly somehow to skip this process?11:39
jjardondoras[m]: I'm not aware of any, sorry11:39
doras[m]What I currently end up doing is clean up my entire cache with rm -rf every week or so. This isn't what everybody else does, is it?11:43
jjardondoras[m]: that is what I do as well11:43
doras[m]There must be some way to selectively remove what I know isn't needed anymore.11:43
doras[m]Well, bummer.11:44
juergbidoras[m]: we have plans to improve this (switching to object-based expiry)11:44
jjardondoras[m]: if you find other solution, please comment in the issue :)11:44
tpollardI believe there's a plan to add a command for delete element artifacts11:44
juergbiright now a very expensive part of the cleanup process is to prune objects, i.e., figure out which object files are still needed11:45
juergbiwith object-based expiry, we can skip that, however, it requires a few changes in BuildStream to accommodate incomplete/partial artifacts11:45
juergbi(on the server side, we already follow this approach, as it can deal with partial artifacts)11:45
jjardonwould that be available in the 1.2 branch, or is too big change?11:46
juergbiI think it's rather unlikely11:46
juergbihowever, hopefully, 1.90.x will be acceptable for general use11:46
juergbiat least the snapshots11:46
doras[m]If I remove refs manually in bulk, can the garbage collector figure out rather quickly which objects are no longer needed?11:48
juergbiif you still have many refs left, it might still take a while as it has to enumerate all reachable objects11:49
doras[m]I see. Looking at what is actually deleted, it appears that it only deletes refs. It doesn't even reach the part of deleting the actual objects.11:54
*** phildawson has quit IRC12:03
*** phildawson has joined #buildstream12:03
doras[m]I wonder when it actually removes the objects, then.12:10
doras[m]Or otherwise how I can figure out which objects can be deleted by myself.12:15
gitlab-br-botjonathanmaw approved MR !1130 (are_you_sure2->master: userconfig: rm really-workspace-close-project-inaccessible) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/113013:17
*** phildawson has quit IRC13:19
gitlab-br-bottpollard opened (was WIP) MR !1135 (tpollard/896->master: Optional creation of buildtrees) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/113513:28
tpollardtests-fedora-update-deps just took 2 hours to complete a test run13:33
tpollardand counting13:33
*** raoul has joined #buildstream13:47
*** kapil___ has quit IRC13:48
*** raoul has quit IRC13:52
gitlab-br-botjennis approved MR !1129 (snakeviz->master: contributing: snakeviz replaces pyflame+flamegraph) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/112913:55
gitlab-br-botjennis approved MR !1130 (are_you_sure2->master: userconfig: rm really-workspace-close-project-inaccessible) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/113014:00
laurencejennis, earlier this week, Kinnison, benshubert and I had a chat and wrt benchmarks, we mentioned having an easy way to compare a local checkout against master14:00
*** nimish has joined #buildstream14:00
laurencejennis, is this feasible with the current set up? what do you think?14:00
*** phildawson has joined #buildstream14:01
*** tpollard has quit IRC14:04
jennisAFAIK, you can run the benchmarking locally on your laptop, so I don't think it will be too difficult to add a helper in where we run this for master and the branch in concern14:04
jennisjonathanmaw, looks like we're having problems with the windows runner: https://gitlab.com/BuildStream/buildstream/-/jobs/15849944914:11
jonathanmawhmm, wifi problems on that computer14:12
jennis:(14:12
Kinnisonphildawson: Good news - the experiment from this morning, assuming we manage to cache usually, is ca. 2x the speed14:13
Kinnisonphildawson: it's *marginally* slower if we *always* have to re-parse14:13
* Kinnison will now try and plumb it alongside _variables.py to do a proper profile14:14
jonathanmawjennis: there we go, I've moved it to wired internet14:14
phildawsonNice Kinnison :)14:15
Kinnisonphildawson: looks like the number of times we call len() it's worth caching14:47
gitlab-br-botjennis approved MR !1075 (phil/plugin-testing-api->master: Expose basic api for testing external plugins.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/107514:48
*** lachlan has quit IRC15:16
*** lachlan has joined #buildstream15:23
*** toscalix has quit IRC15:33
WSalmonhi all15:35
WSalmoni just tried to follow https://buildstream.build/source_install.html#installing_dependencies15:35
WSalmonfor fedora but then installed master15:35
WSalmonit failed15:35
WSalmonis this guild only for 1.2?15:35
WSalmonor should this work?15:35
WSalmonshould i be issuing a bug agenst the website/15:36
tlater[m]WSalmon: If the docker image builds, I find it unlikely that this fails15:42
tlater[m]But yes, I'd file a bug against the website15:42
tlater[m]If you'd like a bit more debugging help, feel free to paste errors and suchlike here :)15:42
WSalmonso the website is not detailing master so all is fine in that regard15:48
WSalmonbut the git clone bit dosent seem to be rendering well so if some one else could check its not just me15:49
WSalmonthen i could put a issue up for that15:49
doras[m]I see: git checkout <desired release tag>15:58
WSalmonnot just me then, thanks doras[m]16:01
WSalmonhttps://gitlab.com/BuildStream/website/issues/2816:08
gitlab-br-botphildawson closed issue #847 (Expose testing api for use by external plugins) on buildstream https://gitlab.com/BuildStream/buildstream/issues/84716:28
gitlab-br-botphildawson merged MR !1075 (phil/plugin-testing-api->master: Expose basic api for testing external plugins.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/107516:28
gitlab-br-botvalentindavid approved MR !1056 (jmac/make_marked_directories->master: _sandboxremote.py: Create marked directories before running) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/105616:37
gitlab-br-botjjardon opened MR !1136 (jjardon/fedora_27->master: .gitlab-ci.yml: Remove testing on Fedora 27) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/113616:49
*** bilelmoussaoui has joined #buildstream17:00
*** bilelmoussaoui has quit IRC17:26
adds68any last votes for the buildstream logo: http://www.strawpoll.me/17389951 ?17:30
adds687.9% of people have voted17:30
adds68See the mailing list for the #1/#2 images also17:31
gitlab-br-botIssue #1: sphinx docs fail on python2-default systems https://gitlab.com/BuildStream/buildstream/issues/117:31
adds68haha silly gitlab-br-bot :)17:32
WSalmondose it do that for any #2217:33
gitlab-br-botIssue #22: failed to upgrade buildstream at 640a734ec1db923b5 https://gitlab.com/BuildStream/buildstream/issues/2217:33
WSalmonhaha thats cool17:33
gitlab-br-botjonathanmaw opened (was WIP) MR !1134 (jonathan/junction-no-tmpdir->master: Stage junctions into .bst instead of a tmpdir) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/113417:34
adds68WSalmon, also !111117:36
gitlab-br-botMR !1111: Run tests using tox https://gitlab.com/BuildStream/buildstream/merge_requests/111117:36
adds68ironfoot is a wizz kid17:36
ironfoot;)17:37
ironfootYou are all gitlabIRCed17:37
*** nimish has quit IRC17:38
*** bilelmoussaoui has joined #buildstream17:45
*** bilelmoussaoui has joined #buildstream17:46
*** lachlan has quit IRC18:03
*** jonathanmaw has quit IRC18:05
*** lachlan has joined #buildstream18:06
*** bilelmoussaoui has quit IRC18:20
jjardonvalentind: number of concurrent jobs were limited to 20; I have increased it to 5018:20
valentindok18:20
jjardonseems the pipeline has grow a lot of parallel jobs lately18:21
jjardonCan I have reviews of https://gitlab.com/BuildStream/buildstream/merge_requests/1136 , please?18:55
gitlab-br-botjjardon closed issue #618 (BuildStream pulls from remote cache, even when configuration removed) on buildstream https://gitlab.com/BuildStream/buildstream/issues/61820:29
gitlab-br-botjjardon closed issue #401 (If a project B use project A as a junction, B should not try to use the bst remote cache of A (at least by default)) on buildstream https://gitlab.com/BuildStream/buildstream/issues/40120:29
gitlab-br-botjjardon merged MR !1113 (abderrahim/artifact-cache-junction->master: Use artifact cache specs from the parent project before those defined in junctions) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/111320:29

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!