IRC logs for #buildstream for Tuesday, 2019-01-22

« Monday, 2019-01-21 Index Wednesday, 2019-01-23 »
*** jswagner has quit IRC02:39
*** jswagner has joined #buildstream02:41
*** jswagner has joined #buildstream02:42
*** jswagner has joined #buildstream02:42
*** jswagner has joined #buildstream02:43
*** jswagner has joined #buildstream02:44
*** jswagner has joined #buildstream02:45
*** jswagner has joined #buildstream02:46
*** jswagner has joined #buildstream02:48
*** nimish has joined #buildstream03:44
*** nimish has quit IRC04:04
*** nimish has joined #buildstream04:05
*** nimish has quit IRC04:10
*** rdale has quit IRC04:59
*** nimish has joined #buildstream05:09
*** rdale has joined #buildstream05:15
*** rdale_ct has joined #buildstream05:19
*** rdale has quit IRC05:20
*** rdale_ct has quit IRC05:24
*** rdale has joined #buildstream05:27
*** nimish has quit IRC05:29
*** rdale has quit IRC05:32
*** rdale has joined #buildstream05:32
*** rdale has quit IRC05:46
*** rdale has joined #buildstream05:48
*** nimish has joined #buildstream06:04
*** nimish has quit IRC06:06
*** nimish has joined #buildstream06:08
*** nimish has quit IRC06:12
*** kapil___ has joined #buildstream06:18
*** nimish has joined #buildstream06:28
*** nimish has quit IRC06:33
*** rdale_ct has joined #buildstream06:58
*** rdale has quit IRC06:59
*** nimish has joined #buildstream07:01
*** nimish has quit IRC07:04
gitlab-br-botjuergbi opened (was WIP) MR !925 (issue-638-validate-all-files->master: Add support for default targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/92507:15
*** nimish has joined #buildstream07:27
*** rdale_ct has quit IRC07:34
*** rdale has joined #buildstream07:36
*** nimish has quit IRC07:36
*** nimish has joined #buildstream07:43
*** nimish has quit IRC07:44
*** nimish has joined #buildstream07:44
*** rdale_ct has joined #buildstream07:48
*** rdale has quit IRC07:48
*** nimish has quit IRC08:10
*** nimish has joined #buildstream08:46
*** toscalix has joined #buildstream08:50
*** nimish has quit IRC08:56
*** nimish has joined #buildstream08:56
*** nimish has quit IRC09:06
*** nimish has joined #buildstream09:07
*** nimish has quit IRC09:17
*** kapil___ has quit IRC09:17
*** nimish has joined #buildstream09:33
*** nimish has quit IRC09:42
*** nimish has joined #buildstream09:53
*** rdale_ct has quit IRC09:53
*** nimish has quit IRC10:03
*** nimish has joined #buildstream10:03
*** toscalix_ has joined #buildstream10:03
*** jonathanmaw has joined #buildstream10:03
*** toscalix_ has quit IRC10:04
*** raoul has joined #buildstream10:06
*** rdale has joined #buildstream10:08
*** nimish has quit IRC10:13
*** nimish has joined #buildstream10:14
juergbijonathanmaw: can you please review this change https://gitlab.com/BuildStream/buildstream/merge_requests/925#note_133533912 ?10:19
* jonathanmaw has a look10:19
jennisls -lrt10:21
jenniswhoops10:21
*** solid_black has quit IRC10:21
*** solid_black has joined #buildstream10:21
*** solid_black has quit IRC10:23
*** solid_black has joined #buildstream10:23
*** tpollard has quit IRC10:24
juergbita10:31
*** nimish has quit IRC10:34
*** nimish has joined #buildstream10:34
*** nimish has quit IRC10:35
*** nimish has joined #buildstream10:35
*** lachlan has joined #buildstream10:38
*** nimish has quit IRC10:40
*** nimish has joined #buildstream10:42
*** alatiera has joined #buildstream10:44
*** raoul has quit IRC10:48
*** lachlan has quit IRC10:51
*** lachlan has joined #buildstream10:51
*** raoul has joined #buildstream10:51
*** nimish has quit IRC11:06
*** nimish has joined #buildstream11:07
*** lachlan has quit IRC11:31
*** nimish has quit IRC11:31
*** nimish has joined #buildstream11:32
gitlab-br-botraoul.hidalgocharman opened issue #878 (Removing artifact cache state dependency in integration tests) on buildstream https://gitlab.com/BuildStream/buildstream/issues/87811:36
*** nimish has quit IRC11:37
*** nimish has joined #buildstream11:38
raoul^ raised an issue for the integration tests fyi, tlater[m]11:38
*** lachlan has joined #buildstream11:47
*** nimish has quit IRC11:48
*** nimish has joined #buildstream11:48
*** nimish has joined #buildstream11:49
*** lachlan has quit IRC11:53
*** kapil___ has joined #buildstream11:53
*** lachlan has joined #buildstream11:57
*** lachlan has quit IRC12:08
*** lachlan has joined #buildstream12:11
*** nimish has quit IRC12:14
*** nimish has joined #buildstream12:14
*** nimish has joined #buildstream12:15
*** nimish has joined #buildstream12:16
*** lachlan has quit IRC12:17
tlater[m]Thanks raoul :)12:19
jennisIs anyone au fait with our man pages?12:20
*** lachlan has joined #buildstream12:27
tlater[m]jennis: I think tristan is the only one who's really touched that part of the infrastructure.12:29
*** toscalix has quit IRC12:30
tlater[m]jennis: Is there a particular problem?12:32
jennisMhmm, they contain things like bst-track.1, bst-fetch.1, still have bst-source-bundle.1 which as been retired12:33
jennisAnd it looks like these are built in some way12:33
*** lachlan has quit IRC12:33
jennisI don't think just going in and trivially changing fetch -> source fetch, track -> source track is the solution12:33
tlater[m]Right, gotcha12:34
*** lachlan has joined #buildstream12:34
tlater[m]That's a pretty standard man page setup, though12:34
tlater[m]So anyone who's written a man page before should be able to help out here x)12:34
jennissure, i'll wait12:34
*** lachlan has quit IRC12:39
*** nimish has quit IRC12:41
*** nimish has joined #buildstream12:43
*** nimish has quit IRC12:44
*** nimish has joined #buildstream12:44
*** nimish has quit IRC12:48
cs-shadowdon't we convert our man pages from sphinx?12:52
cs-shadowjennis: i meant are you seeing those references after updating them?12:53
cs-shadowhttps://docs.buildstream.build/CONTRIBUTING.html#man-pages12:53
jenniscs-shadow, yes12:53
jennisJust found that and did it12:53
jennisIt's added bst-artifact-server, but bst-track reamains bst-track12:54
jennisI feel like I'm missing something obvious here12:54
*** lachlan has joined #buildstream12:55
cs-shadowjennis: i have a suspicion that you might be hitting https://github.com/click-contrib/click-man/issues/1012:56
cs-shadowand that you are only ever generating man pages for the artifact entrypoint12:56
jennisAhh, that looks like it12:56
cs-shadowa hacky test would to remove the artifact entrypoint temporarily and see if you get better results12:56
jennisI just removed everything in man and tried to regenerate them12:56
jennisYes, i'll do that12:57
cs-shadowor that :)12:57
cs-shadow(that issue also relates to how python sorts its dicts, because _first_ in this context depends on that)12:58
jennisok that's sorted12:58
jenniscs-shadow, so now they still exist for `bst fetch` and `bst track` (as well as `bst source fetch`, and `bst source track`), not sure if we should explicitly remove these...?13:00
*** rdale has quit IRC13:00
jennishttps://paste.gnome.org/pkrnap0sg13:01
cs-shadowI think we'd want that in the end, but I'm not sure how to do that with click_man. Ideally it'd read the "hidden" property of the command and decide accordingly. Evidently, it's not doing that at present13:02
cs-shadowmight be worth raising an issue on click_man repo to see how they feel about it13:03
jennisyeah, good shout13:05
*** nimish has joined #buildstream13:06
*** raoul has quit IRC13:07
*** toscalix has joined #buildstream13:08
gitlab-br-botvalentindavid opened MR !1095 (valentindavid/crash_in_scheduler_857->master: Fix crash when spawned job completes very fast) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109513:11
*** nimish has quit IRC13:20
*** nimish has joined #buildstream13:20
*** nimish has joined #buildstream13:21
*** lachlan has quit IRC13:25
*** nimish has quit IRC13:26
*** nimish has joined #buildstream13:26
*** nimish has quit IRC13:36
*** nimish has joined #buildstream13:37
*** nimish has quit IRC13:53
gitlab-br-botjuergbi approved MR !1045 (jennis/migrate_pull_push_commands->master: Move push/pull/checkout to the artifact subcommand group) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/104514:03
*** raoul has joined #buildstream14:04
*** nimish has joined #buildstream14:05
*** nimish has joined #buildstream14:06
jennisthanks juergbi14:09
jennisJust to clarify, we don't think it's worth explicitly deleting the man pages created for the hidden commands?14:10
*** nimish has quit IRC14:11
*** nimish has joined #buildstream14:11
*** nimish has quit IRC14:16
*** nimish has joined #buildstream14:17
*** lachlan has joined #buildstream14:19
juergbijennis: I think the HTML doc is the bigger concern14:20
juergbimaybe whatever solution we come up with for that also helps with the man pages14:20
juergbiso I'd defer this for now14:20
jennisHopefully14:20
jennisOk, I'm filing the issue now14:21
juergbijennis: maybe we could do an improvement right away, though14:21
juergbiadd (obsolete) or similar to the short_help of those commands14:21
juergbithat would then show up in both docs and man pages14:21
juergbiand would be good enough as stop gap, to avoid confusion14:21
*** rdale has joined #buildstream14:23
jennisOk, I'll do another MR for this once the issues are filed14:24
jennisjuergbi, that's likely a sphinx-click issue right?14:26
jennisJust checking that's the right package14:26
*** nimish has quit IRC14:27
*** nimish has joined #buildstream14:27
juergbipossibly, yes14:30
raoulAnyone got any idea why docs in a pipeline would hang? Works locally in the same docker image but it just hang forever on a `bst build hello.bst` command, which doesn't get run locally14:30
gitlab-br-botjennis opened issue #879 (Hidden commands are still shown within our documentation) on buildstream https://gitlab.com/BuildStream/buildstream/issues/87914:31
*** lachlan has quit IRC14:33
*** tristan has joined #buildstream14:35
*** lachlan has joined #buildstream14:36
gitlab-br-botraoul.hidalgocharman approved MR !1093 (chandan/unpin-sphinx->master: tox.ini: Unpin sphinx dependency) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109314:38
gitlab-br-botjennis opened issue #880 (Man pages are only generated for the first entry point) on buildstream https://gitlab.com/BuildStream/buildstream/issues/88014:39
*** lachlan has quit IRC14:39
cs-shadowraoul: it's rebuilding the docs, which is indicated by setting BST_FORCE_SESSION_REBUILD=114:40
cs-shadowyou can try setting it locally as well14:40
raoulAh missed that, hopefully this'll let me track down why it's' hanging14:42
raoulcheers14:42
jenniscs-shadow, it looks like only the development version of click lets us define 'hidden' commands, is that right?14:47
cs-shadowjennis: i think it's Click >= 7.014:48
jennismhmm, I don't see this in their 7.x documentation :/14:48
jennisbut it does mention it in their changelog14:49
*** lachlan has joined #buildstream14:52
gitlab-br-botjennis opened issue #881 (Man pages are generated for 'hidden' commands) on buildstream https://gitlab.com/BuildStream/buildstream/issues/88114:54
raoulcs-shadow, even with BST_FORCE_SESSION_REBUILD=1 is still missing out on those commands, any idea?14:58
raoulmaybe I need to have a look at the make file to see what it's doing14:58
gitlab-br-bottristanvb opened MR !1096 (tristan/fix-terminated-status->master: _scheduler: Fix dont display a failure for terminated jobs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109615:00
gitlab-br-botraoul.hidalgocharman approved MR !1092 (valentindavid/make_cache_dir->master: Make sure testing cache directory exists) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109215:00
jennisok juergbi, cs-shadow, I've filed some issues for us which both mark the relevant upstream issues in click-man and click-sphinx15:05
*** lachlan has quit IRC15:07
gitlab-br-botjennis merged MR !1045 (jennis/migrate_pull_push_commands->master: Move push/pull/checkout to the artifact subcommand group) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/104515:08
jenniswham15:08
*** lachlan has joined #buildstream15:14
gitlab-br-botraoul.hidalgocharman approved MR !1086 (aevri/bst_track_guidance->master: Fixup refs to 'bst track' and 'bst fetch') on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/108615:16
*** nimish has quit IRC15:22
*** nimish has joined #buildstream15:22
*** tristan has joined #buildstream15:28
*** tristan has joined #buildstream15:29
*** rdale has quit IRC15:29
*** ChanServ sets mode: +o tristan15:29
*** tristan has quit IRC15:30
*** tristan has joined #buildstream15:30
*** rdale has joined #buildstream15:31
gitlab-br-botjennis opened MR !1097 (jennis/add_obsoletion_note->master: Add an obsoletion note to our deprecated commands.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109715:34
jennisjuergbi, I guess this is just a question of style, but how's this? https://gitlab.com/BuildStream/buildstream/merge_requests/1097/diffs15:35
*** lachlan has quit IRC15:36
*** nimish has quit IRC15:37
*** nimish has joined #buildstream15:38
*** nimish has joined #buildstream15:38
*** lachlan has joined #buildstream15:44
tlater[m]Are our workspaces transparent to version control yet?15:57
tlater[m]I.e., can I `git pull` in a workspace without messing everything up?15:57
* tlater[m] forgets if that was implemented15:57
*** ChanServ sets mode: +o tristan16:02
tristantlater[m], What do you expect to go wrong ?16:02
tristantlater[m], does running files not handle it right ?16:03
tlater[m]tristan: That's a good question. I mostly remember a long set of discussions around how we're going to exclude the `.git` directory, which would absolutely break that.16:04
* tlater[m] hasn't tested it, mostly asking in preparation for a talk next week16:04
*** lachlan has quit IRC16:06
juergbitlater[m]: we have separate init_workspace. workspace should not be affected by .git directory removal of regular source staging16:06
juergbiso it's supposed to just work, but I have to admit, I'm not really a workspace user16:07
tlater[m]Awesome, thanks juergbi. I'll gloss over potential bugs for the sake of presentation ;)16:08
gitlab-br-botjennis merged MR !1097 (jennis/add_obsoletion_note->master: Add an obsoletion note to our deprecated commands.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109716:15
*** lachlan has joined #buildstream16:22
*** nimish has quit IRC16:23
*** nimish has joined #buildstream16:24
*** nimish has quit IRC16:39
*** nimish has joined #buildstream16:39
*** lachlan has quit IRC16:47
*** nimish has quit IRC16:49
*** nimish has joined #buildstream16:50
cs-shadowjennis: thanks for filing and recording all upstream issues. Very useful :)16:54
jenniscs-shadow, you're welcome16:55
*** tristan has quit IRC16:58
*** tristan has joined #buildstream17:00
*** solid_black has quit IRC17:02
*** lachlan has joined #buildstream17:03
*** lachlan has quit IRC17:07
laurencecs-shadow, very important question from me here, are there any social activities planned for the gathering that you know of?17:08
laurence;)17:08
cs-shadowlaurence: that's a great point. We are planning to have building tours and games organized for the meetup on 31st but I am not sure if there are any major plans for the Gathering just yet. Will be very interested to hear any ideas17:09
* tlater[m] wonders if we can start calling "The Gathering" "Beavercon" yet17:10
laurencecs-shadow, sounds great :) I think dinner on Tuesday night would be great17:10
laurenceBut sometimes it's enough to let people organise between themselves on the day, I've found17:11
* cs-shadow loves BeaverCon17:11
laurencetlater[m], get some stickers printed17:11
laurencehaha17:11
cs-shadowlaurence: good ideas, will see if we can find a nice place17:12
gitlab-br-bottristanvb merged MR !1096 (tristan/fix-terminated-status->master: _scheduler: Fix dont display a failure for terminated jobs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109617:14
*** nimish has quit IRC17:14
*** nimish has joined #buildstream17:15
*** nimish has quit IRC17:20
*** tristan has quit IRC17:20
*** lachlan has joined #buildstream17:20
*** nimish has joined #buildstream17:21
*** nimish has quit IRC17:30
*** nimish has joined #buildstream17:31
*** nimish has quit IRC17:58
*** jonathanmaw has quit IRC18:06
*** tristan has joined #buildstream18:11
*** coldtom has quit IRC18:11
*** adds68 has quit IRC18:11
*** ikerperez has quit IRC18:11
*** jennis has quit IRC18:11
*** phildawson has quit IRC18:11
*** adds68 has joined #buildstream18:15
gitlab-br-bottristanvb opened MR !1098 (tristan/fix-pullbuildtrees-test->master: tests/integration/pullbuildtrees.py: Fix the non-integration case.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109818:15
*** raoul has quit IRC18:21
*** tristan has quit IRC18:27
*** rdale has quit IRC18:34
*** paulsherwood has quit IRC18:38
*** jmac has quit IRC18:38
*** benbrown has quit IRC18:38
*** lachlan has quit IRC18:41
*** tristan has joined #buildstream18:44
*** kapil___ has quit IRC18:53
*** thinkl33t has joined #buildstream18:58
*** thinkl33t has quit IRC18:59
*** valentind has quit IRC19:03
*** johnward has quit IRC19:03
*** mablanch has quit IRC19:03
*** laurence has quit IRC19:03
*** WSalmon has quit IRC19:03
*** bethw has quit IRC19:03
*** johnward has joined #buildstream19:04
*** bethw has joined #buildstream19:05
*** laurence has joined #buildstream19:06
*** mablanch has joined #buildstream19:06
*** valentind has joined #buildstream19:06
*** WSalmon has joined #buildstream19:07
*** adds68 has quit IRC19:13
*** bethw has quit IRC19:16
*** laurence has quit IRC19:16
*** mablanch has quit IRC19:16
*** toscalix has quit IRC19:16
*** mablanch has joined #buildstream19:17
*** laurence has joined #buildstream19:18
*** bethw has joined #buildstream19:20
*** xjuan has joined #buildstream19:32
*** coldtom has joined #buildstream19:41
gitlab-br-bottristanvb merged MR !1098 (tristan/fix-pullbuildtrees-test->master: tests/integration/pullbuildtrees.py: Fix the non-integration case.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/109819:59
*** tristan has quit IRC20:13
*** milloni has quit IRC20:27
*** milloni has joined #buildstream20:27
*** adds68 has joined #buildstream20:57
*** alatiera_ has joined #buildstream21:52
*** alatiera has quit IRC21:52
*** alatiera_ is now known as alatiera21:52
*** alatiera_ has joined #buildstream21:56
*** alatiera has quit IRC21:58
*** alatiera_ is now known as alatiera21:58
« Monday, 2019-01-21 Index Wednesday, 2019-01-23 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!