| *** xjuan has quit IRC | 00:23 | |
| *** nimish has joined #buildstream | 01:59 | |
| *** kapil___ has joined #buildstream | 01:59 | |
| *** lsfranco has joined #buildstream | 02:01 | |
| *** lsfranco has quit IRC | 02:16 | |
| *** lsfranco has joined #buildstream | 02:17 | |
| *** thinkl33t has quit IRC | 03:10 | |
| *** nimish has quit IRC | 03:14 | |
| *** juergbi has quit IRC | 03:16 | |
| *** juergbi has joined #buildstream | 03:17 | |
| *** thinkl33t has joined #buildstream | 03:19 | |
| *** lsfranco has quit IRC | 03:41 | |
| *** tristan has joined #buildstream | 03:50 | |
| *** juergbi has quit IRC | 04:36 | |
| *** juergbi has joined #buildstream | 04:37 | |
| *** kapil___ has quit IRC | 05:39 | |
| *** juergbi has quit IRC | 05:49 | |
| *** juergbi has joined #buildstream | 05:49 | |
| *** brlogger has joined #buildstream | 06:04 | |
| *** tristan has quit IRC | 06:54 | |
| *** slaf has quit IRC | 08:50 | |
| *** slaf has joined #buildstream | 08:53 | |
| *** toscalix has joined #buildstream | 08:58 | |
| *** tristan has joined #buildstream | 09:08 | |
| *** ikerperez has joined #buildstream | 09:11 | |
| *** jennis has joined #buildstream | 09:17 | |
| *** phildawson has joined #buildstream | 09:20 | |
| *** tiagogomes has joined #buildstream | 09:23 | |
| *** alatiera has joined #buildstream | 09:44 | |
| *** raoul has joined #buildstream | 09:54 | |
| *** alatiera has quit IRC | 09:54 | |
| *** alatiera has joined #buildstream | 09:58 | |
| phildawson | juergbi, I've resolved your final points on !959. Are you happy for me to merge once the pipeline has passed? | 10:00 |
|---|---|---|
| gitlab-br-bot | MR !959: Retire bst source bundle command https://gitlab.com/BuildStream/buildstream/merge_requests/959 | 10:00 |
| *** alatiera_ has joined #buildstream | 10:00 | |
| *** alatiera_ is now known as alatiera | 10:02 | |
| *** jonathanmaw has joined #buildstream | 10:03 | |
| *** tpollard has joined #buildstream | 10:08 | |
| toscalix | laurence: can you take a look at https://gitlab.com/BuildStream/nosoftware/communication/merge_requests/5 | 10:10 |
| juergbi | phildawson: looks good to merge now. commented on two minor nits in case you want to do another rebase | 10:19 |
| gitlab-br-bot | juergbi approved MR !959 (phil/source-checkout-options->master: Retire bst source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/959 | 10:19 |
| phildawson | thanks juergbi! | 10:20 |
| juergbi | clarification, the first comment should really be fixed. the second one is just a tiny nit | 10:22 |
| phildawson | I'll fix them both, it's not like it'll take long | 10:22 |
| laurence | toscalix, sure, will find some time soon | 10:29 |
| toscalix | laurence: thansk | 10:30 |
| *** lachlan has joined #buildstream | 10:31 | |
| *** lachlan has joined #buildstream | 10:32 | |
| *** tiagogomes has quit IRC | 10:35 | |
| Nexus | My gitlab isn't updating for some reason. I've pushed updates but my gitlab isn't showing the latest sha | 10:44 |
| toscalix | thanks valentind for the review | 10:45 |
| jonathanmaw | Hi folks, does anyone have free time to look at !954 ? | 11:09 |
| gitlab-br-bot | MR !954: Guess the element when running commands in a workspace https://gitlab.com/BuildStream/buildstream/merge_requests/954 | 11:09 |
| Nexus | jonathanmaw: i'll swap you for !925 ? | 11:19 |
| gitlab-br-bot | MR !925: Added default element and show all functionality to `bst show` https://gitlab.com/BuildStream/buildstream/merge_requests/925 | 11:19 |
| juergbi | both of these are also on my list for today | 11:19 |
| *** kapil___ has joined #buildstream | 11:19 | |
| * jonathanmaw will have a gander | 11:19 | |
| Nexus | also for some reason !926 won't update after i pushed | 11:20 |
| gitlab-br-bot | MR !926: Added default element build all functionality to `bst build` https://gitlab.com/BuildStream/buildstream/merge_requests/926 | 11:20 |
| tpollard | does the cli claim it's pushed an update? | 11:25 |
| Nexus | no | 11:25 |
| Nexus | it took 20 minutes last time i pushed | 11:25 |
| Nexus | gitlab may just be being slow | 11:26 |
| Nexus | i like that it's called "guess_element" like you have no faith in its ability to get it right | 11:27 |
| *** juergbi has quit IRC | 11:39 | |
| *** juergbi has joined #buildstream | 11:40 | |
| benschubert | Hey tristan, not urgent but if you have time to review !702, I would appreciate to finally merge it and be able to run all tests on my laptop :) | 11:47 |
| gitlab-br-bot | MR !702: Mock storage space checks for tests. https://gitlab.com/BuildStream/buildstream/merge_requests/702 | 11:47 |
| *** lsfranco has joined #buildstream | 11:52 | |
| *** lsfranco has joined #buildstream | 11:52 | |
| *** abderrahim has quit IRC | 11:54 | |
| *** abderrahim has joined #buildstream | 11:54 | |
| *** lsfranco has quit IRC | 11:57 | |
| *** nimish has joined #buildstream | 11:58 | |
| *** lsfranco has joined #buildstream | 11:58 | |
| *** avar has joined #buildstream | 12:04 | |
| jonathanmaw | Nexus: I've finished my review of !925 | 12:05 |
| Nexus | thanks :) | 12:05 |
| gitlab-br-bot | phildawson opened (was WIP) MR !959 (phil/source-checkout-options->master: Retire bst source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/959 | 12:26 |
| toscalix | valentind: laurence this RM needs love. When you can, a review and approval is welcome: https://gitlab.com/BuildStream/nosoftware/communication/merge_requests/6 | 12:29 |
| toscalix | MR | 12:29 |
| laurence | toscalix, I am drowning at the moment | 12:29 |
| laurence | I have the graphs open and ready to review, but i can't do it right now | 12:29 |
| laurence | maybe i'll do it before bedtime | 12:29 |
| laurence | sorry - please hang on | 12:30 |
| *** lsfranco has quit IRC | 12:53 | |
| *** lsfranco has joined #buildstream | 12:53 | |
| valentind | toscalix, sorry, libreoffice hanged twice my GPU, had to hard reset. I figured I had to remove OpenCL drivers to be able to open the file from the MR. | 13:02 |
| *** nimish has quit IRC | 13:02 | |
| *** nimish has joined #buildstream | 13:03 | |
| *** nimish has quit IRC | 13:13 | |
| *** nimish has joined #buildstream | 13:13 | |
| *** lsfranco has quit IRC | 13:18 | |
| *** lsfranco has joined #buildstream | 13:18 | |
| *** lsfranco has joined #buildstream | 13:19 | |
| Nexus | my tests are failing on CI but not locally >:( | 13:26 |
| cs-shadow | Nexus: that might due to difference in the versions of the deps installed | 13:27 |
| tpollard | got a link to the ci job? | 13:29 |
| Nexus | https://gitlab.com/BuildStream/buildstream/-/jobs/133498148 | 13:30 |
| Nexus | cs-shadow: possibly, i'm currently a few commits behind | 13:30 |
| tpollard | 'Error mirroring https://bst-integration-test-images.ams3.cdn.digitaloceanspaces.com/integration-tests-base.v1.x86_64.tar.xz: HTTP Error 500: Internal Server Error' | 13:31 |
| tpollard | Who controls that? | 13:33 |
| tpollard | also it's coming from integration/build-tree.py, which I believe jonathanmaw authored | 13:36 |
| valentind | tpollard, I do. | 13:38 |
| jonathanmaw | tpollard: that sounds like it's caused by testutils.create_artifact_share | 13:38 |
| valentind | tpollard, it downloads fine for me. there was probably downtime in digital ocean. | 13:38 |
| * jonathanmaw doesn't know much about how the ArtifactShares actually work | 13:38 | |
| tpollard | yeh works locally for me too | 13:39 |
| tpollard | hopefully it was just a hiccup Nexus | 13:39 |
| *** kapil___ has quit IRC | 13:39 | |
| valentind | Nexus, just rebuild. | 13:39 |
| Nexus | rebuild what? | 13:40 |
| valentind | The job. | 13:41 |
| Nexus | kk | 13:41 |
| tpollard | it's hit other MR's too | 13:42 |
| gitlab-br-bot | juergbi approved MR !954 (jonathan/workspace-fragment-guess-element->master: Guess the element when running commands in a workspace) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/954 | 13:42 |
| *** nimish has quit IRC | 13:43 | |
| *** nimish has joined #buildstream | 13:43 | |
| gitlab-br-bot | jonathanmaw merged MR !954 (jonathan/workspace-fragment-guess-element->master: Guess the element when running commands in a workspace) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/954 | 13:44 |
| *** lsfranco has quit IRC | 13:44 | |
| *** lsfranco has joined #buildstream | 13:44 | |
| adds68 | Is there any way to force rebuild an element yet? | 13:48 |
| tpollard | not via the cli, afaik | 13:49 |
| *** nimish has quit IRC | 13:53 | |
| *** nimish has joined #buildstream | 13:54 | |
| *** tiagogomes has joined #buildstream | 14:00 | |
| juergbi | jmac: I still don't understand the fast import issue | 14:05 |
| juergbi | isn't ordering only relevant when merging two directories? | 14:05 |
| juergbi | i.e,, I'd hope that importing a CasBasedDirectory as a new subdirectory into a CasBasedDirectory never changes anything in that directory, even in the slow path | 14:08 |
| *** kapil___ has joined #buildstream | 14:12 | |
| jmac | juergbi: The directory produced by fast_directory_import might then be used in a further merge | 14:22 |
| jmac | It's not the order of anything in the directory you're importing into, but the order of files/directories/symlinks in the thing being imported that changes | 14:22 |
| juergbi | jmac: that seems like an extremely subtle difference from an API point of view. and fast import fallback would result in a different order | 14:25 |
| juergbi | I don't think we should expose something like this in the public API | 14:26 |
| juergbi | can't we fix this with some relatively cheap sorting somewhere to align the two code paths? | 14:26 |
| jmac | No, sorting will break everything | 14:27 |
| jmac | Yes, fast import fallback would result in a different order, but *only* import_files makes the guarantee of ordering | 14:28 |
| juergbi | jmac: e.g., can't we ensure that any changes in a CasBasedDirectory will be equivalent to exporting to the local filesystem and then importing it into a new CasBasedDirectory? | 14:28 |
| juergbi | (we shouldn't actually do that, of course, but can't we do things in an equivalent way?) | 14:28 |
| jmac | juergbi: Ensuring that is exactly what import_files already does | 14:28 |
| juergbi | I mean for all changes | 14:28 |
| jmac | It's also very complicated | 14:28 |
| jmac | You have to iterate over all of the directory tree to do it, that's why it's not fast | 14:29 |
| juergbi | I think I need a concrete example to really think about this | 14:30 |
| jmac | Right, I understand that | 14:30 |
| juergbi | however, in any case, I don't think we should add this to the stable public API as is | 14:30 |
| juergbi | i.e., if we can't hide this difference, I think this should be internal API only | 14:30 |
| jmac | That puts !952 back several weeks | 14:30 |
| gitlab-br-bot | MR !952: WIP: Remote-execution instance configuration support https://gitlab.com/BuildStream/buildstream/merge_requests/952 | 14:30 |
| jmac | Sorry, !991 | 14:30 |
| gitlab-br-bot | MR !991: Cache artifacts with virtual directories instead of filesystem. https://gitlab.com/BuildStream/buildstream/merge_requests/991 | 14:30 |
| juergbi | jmac: the MR doesn't require it to be public API, right? | 14:31 |
| jmac | I don't want to make it internal API when the only user of it is outside the API | 14:31 |
| juergbi | but the only user is still in BuildStream core, i.e., not in a plugin | 14:31 |
| jmac | Right, sorry... your definition of internal vs external still makes no sense tome | 14:31 |
| juergbi | yes, internal, not private | 14:31 |
| juergbi | I think we need to find a better solution long term and so I don't want to expose this in the stable plugin API | 14:32 |
| juergbi | and to improve performance, we currently don't have to | 14:32 |
| jmac | I'm not happy with it either, but I'm under a lot of pressure to get this feature in. I realise this doesn't make a good argument for including it. | 14:33 |
| jmac | If I make it "private", as in with an underscore on the method and not in Directory, is that OK? | 14:33 |
| juergbi | yes, it could even be in Directory, as long as there is a leading underscore | 14:33 |
| juergbi | including a performance improvement with a not perfect internal API is much less of an issue than rushing a public API | 14:34 |
| juergbi | it would be great to open a corresponding issue about this, ideally with a concrete example (possibly add example later if it's not easy to come up with one) | 14:35 |
| toscalix | valentind: thanks | 14:35 |
| jmac | Fully agree with that juergbi, I've had trouble convincing other people that ordering is important | 14:36 |
| juergbi | ok, I definitely agree that ordering is important as it can influence the staging and thus the build and the artifact | 14:37 |
| juergbi | I still hope that we can simplify the whole ordering issue at some point but that's another discussion | 14:38 |
| *** nimish has quit IRC | 14:39 | |
| *** nimish has joined #buildstream | 14:39 | |
| *** nimish has quit IRC | 14:49 | |
| *** nimish has joined #buildstream | 14:50 | |
| *** nimish has quit IRC | 14:50 | |
| *** nimish has joined #buildstream | 14:50 | |
| *** nimish has quit IRC | 14:55 | |
| *** nimish has joined #buildstream | 14:55 | |
| *** lachlan has quit IRC | 14:59 | |
| *** nimish has quit IRC | 15:00 | |
| *** nimish has joined #buildstream | 15:01 | |
| *** nimish has quit IRC | 15:06 | |
| *** nimish has joined #buildstream | 15:06 | |
| *** lachlan has joined #buildstream | 15:10 | |
| *** nimish has quit IRC | 15:11 | |
| *** nimish has joined #buildstream | 15:11 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1006 (bschubert/fix-unbound-variable-exception->master: element.py: fix unbounded variable in nested python exception) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1006 | 15:15 |
| *** lsfranco has quit IRC | 15:19 | |
| *** lsfranco has joined #buildstream | 15:20 | |
| *** nimish has quit IRC | 15:21 | |
| *** nimish has joined #buildstream | 15:22 | |
| gitlab-br-bot | juergbi approved MR !920 (richardmaw/artifact-log->master: Add artifact log command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/920 | 15:31 |
| gitlab-br-bot | jmacarthur opened issue #817 (We need examples showing the importance of file import ordering) on buildstream https://gitlab.com/BuildStream/buildstream/issues/817 | 15:37 |
| jmac | juergbi: ^ #817 attempts to capture the discussion we've just had | 15:38 |
| juergbi | thanks | 15:38 |
| juergbi | jmac: btw: I still need to think about the absolute symlink conversion commit in 919 to make sure there aren't issues if any of the path components are directory symlinks | 15:41 |
| jmac | 919? | 15:41 |
| *** nimish has quit IRC | 15:42 | |
| *** nimish has joined #buildstream | 15:42 | |
| * jmac will assume 991 | 15:43 | |
| juergbi | eh, yes, sorry | 15:43 |
| *** nimish has joined #buildstream | 15:43 | |
| gitlab-br-bot | phildawson closed issue #672 (Retire `source-bundle` command) on buildstream https://gitlab.com/BuildStream/buildstream/issues/672 | 15:45 |
| gitlab-br-bot | phildawson merged MR !959 (phil/source-checkout-options->master: Retire bst source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/959 | 15:45 |
| *** lsfranco has quit IRC | 16:10 | |
| *** lsfranco has joined #buildstream | 16:10 | |
| *** Bitcoin has joined #buildstream | 16:10 | |
| *** tiagogomes has quit IRC | 16:11 | |
| *** tiagogomes has joined #buildstream | 16:12 | |
| *** Bitcoin has quit IRC | 16:14 | |
| gitlab-br-bot | jonathanmaw approved MR !925 (issue-638-validate-all-files->master: Added default element and show all functionality to `bst show`) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/925 | 16:15 |
| Nexus | juergbi: did ypu have a chance to look at my 2 mrs? | 16:24 |
| juergbi | not yet. last time I checked tests were failing and there were quite a few pending review comments | 16:25 |
| juergbi | but I can take a look nowish | 16:25 |
| *** lsfranco has quit IRC | 16:25 | |
| *** lsfranco has joined #buildstream | 16:26 | |
| *** nimish has quit IRC | 16:38 | |
| *** nimish has joined #buildstream | 16:38 | |
| *** alatiera has quit IRC | 16:44 | |
| juergbi | Nexus: CI is actually still failing. you should generally fix this before asking for review | 16:50 |
| gitlab-br-bot | cs-shadow approved MR !1006 (bschubert/fix-unbound-variable-exception->master: element.py: fix unbounded variable in nested python exception) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1006 | 17:00 |
| *** lsfranco has quit IRC | 17:06 | |
| *** lsfranco has joined #buildstream | 17:06 | |
| *** lsfranco has quit IRC | 17:21 | |
| *** lsfranco has joined #buildstream | 17:21 | |
| gitlab-br-bot | aevri opened (was WIP) MR !973 (aevri/contributing_e2e_tests->master: contributing: more clarity on testing) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/973 | 17:33 |
| *** nimish has quit IRC | 17:43 | |
| *** nimish has joined #buildstream | 17:44 | |
| *** lachlan has quit IRC | 17:48 | |
| *** toscalix has quit IRC | 17:49 | |
| adds68 | Hi, i am working on the collect_manifest plugin here: https://gitlab.com/BuildStream/bst-external/merge_requests/60 | 18:00 |
| gitlab-br-bot | richardmaw-codethink merged MR !920 (richardmaw/artifact-log->master: Add artifact log command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/920 | 18:01 |
| adds68 | I am trying to find a sane thing to return from get_unique_key() | 18:01 |
| *** lachlan has joined #buildstream | 18:01 | |
| adds68 | This plugin generates a manifest from the sources of all defined dependencies, however returning dep.sources() is only going to be addressing that specific dependency | 18:02 |
| adds68 | the plugin can handle multiple, so i am wondering if there is a more sensible way to say "all the sources that this element depends on" ?> | 18:02 |
| *** tiagogomes has quit IRC | 18:12 | |
| *** jonathanmaw has quit IRC | 18:18 | |
| *** nimish has quit IRC | 18:19 | |
| *** nimish has joined #buildstream | 18:19 | |
| *** nimish has quit IRC | 18:29 | |
| *** nimish has joined #buildstream | 18:30 | |
| *** lsfranco has quit IRC | 18:31 | |
| *** lsfranco has joined #buildstream | 18:32 | |
| *** raoul has quit IRC | 18:37 | |
| valentind | adds68, you do not have to do anything in get_unique_key() about dependencies. Dependencies are added to the key automatically. What you need in get_unique_key() is to take anything from the configuration node of the plugin that affects the resulting artifact. | 18:39 |
| *** juergbi has quit IRC | 18:51 | |
| *** lsfranco has quit IRC | 19:02 | |
| *** lsfranco has joined #buildstream | 19:02 | |
| *** xjuan has joined #buildstream | 19:04 | |
| *** kapil___ has quit IRC | 19:21 | |
| *** nimish has quit IRC | 19:25 | |
| *** nimish has joined #buildstream | 19:25 | |
| *** lachlan has quit IRC | 19:48 | |
| *** tristan has quit IRC | 19:52 | |
| *** lachlan has joined #buildstream | 19:55 | |
| *** nimish has quit IRC | 20:01 | |
| *** lsfranco has quit IRC | 20:09 | |
| *** juergbi has joined #buildstream | 20:21 | |
| *** mohan43u has quit IRC | 20:34 | |
| *** mohan43u has joined #buildstream | 20:37 | |
| *** lachlan has quit IRC | 20:56 | |
| *** mohan43u has quit IRC | 21:22 | |
| *** mohan43u has joined #buildstream | 21:25 | |
| *** mohan43u has quit IRC | 21:28 | |
| *** mohan43u has joined #buildstream | 21:32 | |
| *** mohan43u has quit IRC | 21:43 | |
| *** mohan43u has joined #buildstream | 21:48 | |
| *** mohan43u has quit IRC | 21:51 | |
| *** mohan43u has joined #buildstream | 21:55 | |
| *** mohan43u has quit IRC | 22:08 | |
| *** mohan43u has joined #buildstream | 22:30 | |
| *** mohan43u has quit IRC | 22:48 | |
| *** mohan43u has joined #buildstream | 22:52 | |
| *** mohan43u has quit IRC | 22:58 | |
| *** mohan43u has joined #buildstream | 23:09 | |
| *** mohan43u has quit IRC | 23:12 | |
| *** mohan43u has joined #buildstream | 23:15 | |
| *** mohan43u has quit IRC | 23:18 | |
| *** mohan43u has joined #buildstream | 23:21 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!