| *** alatiera has quit IRC | 00:19 | |
| *** nimish has joined #buildstream | 01:38 | |
| *** nimish has quit IRC | 01:48 | |
| *** wzhang has joined #buildstream | 01:52 | |
| *** nimish has joined #buildstream | 02:15 | |
| *** nimish has quit IRC | 02:24 | |
| *** sedbot has joined #buildstream | 04:43 | |
| *** lsfranco has joined #buildstream | 05:54 | |
| *** tristan has joined #buildstream | 06:00 | |
| *** lsfranco has quit IRC | 07:09 | |
| *** jrl has joined #buildstream | 07:20 | |
| *** Lazuruz_ has joined #buildstream | 07:48 | |
| *** phildawson has joined #buildstream | 08:12 | |
| *** kapil___ has quit IRC | 08:19 | |
| *** phildawson has quit IRC | 08:31 | |
| *** phildawson has joined #buildstream | 08:31 | |
| *** phildawson has quit IRC | 08:32 | |
| *** phildawson has joined #buildstream | 08:33 | |
| *** solid_black has joined #buildstream | 08:34 | |
| *** toscalix has joined #buildstream | 08:58 | |
| *** alatiera has joined #buildstream | 09:10 | |
| *** tristan has quit IRC | 09:11 | |
| *** tristan has joined #buildstream | 09:11 | |
| gitlab-br-bot | jjardon closed issue #794 (Build some CI jobs with buildstream remote execution) on buildstream https://gitlab.com/BuildStream/buildstream/issues/794 | 09:17 |
|---|---|---|
| jjardon | Can I have reviews of https://gitlab.com/BuildStream/buildstream/merge_requests/987 , please? | 09:19 |
| gitlab-br-bot | adds68 approved MR !987 (jjardon/strip-binaries-removal->master: Remove default strip-commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/987 | 09:20 |
| *** finn has joined #buildstream | 09:24 | |
| gitlab-br-bot | valentindavid approved MR !987 (jjardon/strip-binaries-removal->master: Remove default strip-commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/987 | 09:39 |
| *** ChanServ sets mode: +o tristan | 09:39 | |
| tristan | valentind, I think with your artifact cache server stability changes and the fix for not downloading unused submodules I'm backporting, we'll have a bugfix release this week | 09:39 |
| tristan | valentind, remind me, I guess it is recommended to also upgrade artifact cache servers with the bugfix release ? | 09:39 |
| valentind | Yes. | 09:40 |
| tristan | Alright I'll remember to mention that in the notes | 09:40 |
| valentind | tristan, I need to merge that in 1.2 though. I think I have an unmerged mr for it. | 09:40 |
| tristan | wont be today I think... lets release at the same time as the 1.3.1 snapshot, after fixing arch name compatibility support | 09:41 |
| valentind | !979 | 09:41 |
| gitlab-br-bot | MR !979: [backport 1.2] Fix cleanup of cache in server when disk is full https://gitlab.com/BuildStream/buildstream/merge_requests/979 | 09:41 |
| valentind | I will merge that. | 09:41 |
| tristan | valentind, Ah I didnt realize, I saw some cache server commits on the tip of bst-1.2 | 09:41 |
| tristan | valentind, yes please do :) | 09:41 |
| gitlab-br-bot | valentindavid merged MR !979 (valentindavid/cache_server_fill_up-1.2->bst-1.2: [backport 1.2] Fix cleanup of cache in server when disk is full) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/979 | 09:41 |
| tristan | There was "valentindavid/script-artifact-corruption-1.2" but it's from a few weeks ago ;-) | 09:42 |
| gitlab-br-bot | valentindavid opened issue #815 (Properly handle grpc exceptions) on buildstream https://gitlab.com/BuildStream/buildstream/issues/815 | 09:49 |
| gitlab-br-bot | jjardon closed issue #645 (Default stripping rules cause seemingly random failures) on buildstream https://gitlab.com/BuildStream/buildstream/issues/645 | 09:49 |
| gitlab-br-bot | jjardon merged MR !987 (jjardon/strip-binaries-removal->master: Remove default strip-commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/987 | 09:49 |
| *** finn has quit IRC | 09:50 | |
| valentind | tristan, yes, I am waiting on valentindavid/script-artifact-corruption-1.2 to be released for a MR on Freedesktop SDK. | 09:52 |
| *** finn has joined #buildstream | 09:58 | |
| *** tiagogomes has quit IRC | 10:01 | |
| gitlab-br-bot | tristanvb opened MR !1001 (tristan/avoid-unused-submodules-1.2->bst-1.2: [backport 1.2] Avoid downloading unused git submodules) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1001 | 10:02 |
| *** tiagogomes has joined #buildstream | 10:03 | |
| tristan | hmmm, gitlab issues ? | 10:11 |
| tristan | valentind, your pipeline seems to have failed post merge, but I can't load the page and I am guessing it is a problem with gitlab infra | 10:11 |
| valentind | I get error 500 when trying to load the MR. | 10:12 |
| valentind | I think gitlab is broken. | 10:12 |
| tristan | I get one successful load out of every 5 reloads or so of https://gitlab.com/BuildStream/buildstream/merge_requests/1001 | 10:12 |
| tristan | But even then, it loads with a read header bar saying "Something went wrong" | 10:13 |
| valentind | I just get errors everywhere on gitlab. | 10:13 |
| valentind | I think we have to wait a bit. | 10:13 |
| *** jonathanmaw has joined #buildstream | 10:21 | |
| *** lachlan has joined #buildstream | 10:31 | |
| juergbi | https://twitter.com/gitlabstatus | 10:32 |
| gitlab-br-bot | tristanvb merged MR !1001 (tristan/avoid-unused-submodules-1.2->bst-1.2: [backport 1.2] Avoid downloading unused git submodules) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1001 | 10:42 |
| gitlab-br-bot | tristanvb closed issue #804 (Not possible to disable git ls-tree for submodules) on buildstream https://gitlab.com/BuildStream/buildstream/issues/804 | 10:45 |
| *** lachlan has quit IRC | 11:07 | |
| *** lachlan has joined #buildstream | 11:11 | |
| *** lachlan has quit IRC | 11:11 | |
| *** lachlan has joined #buildstream | 11:11 | |
| *** tristan has quit IRC | 11:35 | |
| jmac | Does anyone else want to review !991 before I merge it? I've had a 'quick skim' from Kinnison and phildawson, not sure if either count as a full review | 11:37 |
| gitlab-br-bot | MR !991: Cache artifacts with virtual directories instead of filesystem. https://gitlab.com/BuildStream/buildstream/merge_requests/991 | 11:37 |
| *** abderrahim has quit IRC | 11:53 | |
| *** abderrahim has joined #buildstream | 11:53 | |
| *** tristan has joined #buildstream | 12:01 | |
| *** raoul has joined #buildstream | 12:08 | |
| *** kapil___ has joined #buildstream | 12:23 | |
| jonathanmaw | WSalmon: I'm pondering the naming of required_workspace_element | 13:17 |
| jonathanmaw | My first thought for an alternative was loaded_from_element, but I think that'd just confuse people by implying it might have something to do with junctions | 13:18 |
| WSalmon | invoked? | 13:18 |
| *** lachlan has quit IRC | 13:18 | |
| jonathanmaw | i.e. "invoked_workspace_element"? | 13:19 |
| WSalmon | something along the lines of invoked_from_workspace_element() | 13:19 |
| jonathanmaw | sounds good | 13:19 |
| WSalmon | :) | 13:19 |
| gitlab-br-bot | jonathanmaw opened (was WIP) MR !954 (jonathan/workspace-fragment-guess-element->master: Guess the element when running commands in a workspace) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/954 | 13:24 |
| *** lsfranco has joined #buildstream | 13:31 | |
| *** nimish has joined #buildstream | 13:31 | |
| *** lsfranco has quit IRC | 13:36 | |
| *** nimish has quit IRC | 13:40 | |
| *** nimish has joined #buildstream | 13:41 | |
| *** nimish has quit IRC | 13:46 | |
| *** lsfranco has joined #buildstream | 13:50 | |
| *** phildawson has quit IRC | 13:55 | |
| *** nimish has joined #buildstream | 13:57 | |
| *** nimish has quit IRC | 14:02 | |
| *** nimish has joined #buildstream | 14:02 | |
| *** phildawson has joined #buildstream | 14:04 | |
| *** nimish has quit IRC | 14:08 | |
| *** phildawson has quit IRC | 14:11 | |
| *** nimish has joined #buildstream | 14:12 | |
| *** lsfranco has quit IRC | 14:15 | |
| *** lsfranco has joined #buildstream | 14:16 | |
| *** lachlan has joined #buildstream | 14:16 | |
| *** nimish has quit IRC | 14:17 | |
| *** nimish has joined #buildstream | 14:18 | |
| *** lsfranco has quit IRC | 14:21 | |
| *** lsfranco has joined #buildstream | 14:21 | |
| *** nimish has quit IRC | 14:28 | |
| *** raoul_ has joined #buildstream | 14:31 | |
| *** lsfranco has quit IRC | 14:31 | |
| *** lsfranco has joined #buildstream | 14:31 | |
| *** lsfranco has joined #buildstream | 14:32 | |
| *** lachlan has quit IRC | 14:32 | |
| *** raoul has quit IRC | 14:32 | |
| *** nimish has joined #buildstream | 14:34 | |
| *** raoul_ has quit IRC | 14:47 | |
| *** nimish has quit IRC | 14:47 | |
| *** nimish has joined #buildstream | 14:48 | |
| Nexus | tristan: Do we want to have the default element functionality on every command or just build and show? I've heard that there's interest in it being on shell too? | 14:57 |
| Nexus | juergbi: ^ | 14:57 |
| *** phildawson has joined #buildstream | 15:00 | |
| juergbi | Nexus: I think it probably also makes sense for fetch/pull/push. for bst shell it's potentially problematic as there are potential file overlaps, however, we could theoretically still implement it. for bst shell --build it doesn't make sense, though as one element is special in that case | 15:01 |
| *** raoul_ has joined #buildstream | 15:07 | |
| *** lsfranco has quit IRC | 15:07 | |
| *** lsfranco has joined #buildstream | 15:07 | |
| *** lachlan has joined #buildstream | 15:08 | |
| *** phildawson has quit IRC | 15:08 | |
| *** lsfranco has quit IRC | 15:12 | |
| *** lsfranco has joined #buildstream | 15:13 | |
| *** lsfranco has quit IRC | 15:18 | |
| *** lsfranco has joined #buildstream | 15:18 | |
| *** lachlan has quit IRC | 15:23 | |
| gitlab-br-bot | valentindavid opened MR !1002 (valentindavid/handle_grpc_errors->master: Handle grpc errors of type UNAVAILABLE and ABORTED.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1002 | 15:24 |
| *** lachlan has joined #buildstream | 15:31 | |
| *** nimish has quit IRC | 15:33 | |
| *** lsfranco has quit IRC | 15:33 | |
| *** nimish has joined #buildstream | 15:33 | |
| *** lsfranco has joined #buildstream | 15:34 | |
| *** lsfranco has joined #buildstream | 15:34 | |
| *** kapil___ has quit IRC | 15:35 | |
| juergbi | WSalmon: can you please check whether jonathanmaw has addressed the comment you raised and if so, resolve this discussion? https://gitlab.com/BuildStream/buildstream/merge_requests/924#note_121010561 | 15:40 |
| juergbi | also, should this really be a discussion? https://gitlab.com/BuildStream/buildstream/merge_requests/924#note_123304887 | 15:44 |
| juergbi | it refers to two points that already have their own discussion | 15:45 |
| WSalmon | i have resolved the first and another, i like discussions as people can reply and it can be marked as resolved when the issues are no longer pertinent, but maybe i over use them | 15:47 |
| juergbi | WSalmon: discussions generally make sense to allow replies and track what still needs to be resolved, so keep using them. however, in that last link it seems like it's about a general comment (not requiring discussion/resolving) + referring to two points that already have their own discussions | 15:51 |
| WSalmon | yep so i wasnt sure weather to comment or discuss as if any one wanted to reply, there reply would have to be a comment not a direct reply. as you can close a discussion but not reply to a comment if there is any doudt i have just been avoiding comment.. | 15:55 |
| juergbi | right, I'm not too happy about gitlab strictly separating the two | 15:56 |
| juergbi | it would be nice if you could turn comments into discussions | 15:56 |
| WSalmon | didto | 15:56 |
| WSalmon | dito | 15:56 |
| *** phildawson has joined #buildstream | 15:56 | |
| WSalmon | sometimes when you resolve a discussion it leaves the top one semi shown so that is a nice compromise but there UI changes so much its hard to know whats a feature and whats a bug | 15:57 |
| *** finn_ has joined #buildstream | 16:01 | |
| *** finn has quit IRC | 16:02 | |
| *** nimish has quit IRC | 16:03 | |
| *** phildawson_ has joined #buildstream | 16:15 | |
| laurence | i just amended my gitlab settings to 'mention' only... | 16:15 |
| laurence | let's see if it makes it easier to can follow | 16:16 |
| laurence | woops | 16:16 |
| laurence | easier to follow the project or not* | 16:16 |
| *** phildawson has quit IRC | 16:16 | |
| *** phildawson_ is now known as phildawson | 16:16 | |
| *** lsfranco has quit IRC | 16:39 | |
| *** lsfranco has joined #buildstream | 16:39 | |
| *** lachlan has quit IRC | 16:57 | |
| *** lachlan has joined #buildstream | 17:02 | |
| WSalmon | we have element._cached() and element._cached_buildtree but do we have something like element._cached(success=True) or element._cached_success() ? | 17:04 |
| WSalmon | can i team it up with _get_build_result ? is there a example somewhere? | 17:06 |
| WSalmon | _cached_success dose this do what it says on the tin? | 17:07 |
| WSalmon | it looks like it from the code... | 17:08 |
| *** lsfranco has quit IRC | 17:09 | |
| *** lsfranco has joined #buildstream | 17:10 | |
| *** raoul_ is now known as raoul | 17:15 | |
| raoul | In the artifact cache implementation, is there any reason why initialize_remote uses subprocesses for grpc calls, but no other grpc calls do this? Should they all be using subprocesses? | 17:17 |
| *** phildawson has quit IRC | 17:17 | |
| *** solid_black has quit IRC | 17:17 | |
| *** kapil___ has joined #buildstream | 17:28 | |
| *** lsfranco has quit IRC | 17:30 | |
| *** lsfranco has joined #buildstream | 17:30 | |
| *** lachlan has quit IRC | 17:32 | |
| *** toscalix has quit IRC | 17:37 | |
| *** lsfranco has quit IRC | 17:40 | |
| *** lsfranco has joined #buildstream | 17:40 | |
| *** bilelmoussaoui has joined #buildstream | 17:44 | |
| *** bilelmoussaoui has joined #buildstream | 17:45 | |
| *** lsfranco has quit IRC | 17:45 | |
| *** bilelmoussaoui has left #buildstream | 17:46 | |
| *** lsfranco has joined #buildstream | 17:46 | |
| *** utp has joined #buildstream | 17:47 | |
| *** bilelmoussaoui has joined #buildstream | 17:48 | |
| *** lachlan has joined #buildstream | 17:48 | |
| *** bilelmoussaoui has quit IRC | 17:55 | |
| juergbi | raoul: we need to use subprocesses for grpc calls in the main bst process to avoid issues with our forked job subprocesses. inside the forked job subprocesses it's fine to directly use grpc calls | 17:55 |
| *** bilelmoussaoui has joined #buildstream | 17:55 | |
| *** bilelmoussaoui has quit IRC | 17:56 | |
| juergbi | almost everything happens inside forked job subprocesses, the exception being the initialization. if you see any other grpc calls in the main bst process, we need to take a look | 17:56 |
| raoul | yes, mablanch just pointed that out to me. Was a bit confused as they're methods in the same class so it's not immediately obvious why one call is forked and all the others aren't | 17:58 |
| *** bilelmoussaoui has joined #buildstream | 17:59 | |
| *** bilelmoussaoui has left #buildstream | 18:00 | |
| *** lsfranco has quit IRC | 18:01 | |
| *** lsfranco has joined #buildstream | 18:01 | |
| juergbi | should improve the comment in that case | 18:02 |
| *** tristan has quit IRC | 18:26 | |
| *** raoul has quit IRC | 18:30 | |
| *** xjuan has joined #buildstream | 18:31 | |
| *** bilelmoussaoui has joined #buildstream | 18:34 | |
| *** bilelmoussaoui has left #buildstream | 18:34 | |
| *** bilelmoussaoui has joined #buildstream | 18:36 | |
| *** lsfranco has quit IRC | 18:36 | |
| *** lsfranco has joined #buildstream | 18:37 | |
| *** bilelmoussaoui has left #buildstream | 18:37 | |
| *** finn_ has quit IRC | 18:38 | |
| *** finn_ has joined #buildstream | 18:40 | |
| *** finn_ has joined #buildstream | 18:40 | |
| *** finn_ has quit IRC | 18:43 | |
| *** xjuan has quit IRC | 18:51 | |
| *** xjuan has joined #buildstream | 19:06 | |
| *** nimish has joined #buildstream | 19:10 | |
| *** lsfranco has quit IRC | 19:12 | |
| *** lsfranco has joined #buildstream | 19:12 | |
| *** ChiLLabi1 has joined #buildstream | 19:20 | |
| *** lsfranco has quit IRC | 19:22 | |
| *** lsfranco has joined #buildstream | 19:22 | |
| *** lsfranco has quit IRC | 19:32 | |
| *** lsfranco has joined #buildstream | 19:33 | |
| *** lsfranco has quit IRC | 19:37 | |
| *** lsfranco has joined #buildstream | 19:38 | |
| gitlab-br-bot | cs-shadow opened MR !1003 (chandan/source-subgroup->master: Introduce new "source" command group) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1003 | 19:53 |
| *** nimish has quit IRC | 19:55 | |
| *** nimish has joined #buildstream | 19:56 | |
| *** nimish has quit IRC | 20:31 | |
| *** nimish has joined #buildstream | 20:31 | |
| *** kapil___ has quit IRC | 20:35 | |
| *** lsfranco has quit IRC | 20:43 | |
| *** lsfranco has joined #buildstream | 20:43 | |
| *** lachlan has quit IRC | 20:50 | |
| *** finn_ has joined #buildstream | 20:53 | |
| *** jonathanmaw has quit IRC | 21:12 | |
| *** nimish has quit IRC | 21:31 | |
| *** nimish has joined #buildstream | 21:31 | |
| gitlab-br-bot | adds68 opened issue #816 (Unexpected caching behaviour with bst plugin) on buildstream https://gitlab.com/BuildStream/buildstream/issues/816 | 21:33 |
| *** xjuan has quit IRC | 21:40 | |
| *** bilelmoussaoui has joined #buildstream | 21:42 | |
| *** bilelmoussaoui has quit IRC | 21:45 | |
| *** finn_ has quit IRC | 21:49 | |
| *** xjuan has joined #buildstream | 21:51 | |
| *** finn has joined #buildstream | 21:52 | |
| *** alatiera has quit IRC | 21:53 | |
| *** finn has quit IRC | 21:56 | |
| *** alatiera has joined #buildstream | 22:01 | |
| *** xjuan has quit IRC | 22:01 | |
| *** xjuan has joined #buildstream | 22:18 | |
| *** Guest65775 has joined #buildstream | 23:21 | |
| *** xjuan has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!