IRC logs for #buildstream for Monday, 2018-12-03

« Sunday, 2018-12-02 Index Tuesday, 2018-12-04 »
*** nimish has quit IRC00:34
*** mohan43u has quit IRC00:59
*** abracada- has joined #buildstream02:05
*** m4rcu5 has joined #buildstream05:02
*** nimish has joined #buildstream05:23
*** nimish has quit IRC05:27
*** nimish has joined #buildstream05:27
*** tristan has joined #buildstream05:43
*** ChanServ sets mode: +o tristan05:43
*** namol has joined #buildstream06:11
*** Arguggi has joined #buildstream06:29
*** storshoo has joined #buildstream07:06
*** kapil___ has joined #buildstream07:56
gitlab-br-bottristanvb opened MR !984 (tristan/fix-doc-session-rebuilds->master: MANIFEST.in: Include the sources for rebuilding the documentation session HTML) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/98408:44
*** nimish has quit IRC08:47
*** nimish has joined #buildstream08:48
*** toscalix has joined #buildstream08:51
*** mohan43u has joined #buildstream08:52
*** toscalix has quit IRC08:54
*** toscalix has joined #buildstream08:54
*** mohan43u has quit IRC08:58
*** mohan43u has joined #buildstream08:58
gitlab-br-bottristanvb closed MR !966 (willsalmon/sessionsBug->master: Keep the Bst2html output up to date.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/96609:01
*** finn has joined #buildstream09:05
gitlab-br-bottristanvb closed issue #778 (bst example html in the doc's is out of date and is hard to maintain) on buildstream https://gitlab.com/BuildStream/buildstream/issues/77809:19
gitlab-br-bottristanvb merged MR !984 (tristan/fix-doc-session-rebuilds->master: MANIFEST.in: Include the sources for rebuilding the documentation session HTML) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/98409:19
*** WSalmon_ has joined #buildstream09:23
*** phildawson has joined #buildstream09:28
tristanvalentind, I haven't been following everything in the notification streams... the merge request which makes the CAS server more robust and reliable was resolved and merged last week ?09:32
tristanAnd... was it backported ?09:32
juergbitristan: !830 was merged to master09:34
gitlab-br-botMR !830: Fix cleanup of cache in server when disk is full https://gitlab.com/BuildStream/buildstream/merge_requests/83009:34
juergbibackport is !979, not yet merged to 1.209:35
gitlab-br-botMR !979: [backport 1.2] Fix cleanup of cache in server when disk is full https://gitlab.com/BuildStream/buildstream/merge_requests/97909:35
*** alatiera has joined #buildstream09:44
tristanjuergbi, Thanks :)09:45
benschubertHey tristan ! Would you have time to have a look at my changes to !819 ?09:46
gitlab-br-botMR !819: Add `--deps build` option to `bst checkout` https://gitlab.com/BuildStream/buildstream/merge_requests/81909:46
tristanAh this... sorry this has been falling behind benschubert09:49
tristanLets take a look, as I recall this is somewhat entangled in the `bst source checkout` conversation09:50
benschubertYep, thanks a lot!09:50
tristanOh I remember this... benschubert I'll take a look... I recall now that the way the code runs prior to this patch is already bit gruesome...09:54
benschubertThanks! I'll update code asap after your comments so we can get this through09:54
gitlab-br-botwillsalmon reopened issue #778 (bst example html in the doc's is out of date and is hard to maintain) on buildstream https://gitlab.com/BuildStream/buildstream/issues/77809:54
tristanbenschubert, an initial reading of it is beautiful actually, I think I'm really very happy with it :)09:58
tristanmuch better than confusingly having both deps and scope in that function09:58
tristanjuergbi, regarding this line: https://gitlab.com/BuildStream/buildstream/merge_requests/819/diffs#b0cc8316a1229e1e0d1774b5278cd73dbc44bf42_51_51 ... am I hallucinating that I seem to recall you had some discussion about this ?10:00
tristanjuergbi, and someone was suggesting that the value for Scope.NONE should be 'None' ? or was that something else ?10:00
tristanI am fine with it either way to be honest10:00
juergbiI think I suggested Scope.NONE initially, but I don't think I suggested a particular value10:01
tristanOkay, I thing I may be mixing it up with another orthogonal conversation I observed10:01
tristanprobably to do with a different type/enumeration10:01
tristan*think10:01
juergbimight have been SandboxFlags.NONE10:01
juergbior maybe not10:01
tristanAh... yes that can very well be :)10:01
* Kinnison was suggesting that 0 was a poor bare argument to something not obviously taking a count or somesuch10:02
* Kinnison suggested either None, or SandboxFlags.NONE which could be 0 or None10:02
juergbifor reference, https://gitlab.com/BuildStream/buildstream/merge_requests/819#note_10379686310:02
* Kinnison dislikes magical numbers10:02
Kinnisonaah, wrong thing, sorry10:03
* Kinnison goes back to sleep under his rock10:03
juergbitangentially related10:03
juergbihehe10:03
*** WSalmon_ has quit IRC10:10
gitlab-br-botjuergbi opened issue #799 (Remote execution: Make TLS and client certificate optional for storage service) on buildstream https://gitlab.com/BuildStream/buildstream/issues/79910:14
*** jonathanmaw has joined #buildstream10:18
juergbitristan: what's your opinion on 'bst build world'? https://irclogs.baserock.org/buildstream/%23buildstream.2018-11-30.log.html#t2018-11-30T14:16:0010:18
juergbiI'm tending towards the default target approach that could become configurable in project.conf in the future10:18
juergbi(as I expect many larger bst projects will have a few elements that should not be built by default)10:19
*** raoul has joined #buildstream10:22
*** WSalmon_ has joined #buildstream10:28
*** lachlan has joined #buildstream10:30
*** Nexus_ has joined #buildstream10:33
*** Nexus has quit IRC10:35
lachlanHi, I've been trying to test out a new gitlab runner for benchmark testing but I'm getting an error when buildstream/buildstream-fedora:latest is attempted to be downloaded.10:45
KinnisonCan you link to a log?10:46
lachlanLet me see10:47
*** Nexus_ has quit IRC10:47
*** Nexus has joined #buildstream10:47
lachlanhttps://gitlab.com/BuildStream/benchmarks/-/jobs/12832518610:48
* phildawson does `docker pull buildstream/buildstream-fedora:latest`10:49
phildawsonseems to be available10:50
* phildawson reads the logs :P10:50
gitlab-br-botphildawson opened (was WIP) MR !959 (phil/source-checkout-options->master: Retire bst source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/95910:53
lachlanphildawson: Let me try it again10:54
*** WSalmon_ has quit IRC10:59
tristanjuergbi, I would add to that, that I don't expect all elements to always be buildable under every possible combination, e.g. the (!) assert statement can cause things to explicitly not build a given element when that element is not valid for a given project option11:00
*** WSalmon_ has joined #buildstream11:00
tristanor when a given project option is known to be incompatible with another one11:00
juergbiyes, e.g., platform-specific elements11:01
tristans/statement/directive (to use our own jargon)11:01
gitlab-br-bottristanvb closed issue #670 (`--deps none` does not work for `bst checkout`) on buildstream https://gitlab.com/BuildStream/buildstream/issues/67011:01
gitlab-br-bottristanvb merged MR !819 (chandan/bst-checkout-build->master: Add `--deps build` option to `bst checkout`) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/81911:01
tristanbenschubert, merged !11:02
benschuberttristan: thank y ou very much! Would you also have time to quickly answer https://gitlab.com/BuildStream/buildstream/merge_requests/702#note_111864125 ? That way I could also push it even though it is clearly not high priority so it can wait :)11:02
tristanbenschubert, looks like the code has changed since that comment ? maybe it now refers to https://gitlab.com/BuildStream/buildstream/blob/BenjaminSchubert/fix-quota-tests/buildstream/_artifactcache/artifactcache.py#L946 ?11:07
tristanbenschubert, basically you are asking whether to add a private ArtifactCache._get_available_space() function ?11:08
*** nimish has quit IRC11:08
benschuberttristan: oups yes exactly11:08
phildawsonls11:08
phildawsongah11:08
benschubertThat way we know we are not patching somethign that is used somewhere else and make sure everything is clean11:08
benschubertplus the performance impact is negligible11:09
tristanbenschubert, replied here: https://gitlab.com/BuildStream/buildstream/merge_requests/702#note_12180847011:10
benschuberttristan: thank you very much, I'll update the code now so it can finally get merged :D11:11
tristanAnd yes, certainly it would be a sad day if we started creating huge function blocks for the sake of avoiding function calling for performance reasons :)11:11
*** tristan has quit IRC11:22
*** toscalix_ has joined #buildstream11:29
*** toscalix has quit IRC11:29
*** tristan has joined #buildstream11:37
*** solid_black has joined #buildstream11:37
*** jjardon has quit IRC11:42
*** jjardon has joined #buildstream11:42
*** ChanServ sets mode: +o jjardon11:42
*** m_22[m] has quit IRC11:42
*** oknf[m] has quit IRC11:42
*** benschubert has quit IRC11:42
*** benschubert has joined #buildstream11:42
*** tintou has quit IRC11:42
*** tintou has joined #buildstream11:43
*** kapil___ has quit IRC11:43
*** theawless[m] has quit IRC11:43
*** tlater[m] has quit IRC11:43
*** asingh_[m] has quit IRC11:43
*** inigomartinez has quit IRC11:43
*** kapil___ has joined #buildstream11:43
*** waltervargas[m] has quit IRC11:43
*** mattiasb has quit IRC11:43
*** jjardon[m] has quit IRC11:43
*** cgmcintyre[m] has quit IRC11:43
*** rafaelff[m] has quit IRC11:43
*** segfault3[m] has quit IRC11:43
*** pro[m] has quit IRC11:43
gitlab-br-bottristanvb merged MR !983 (jjardon/doc_git_submodules->master: git: warn about checkout submodules  by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/98311:45
*** abderrahim has quit IRC11:46
*** abderrahim has joined #buildstream11:47
*** m_22[m] has joined #buildstream11:49
*** oknf[m] has joined #buildstream11:52
*** WSalmon_ has quit IRC11:57
*** theawless[m] has joined #buildstream12:10
*** asingh_[m] has joined #buildstream12:15
*** tristan has quit IRC12:40
*** tlater[m] has joined #buildstream12:43
*** jjardon[m] has joined #buildstream12:50
*** cgmcintyre[m] has joined #buildstream12:55
*** solid_black has quit IRC12:57
*** inigomartinez has joined #buildstream12:58
*** waltervargas[m] has joined #buildstream12:59
*** mattiasb has joined #buildstream13:04
*** rafaelff[m] has joined #buildstream13:10
*** segfault3[m] has joined #buildstream13:17
*** tristan has joined #buildstream13:18
*** pro[m] has joined #buildstream13:23
valentindWhere do we document what we are breaking in 1.4?13:24
KinnisonMostly I've seen things in NEWS13:26
* Kinnison imagines that'll also go on the website and the release announcement13:26
jonathanmawjuergbi: https://gitlab.com/BuildStream/buildstream/merge_requests/980 ought to have all its issues resolved now13:26
juergbita, will take a look13:27
*** solid_black has joined #buildstream13:34
*** solid_black has quit IRC13:38
*** solid_black has joined #buildstream13:43
*** bochecha has joined #buildstream14:02
*** lachlan has quit IRC14:02
*** lantw44 has quit IRC14:12
*** lantw44 has joined #buildstream14:12
*** lachlan has joined #buildstream14:18
*** WSalmon_ has joined #buildstream14:23
*** WSalmon_ has quit IRC14:24
*** WSalmon_ has joined #buildstream14:33
jjardonvalentind: https://gitlab.com/BuildStream/website/issues/24 (apart of the NEWS file, of course)14:34
gitlab-br-botjjardon closed MR !972 (jjardon/submodules->master: plugins/sources/git.py: Do not checkout submodules by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/97214:37
*** finn has quit IRC14:38
*** finn has joined #buildstream14:50
valentindjjardon, I added in the NEWS file in my MR.15:08
*** kapil___ has quit IRC15:15
jjardonvalentind: thanks15:27
* jjardon updates https://gitlab.com/BuildStream/website/issues/2415:27
*** nimish has joined #buildstream15:36
*** kapil___ has joined #buildstream15:40
WSalmoni can't think were to look for a good example test that interacts with a option in buildstream, i want to test a click.confirm15:51
WSalmoncan anyone rember one?15:51
WSalmoni have had a bit of a look but cant think what best to grep for15:51
phildawsonjuergbi, benschubert and I have had some discussion arising from a comment you made on !959 (https://gitlab.com/BuildStream/buildstream/merge_requests/959#note_121047463). I was wondering if you have an opinion?15:56
gitlab-br-botMR !959: Retire bst source bundle command https://gitlab.com/BuildStream/buildstream/merge_requests/95915:56
juergbiphildawson: commented16:12
phildawsonta juergbi16:13
gitlab-br-botjuergbi closed issue #795 (BuildStream crashes when we try to use the same junction twice, but named differently) on buildstream https://gitlab.com/BuildStream/buildstream/issues/79516:27
gitlab-br-botjuergbi merged MR !980 (jonathan/fix-identical-element->master: _yamlcache.py: Use a project's junction name if present) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/98016:27
Kinnisonjmac: Given the tacit indication that we should maintain the status quo regarding "unreadable files", is !837 worth keeping open, or should it be closed?16:30
gitlab-br-botMR !837: WIP: Import unreadable files https://gitlab.com/BuildStream/buildstream/merge_requests/83716:30
*** ChanServ sets mode: +o tristan16:30
tristanWSalmon, we need to develop the testing support for interacting with prompts, none of the interactive stuff is currently tested16:30
WSalmontristan, i came to that conclusion reading the testutils code, thanks for confirming16:31
jmacKinnison: I can't get to gitlab at the moment, I'll take a look when I can16:32
*** bochecha has quit IRC16:34
jmacKinnison: Closed16:52
KinnisonThanks jmac16:53
*** nimish has quit IRC17:30
*** nimish has joined #buildstream17:31
*** nimish has quit IRC17:36
*** finn has quit IRC17:36
*** nimish has joined #buildstream17:36
*** nimish has quit IRC17:41
*** nimish has joined #buildstream17:42
*** portdirect has joined #buildstream17:45
*** jonathanmaw has quit IRC18:13
gitlab-br-botgokcennurlu opened issue #800 (There is no clear way to disable batching of prepare+assemble in BuildElement) on buildstream https://gitlab.com/BuildStream/buildstream/issues/80018:23
*** finn has joined #buildstream18:23
*** xjuan has joined #buildstream18:24
*** finn has quit IRC18:24
valentindjuergbi, what do you think about this exception? https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/jobs/12894939218:34
valentindgoogle.protobuf.message.DecodeError: Tag had invalid wire type.18:34
*** kapil___ has quit IRC18:35
juergbihm, haven't seen that before. wondering whether it could be some kind of cache corruption18:35
valentindjuergbi, It happens for the same branch on all platforms.18:42
*** jjardon has quit IRC18:42
*** jjardon has joined #buildstream18:42
*** ChanServ sets mode: +o jjardon18:42
*** solid_black has quit IRC18:49
*** raoul has quit IRC19:10
*** tristan has quit IRC19:20
*** xjuan has quit IRC19:22
*** tristan has joined #buildstream19:30
*** nimish has quit IRC19:32
*** toscalix_ has quit IRC19:36
valentindjuergbi, yes it was just because we have not released 1.2 with the script corruption issue.19:39
juergbiah19:40
valentindDid not update the .gitlab-ci.yml on that branch.19:41
*** xjuan has joined #buildstream20:17
*** xjuan has quit IRC20:33
*** nimish has joined #buildstream21:13
*** nimish has quit IRC21:23
*** lachlan has quit IRC21:36
*** xjuan has joined #buildstream21:40
*** xjuan has quit IRC23:24
*** xjuan has joined #buildstream23:30
*** nimish has joined #buildstream23:41
*** alatiera has quit IRC23:47
« Sunday, 2018-12-02 Index Tuesday, 2018-12-04 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!