| *** cs-shadow has quit IRC | 00:49 | |
| *** abderrah1 has quit IRC | 00:54 | |
| *** abderrah1 has joined #buildstream | 00:57 | |
| *** alatiera has joined #buildstream | 01:08 | |
| *** nimish has joined #buildstream | 01:41 | |
| *** abderrahim has joined #buildstream | 03:16 | |
| *** abderrah1 has quit IRC | 03:17 | |
| *** nimish has quit IRC | 05:58 | |
| *** slaf has quit IRC | 07:04 | |
| *** tristan has joined #buildstream | 07:23 | |
| *** mistiry has joined #buildstream | 07:25 | |
| *** s3krit has joined #buildstream | 08:09 | |
| *** tristan has quit IRC | 08:16 | |
| *** tristan has joined #buildstream | 08:24 | |
| *** slaf has joined #buildstream | 08:48 | |
| *** finn has joined #buildstream | 08:54 | |
| *** slaf has quit IRC | 08:59 | |
| *** slaf has joined #buildstream | 08:59 | |
| *** slaf has quit IRC | 09:07 | |
| *** slaf has joined #buildstream | 09:07 | |
| *** slaf has quit IRC | 09:14 | |
| *** toscalix has joined #buildstream | 09:18 | |
| *** phildawson_ has joined #buildstream | 09:20 | |
| *** jonathanmaw has joined #buildstream | 09:25 | |
| *** WSalmon_ has joined #buildstream | 09:28 | |
| *** slaf has joined #buildstream | 09:29 | |
| *** tiagogomes_ has joined #buildstream | 09:30 | |
| *** ChanServ sets mode: +o tristan | 09:34 | |
| tristan | valentind, I just resolved the comments which appear to be resolvable, and I think all that is left is to answer https://gitlab.com/BuildStream/buildstream/merge_requests/830#note_105087294 | 09:34 |
|---|---|---|
| tristan | valentind, I will now look at the branch patch-by-patch | 09:35 |
| valentind | OK | 09:36 |
| *** mon has joined #buildstream | 09:39 | |
| *** voltage_ has joined #buildstream | 09:42 | |
| gitlab-br-bot | jonathanmaw opened (was WIP) MR !924 (jonathan/workspace-fragment-create->master: Support invoking buildstream from a workspace outside a project) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/924 | 09:50 |
| *** raoul has joined #buildstream | 10:01 | |
| *** tpollard has joined #buildstream | 10:05 | |
| tristan | valentind, comments up, I think it's really mostly ready to go but let's answer your fallocate question first | 10:29 |
| tristan | juergbi, do you have an opinion on this comment: https://gitlab.com/BuildStream/buildstream/merge_requests/830?commit_id=bd72cbace2e3eb3dba966cc24dedadc4b640fa6e#note_120665733 ? | 10:29 |
| tristan | juergbi, This is in the interest of improving fault tolerance of CAS server cleanup | 10:30 |
| *** lachlan has joined #buildstream | 10:30 | |
| juergbi | will take a look in a bit | 10:30 |
| tristan | Sure :) | 10:30 |
| *** lachlan has quit IRC | 11:19 | |
| *** lachlan has joined #buildstream | 11:35 | |
| gitlab-br-bot | jjardon opened issue #792 (Overnigth test failure: docker daemon not tunning Job) on buildstream https://gitlab.com/BuildStream/buildstream/issues/792 | 12:17 |
| *** rdale has quit IRC | 12:29 | |
| gitlab-br-bot | jmacarthur opened MR !976 (jmac/no-verify-digests->master: _sandboxremote.py: Remove unnecessary tests.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/976 | 12:38 |
| *** tristan has quit IRC | 12:40 | |
| *** alatiera has quit IRC | 12:55 | |
| *** alatiera has joined #buildstream | 12:59 | |
| *** nimish has joined #buildstream | 13:29 | |
| gitlab-br-bot | valentindavid merged MR !975 (valentindavid/ruamel_0_15_41->master: setup.py: require ruamel.yaml >= 0.15.41 < 0.15.52) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/975 | 14:02 |
| jonathanmaw | hrm, I'm a bit uncertain of where to document that the element is optional when commands are run from inside a workspace | 14:05 |
| jonathanmaw | looking in the documentation, that seems to be doc/source/developing/workspaces.rst, where I could change some of the commands to be run from inside the workspace | 14:06 |
| jonathanmaw | or I could change the docstrings in buildstream/_frontend/cli.py, and that'll get pulled out into doc/sources/using_commands.rst | 14:07 |
| jonathanmaw | s/sources/source/ | 14:07 |
| *** cs-shadow has joined #buildstream | 14:40 | |
| *** xlei has joined #buildstream | 14:41 | |
| *** lachlan has quit IRC | 14:42 | |
| valentind | jjardon, I think I asked you for the build logs of the issue you have for #645. Do not remember if I did. But please give some more information on the issue. | 14:44 |
| gitlab-br-bot | Issue #645: Default stripping rules cause seemingly random failures https://gitlab.com/BuildStream/buildstream/issues/645 | 14:44 |
| *** lachlan has joined #buildstream | 14:45 | |
| gitlab-br-bot | valentindavid opened (was WIP) MR !830 (valentindavid/cache_server_fill_up->master: Fix cleanup of cache in server when disk is full) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/830 | 14:45 |
| jmac | !952 was originally written by raoul, reviewed by me and then I've made some updates to it. I think it should have a quick review by a third party, if anyone has time? | 14:53 |
| gitlab-br-bot | MR !952: Remote-execution instance configuration support https://gitlab.com/BuildStream/buildstream/merge_requests/952 | 14:53 |
| toscalix | juergbi: just to double check, https://gitlab.com/BuildStream/buildstream/issues/675 is closed although it has an open MR. Is this ok? | 14:55 |
| gitlab-br-bot | eysz7-x-x opened MR !977 (132-loading-external-plugins-works-without-explicit-requirement-in-project-conf->master: Resolve "Loading external plugins works without explicit requirement in project.conf") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/977 | 14:57 |
| toscalix | jjardon: I am removing the blocker label from https://gitlab.com/BuildStream/buildstream/issues/719 correct, as per discussed in the comments? | 14:57 |
| toscalix | or do you want to raise this ticket in the next monday meeting? | 14:58 |
| jjardon | toscalix: yeah, let's talk about that next monday | 15:03 |
| jjardon | toscalix: as I said there, if we know that is not going to be ready, we need a solution to the other issue referenced in that one | 15:03 |
| jjardon | valentind: sorry, no time to prepare the minimum system to reproduce the issues yet | 15:04 |
| valentind | jjardon, Just wanted to make sure I told you. | 15:05 |
| valentind | I did not remember. | 15:05 |
| jjardon | valentind: sure, thanks for the reminder | 15:05 |
| juergbi | toscalix: yes, that's fine. !951 depends on #675, it's not needed to solve #675 | 15:06 |
| gitlab-br-bot | MR !951: WIP: Add BuildBox backend for sandboxing https://gitlab.com/BuildStream/buildstream/merge_requests/951 | 15:06 |
| gitlab-br-bot | Issue #675: Batch commands for remote execution https://gitlab.com/BuildStream/buildstream/issues/675 | 15:06 |
| toscalix | jjardon: juergbi thanks | 15:16 |
| *** nimish has quit IRC | 15:39 | |
| *** nimish has joined #buildstream | 15:39 | |
| gitlab-br-bot | juergbi opened issue #793 (Create helper class/functions to centralize knowledge about artifact structure) on buildstream https://gitlab.com/BuildStream/buildstream/issues/793 | 15:59 |
| *** lachlan has quit IRC | 16:21 | |
| gitlab-br-bot | tpollard opened MR !978 (tpollard/774->master: _stream.py: Ability to pull missing buildtrees outside of pull/build) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/978 | 16:26 |
| tpollard | juergbi: as you did quite a lot of review of the pulling of buildtrees, would you mind looking at !978 when possible please? :) | 16:35 |
| juergbi | sure, will take a look | 16:36 |
| *** lachlan has joined #buildstream | 16:48 | |
| *** nimish has quit IRC | 16:49 | |
| *** nimish has joined #buildstream | 16:50 | |
| tpollard | juergbi: cheers | 16:53 |
| *** lachlan has quit IRC | 16:55 | |
| *** bochecha has joined #buildstream | 16:57 | |
| jonathanmaw | WSalmon: do you know how the sessions files work? I'm trying to add a new command and I seem to be having problems | 16:59 |
| cs-shadow | Hi, in case someone gets a chance, I'd appreciate a review of !731 | 16:59 |
| gitlab-br-bot | MR !731: .gitlab-ci.yml: Publish to PyPI when new tags are pushed https://gitlab.com/BuildStream/buildstream/merge_requests/731 | 16:59 |
| jonathanmaw | firstly, when I try `bst build` (guessing the element from inside the workspace), I end up with an empty pipeline | 17:01 |
| jonathanmaw | secondly, the CI breaks in the 'docs' stage, because it can't find the new session HTML file. Apparently because it never actually ran bst2html | 17:02 |
| *** lachlan has joined #buildstream | 17:07 | |
| *** nimish has quit IRC | 17:10 | |
| tlater[m] | cs-shadow: ooi, reading discussion on that MR, does this mean any developer can technically push to pypi? | 17:10 |
| *** nimish has joined #buildstream | 17:10 | |
| tlater[m] | That makes developer permissions more security sensitive than they used to be. | 17:10 |
| tlater[m] | otoh, I suppose you could already take over someone's machine by merging to master | 17:10 |
| gitlab-br-bot | tlater closed MR !977 (132-loading-external-plugins-works-without-explicit-requirement-in-project-conf->master: Resolve "Loading external plugins works without explicit requirement in project.conf") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/977 | 17:16 |
| juergbi | tlater[m]: oh, another spam MR. do you know if there is a way we can block a user? | 17:17 |
| tlater[m] | juergbi: Not something I've had to try before | 17:18 |
| tlater[m] | Let's see | 17:18 |
| gitlab-br-bot | eysz7-x-x reopened MR !977 (132-loading-external-plugins-works-without-explicit-requirement-in-project-conf->master: Resolve "Loading external plugins works without explicit requirement in project.conf") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/977 | 17:18 |
| tlater[m] | I wonder if there's some sort of gitlab 0-day they're testing for or something. | 17:18 |
| juergbi | https://gitlab.com/gitlab-org/gitlab-ce/issues/35943 | 17:20 |
| juergbi | only possible at the instance level | 17:20 |
| juergbi | can only report the user, I suppose | 17:20 |
| tlater[m] | Hm annoying | 17:21 |
| tlater[m] | Oh, they're reopening them, too | 17:21 |
| tlater[m] | Can't even report them again, grr | 17:22 |
| juergbi | yes, just noticed | 17:23 |
| juergbi | I think project/group owner could completely delete the MRs, instead of just close them | 17:24 |
| *** nimish has quit IRC | 17:25 | |
| *** finn has quit IRC | 17:37 | |
| *** phildawson_ has quit IRC | 17:40 | |
| *** tpollard has quit IRC | 17:45 | |
| *** jonathanmaw has quit IRC | 17:52 | |
| *** finn has joined #buildstream | 18:06 | |
| *** lachlan has quit IRC | 18:06 | |
| cs-shadow | tlater[m]: sorry for late response, ran away for lunch shortly after posting here | 18:15 |
| cs-shadow | short answer is yes | 18:15 |
| cs-shadow | long answer is that the security of the job is as good as the security of the "protected variables". But since we allow devs to merge to master, they are not really very protected anyway. FWIW this is the same situation with buildstream-docker-images but I am not aware of how to do anything better with GitLab CI | 18:15 |
| *** toscalix has quit IRC | 18:18 | |
| *** WSalmon_ has quit IRC | 18:20 | |
| *** raoul has quit IRC | 18:47 | |
| tlater[m] | cs-shadow: Yeah, I think we'll have to just accept the risk, as discussed on the MR. It's just a good idea to make sure people who can elevate rights are aware; making someone a developer is pretty impactful now. | 18:55 |
| *** pakettiale has joined #buildstream | 19:01 | |
| *** lachlan has joined #buildstream | 19:17 | |
| *** nimish has joined #buildstream | 19:24 | |
| *** nimish has quit IRC | 19:29 | |
| *** nimish has joined #buildstream | 19:31 | |
| jjardon | valentind: (or any website maintainer) can I have a review of https://gitlab.com/BuildStream/website/merge_requests/97/ , please? | 19:36 |
| valentind | jjardon, approved | 19:38 |
| jjardon | thanks! | 19:38 |
| *** tristan has joined #buildstream | 19:41 | |
| jjardon | valentind: Can I have another quick review, please? https://gitlab.com/BuildStream/website/merge_requests/99 | 19:47 |
| jjardon | cs-shadow: thanks for spotting that :) | 19:47 |
| cs-shadow | np | 19:47 |
| *** nimish_ has joined #buildstream | 19:49 | |
| jjardon | Is this intended or is a bug? https://buildstream.build/authors.html | 19:50 |
| *** nimish has quit IRC | 19:50 | |
| *** nimish_ is now known as nimish | 19:50 | |
| *** tiagogomes_whostolemyidentity has joined #buildstream | 19:51 | |
| cs-shadow | jjardon: I find that confusing too but I think it refers to the authors of the blog posts on the website and not the tool itself. We only have one post at present - https://buildstream.build/news.html | 19:51 |
| jjardon | ah rigth | 19:52 |
| *** tiagogomes_ has quit IRC | 19:52 | |
| *** alatiera has quit IRC | 20:00 | |
| *** nimish_ has joined #buildstream | 20:08 | |
| *** nimish has quit IRC | 20:09 | |
| *** nimish_ is now known as nimish | 20:09 | |
| *** nimish has quit IRC | 20:13 | |
| *** nimish has joined #buildstream | 20:13 | |
| *** finn has quit IRC | 21:15 | |
| *** lachlan has quit IRC | 21:28 | |
| gitlab-br-bot | jjardon closed issue #792 (Overnigth test failure: docker daemon not running) on buildstream https://gitlab.com/BuildStream/buildstream/issues/792 | 21:28 |
| *** tristan has quit IRC | 21:46 | |
| *** bochecha has quit IRC | 21:50 | |
| *** finn has joined #buildstream | 22:00 | |
| *** finn has quit IRC | 22:09 | |
| *** finn has joined #buildstream | 22:10 | |
| *** finn has quit IRC | 22:13 | |
| *** tiagogomes_whostolemyidentity has quit IRC | 22:29 | |
| jjardon | if anyone around: https://gitlab.com/BuildStream/website/merge_requests/100 | 22:32 |
| *** alatiera has joined #buildstream | 22:52 | |
| *** alatiera has quit IRC | 23:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!