IRC logs for #buildstream for Tuesday, 2018-11-20

*** trash has joined #buildstream05:30
*** mohan43u has quit IRC06:30
*** mohan43u has joined #buildstream06:30
*** tristan has joined #buildstream07:44
benschubertHey tristan, would you have time to look at !702 and (more importantly) !819 ?08:39
gitlab-br-botMR !702: WIP: Mock storage space checks for tests. https://gitlab.com/BuildStream/buildstream/merge_requests/70208:39
gitlab-br-botMR !819: Add `--deps build` option to `bst checkout` https://gitlab.com/BuildStream/buildstream/merge_requests/81908:39
*** toscalix has joined #buildstream08:46
KinnisonDoes anyone here happen to know what the rules are about overlapping plugin names and junctions?09:05
juergbiKinnison: each (sub)project has their own plugin context with a corresponding ElementFactory and SourceFactory09:10
Kinnisonjuergbi: Excellent, my assumption there holds, thank you09:10
juergbiso I think there should be no conflict potential09:10
Kinnisonnod.09:11
benschubertjuergbi: if you have time, could you quickly check that !949 is good for you and that I addressed your comments from !938 in !958 ?09:20
gitlab-br-botMR !949: Add tests for fedora with no bubblewrap available https://gitlab.com/BuildStream/buildstream/merge_requests/94909:20
gitlab-br-botMR !938: Fix os.rename in git source element to correctly handle error codes https://gitlab.com/BuildStream/buildstream/merge_requests/93809:20
gitlab-br-botMR !958: Followup on MR 938, addressing additional comments https://gitlab.com/BuildStream/buildstream/merge_requests/95809:20
*** alatiera_ has joined #buildstream09:20
*** alatiera_ has joined #buildstream09:20
juergbiwill take a look, probably this afternoon09:21
benschubertthanks!09:23
*** solid_black has joined #buildstream09:24
*** rdale has joined #buildstream09:25
*** phildawson has joined #buildstream09:25
*** jonathanmaw has joined #buildstream09:38
valentindjuergbi, I updated the Freedesktop cache server to be object-based clean up, yesterday.09:44
valentindThe clean-up worked OK.09:44
valentindBut this morning we had a spike of CPU usage.09:44
valentindCorresponding with a spike in network bandwitdh09:44
valentindBut disk I/O is relatively small.09:45
juergbihm, the new approach is supposed to avoid expensive operations causing such spikes09:45
valentindIt is 669 Mbps of network. And 230 kB/s of disk I/O09:45
juergbispike in network bandwidth: would this be due to a spike in client requests?09:45
valentindjuergbi, yes, but not that many. Around 25 clients. We have seen more.09:46
juergbimaybe a few with really fast connection, hm09:46
valentindI do not understand why there is so much more network than disk I/O09:46
juergbilow disk I/O doesn't mean anything if tons is in the page cache. however, the ratio is a bit extreme...09:47
valentindAnd CPU gets 100% then connect()s timeout.09:47
valentindjuergbi, The machine does not have much memory to cache what it needs.09:47
valentindThe cache data is huge. And builds require quite a lot of objects.09:47
juergbiyes, it seems quite odd09:48
valentindI am looking the history. And it does not seem my changes changed much of the behavior09:49
valentindIt is outbound traffic mostly.09:50
valentindinbound is negligable.09:50
valentindAnd it is the push enabled server. So it must be the builders.09:51
juergbidid CPU usage remain at 100%, i.e., did you have to forcefully terminate it?09:53
valentindjuergbi, No. It went down by itself.09:53
valentindIt was also going up and down.09:53
valentindI saw it going between 140% and 190% in top (with 2 cpus).09:53
valentindand now it is much less than 50%. So no loop.09:54
juergbiok09:54
valentindjuergbi, we will increase the size of the server.09:56
valentindThe outbound network follows very well the CPU usage in the graphs.09:57
juergbidid you see any client issues in the CI except for the connect failure?09:59
juergbii.e., the outbound network traffic was likely correct?10:00
*** tpollard has joined #buildstream10:01
valentindOnly connect() timeout.10:05
valentindYes, it might have been OK.10:05
valentindIt might be that all the build have been started exactly at the same time, which does not usually happen.10:08
*** raoul has joined #buildstream10:17
*** lachlan has joined #buildstream10:27
*** lachlan has quit IRC10:29
*** lachlan has joined #buildstream10:29
*** lachlan has quit IRC10:44
*** lachlan has joined #buildstream10:52
benschubertDo we have somewhere documentation about how staging is done exactly?10:53
tiagogomesbenschubert https://wiki.gnome.org/Projects/BuildStream/ImportRules perhaps?10:57
jmacThat's not meant to be user-facing documentation, but should be up-to-date10:57
benschubertok, perfect thanks!10:58
benschubertI'm trying to understand why it is so slow and where I could make improvements (7 minutes for 600MB archive, which is my base platform)10:59
juergbibenschubert: CAS-based source cache + buildbox will likely improve this a lot10:59
benschubertI'm looking more into local dev, so without buildbox access (and on windows WSL, which is extremely slow by default)11:00
*** lachlan has quit IRC11:02
Kinnisontristan: thanks for your input on the plugin thread I started.  I'll give your ideas some thought and see if I can get a response written today11:05
juergbibenschubert: the plan is to use source cache and buildbox also locally11:09
benschubertOh, I seem to have missed that, won't look into optimizing then thanks!11:10
juergbiWSL can't use buildbox (FUSE) but can still use source cache. and in that case you anyway either have to use remote execution or docker11:10
juergbi(or local execution without full sandboxing but FUSE in docker would likely be faster)11:10
*** lachlan has joined #buildstream11:12
benschubertOk, thanks!11:12
*** adds68 has quit IRC11:14
*** adds68 has joined #buildstream11:15
*** ChanServ sets mode: +o tristan11:15
tristanKinnison, I did read through your email and it is a lot of stuff to think about indeed, just wanted to add some of the thoughts I've been having on the same subject :)11:15
KinnisonAye, they're helpful to have on one place so we can all stew :-)11:16
juergbitristan: in my second mail regarding execution environments, I'm proposing an approach how to handle backward compatibility with format-version. not extremely urgent but I'd appreciate a comment on whether this sounds like an acceptable approach in general or not11:23
juergbiand thanks for the command batching comments, will fix this up tomorrow morning11:23
juergbirelevant execution environments mail: https://mail.gnome.org/archives/buildstream-list/2018-November/msg00056.html11:24
*** lachlan has quit IRC11:30
Nexusbenschubert: Would it be possible for me to have a look at te kindof projcet you said isn't working with `build-world`? I'm having difficulty visualising it to debug exactly what's happening11:31
benschubertNexus: the problem is we don't have an element-path specified, Didn't occur to me directly. So we have every element at the root of the project11:32
Nexusbenschubert: i see. As i understand it, buildstream currently does not support elements boing outside of an element-path11:33
Nexusthough if it's in the root, i would expect it to still get caught by the build-all logic11:34
Nexusas i believe ethat;s the element-path defaultr11:34
* Nexus can't type today11:34
tristanjuergbi, lemme take a look thanks, that one probably slipped through the cracks11:35
juergbithanks11:35
tristanohhh that11:35
tristanyeah I remember :-S11:35
*** adds68 has quit IRC11:36
benschubertNexus: yeah it should, but there was a bug in the PR previously that hardcoded "elements" if I remember well?11:36
*** adds68 has joined #buildstream11:36
benschubertNexus: mainly ```if build_world:        elements = get_files(app._main_options.get("directory"), "elements"```11:37
*** lachlan has joined #buildstream11:44
*** lachlan has quit IRC11:49
*** lachlan has joined #buildstream11:49
gitlab-br-botaevri merged MR !887 (aevri/prompt-config->master: Add 'prompt.*' config options to buildstream.conf) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/88712:12
*** tristan has quit IRC12:13
*** lachlan has quit IRC12:20
*** lachlan has joined #buildstream12:22
*** lachlan has quit IRC12:27
*** phildawson has quit IRC12:29
*** phildawson has joined #buildstream12:29
paulsherwoodwhat's with the strongarm icon in gitlab?12:31
Nexusbenschubert: yes, that's been removed now :)12:32
paulsherwood(it's one of the many things that is currently annoying me about https://gitlab.com/BuildStream/buildstream/issues/711)12:32
jmacThat's just toscalix's user name12:32
jmacOh no, maybe not12:33
benschubertEverything should be good then I can try after12:33
jmacNo idea what that's for, actually12:37
jmacLooks like you can set a current status which includes an emoji12:38
toscalixjmac: solved. I removed it12:38
paulsherwoodtvm. it was sending entirely the wrong signals imo12:38
*** lachlan has joined #buildstream12:45
*** cs-shadow has quit IRC13:03
*** tristan has joined #buildstream13:06
*** lachlan has quit IRC13:19
*** phildawson has quit IRC13:26
*** phildawson has joined #buildstream13:28
*** alatiera_ has quit IRC13:33
*** catonano has joined #buildstream13:38
*** alatiera_ has joined #buildstream14:09
*** lachlan has joined #buildstream14:15
*** phildawson has quit IRC14:19
*** phildawson_ has joined #buildstream14:22
*** phildawson_ has quit IRC14:24
*** phildawson has joined #buildstream14:28
jonathanmawIs there a way to override what click describes for its usage string?14:32
skullmannot that I've seen14:33
jonathanmawI can trick it into letting me make `bst checkout`'s ELEMENT as optional if I flag LOCATION as optional, too14:33
jonathanmawbut then it changes the usage string :/14:33
* skullman opted to check the options and raise an AppError14:33
*** phildawson has quit IRC14:35
*** phildawson has joined #buildstream14:36
*** phildawson_ has joined #buildstream14:58
*** raoul_ has joined #buildstream15:00
*** phildawson has quit IRC15:00
*** raoul has quit IRC15:01
*** phildawson_ has quit IRC15:02
*** phildawson has joined #buildstream15:02
tpollardtests seem to be broken on master for me15:12
tpollardnot sure if it's a local issue yet though, will push to a WIP to check15:13
*** solid_black has quit IRC15:13
*** alatiera__ has joined #buildstream15:17
*** alatiera_ has quit IRC15:20
gitlab-br-bottpollard opened issue #774 (Provide the ability to pull missing buildtrees via the scheduler outside of user invoked bst push & build) on buildstream https://gitlab.com/BuildStream/buildstream/issues/77415:29
*** raoul_ has quit IRC15:36
*** raoul_ has joined #buildstream15:36
*** raoul_ has quit IRC15:37
*** raoul_ has joined #buildstream15:38
*** Jobava has joined #buildstream15:43
*** lachlan has quit IRC15:50
*** lachlan has joined #buildstream16:06
*** alatiera__ has quit IRC16:08
*** CTtpollard has joined #buildstream16:11
*** tpollard has quit IRC16:13
*** lachlan has quit IRC16:15
*** lachlan has joined #buildstream16:18
*** CTtpollard has quit IRC16:29
*** tpollard has joined #buildstream16:33
*** solid_black has joined #buildstream16:33
*** solid_black_ has joined #buildstream16:36
*** solid_black_ has quit IRC16:38
*** solid_black__ has joined #buildstream16:38
*** solid_black has quit IRC16:38
*** solid_black__ is now known as solid_black16:39
juergbijennis: regarding !956, is 'pathway' a commonly used term (instead of just path) in the context of filesystems?16:41
gitlab-br-botMR !956: Fix warning when using an absolute path which exists inside the project https://gitlab.com/BuildStream/buildstream/merge_requests/95616:41
*** solid_black has quit IRC16:42
juergbiI don't think I've seen pathway used before in this area, or at the very least not frequently16:42
juergbiso I would just go for path16:42
jennisjuergbi, noted. Will amend the MR16:44
* Kinnison doesn't think 'pathway' is right either :)16:44
juergbita16:44
*** phildawson has quit IRC16:44
jennisjuergbi, all done16:46
jennisAlso rebased16:47
gitlab-br-botLaurenceUrhegyi opened issue #775 (Execution Environment Requirements) on buildstream https://gitlab.com/BuildStream/buildstream/issues/77516:48
tpollardI seemed to have found a few tests that are picking up the host systems userconfig, I'll try to narrow it down16:50
tpollardI purposely had an incompatible config option in my user conf, which leads to some of the tests failing16:50
*** alatiera_ has joined #buildstream16:56
gitlab-br-botjuergbi closed issue #725 (Job cancellation on remote builds) on buildstream https://gitlab.com/BuildStream/buildstream/issues/72516:59
gitlab-br-botjuergbi merged MR !900 (725-job-cancellation-on-remote-builds->master: _sandboxremote.py: Add sigterm handler that sends CancelOperation) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/90016:59
*** rkukura has joined #buildstream17:04
*** lachlan has quit IRC17:04
*** catonano has quit IRC17:12
*** tpollard has quit IRC17:25
*** tpollard has joined #buildstream17:27
gitlab-br-botjuergbi merged MR !956 (jennis/less_restrictive_pathways->master: Fix warning when using an absolute path which exists inside the project) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/95617:32
*** abderrahim has joined #buildstream17:34
*** abderrah1 has quit IRC17:36
*** lachlan has joined #buildstream17:37
*** boucman_work has joined #buildstream17:41
*** lachlan has quit IRC17:41
benschubertthanks juergbi for the reviews! I'll address the comments and merge the prs now !17:41
*** lachlan has joined #buildstream17:49
benschubertFor those interested I have a POC about a docker sandbox here https://gitlab.com/BuildStream/buildstream/tree/bschubert/docker-sandbox17:58
*** lachlan has quit IRC18:04
*** catonano has joined #buildstream18:05
*** jonathanmaw has quit IRC18:08
*** raoul_ has quit IRC18:18
*** tiagogomes_ has joined #buildstream18:18
*** CTtpollard has joined #buildstream18:18
*** raoul has joined #buildstream18:18
*** tiagogomes has quit IRC18:18
*** tpollard has quit IRC18:18
*** toscalix has quit IRC18:35
*** catonano has quit IRC18:37
*** alatiera_ has quit IRC18:39
gitlab-br-botBenjaminSchubert merged MR !949 (bschubert/add-fedora-nobwrap-tests->master: Add tests for fedora with no bubblewrap available) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/94918:41
*** raoul has quit IRC19:08
*** catonano has joined #buildstream19:10
*** alatiera_ has joined #buildstream19:57
*** Guest54789 has joined #buildstream20:05
*** phildawson has joined #buildstream20:07
*** catonano has quit IRC20:28
*** catonano has joined #buildstream20:32
*** catonano has quit IRC20:36
*** Tony99 has joined #buildstream22:04
*** alatiera__ has joined #buildstream22:16
*** alatiera_ has quit IRC22:18
*** benschubert has quit IRC23:04
*** laurence has quit IRC23:04
*** skullman has quit IRC23:04
*** Demos[m] has quit IRC23:04
*** awacheux[m] has quit IRC23:04
*** kailueke[m] has quit IRC23:04
*** alatiera has quit IRC23:04
*** ssssam[m] has quit IRC23:04
*** abderrahim[m] has quit IRC23:04
*** pro[m] has quit IRC23:04
*** theawless[m] has quit IRC23:04
*** persia has quit IRC23:04
*** CTtpollard has quit IRC23:04
*** tristan has quit IRC23:04
*** mohan43u has quit IRC23:04
*** ctolentino has quit IRC23:04
*** slaf has quit IRC23:04
*** gitlab-br-bot has quit IRC23:04
*** lchlan has quit IRC23:04
*** paulsherwood has quit IRC23:04
*** jmac has quit IRC23:04
*** dineshdb[m] has quit IRC23:04
*** waltervargas[m] has quit IRC23:04
*** doras[m] has quit IRC23:04
*** inigomartinez has quit IRC23:04
*** connorshea[m] has quit IRC23:04
*** oknf[m] has quit IRC23:04
*** segfault3[m] has quit IRC23:04
*** jjardon[m] has quit IRC23:04
*** asingh_[m] has quit IRC23:04
*** tlater[m] has quit IRC23:04
*** krichter[m] has quit IRC23:04
*** cgmcintyre[m] has quit IRC23:04
*** rafaelff[m] has quit IRC23:04
*** mattiasb has quit IRC23:04
*** albfan[m] has quit IRC23:04
*** m_22[m] has quit IRC23:04
*** juergbi has quit IRC23:04
*** jjardon has quit IRC23:04
*** hergertme has quit IRC23:04
*** ironfoot has quit IRC23:04
*** tintou has quit IRC23:04
*** mohan43u has joined #buildstream23:46
*** mohan43u has quit IRC23:49
*** mohan43u has joined #buildstream23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!