| *** bochecha has quit IRC | 00:36 | |
| *** catonano has quit IRC | 01:03 | |
| *** azwieg103 has joined #buildstream | 01:33 | |
| *** ring0 has joined #buildstream | 02:20 | |
| *** Prince781 has quit IRC | 04:07 | |
| *** Prince781 has joined #buildstream | 04:09 | |
| *** Prince781 has quit IRC | 04:12 | |
| *** Prince781 has joined #buildstream | 04:15 | |
| *** Prince781 has quit IRC | 04:38 | |
| *** mohan43u has quit IRC | 05:20 | |
| *** mohan43u has joined #buildstream | 05:20 | |
| *** alatiera_ has joined #buildstream | 07:15 | |
| *** anahuelamo has joined #buildstream | 07:47 | |
| *** anahuelamo has quit IRC | 07:54 | |
| *** toscalix has joined #buildstream | 08:43 | |
| *** toscalix has quit IRC | 08:48 | |
| *** toscalix has joined #buildstream | 08:48 | |
| *** finn has joined #buildstream | 08:57 | |
| *** tristan has joined #buildstream | 09:20 | |
| *** tiagogomes has joined #buildstream | 09:46 | |
| *** tpollard has joined #buildstream | 09:47 | |
| *** raoul has joined #buildstream | 09:51 | |
| *** anahuelamo has joined #buildstream | 09:52 | |
| *** jonathanmaw has joined #buildstream | 09:52 | |
| gitlab-br-bot | tacgomes approved MR !905 (bschubert/fix-binary-output-capture->master: Don't close stdout when running 'checkout' to stdout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/905 | 09:55 |
|---|---|---|
| *** solid_black has joined #buildstream | 09:58 | |
| *** rdale has joined #buildstream | 10:11 | |
| *** cs-shadow has joined #buildstream | 10:13 | |
| gitlab-br-bot | BenjaminSchubert closed issue #486 (Capturing binary output using pytest capsysmodule doesn't work) on buildstream https://gitlab.com/BuildStream/buildstream/issues/486 | 10:17 |
| gitlab-br-bot | BenjaminSchubert merged MR !905 (bschubert/fix-binary-output-capture->master: Don't close stdout when running 'checkout' to stdout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/905 | 10:17 |
| *** benschubert has joined #buildstream | 10:20 | |
| jonathanmaw | tristan: do you have time to look at https://gitlab.com/BuildStream/buildstream/merge_requests/869 ? | 10:24 |
| jonathanmaw | whoops, I accidentally hit the rebase button on https://gitlab.com/BuildStream/buildstream/merge_requests/886 | 10:30 |
| * jonathanmaw closes the tab before he accidentally hits merge. | 10:31 | |
| *** ChanServ sets mode: +o tristan | 10:35 | |
| tristan | jonathanmaw, I'm trying to catch up on my backlog but I'll give it a look over | 10:35 |
| jonathanmaw | tristan: tvm | 10:36 |
| *** bochecha has joined #buildstream | 10:42 | |
| *** Prince781 has joined #buildstream | 10:53 | |
| *** jonathanmaw_ has joined #buildstream | 10:54 | |
| *** jonathanmaw has quit IRC | 10:55 | |
| *** Prince781 has quit IRC | 11:14 | |
| toscalix | tristan: valentind due to preparations for the gathering, the gathering itself and elce 2018 we have several additional tickets to process. Would you agree on having a second session this week to deal with them? | 11:14 |
| *** Prince781 has joined #buildstream | 11:15 | |
| tristan | toscalix, Sure... I think I have it on my todo list to also report back to the list regarding the blockers we agreed on, plus the extra one that sander asked for (splitting out core plugins into a separate package/repo), which I think is a bit controversial | 11:16 |
| toscalix | tristan: the outcome of that conversation about plugins was that I was going to present a proposal | 11:17 |
| tristan | it's a bit annoying (or quite annoying), that the API breaks we agreed on related to the CLI have gotten blown out of proportion | 11:17 |
| tristan | and now we are talking about splitting out plugins and breaking other non-cli related things | 11:17 |
| toscalix | we have a lot of outcome to process out of the gathering too so it will take us some days to back to normal. I am not too worry about it. We will get there | 11:18 |
| tristan | Yeah, there was that conversation, which was followed by the blockers discussion, which I left at the end, and when I returned there was this extra "remove plugins from core" item which was snuck onto the end of that list | 11:18 |
| toscalix | tristan: I think it was the quick way to record the topic on the board. I do not consider that there was any additional outcome while you were out | 11:19 |
| tpollard | Does anyone have time to approve/review https://gitlab.com/BuildStream/buildstream/merge_requests/786 please | 11:20 |
| toscalix | related to the request from tpollard and others..... at some point we need to start using the assignee to the MR to avoid using IRC for something gitlab can be used for | 11:20 |
| toscalix | the ping pong game should we played through the assignee field | 11:21 |
| tristan | The real question we need to discuss on the list is, if we're going to grow the scope of the breakages at this point, does it merit a bst 2.0, and if so, does it need to be parallel installable; I feel like splitting out plugins from core is too large of a scope to cover in this release cycle, though | 11:21 |
| tristan | So maybe there are two steps | 11:21 |
| toscalix | that would be my suggestion | 11:21 |
| toscalix | tristan: I did the same comment during the discussion | 11:22 |
| jmac | tpollard: Do you need new reviewers on that, or approval from previous reviewers? I'm happy to take a look at some point today | 11:22 |
| toscalix | I mentioned it was not going to happen on this release | 11:22 |
| toscalix | I still believe it | 11:22 |
| tpollard | jmac: it could probably have an approval from juergbi if it's satisfactory | 11:23 |
| toscalix | So we need to agree first on the strategy to split them and manage the plugins then evaluate the amount of work to implement it and finally do it | 11:23 |
| juergbi | it's on my list to go over it one more time | 11:23 |
| tristan | jmac, while reviewing jonathanmaw_'s patch, I stumbled upon make_dir_writeable() in Element._stage_sources_at() | 11:28 |
| tristan | jmac, Why is that reimplementing utils._force_rmtree() ? | 11:28 |
| tristan | jmac, or rather, can you please fix that to ensure that _force_rmtree() works for the case that make_dir_writable() needs, and remove the dual codepaths ? | 11:28 |
| jmac | I'll take a look tristan | 11:29 |
| *** lachlan has joined #buildstream | 11:37 | |
| tristan | jonathanmaw_, it's a partial review but I think it's good for a first round | 11:39 |
| *** jonathanmaw_ is now known as jonathanmaw | 11:39 | |
| tristan | jonathanmaw_, actually your branch is nice and fairly smaller than I might have expected, which is a good sign :) | 11:39 |
| jonathanmaw | tristan: yep, I was surprised how little change was actually required | 11:39 |
| jmac | tristan: Looks like an efficiency improvement, since make_dir_writable doesn't need to do os.walk or use chmod unless there's an error. I'll see if it's possible to do the same in _force_rmtree and combine them. | 11:40 |
| *** phildawson has joined #buildstream | 11:44 | |
| gitlab-br-bot | jmacarthur opened issue #735 (Combine _force_rmtree and make_dir_writable) on buildstream https://gitlab.com/BuildStream/buildstream/issues/735 | 11:44 |
| tristan | jmac, whichever works better; it appears that both code blocks serve pretty much the same purpose, so we shouldnt have two | 11:48 |
| *** catonano has joined #buildstream | 11:51 | |
| valentind | toscalix, yes. I do not mind a second session. Just set the meeting. | 11:58 |
| tristan | oh | 11:59 |
| tristan | toscalix, I cannot do wednesday, or rather I could do wednesday but later in the day | 11:59 |
| toscalix | no wed then | 12:02 |
| *** Bhujay has joined #buildstream | 12:04 | |
| *** lachlan has quit IRC | 12:04 | |
| *** lachlan has joined #buildstream | 12:05 | |
| *** lachlan has quit IRC | 12:16 | |
| *** lachlan has joined #buildstream | 12:19 | |
| *** Bemmu has joined #buildstream | 12:35 | |
| *** lachlan has quit IRC | 12:40 | |
| *** lachlan has joined #buildstream | 12:50 | |
| *** jonathanmaw_ has joined #buildstream | 12:50 | |
| *** jonathanmaw has quit IRC | 12:51 | |
| *** crater2150 has joined #buildstream | 13:10 | |
| tristan | juergbi, jmac; I just finished up my todo list for the architecture docs, and added a new diagram for the scheduler Job section (also detailing that we are fork() without execve()) | 13:14 |
| tristan | Am about to push that up... but then I think... we should absorb some of the "Additional Writings" which are lying around in arbitrary places, and wrap that up into the Architecture section | 13:14 |
| tristan | I.e. the in depth explanation on cache keys and on sandboxing, probably belong in there | 13:15 |
| jmac | I have a section on execution & sandboxing, it's just waiting for something to attach it to | 13:15 |
| tristan | thoughts on moving those two chapters from the reference "book" to the architecture "book" ? | 13:15 |
| tristan | jmac, Nice :) | 13:16 |
| tristan | I think it would be desirable to nuke the "Additional" section altogether, but then I don't know what to do with this new docker related thing | 13:18 |
| tristan | I also don't know why we bother maintaining a script and documentation for the special purpose of transforming a checked out directory into a docker image | 13:19 |
| tristan | I would think docker has scripts and documentation about that :-S | 13:19 |
| tristan | bst-docker-import... errrm, actually useful ? | 13:19 |
| * tristan just lets it be and leaves the section there in the docs | 13:19 | |
| gitlab-br-bot | tristanvb opened MR !907 (tristan/architecture-docs->master: Tristan/architecture docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/907 | 13:33 |
| gitlab-br-bot | valentindavid opened MR !908 (valentindavid/netrc->master: Add support for .netrc in remote/tar/zip plugins) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/908 | 13:49 |
| jjardon | valentind: are the daily builds for fdsdk active now? | 13:51 |
| valentind | jjardon, oh, forgot to activate. | 13:52 |
| valentind | We are still missing a builder though. | 13:52 |
| jjardon | valentind: still no word from ops? what about if we create the runners in DO, like the other ones? | 13:55 |
| jjardon | valentind: if you are ok with that I can setup them now | 13:55 |
| jjardon | tiagogomes: valentind is there an issue open about the daily build failing because lack of space? | 13:56 |
| valentind | jjardon, we know that master does not build freedesktop sdk for sure. And 1.2 branch still builds it. | 13:58 |
| jjardon | valentind: sure, but there are 2 issues there: 1. It doesnt build because the describe stuff 2. It doesnt build because the infra doesnt have enough space | 13:59 |
| tiagogomes | afaik, there isn't a specific issue opened for that | 14:00 |
| valentind | jjardon, anyway, I set the builds to happen at different time on the same machine. | 14:05 |
| gitlab-br-bot | richardmaw-codethink opened MR !909 (richardmaw/shell-multi-stage->master: WIP: Allow staging multiple elements in `bst shell`) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/909 | 14:18 |
| gitlab-br-bot | tristanvb merged MR !907 (tristan/architecture-docs->master: Tristan/architecture docs) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/907 | 14:28 |
| gitlab-br-bot | tristanvb merged MR !828 (chandan/fix-checkout-none-1.2->bst-1.2: Ensure `--deps=none` option works for `bst checkout`) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/828 | 14:28 |
| *** lachlan has quit IRC | 14:31 | |
| *** jonathanmaw has joined #buildstream | 14:31 | |
| *** jonathanmaw_ has quit IRC | 14:32 | |
| jjardon | valentind: would that fix the lack of space problem? | 14:35 |
| valentind | jjardon, I disabled the machine that lacked of space. | 14:36 |
| jjardon | right, ok; problem solved then :), let me know if you change your mind and prefer to create the runners on demand; happy to help | 14:38 |
| toscalix | adds68: please can you check https://gitlab.com/BuildStream/buildstream/issues/655 ? | 14:38 |
| adds68 | toscalix, what would you like me to check? | 14:41 |
| toscalix | the current state of the ticket. Should it be closed? | 14:43 |
| juergbi | tristan: have you intentionally merged backport !828 before the corresponding master MR !819? seems odd to me | 14:45 |
| adds68 | toscalix, there is no MR associated with it, that shows the issue is resolved, so it should stay open | 14:46 |
| Nexus | cs-shadow: hey, you around? I'd like to chat about https://gitlab.com/BuildStream/buildstream/issues/638 | 14:50 |
| gitlab-br-bot | BenjaminSchubert opened issue #736 (Integration tests are leaking into each others) on buildstream https://gitlab.com/BuildStream/buildstream/issues/736 | 14:51 |
| toscalix | adds68: have you taken a look at !796 comments ? There are relations with a different MR | 14:54 |
| adds68 | toscalix that MR is closed | 14:55 |
| toscalix | which one? | 14:55 |
| adds68 | !796 | 14:55 |
| toscalix | ait seems to be related with https://gitlab.com/BuildStream/buildstream/merge_requests/801 | 14:56 |
| toscalix | as per comments states | 14:56 |
| phildawson | is there anything in the test suite atm which is testing bst's interactive mode? | 15:03 |
| *** lachlan has joined #buildstream | 15:07 | |
| tpollard | toscalix: in terms of assigning an MR for review, should that be to the person who raised the original issue? | 15:09 |
| adds68 | toscalix that is the same MR, if you see the commits | 15:11 |
| adds68 | toscalix but in summary, no it should stay open | 15:11 |
| toscalix | adds68: thanks | 15:11 |
| toscalix | tpollard: when the MR is ready for review... assign it to a reviewer.... or several, or all. But this has not been agreed so maybe we should agree on it first or simply stop doing it and roll it little by little | 15:12 |
| toscalix | I would prefer the second approach | 15:12 |
| toscalix | but the first approach would work too | 15:13 |
| tristan | juergbi, I did, and yeah I know it's odd - but they are both almost ready basically | 15:14 |
| tristan | juergbi, I also commented on !819 which is on the verge | 15:14 |
| tristan | juergbi, better to expedite | 15:14 |
| *** Prince781 has quit IRC | 15:17 | |
| *** tristan has quit IRC | 15:17 | |
| *** Prince781 has joined #buildstream | 15:19 | |
| *** anahuelamo has quit IRC | 15:28 | |
| *** anahuelamo has joined #buildstream | 15:28 | |
| gitlab-br-bot | jjardon opened issue #737 (Buildstream local cache doesn't get cleanup automatically when the disk is full) on buildstream https://gitlab.com/BuildStream/buildstream/issues/737 | 15:38 |
| *** ctolentino has joined #buildstream | 15:38 | |
| *** ChunkyPuffs has quit IRC | 15:40 | |
| *** tristan has joined #buildstream | 15:41 | |
| cs-shadow | Nexus: Hey! Sorry I have to run to our planning meeting now. I'll try to catchup with you later today, or tomorrow if I can't find you today. | 15:58 |
| tpollard | toscalix: I don't really have a strong opinion, just wanted to follow process | 16:12 |
| toscalix | there is no pre-defined process. My point is that, because there is no process, we end up pinging people in IRC | 16:12 |
| toscalix | you did the right thing | 16:13 |
| toscalix | pinging through IRC | 16:13 |
| *** bochecha has quit IRC | 16:14 | |
| *** catonano has quit IRC | 16:17 | |
| *** BuckTurg- has joined #buildstream | 16:17 | |
| Nexus | cs-shadow: np :) | 16:26 |
| *** Prince781 has quit IRC | 17:03 | |
| *** xjuan has joined #buildstream | 17:16 | |
| *** abderrahim4 has joined #buildstream | 17:22 | |
| *** abderrahim3 has quit IRC | 17:22 | |
| *** Prince781 has joined #buildstream | 17:29 | |
| *** toscalix has quit IRC | 17:52 | |
| *** Prince781 has quit IRC | 17:54 | |
| *** catonano has joined #buildstream | 18:08 | |
| *** ctolentino has quit IRC | 18:23 | |
| *** Prince781 has joined #buildstream | 18:52 | |
| gitlab-br-bot | gokcennurlu opened MR !910 (gokcen/no_auto_fetch->master: WIP: Add explicit `--fetch` flag to bst commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/910 | 18:53 |
| *** raoul has quit IRC | 19:02 | |
| *** Prince781 has quit IRC | 19:11 | |
| *** Prince781 has joined #buildstream | 19:25 | |
| *** divadsn has joined #buildstream | 19:36 | |
| *** Prince781 has quit IRC | 19:48 | |
| *** Prince781 has joined #buildstream | 20:25 | |
| *** benschubert has quit IRC | 20:34 | |
| *** lachlan has quit IRC | 20:51 | |
| *** catonano has quit IRC | 20:53 | |
| *** catonano has joined #buildstream | 20:53 | |
| *** jonathanmaw has quit IRC | 20:54 | |
| *** bochecha has joined #buildstream | 21:44 | |
| *** alatiera_ has quit IRC | 21:58 | |
| *** catonano has quit IRC | 22:06 | |
| *** catonano has joined #buildstream | 22:07 | |
| *** Prince781 has quit IRC | 22:18 | |
| *** catonano has quit IRC | 22:30 | |
| *** Prince781 has joined #buildstream | 22:35 | |
| *** tristan has quit IRC | 23:25 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!