IRC logs for #buildstream for Friday, 2018-10-12

*** xjuan has quit IRC01:21
*** albfan[m] has quit IRC01:30
*** albfan[m] has joined #buildstream01:31
*** toscalix has joined #buildstream07:34
*** pro[m] has quit IRC09:05
*** pro[m] has joined #buildstream09:05
flatmushI think I've found a bug with buildstream artifact caching, it doesn't seem to correctly hash when I remove "type: build"09:09
flatmushwhich is causing it to incorrectly succeed09:09
flatmushI can't easily share my file, but has anyone experienced anything similar or is this expected?09:10
Kinnisonflatmush: from a dependency?09:10
flatmushyeah09:10
flatmushso in this case I had a load of dependencies, all "type: build"09:10
flatmushI removed "type: build" from all of them and the hash changed and it rebuilt09:10
Kinnisonflatmush: are you able to construct a small project to demonstrate this, by means of `bst show` to compare artifact ids?09:10
flatmushI can try09:10
KinnisonOh hang on09:10
Kinnisonhrm09:11
KinnisonIIRC the default dependency type is 'build'09:11
* Kinnison could be wrong though09:11
flatmushI think the default is runtime and buildtime09:11
flatmushif it's not, then it just changes what the bug is09:11
* skullman thought it was build+runtime, hence separate build-dependencies and runtime-dependencies keys09:11
KinnisonThen I was wrong :-)09:11
KinnisonI suppose, in theory, changing the runtime deps of an element ought not to change its artifact ID, but I imagine currently it would09:12
KinnisonI imagine we do that, rather than recursively include the runtime deps of an elements build-deps when calculating its ID09:12
tiagogomesI thought the default dependency type as 'all'09:12
tiagogomes8was09:12
tiagogomesbah09:12
* Kinnison sends tiagogomes to get more coffee09:13
tiagogomesplease :)09:13
tiagogomesflatmush are you sure that you didn't already have a cached artifact with the same cache key as when you removed 'type: build'09:15
flatmushtiagogomes: I am certain09:15
flatmushin-fact the build should fail with this specific set of "type: build"s in it09:15
flatmushif I duplicate the dependency, to force a sha change then the build fails09:16
flatmushbut also, when I add/remove the "type: build" from the final dependency, the hash stays the same09:16
*** jonathanmaw has joined #buildstream09:21
*** lachlan has joined #buildstream09:26
toscalixHands up: I will need to re-schedule the 102 training session and the Arch. presentation from tristan. I will announce it later today09:55
*** lachlan has quit IRC09:55
*** tristan has joined #buildstream09:59
*** lachlan has joined #buildstream09:59
*** ChanServ sets mode: +o tristan09:59
*** lachlan has quit IRC10:05
*** lachlan has joined #buildstream10:09
*** lachlan has quit IRC10:14
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: WIP - Add YAM cache testing to yaml tests and further YAML cache refinements) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83610:14
*** lachlan has joined #buildstream10:14
*** lachlan has quit IRC10:21
gitlab-br-botbuildstream: merge request (tristan/remove-install-guide->master: Remove install guide) #872 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/87210:28
gitlab-br-botbuildstream: merge request (tiagogomes/docs-improvements->master: Documentation improvements) #835 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/83510:29
*** lachlan has joined #buildstream10:30
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: WIP - Add YAM cache testing to yaml tests and further YAML cache refinements) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83610:31
gitlab-br-botbuildstream: merge request (tristan/remove-install-guide->master: Remove install guide) #872 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/87210:49
*** bochecha has joined #buildstream10:51
*** abderrahim has quit IRC10:53
*** abderrahim has joined #buildstream10:53
*** alatiera_ has joined #buildstream11:02
*** tristan has quit IRC11:23
gitlab-br-botbuildstream: merge request (jonathan/debug-remote-failed-builds->master: Jonathan/debug remote failed builds) #869 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86912:05
gitlab-br-botbuildstream: issue #711 ("Cache key calculation fails to take dependency type into account in some cases") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/71112:33
*** finn has joined #buildstream12:38
flatmushI've reported the issue I had this morning as issue 71112:41
*** csoriano has left #buildstream12:44
*** lachlan has quit IRC13:19
*** lachlan has joined #buildstream13:23
*** lachlan has quit IRC13:30
*** lachlan has joined #buildstream13:30
gitlab-br-botbuildstream: merge request (jonathan/debug-remote-failed-builds->master: Jonathan/debug remote failed builds) #869 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86913:39
*** lachlan has quit IRC13:41
*** lachlan has joined #buildstream13:43
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: WIP - Add YAM cache testing to yaml tests and further YAML cache refinements) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83614:16
tiagogomeshmm, variables are not supported on `ref:` right14:42
*** finn has quit IRC15:05
*** lachlan has quit IRC15:10
*** finn has joined #buildstream15:12
toscalixI just scheduled the last topic. If I finish the roadmapping proposal, I will add that topic too during the weekend15:20
*** finn has joined #buildstream15:29
*** finn has joined #buildstream15:33
gitlab-br-botbuildstream: merge request (tpollard/workspacebuildtree->master: WIP: Opening a workspace with a cached build) #873 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/87315:34
*** lachlan has joined #buildstream15:42
*** lachlan has quit IRC16:01
*** lachlan has joined #buildstream16:10
*** lachlan has quit IRC16:16
*** tpollard has quit IRC16:16
gitlab-br-botbuildstream: merge request (jonathan/debug-remote-failed-builds->master: Jonathan/debug remote failed builds) #869 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86916:18
coldtomjonathanmaw could we get a new release on bst-external please? I forgot to add an entrypoint for the git-tag plugin16:27
jonathanmawokie doke16:28
*** toscalix has quit IRC16:29
jonathanmawcoldtom: done https://gitlab.com/BuildStream/bst-external/tree/0.6.116:32
coldtomty jonathanmaw16:36
*** jonathanmaw has quit IRC16:46
*** lachlan has joined #buildstream17:07
*** dineshdb[m] has quit IRC17:12
*** waltervargas[m] has quit IRC17:12
*** awacheux[m] has quit IRC17:12
*** pro[m] has quit IRC17:12
*** rafaelff[m] has quit IRC17:12
*** abderrahim[m] has quit IRC17:12
*** m_22[m] has quit IRC17:12
*** tlater[m] has quit IRC17:12
*** jjardon[m] has quit IRC17:13
*** inigomartinez has quit IRC17:13
*** connorshea[m] has quit IRC17:13
*** dineshdb[m] has joined #buildstream17:28
*** awacheux[m] has joined #buildstream17:28
*** waltervargas[m] has joined #buildstream17:29
*** pro[m] has joined #buildstream17:32
*** rafaelff[m] has joined #buildstream17:34
*** abderrahim[m] has joined #buildstream17:38
*** alatiera has quit IRC18:03
*** lachlan has quit IRC18:04
*** lachlan has joined #buildstream18:09
*** connorshea[m] has joined #buildstream18:21
*** m_22[m] has joined #buildstream18:25
*** tlater[m] has joined #buildstream18:30
*** jjardon[m] has joined #buildstream18:39
*** finn has joined #buildstream18:40
*** inigomartinez has joined #buildstream18:43
*** tristan has joined #buildstream18:49
*** lachlan has quit IRC18:52
*** xjuan has joined #buildstream18:52
*** alatiera_ has quit IRC19:10
*** alatiera has joined #buildstream19:21
*** lachlan has joined #buildstream19:34
*** lachlan has quit IRC19:35
*** finn has joined #buildstream19:40
*** tristan has quit IRC21:29
*** bochecha has quit IRC22:38
*** xjuan has quit IRC22:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!