IRC logs for #buildstream for Monday, 2018-10-08

*** Prince781 has joined #buildstream00:31
*** abderrahim has quit IRC06:21
*** abderrahim has joined #buildstream06:22
*** Prince781 has quit IRC07:08
*** toscalix has joined #buildstream07:52
*** tristan has joined #buildstream08:17
*** rdale has joined #buildstream08:31
*** ahmed89_ has joined #buildstream08:43
*** ahmed89 has quit IRC08:44
*** ahmed89_ is now known as ahmed8908:44
*** ahmed89 has quit IRC08:52
*** tpollard has joined #buildstream08:58
*** ahmed89 has joined #buildstream09:03
Kinnisontristan: Thank you for your effort on CONTRIBUTING.rst -- I shall take my time reading it :-)09:17
*** jonathanmaw has joined #buildstream09:23
*** lachlan has joined #buildstream09:30
*** ChanServ sets mode: +o tristan09:31
tristanKinnison, much appreciated :)09:31
gitlab-br-botbuildstream: issue #563 ("BuildStream should fail to install on unsupported platforms") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/56309:47
*** WSalmon_ is now known as WSalmon09:56
WSalmonHi tristan, I was wondering if you could add looking at https://gitlab.com/BuildStream/buildstream/merge_requests/776 to your todo, many thanks09:57
*** lachlan has quit IRC09:57
*** WSalmon has quit IRC10:05
*** WSalmon has joined #buildstream10:07
*** lachlan has joined #buildstream10:11
tristanWSalmon, I recall that the desire was to add some core functionality, and that it was going to be difficult to streamline this such that it "just works" uniformly with workspaces and builds, etc10:13
tristanSounds like a very complex endeavor which I was hoping to discourage...10:13
tristanWSalmon, has the approach changed to avoid all of this ?10:14
*** lachlan has quit IRC10:15
WSalmonit now dose not touch any core python, it just has a single adition to the core yaml (buildstream/data/projectconfig.yaml ) (one default value) and everything else is in the plugin yamls, it works uniformly across all plug ins that have build systems that can support this sort of thing, it is not quite as nice as i could have made it with some python changes but its seems to quite nice to me...10:18
toscalixjjardon: please do not forget to add your points about #220 and #697 to the topics list in the wiki. I will make an attempt today of creating a first agenda draft10:19
NexusWhere do i assign my remote cache? i don't have a `~/.config/buildstream.conf` :/10:21
tpollardcreate the file?10:21
Nexuswill that just work?10:22
tpollardshould do10:22
tristanWSalmon, sounds good, thanks for the heads up :)10:24
*** lachlan has joined #buildstream10:27
*** lachlan has quit IRC10:31
*** catonano has joined #buildstream10:35
WSalmontristan, also after a lot of rooting around and help from skullman we worked out the course of the no build dir in workspaces, for both sandboxis so were able to come up with a non workspace spesific fix's. please see the first commit. and juergbi helpped getting the working write on the function definition to help avoid it happening again...10:35
*** lachlan has joined #buildstream10:41
NexusAnyone got any idea what's causing this? https://hastebin.com/mebimoyavi.sql10:45
Nexusthat's in master for me10:46
KinnisonNexus: that looks odd.  Is it something strange in project.conf or buildstream.conf ?10:49
Kinnisonbecause it sounds like a mapping used as a key in a mapping10:50
Kinnisonor perhaps in a list, hmm10:50
NexusKinnison: very possibly, i'm trying to set up the buildstream.conf but the docs aren't very helpful for me10:50
KinnisonIf you move your buildstream.conf out of the way, can bst run?10:51
Nexusyeah :/ it's my .conf10:53
phildawsontristan, nice work on the contributing.rst, it's *much* more helpful now :)10:54
KinnisonThat's bad, both that your conf is wrong, and that having a wrong conf can cause a horrible traceback10:54
Nexusmissing an indent10:54
KinnisonPlease can you file an issue showing "This bad config causes a nasty traceback" ?10:55
Nexusyup10:57
Nexuswill do10:57
Nexustristan: the fix i posted to sphinx-click for \b not working has now been merged https://github.com/click-contrib/sphinx-click/pull/29#event-188194154410:58
*** bochecha has joined #buildstream10:58
*** ahmed89 has quit IRC10:59
tristanNexus, great :)11:03
tristanNexus, I noticed the other fix landed for pytest-datafiles and recent versions of pytest too11:03
Nexus\o/11:04
tristanWould be good to start requiring a new version of those... maybe we need to talk to cs-shadow first and update the CI images11:04
tristanI think the \b thing cannot be elegantly, or perfectly handled unfortunately, but it's a start11:05
tristanI was thinking, it would be best to add markdown/rst support to upstream click instead11:06
tristanSo that upstream click could do a *basic* ASCII rendering of markdown help output11:06
tristanAnd the HTML and man page plugins could use that markdown too11:06
lachlantristan: Hi, just to confirm we have updated !836 in light of your comments.11:06
tristanWould be much more powerful, but would have to be opt-in in order to not break click API11:07
tristanNexus, but then... I'm just dreaming of a brighter future :)11:07
NexusWhat are the definitions of the issue labels? Are those written anywhere?11:07
Nexuse.g. When is it a bug/enhancement11:08
Nexus?11:08
gitlab-br-botbuildstream: merge request (jjardon/pycodestyle->master: WIP:  Use pycodestyle instead pep8 python module) #638 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/63811:08
tristanNexus, So for that there is a labels page on gitlab which lists all the labels and some description sentence... but I think it is a bit of a moving target, I'm leaving that mostly in toscalix's hands11:08
*** lachlan has quit IRC11:10
*** ahmed89 has joined #buildstream11:19
*** ahmed89 has quit IRC11:21
tpollardis there a command I can do (maybe a flag on show?) to give me the path where the aritfact is cached?11:32
tristantpollard, Unfortunately not, and I think you mean where it is "extracted", which is considered an internal implementation detail11:33
tristantpollard, I have to wrap up the `bst artifact` command subgroup thread finally, and we will move `bst checkout` to `bst artifact checkout`, which can do better to allow checking out an artifact by a specific key, not only by element.bst11:34
tristantpollard, In the future, we hope that we can remove the extract/ directories entirely, actually11:35
tpollardI've got a test that passes artifactdir in via buildstream.conf. bst shows the element is cached/ has a key, but the artifact directory is empty11:35
tpollardso I'm trying to work out where it's caching11:35
tristanRight, the extract directory is only ever populated when an artifact is *used*, not when it is *cached*11:36
tristantpollard, the files exist in the CAS, and the redundant unpacking of it into an extract/ directory is an implementation detail11:36
tiagogomesIf we have `artifact checkout`, then we should have `artifact pull`11:37
tristan(which juergbi mentioned he would like to remove, I agree, except only it is complicated to do, because of symlink logic at stage time)11:37
tristantiagogomes, That is also covered in the `bst artifact` subgroup thread I believe11:37
tristantiagogomes, but feel free to go over the thread if it is not, I will have to review the whole thread and summarize11:38
tiagogomescool. And we will have `source checkout` and `source fetch` as well?11:38
tristanI think those are separate proposals; `bst fetch` itself is already only related to sources11:38
tristansource checkout was discussed elsewhere though, indeed11:38
tpollardtristan: I'm trying to use remove_artifact_from_cache, from cli.py in the integration tests11:38
tpollard*runcli.py11:39
tristantpollard, Yeah I keep questioning the validity of that function :-S11:39
tristanIt's not using BuildStream codepaths to do what it's doing11:39
tristanSo far it seems to be "working"11:39
tpollardI'm not sure where to go from here11:40
tristantpollard, I don't really have the full context of what you are trying to do11:40
tristanIs this a specific existing test case ? is it possible that a cleanup job ran ?11:41
tpollardremove an artifact from the cache within a test11:41
tpollardget_element_state asserts it's cached11:41
tristanWhen you say that "the artifact directory is empty"11:41
tristanWhat directory is that ?11:41
tpollardbuildstream.conf has artifactdir: /home/tom/buildstream/integration-cache/artifacts, but there is no artifacts dir there11:43
tristantpollard, As a rule, all test cases never effect the user's home directory or anything11:44
tristantpollard, Look at the state of the directories for the given test, which should be a subdirectory of the buildstream checkout11:45
tristanbuildstream_checkout/tmp/test_foobar0/...11:45
*** jonathanmaw_ has joined #buildstream11:45
tristantpollard, If a test case every writes outside of it's directory, or picks up any configuration from outside of its directory, that in itself is a bug11:46
tristans/every/ever11:46
*** jonathanmaw has quit IRC11:46
gitlab-br-botbuildstream: merge request (aevri/contributing_fixups->master: Minor fixups to contributing.rst) #866 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86611:48
*** tristan has quit IRC11:49
tpollardthe cli integration tests share sources and aritfacts at buildstream/integration-cache it seems11:52
tpollardpurposely infact11:54
*** tristan has joined #buildstream11:55
gitlab-br-botbuildstream: issue #698 ("Bad formatting on buildstream.conf results in ugly stacktrace") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/69812:37
*** CTtpollard has joined #buildstream13:01
*** tpollard has quit IRC13:02
*** lachlan has joined #buildstream13:43
*** lachlan has quit IRC14:08
*** lachlan has joined #buildstream14:24
*** lachlan has joined #buildstream14:25
*** lachlan has quit IRC14:33
*** bochecha has quit IRC14:43
*** lachlan has joined #buildstream14:44
tiagogomesIf the Makefile is on the root of the sources, is there a way of specifying where it is instead of modifying all commands to handle this14:51
*** CTtpollard is now known as tpollard14:57
tpollardis anyone aware of any of the currently included test projects/elements that would produce an artifact with a populated buildtree directory?14:57
tpollardso that'd be something that builds with a build-root dir14:58
tiagogomescommand-subdir is what I was looking for15:03
gitlab-br-botbuildstream: issue #699 ("invalid buildstream.conf format returns stacktrace") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/69915:18
NexusI currently have a netcat listener set up with a port on my machine, I have set my buildstream.conf file to point at that as a remote artifact cache. I am doing this in hopes of reproducing https://gitlab.com/BuildStream/buildstream/issues/423. Is this a valid way to test this? Also, pulls seem to hang on `Initializing remote caches`, Does this mean we don't timeout at all if we never get a responce,15:20
Nexusbut don't get back a `server unreachable` error?15:20
*** toscalix has quit IRC15:42
*** dtf has joined #buildstream15:50
*** lachlan has quit IRC15:56
*** lachlan has joined #buildstream16:01
*** lachlan has quit IRC16:14
gitlab-br-botbuildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86316:15
gitlab-br-botbuildstream: merge request (willsalmon/outOfSourecBuild->master: Out of source builds) #776 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/77616:15
gitlab-br-botbuildstream: merge request (chandan/bst-and-docker->master: Add documentation and NEWS entry about bst-docker-import) #864 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86416:16
*** finn has joined #buildstream16:22
*** lachlan has joined #buildstream16:25
*** lachlan has quit IRC16:28
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: Add yaml cache testing to yaml tests) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83616:29
*** lachlan has joined #buildstream16:29
*** lachlan has quit IRC16:39
*** bochecha has joined #buildstream16:40
*** catonano has quit IRC16:48
*** finn has quit IRC16:52
gitlab-br-botbuildstream: merge request (chandan/source-checkout->master: WIP: Add `bst source-checkout` command) #820 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/82016:55
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78617:01
*** lachlan has joined #buildstream17:18
*** Prince781 has joined #buildstream17:20
*** finn has joined #buildstream17:29
*** finn has quit IRC17:37
*** finn has joined #buildstream17:44
*** finn has quit IRC17:47
*** Prince781 has quit IRC17:52
gitlab-br-botbuildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/86318:25
*** lachlan has quit IRC18:48
gitlab-br-botbuildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/86318:58
*** lachlan has joined #buildstream19:04
*** lachlan has quit IRC19:15
*** rdale has quit IRC19:21
*** catonano has joined #buildstream19:49
*** finn has joined #buildstream19:51
*** jonathanmaw_ has quit IRC19:52
*** alatiera_ has quit IRC20:50
*** bochecha has quit IRC21:13
*** catonano has quit IRC21:32
*** catonano has joined #buildstream23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!