*** Prince781 has joined #buildstream | 00:31 | |
*** abderrahim has quit IRC | 06:21 | |
*** abderrahim has joined #buildstream | 06:22 | |
*** Prince781 has quit IRC | 07:08 | |
*** toscalix has joined #buildstream | 07:52 | |
*** tristan has joined #buildstream | 08:17 | |
*** rdale has joined #buildstream | 08:31 | |
*** ahmed89_ has joined #buildstream | 08:43 | |
*** ahmed89 has quit IRC | 08:44 | |
*** ahmed89_ is now known as ahmed89 | 08:44 | |
*** ahmed89 has quit IRC | 08:52 | |
*** tpollard has joined #buildstream | 08:58 | |
*** ahmed89 has joined #buildstream | 09:03 | |
Kinnison | tristan: Thank you for your effort on CONTRIBUTING.rst -- I shall take my time reading it :-) | 09:17 |
---|---|---|
*** jonathanmaw has joined #buildstream | 09:23 | |
*** lachlan has joined #buildstream | 09:30 | |
*** ChanServ sets mode: +o tristan | 09:31 | |
tristan | Kinnison, much appreciated :) | 09:31 |
gitlab-br-bot | buildstream: issue #563 ("BuildStream should fail to install on unsupported platforms") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/563 | 09:47 |
*** WSalmon_ is now known as WSalmon | 09:56 | |
WSalmon | Hi tristan, I was wondering if you could add looking at https://gitlab.com/BuildStream/buildstream/merge_requests/776 to your todo, many thanks | 09:57 |
*** lachlan has quit IRC | 09:57 | |
*** WSalmon has quit IRC | 10:05 | |
*** WSalmon has joined #buildstream | 10:07 | |
*** lachlan has joined #buildstream | 10:11 | |
tristan | WSalmon, I recall that the desire was to add some core functionality, and that it was going to be difficult to streamline this such that it "just works" uniformly with workspaces and builds, etc | 10:13 |
tristan | Sounds like a very complex endeavor which I was hoping to discourage... | 10:13 |
tristan | WSalmon, has the approach changed to avoid all of this ? | 10:14 |
*** lachlan has quit IRC | 10:15 | |
WSalmon | it now dose not touch any core python, it just has a single adition to the core yaml (buildstream/data/projectconfig.yaml ) (one default value) and everything else is in the plugin yamls, it works uniformly across all plug ins that have build systems that can support this sort of thing, it is not quite as nice as i could have made it with some python changes but its seems to quite nice to me... | 10:18 |
toscalix | jjardon: please do not forget to add your points about #220 and #697 to the topics list in the wiki. I will make an attempt today of creating a first agenda draft | 10:19 |
Nexus | Where do i assign my remote cache? i don't have a `~/.config/buildstream.conf` :/ | 10:21 |
tpollard | create the file? | 10:21 |
Nexus | will that just work? | 10:22 |
tpollard | should do | 10:22 |
tristan | WSalmon, sounds good, thanks for the heads up :) | 10:24 |
*** lachlan has joined #buildstream | 10:27 | |
*** lachlan has quit IRC | 10:31 | |
*** catonano has joined #buildstream | 10:35 | |
WSalmon | tristan, also after a lot of rooting around and help from skullman we worked out the course of the no build dir in workspaces, for both sandboxis so were able to come up with a non workspace spesific fix's. please see the first commit. and juergbi helpped getting the working write on the function definition to help avoid it happening again... | 10:35 |
*** lachlan has joined #buildstream | 10:41 | |
Nexus | Anyone got any idea what's causing this? https://hastebin.com/mebimoyavi.sql | 10:45 |
Nexus | that's in master for me | 10:46 |
Kinnison | Nexus: that looks odd. Is it something strange in project.conf or buildstream.conf ? | 10:49 |
Kinnison | because it sounds like a mapping used as a key in a mapping | 10:50 |
Kinnison | or perhaps in a list, hmm | 10:50 |
Nexus | Kinnison: very possibly, i'm trying to set up the buildstream.conf but the docs aren't very helpful for me | 10:50 |
Kinnison | If you move your buildstream.conf out of the way, can bst run? | 10:51 |
Nexus | yeah :/ it's my .conf | 10:53 |
phildawson | tristan, nice work on the contributing.rst, it's *much* more helpful now :) | 10:54 |
Kinnison | That's bad, both that your conf is wrong, and that having a wrong conf can cause a horrible traceback | 10:54 |
Nexus | missing an indent | 10:54 |
Kinnison | Please can you file an issue showing "This bad config causes a nasty traceback" ? | 10:55 |
Nexus | yup | 10:57 |
Nexus | will do | 10:57 |
Nexus | tristan: the fix i posted to sphinx-click for \b not working has now been merged https://github.com/click-contrib/sphinx-click/pull/29#event-1881941544 | 10:58 |
*** bochecha has joined #buildstream | 10:58 | |
*** ahmed89 has quit IRC | 10:59 | |
tristan | Nexus, great :) | 11:03 |
tristan | Nexus, I noticed the other fix landed for pytest-datafiles and recent versions of pytest too | 11:03 |
Nexus | \o/ | 11:04 |
tristan | Would be good to start requiring a new version of those... maybe we need to talk to cs-shadow first and update the CI images | 11:04 |
tristan | I think the \b thing cannot be elegantly, or perfectly handled unfortunately, but it's a start | 11:05 |
tristan | I was thinking, it would be best to add markdown/rst support to upstream click instead | 11:06 |
tristan | So that upstream click could do a *basic* ASCII rendering of markdown help output | 11:06 |
tristan | And the HTML and man page plugins could use that markdown too | 11:06 |
lachlan | tristan: Hi, just to confirm we have updated !836 in light of your comments. | 11:06 |
tristan | Would be much more powerful, but would have to be opt-in in order to not break click API | 11:07 |
tristan | Nexus, but then... I'm just dreaming of a brighter future :) | 11:07 |
Nexus | What are the definitions of the issue labels? Are those written anywhere? | 11:07 |
Nexus | e.g. When is it a bug/enhancement | 11:08 |
Nexus | ? | 11:08 |
gitlab-br-bot | buildstream: merge request (jjardon/pycodestyle->master: WIP: Use pycodestyle instead pep8 python module) #638 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/638 | 11:08 |
tristan | Nexus, So for that there is a labels page on gitlab which lists all the labels and some description sentence... but I think it is a bit of a moving target, I'm leaving that mostly in toscalix's hands | 11:08 |
*** lachlan has quit IRC | 11:10 | |
*** ahmed89 has joined #buildstream | 11:19 | |
*** ahmed89 has quit IRC | 11:21 | |
tpollard | is there a command I can do (maybe a flag on show?) to give me the path where the aritfact is cached? | 11:32 |
tristan | tpollard, Unfortunately not, and I think you mean where it is "extracted", which is considered an internal implementation detail | 11:33 |
tristan | tpollard, I have to wrap up the `bst artifact` command subgroup thread finally, and we will move `bst checkout` to `bst artifact checkout`, which can do better to allow checking out an artifact by a specific key, not only by element.bst | 11:34 |
tristan | tpollard, In the future, we hope that we can remove the extract/ directories entirely, actually | 11:35 |
tpollard | I've got a test that passes artifactdir in via buildstream.conf. bst shows the element is cached/ has a key, but the artifact directory is empty | 11:35 |
tpollard | so I'm trying to work out where it's caching | 11:35 |
tristan | Right, the extract directory is only ever populated when an artifact is *used*, not when it is *cached* | 11:36 |
tristan | tpollard, the files exist in the CAS, and the redundant unpacking of it into an extract/ directory is an implementation detail | 11:36 |
tiagogomes | If we have `artifact checkout`, then we should have `artifact pull` | 11:37 |
tristan | (which juergbi mentioned he would like to remove, I agree, except only it is complicated to do, because of symlink logic at stage time) | 11:37 |
tristan | tiagogomes, That is also covered in the `bst artifact` subgroup thread I believe | 11:37 |
tristan | tiagogomes, but feel free to go over the thread if it is not, I will have to review the whole thread and summarize | 11:38 |
tiagogomes | cool. And we will have `source checkout` and `source fetch` as well? | 11:38 |
tristan | I think those are separate proposals; `bst fetch` itself is already only related to sources | 11:38 |
tristan | source checkout was discussed elsewhere though, indeed | 11:38 |
tpollard | tristan: I'm trying to use remove_artifact_from_cache, from cli.py in the integration tests | 11:38 |
tpollard | *runcli.py | 11:39 |
tristan | tpollard, Yeah I keep questioning the validity of that function :-S | 11:39 |
tristan | It's not using BuildStream codepaths to do what it's doing | 11:39 |
tristan | So far it seems to be "working" | 11:39 |
tpollard | I'm not sure where to go from here | 11:40 |
tristan | tpollard, I don't really have the full context of what you are trying to do | 11:40 |
tristan | Is this a specific existing test case ? is it possible that a cleanup job ran ? | 11:41 |
tpollard | remove an artifact from the cache within a test | 11:41 |
tpollard | get_element_state asserts it's cached | 11:41 |
tristan | When you say that "the artifact directory is empty" | 11:41 |
tristan | What directory is that ? | 11:41 |
tpollard | buildstream.conf has artifactdir: /home/tom/buildstream/integration-cache/artifacts, but there is no artifacts dir there | 11:43 |
tristan | tpollard, As a rule, all test cases never effect the user's home directory or anything | 11:44 |
tristan | tpollard, Look at the state of the directories for the given test, which should be a subdirectory of the buildstream checkout | 11:45 |
tristan | buildstream_checkout/tmp/test_foobar0/... | 11:45 |
*** jonathanmaw_ has joined #buildstream | 11:45 | |
tristan | tpollard, If a test case every writes outside of it's directory, or picks up any configuration from outside of its directory, that in itself is a bug | 11:46 |
tristan | s/every/ever | 11:46 |
*** jonathanmaw has quit IRC | 11:46 | |
gitlab-br-bot | buildstream: merge request (aevri/contributing_fixups->master: Minor fixups to contributing.rst) #866 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/866 | 11:48 |
*** tristan has quit IRC | 11:49 | |
tpollard | the cli integration tests share sources and aritfacts at buildstream/integration-cache it seems | 11:52 |
tpollard | purposely infact | 11:54 |
*** tristan has joined #buildstream | 11:55 | |
gitlab-br-bot | buildstream: issue #698 ("Bad formatting on buildstream.conf results in ugly stacktrace") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/698 | 12:37 |
*** CTtpollard has joined #buildstream | 13:01 | |
*** tpollard has quit IRC | 13:02 | |
*** lachlan has joined #buildstream | 13:43 | |
*** lachlan has quit IRC | 14:08 | |
*** lachlan has joined #buildstream | 14:24 | |
*** lachlan has joined #buildstream | 14:25 | |
*** lachlan has quit IRC | 14:33 | |
*** bochecha has quit IRC | 14:43 | |
*** lachlan has joined #buildstream | 14:44 | |
tiagogomes | If the Makefile is on the root of the sources, is there a way of specifying where it is instead of modifying all commands to handle this | 14:51 |
*** CTtpollard is now known as tpollard | 14:57 | |
tpollard | is anyone aware of any of the currently included test projects/elements that would produce an artifact with a populated buildtree directory? | 14:57 |
tpollard | so that'd be something that builds with a build-root dir | 14:58 |
tiagogomes | command-subdir is what I was looking for | 15:03 |
gitlab-br-bot | buildstream: issue #699 ("invalid buildstream.conf format returns stacktrace") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/699 | 15:18 |
Nexus | I currently have a netcat listener set up with a port on my machine, I have set my buildstream.conf file to point at that as a remote artifact cache. I am doing this in hopes of reproducing https://gitlab.com/BuildStream/buildstream/issues/423. Is this a valid way to test this? Also, pulls seem to hang on `Initializing remote caches`, Does this mean we don't timeout at all if we never get a responce, | 15:20 |
Nexus | but don't get back a `server unreachable` error? | 15:20 |
*** toscalix has quit IRC | 15:42 | |
*** dtf has joined #buildstream | 15:50 | |
*** lachlan has quit IRC | 15:56 | |
*** lachlan has joined #buildstream | 16:01 | |
*** lachlan has quit IRC | 16:14 | |
gitlab-br-bot | buildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/863 | 16:15 |
gitlab-br-bot | buildstream: merge request (willsalmon/outOfSourecBuild->master: Out of source builds) #776 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/776 | 16:15 |
gitlab-br-bot | buildstream: merge request (chandan/bst-and-docker->master: Add documentation and NEWS entry about bst-docker-import) #864 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/864 | 16:16 |
*** finn has joined #buildstream | 16:22 | |
*** lachlan has joined #buildstream | 16:25 | |
*** lachlan has quit IRC | 16:28 | |
gitlab-br-bot | buildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: Add yaml cache testing to yaml tests) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/836 | 16:29 |
*** lachlan has joined #buildstream | 16:29 | |
*** lachlan has quit IRC | 16:39 | |
*** bochecha has joined #buildstream | 16:40 | |
*** catonano has quit IRC | 16:48 | |
*** finn has quit IRC | 16:52 | |
gitlab-br-bot | buildstream: merge request (chandan/source-checkout->master: WIP: Add `bst source-checkout` command) #820 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/820 | 16:55 |
gitlab-br-bot | buildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/786 | 17:01 |
*** lachlan has joined #buildstream | 17:18 | |
*** Prince781 has joined #buildstream | 17:20 | |
*** finn has joined #buildstream | 17:29 | |
*** finn has quit IRC | 17:37 | |
*** finn has joined #buildstream | 17:44 | |
*** finn has quit IRC | 17:47 | |
*** Prince781 has quit IRC | 17:52 | |
gitlab-br-bot | buildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/863 | 18:25 |
*** lachlan has quit IRC | 18:48 | |
gitlab-br-bot | buildstream: merge request (chandan/fix-bst-docker-import-logging->master: bst-docker-import: Consistently use stderr for all logs) #863 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/863 | 18:58 |
*** lachlan has joined #buildstream | 19:04 | |
*** lachlan has quit IRC | 19:15 | |
*** rdale has quit IRC | 19:21 | |
*** catonano has joined #buildstream | 19:49 | |
*** finn has joined #buildstream | 19:51 | |
*** jonathanmaw_ has quit IRC | 19:52 | |
*** alatiera_ has quit IRC | 20:50 | |
*** bochecha has quit IRC | 21:13 | |
*** catonano has quit IRC | 21:32 | |
*** catonano has joined #buildstream | 23:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!