IRC logs for #buildstream for Wednesday, 2018-09-12

*** xjuan has quit IRC00:45
*** tristan has joined #buildstream05:25
paulsher1oodrobjh: or borrow a moonshot sled, or use packet.net or other arm cloud06:46
paulsher1oodthe pi route will likely be quite slow to build06:47
paulsher1oodin case it's not obvious, the reason bst projects are normally native (not cross) is that it avoids having to carry differences in impelementation higher up the stack. normally all arch-specific or device-specific patches can stay in the 'bsp'06:48
*** iker has joined #buildstream07:07
*** tristan has quit IRC07:16
*** toscalix has joined #buildstream07:49
qinustyhttps://xkcd.com/2044/ slight relevance08:01
*** tristan has joined #buildstream08:11
*** bochecha has joined #buildstream08:25
*** rdale has joined #buildstream08:30
*** WSalmon_ has joined #buildstream09:02
*** toscalix_ has joined #buildstream09:03
*** WSalmon has quit IRC09:03
*** jonathanmaw has joined #buildstream09:04
*** CTtpollard has joined #buildstream09:04
*** tpollard has quit IRC09:05
*** abderrahim has quit IRC09:12
*** abderrahim has joined #buildstream09:13
tlater[m]Oh, we have pytest-timeout now?09:22
tlater[m]Nice, that should help debugging :)09:22
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76509:26
*** lachlan has joined #buildstream09:27
*** toscalix_ has quit IRC09:36
tlater[m]Would someone mind giving https://gitlab.com/BuildStream/buildstream-docker-images/merge_requests/53 a quick review? Sam was nice enough to do so already, so it's close to merging.09:37
*** lachlan has quit IRC09:41
*** lachlan has joined #buildstream09:52
*** toscalix_ has joined #buildstream09:53
tlater[m]jjardon: I see you recently updated some of the docker image dependencies09:56
tlater[m]Is there any reason you added bubblewrap and fuse to the artifact server dependencies? To my knowledge we need neither for just a cache09:57
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76510:02
Nexustlater[m]: i'll have a scan10:03
qinustyCan I get a review of https://gitlab.com/BuildStream/buildstream/merge_requests/765? This is up for a backport consideration also. (1.2.1 maybe?)10:04
tlater[m]Thanks Nexus :)10:04
qinustyDuring the work I came across a comment I've noted here https://gitlab.com/BuildStream/buildstream/merge_requests/765#note_100063057. Perhaps someone knows something regarding the origin of this comment?10:04
tiagogomesqinusty git blame?10:05
* Nexus always recommends resolvinf git issues using `git push <remote_name> :<branch_name>`10:06
qinustyIndeed. Looking at the commit which the comment was added. It's most likely an interpretation issue. But perhaps it needs clarifying.10:06
Nexus*results may vary*10:06
*** lachlan has quit IRC10:09
*** lachlan has joined #buildstream10:14
jjardontlater[m]: mmm, probably an overuse of sed? I should not have touched the artifact-server folder. Let me check10:15
*** toscalix_ has quit IRC10:19
*** lachlan has quit IRC10:20
*** lachlan has joined #buildstream10:21
qinustytristan, re: accessing protected members outside of class scope. Is this not checked in pylint?10:29
tristanqinusty, It's not; because we currently cannot follow the standard to the letter10:35
qinustyAh okay, so we /could/ enable it10:36
tristanWe have functions that are API private (not a part of stable public facing API), but need to be called by BuildStream internals10:36
tristanMy last email the list illustrates a possible avenue to allow such linting, at the bottom of the email10:36
tristanI actually considered having ElementController, SourceController, etc... at the beginning10:37
tristanBut thought it was just overkill10:37
qinustySeems like a reasonable idea. We only really have those two public API surfaces10:37
jjardontlater[m]: looking at the commit, I left there what are the current hard dependecies of buildstream. If the artifact cache have different dependencies maybe we should document those somewhere (and then use the artifact-cache installation commands to create the docker image)?10:40
tlater[m]jjardon: We have this page: https://buildstream.gitlab.io/buildstream/install_artifacts.html10:41
tristanqinusty, we have Sandbox also, which is not publicly subclassable but has the same problems10:41
tlater[m]It does in fact not list the dependencies10:41
tlater[m]I'll write an issue about this, seeing as I'm trying to debug something else right now. I do think the dependencies are different, but it seems that we've neglected to document this.10:42
jjardontlater[m]: seems we already use "BST_ARTIFACTS_ONLY=1 pip3 install ." to create the docker image, so that is done10:42
jjardontlater[m]: yeah, let's open an issue so we do not forget10:42
*** tristan has quit IRC10:45
*** lachlan has quit IRC10:46
*** lachlan has joined #buildstream10:48
gitlab-br-botbuildstream: issue #648 ("Dependencies for a pure artifact server are undocumented") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/64810:49
*** lachlan has quit IRC11:01
*** toscalix_ has joined #buildstream11:01
*** lachlan has joined #buildstream11:05
tlater[m]qinusty: Looks like you're the person to talk to about website contents in absence of toscalix_ - is there an overview of topics that we want to be covered?11:10
qinustyThe feature page lists features which are to be included. Some are not detailed. tlater[m],11:12
qinustyIf you can elaborate on any of these, feel free.11:13
*** lachlan has quit IRC11:13
tiagogomestlater[m] I think there is an issue created for every page which describes the content he wanted there11:19
tlater[m]I've seen the issues, they're just a bit hard to navigate11:20
tlater[m]Lots of empty ticks, which is scary, heh11:20
tlater[m]But "features page" is a good pointer, thanks qinusty11:20
qinustyIndeed, I think toscalix is around11:21
*** jonathanmaw_ has joined #buildstream11:21
*** jonathanmaw has quit IRC11:21
toscalix_tlater[m]: was talking to qinusty about it11:30
toscalix_he will talk to you11:31
toscalix_about the contents left t be done: feature page and known issues page11:31
*** lachlan has joined #buildstream11:31
toscalix_buildstream in detail can wait11:31
toscalix_we will do it the coming days11:31
gitlab-br-botbuildstream: issue #649 ("Artifact cache file can get stale") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/64911:32
gitlab-br-botbuildstream: merge request (tiagogomes/issue-573->master: Reduce IO overhead caused by artifact cache size calculation) #671 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/67111:36
adds68When you bst shell on a failed element, does that checkout the log files that were generated when it failed?11:39
tlater[m]Do we have a spell check run planned for the website as well?11:40
tlater[m]adds68: Unless this has changed, log files are simply kept in .cache and never touched by buildstream.11:40
adds68tlater[m], so when you enter the shell on a failed build that is a clean sandbox?11:41
adds68tlater[m], as for example i can see a config.log, which has errors, so i'm wondering if these errors are what have been generated when bst has tried to build it11:42
tlater[m]adds68: Ah, no, that is not a clean sandbox11:42
tlater[m]I thought you meant the log files buildstream generates - the log files generated by the build tool will be in the sandbox11:43
tlater[m]You see the dirty, failed build in that sandbox.11:43
adds68tlater[m], ta :)11:43
tlater[m]qinusty: I assume you only want detail to be added to the little features table on the features page.11:52
*** toscalix_ has quit IRC11:58
*** alatiera_ has joined #buildstream12:13
tlater[m]qinusty: Is this sort of what you were looking for? https://gitlab.com/BuildStream/website/commit/ab0b9d50340ef0691a71d9c110b39847bd955b1d12:29
gitlab-br-botbuildstream: merge request (tiagogomes/issue-573->master: Reduce IO overhead caused by artifact cache size calculation) #671 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/67112:30
tlater[m]juergbi: Sorry to prod, but do you intend to write the section on CAS on that page?12:42
* tlater[m] is quite happy to take on writing that if you're too busy this week12:46
juergbitlater[m]: I would certainly not mind passing this on to you12:48
tlater[m]juergbi: I'll get you to review, then :)12:49
juergbithanks a lot12:49
*** rdale has quit IRC12:53
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76512:54
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76512:54
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76512:54
qinustyApologies for spam, gitlab autoclose issue detection is not quite as predictable as I had hoped... And it doesn't show in preview12:55
gitlab-br-botbuildstream: merge request (richardmaw/builddir-sockets->master: Fix: While caching build artifact: "Cannot extract [path to socket file] into staging-area. Unsupported type.") #783 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78312:57
gitlab-br-botbuildstream: merge request (tiagogomes/issue-573->master: Reduce IO overhead caused by artifact cache size calculation) #671 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/67112:58
robjhthe other i managed to build a kernel using the tlater/image-authoring branch. today im trying to replicate the success on aarch64 using a moonshot sled. But it fails with an error suggesting that its trying to run a shell binary for x86;13:20
robjh            sed -i 's|#!/bin/bash|#!/bin/ash|' scripts/config13:20
robjh        bwrap: execvp sh: Exec format error13:20
robjhIve tired changing all references to x86{,_64} to aarch64. ive tried changing the url specified in elements/contents/alpine.bst to the aarch64 download. And ive tried removing the cache in ~/.cache/buildstream13:20
tlater[m]This is during the linux kernel compilation...13:21
robjhyep13:21
tlater[m]robjh: One complexity of this process is that there are actually two base images in use13:22
robjhat the start, as its setting up its config file13:22
robjhtlater[m], i didnt realise that13:22
tlater[m]One to build the image, and one to place on the image13:22
tlater[m]The alpine element is only placed on the image, so setting it to aarch64 is irrelevant13:22
tlater[m]You'll need to change the docker image13:22
robjhi see. `find . -name *docker*` isnt giving me any results13:23
* tlater[m] checks the branch and sees if he can fix that13:23
tlater[m]I think it was bluntly named base.bst or something13:23
* tlater[m] is happy it's working well on x86 though 😆13:24
robjhi see that file. but im unsure of what to change in there :x13:24
robjhim happy youre happy :)13:25
tlater[m]It's going to be a learning experience for both of us then! I didn't intend for this to run on anything but x86, btw, I'm not sure if our image plugin will support this.13:25
tlater[m]robjh: Alright, so this is not currently possible with the docker image13:27
tlater[m]We don't build an aarch64 version of that particular image (presumably because it explicitly says x86image)13:28
robjhis it possible to specify a different docker image? (an arm based one)13:28
tlater[m]Yes, but you will first need to create such a docker image13:28
robjhi see that it's using buildstream/image-tools. where can i find that?13:29
tlater[m]I'm also unsure if you can use a local docker image, so you may need to build one and push it to dockerhub...13:30
tlater[m]Let me link you to our docker image repo13:30
robjhdocker on arm is a thing, i'd be surprised if there isnt a slimmed down image out there already13:31
tlater[m]robjh: This is the source for this: https://gitlab.com/BuildStream/buildstream-docker-images/tree/master/image-tools13:31
robjhcool, thank you13:31
tlater[m]robjh: If you can get that to build on arm, our CI supports arm builds. Presumably enabling that should just be a small change to the CI config there. It will automatically upload to dockerhub.13:32
robjhlet me have a look13:32
tlater[m]After that you'll just need to change the tag used by `base.bst`13:32
tlater[m]tiagogomes: On the known issues page... Do you have any bright ideas for displaying a (closed) thing next to issue links?13:36
tlater[m]I think it can be done quite easily with some embedded javascript, but obviously that won't work if javascript is disabled. Not sure how big of an issue that is.13:37
tiagogomesUse gitlab API?13:37
tlater[m]Yep, it's just one ajax call from what I can tell.13:38
tiagogomesAnd an pelican extension to use it13:38
tiagogomesAs is being done for releases13:38
tlater[m]Right, I haven't looked into pelican extensions yet.13:38
*** lachlan has quit IRC13:40
Nexusjuergbi: Would you be able to look at the latest commit on https://gitlab.com/BuildStream/buildstream/merge_requests/726 for me pls?13:48
tiagogomesMe neither. I only know they exist and valentind used one to full up the releases page13:48
tiagogomess/full/fill13:48
tlater[m]tiagogomes: Looking further into it, this seems to be a markdown extension13:49
juergbiNexus: I wrote a couple of comments ten minutes ago, you saw those already?13:49
tlater[m]So one way to do this would be to mimick gitlab and allow people to link to issues with buildstream#25613:49
valentindtlater[m], What do you need as extension?13:49
tlater[m]valentind: We want to be able to see a little (closed) message next to links to buildstream issues when they are closed13:50
tlater[m]I'm thinking about the best way to do this...13:50
tlater[m]I don't think a markdown extension is a bad idea, but I think transforming buildstream#issue_num -> #issue_num is probably better.13:50
valentindIs there a  markdown extension that already exist for that?13:51
tlater[m]Good question13:53
* tlater[m] checks13:53
valentindOtherwise, making a markdown extension should be quick.13:54
tlater[m]Yeah, I've had a look through your table extension13:55
tlater[m]It doesn't seem too hard13:55
valentindAnd then use that: https://docs.gitlab.com/ee/api/issues.html13:56
Nexusjuergbi: i hadn't refreshed :) mb13:56
tlater[m]GET /projects/:id/issues/:issue_iid is all we need, actually13:56
*** lachlan has joined #buildstream13:57
tlater[m]We could even do fun things such as display the number of comments, or last update date13:57
tlater[m]Perhaps in a mouseover thing13:57
*** WSalmon_ has quit IRC13:58
valentindI would put the title of the issue as anchor title.13:58
valentindSo that the mouseover shows the title of the issue.13:58
*** WSalmon has joined #buildstream13:58
tiagogomesI wouldn't lose time making it very fancy. The existence of a known issues page is quite debatable13:59
tlater[m]That is probably better, yes13:59
*** toscalix_ has joined #buildstream14:00
Nexusjuergbi: please can you quickly confirm or correct my question on the MR? :)14:00
tlater[m]Looks like gitlab's own extensions are all vue-specific14:00
tiagogomes~~~~~~~ tristan can you review https://gitlab.com/BuildStream/buildstream/merge_requests/671 before it becomes bit rot again :) commit-by-commit review is recommended14:02
*** ikerperez has joined #buildstream14:04
*** ikerperez has quit IRC14:04
juergbiNexus: replied14:13
Nexusjuergbi: thanks :D14:13
*** rdale has joined #buildstream14:15
*** lachlan has quit IRC14:16
*** toscalix_ has quit IRC14:17
*** lachlan has joined #buildstream14:23
*** lachlan has quit IRC14:26
toscalixadded sept. 30th as fosdem 2019 dev room announcement date to the calendar14:37
gitlab-br-botbuildstream: merge request (tiagogomes/issue-287-backport->bst-1.2: Backport of !678 (Add validation of configuration variables) to 1.2 branch.) #789 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78914:40
gitlab-br-botbuildstream: issue #650 ("RFE: Add plugin to generate snaps") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/65014:41
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76514:44
*** lachlan has joined #buildstream14:45
toscalixI also added the lightning talks deadline14:46
toscalixIf you want to receive alerts, go to the calendar and add yourself to the event.14:47
gitlab-br-botbuildstream: merge request (richardmaw/test-config-fixes->master: Fix tests that attempt to access the home directory) #780 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78014:47
toscalixLink to calendar: https://calendar.google.com/calendar/embed?src=codethink.co.uk_mpgah0uj538hnbsf4l7b4rchts%40group.calendar.google.com&ctz=Europe%2FMadrid14:49
gitlab-br-botbuildstream: merge request (jjardon/pycodestyle->master: WIP:  Use pycodestyle instead pep8 python module) #638 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/63814:49
gitlab-br-botbuildstream: merge request (jjardon/pycodestyle->master: WIP:  Use pycodestyle instead pep8 python module) #638 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/63814:50
qinustyhttps://gitlab.com/BuildStream/buildstream/merge_requests/765 is ready for review. Rebased to latest master.14:52
gitlab-br-botbuildstream: merge request (jjardon/pycodestyle->master: WIP:  Use pycodestyle instead pep8 python module) #638 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/63814:52
*** lachlan has quit IRC15:02
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78615:05
*** lachlan has joined #buildstream15:16
gitlab-br-botbuildstream: merge request (mac_fixes->master: WIP: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/72615:20
*** lachlan has quit IRC15:25
qinustyI'm not going to get through all of these commits today tiagogomes, but I've dropped a few things I picked up on15:38
*** lachlan has joined #buildstream15:41
tiagogomesqinusty thanks, what do you mean by "This can be removed."?15:44
qinustyWe do not need 'pass' when there is another line of code there. tiagogomes15:45
tiagogomesah, indeed15:46
gitlab-br-botbuildstream: merge request (jonathan/pickle-yaml->master: WIP: Add a cache of parsed and provenanced yaml) #787 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78715:52
*** lachlan has quit IRC16:39
*** toscalix has quit IRC16:49
*** jonathanmaw_ has quit IRC17:05
*** lachlan has joined #buildstream17:17
*** lachlan has quit IRC17:23
*** lachlan has joined #buildstream17:39
*** rdale has quit IRC18:16
gitlab-br-botbuildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/76518:19
*** tristan has joined #buildstream18:24
*** xjuan has joined #buildstream18:27
*** lachlan has quit IRC18:28
*** lachlan has joined #buildstream18:42
*** xjuan has quit IRC19:01
*** lachlan has quit IRC19:22
gitlab-br-botbuildstream: merge request (valentindavid/cargo_plugin->master: WIP: Add source plugin for cargo.) #790 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/79020:14
*** bochecha has quit IRC20:20
*** xjuan has joined #buildstream20:53
gitlab-br-botbuildstream: merge request (mac_fixes->master: WIP: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/72623:04

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!