| *** rdale has quit IRC | 01:37 | |
| *** tristan has quit IRC | 06:34 | |
| *** tristan has joined #buildstream | 06:57 | |
| tristan | tlater[m], I'm noticing now that you have added a lot of private methods related to this cache size stuff, which are in fact not private and called from all over the place | 07:12 |
|---|---|---|
| * tristan is untangling all of this because the biggest problem seems to be the messaging around the APIs and what they do | 07:13 | |
| tristan | (well, biggest problem related to the remaining false ERROR after fixing the crashes/corruption) | 07:13 |
| *** tristan has quit IRC | 08:02 | |
| tlater[m] | tristan: Could you point me to the specific file? | 08:03 |
| *** abderrahim has quit IRC | 09:10 | |
| *** abderrahim has joined #buildstream | 09:10 | |
| *** leopi has joined #buildstream | 09:12 | |
| *** bochecha has joined #buildstream | 09:16 | |
| *** tristan has joined #buildstream | 09:20 | |
| *** bochecha_ has joined #buildstream | 09:20 | |
| *** bochecha has quit IRC | 09:20 | |
| *** leopi has quit IRC | 09:58 | |
| tristan | Mkay, now I get a whole new set of errors from pylint, great ! | 10:19 |
| tristan | how reliable | 10:19 |
| *** bochecha_ has quit IRC | 10:20 | |
| tristan | ArtifactCache <--> CasCache has become a mangled pile of spaghetti :'( | 10:22 |
| *** toscalix has joined #buildstream | 10:26 | |
| *** toscalix has quit IRC | 10:35 | |
| * tristan is blinking in disbelief at just how bad this code is... ArtifactCache.cache_size... AND ArtifactCache.estimated_size, and code littered around CasCache, Queue/Job implementations, Even the base Queue class; which arbitrarily decide to set either of the two variables, which belongs to ArtifactCache; without even marshalling that through a mutator function on the ArtifactCache | 10:55 | |
| tristan | This is just... wow. | 10:55 |
| tristan | And now the API documenting comments are spread out between ArtifactCache and CasCache ? Man... ArtifactCache.remove() is documented to not return anything, yet CasCache returns something and *redocuments it*, and worse, ArtifactCache actually *observes* the return value | 10:58 |
| tristan | Make up your mind, is remove() an implementation of an ArtifactCache method ? Or is it an implementation detail of CasCache ? because it *cannot* be both | 10:59 |
| tristan | remove() at the CAS level exposes 'defer' prune, which means prune is effectively an API detail of ArtifactCache; so CasCache.prune() *must* be an implementation of an ArtifactCache virtual method | 11:00 |
| *** bochecha has joined #buildstream | 11:00 | |
| *** slaf has quit IRC | 11:20 | |
| *** bochecha has quit IRC | 11:21 | |
| *** slaf has joined #buildstream | 11:26 | |
| *** tristan has quit IRC | 11:28 | |
| *** bochecha has joined #buildstream | 11:40 | |
| gitlab-br-bot | buildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/765 | 13:03 |
| *** dtf has joined #buildstream | 13:26 | |
| *** dtf has joined #buildstream | 13:26 | |
| bochecha | !!!!! | 15:51 |
| bochecha | I tried editing a file in Gitlab, thinking it would create a merge request | 15:51 |
| bochecha | and Gitlab just committed in master :o | 15:51 |
| bochecha | oh wow, I'm sorry | 15:52 |
| bochecha | I really didn't expect that to happen | 15:52 |
| bochecha | https://gitlab.com/BuildStream/bst-external/commit/c3ee165980a1476b4f5accf580fda8ae696ed4cf | 15:52 |
| *** alatiera_ has joined #buildstream | 15:56 | |
| *** bochecha has quit IRC | 16:16 | |
| gitlab-br-bot | buildstream: merge request (Qinusty/skipped-rework->master: Add SkipError for indicating a skipped activity) #765 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/765 | 16:40 |
| gitlab-br-bot | buildstream: merge request (coldtom/autotools-libtool->master: Upstream freedesktop-sdk autotools config for libtool .la files) #683 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/683 | 17:54 |
| jjardon | valentind: can you please review https://gitlab.com/BuildStream/buildstream/merge_requests/683 ? | 17:56 |
| *** bochecha has joined #buildstream | 18:03 | |
| gitlab-br-bot | buildstream: merge request (coldtom/autotools-libtool->master: Upstream freedesktop-sdk autotools config for libtool .la files) #683 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/683 | 20:06 |
| gitlab-br-bot | buildstream: merge request (coldtom/autotools-libtool->master: Upstream freedesktop-sdk autotools config for libtool .la files) #683 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/683 | 20:07 |
| *** alatiera_ has quit IRC | 20:51 | |
| *** bochecha has quit IRC | 22:13 | |
| gitlab-br-bot | buildstream: merge request (coldtom/strip-rules->master: WIP: Upstream freedesktop-sdk strip rules) #750 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/750 | 22:39 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!