| gitlab-br-bot | buildstream: merge request (chandan/setup.py-metadata->master: setup.py: Add more metadata useful for PyPI) #718 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/718 | 00:03 |
|---|---|---|
| gitlab-br-bot | buildstream: merge request (chandan/pypi-badge->master: README.rst: Add status badges for PyPI release and Python versions) #719 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/719 | 00:20 |
| *** leopi has joined #buildstream | 00:54 | |
| gitlab-br-bot | buildstream: merge request (chandan/ci-sdist-test->master: .gitlab-ci.yml: Verify that source tarball installs correctly) #720 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/720 | 02:11 |
| gitlab-br-bot | buildstream: merge request (chandan/ci-sdist-test->master: .gitlab-ci.yml: Verify that source tarball installs correctly) #720 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/720 | 02:12 |
| *** leopi has quit IRC | 03:52 | |
| *** leopi has joined #buildstream | 04:18 | |
| *** alatiera_ has joined #buildstream | 04:56 | |
| *** alatiera_ has quit IRC | 05:36 | |
| *** tristan has joined #buildstream | 05:55 | |
| *** ChanServ sets mode: +o tristan | 05:55 | |
| *** noisecell has joined #buildstream | 06:18 | |
| *** alatiera_ has joined #buildstream | 06:20 | |
| *** kim has joined #buildstream | 06:26 | |
| gitlab-br-bot | buildstream: merge request (chandan/ci-sdist-test->master: .gitlab-ci.yml: Verify that source tarball installs correctly) #720 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/720 | 06:42 |
| gitlab-br-bot | buildstream: merge request (valentindavid/cli_integration_source_determinism->master: tests/integration/source-determinism.py: Use cli_integration.) #715 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/715 | 06:48 |
| gitlab-br-bot | buildstream: merge request (Qinusty/597-non-alias-url-fix->master: Fix ValueError traceback for URL without alias or URI scheme) #700 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/700 | 07:03 |
| gitlab-br-bot | buildstream: merge request (Qinusty/597-non-alias-url-fix->master: Fix ValueError traceback for URL without alias or URI scheme) #700 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/700 | 07:03 |
| *** kim_ has joined #buildstream | 07:11 | |
| *** kim has quit IRC | 07:11 | |
| *** kim_ is now known as kim | 07:11 | |
| *** kim has quit IRC | 07:13 | |
| *** kim has joined #buildstream | 07:13 | |
| *** finn has joined #buildstream | 07:17 | |
| *** mohan43u has quit IRC | 07:19 | |
| *** mohan43u has joined #buildstream | 07:20 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/cli_integration_source_determinism->master: tests/integration/source-determinism.py: Use cli_integration.) #715 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/715 | 07:36 |
| *** shibualex has joined #buildstream | 07:37 | |
| *** shibualex has quit IRC | 07:37 | |
| *** shibualex has joined #buildstream | 07:38 | |
| gitlab-br-bot | buildstream: merge request (tristan/integration-cli-source-determinism->bst-1.2: tests/integration/source-determinism.py: Use cli_integration.) #721 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/721 | 07:42 |
| *** kim has quit IRC | 07:55 | |
| gitlab-br-bot | buildstream: merge request (tristan/avoid-redundant-alpine->master: tests/integration/project: Use the same alias for the alpine tarball) #722 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/722 | 07:56 |
| *** WSalmon has quit IRC | 08:06 | |
| *** toscalix has joined #buildstream | 08:16 | |
| gitlab-br-bot | buildstream: merge request (tristan/integration-cli-source-determinism->bst-1.2: tests/integration/source-determinism.py: Use cli_integration.) #721 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/721 | 08:21 |
| *** rdale has joined #buildstream | 08:22 | |
| *** kim has joined #buildstream | 08:26 | |
| *** kim has quit IRC | 08:31 | |
| *** tpollard has joined #buildstream | 08:32 | |
| *** WSalmon has joined #buildstream | 08:34 | |
| gitlab-br-bot | buildstream: merge request (tristan/avoid-redundant-alpine->master: tests/integration/project: Use the same alias for the alpine tarball) #722 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/722 | 08:39 |
| *** shibualex has quit IRC | 08:47 | |
| *** shibualex has joined #buildstream | 08:48 | |
| gitlab-br-bot | buildstream: merge request (tristan/avoid-redundant-alpine-1.2->bst-1.2: tests/integration/project: Use the same alias for the alpine tarball) #723 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/723 | 08:56 |
| *** kim has joined #buildstream | 09:01 | |
| *** kim has quit IRC | 09:05 | |
| *** shibualex_ has joined #buildstream | 09:08 | |
| *** shibualex has quit IRC | 09:10 | |
| *** shibualex_ is now known as shibualex | 09:13 | |
| *** jonathanmaw has joined #buildstream | 09:15 | |
| *** flatmush has quit IRC | 09:23 | |
| *** flatmush has joined #buildstream | 09:26 | |
| *** ironfoot has quit IRC | 09:29 | |
| *** ironfoot has joined #buildstream | 09:30 | |
| gitlab-br-bot | buildstream: merge request (tristan/avoid-redundant-alpine-1.2->bst-1.2: tests/integration/project: Use the same alias for the alpine tarball) #723 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/723 | 09:30 |
| gitlab-br-bot | buildstream: merge request (jennis/correct_HACKING->master: '-k' flag not needed to run individual tests) #714 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/714 | 09:42 |
| gitlab-br-bot | buildstream: merge request (jmac/tempfile-extraction-bug->master: Correct crash after staging tars with read-only directories) #713 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/713 | 09:51 |
| gitlab-br-bot | buildstream: merge request (jennis/correct_HACKING->master: '-k' flag not needed to run individual tests) #714 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/714 | 09:58 |
| *** noisecell has quit IRC | 09:58 | |
| *** noisecell has joined #buildstream | 09:58 | |
| adds68 | Is there a way to extend an option set in project.conf? | 09:59 |
| *** Benjamin has joined #buildstream | 09:59 | |
| adds68 | I want to set something like CXXFLAGS: "xyz" and then extend those default later on based on some conditional using (?) | 10:00 |
| tpollard | adds68: list append? | 10:01 |
| coldtom | unfortunately CXXFLAGS aren't a list | 10:03 |
| jennis | jmac, are we ok with the fact that this is going to take that much more time for read-only dirs/files? I'm happy to merge !713 | 10:03 |
| coldtom | it's just one variable | 10:03 |
| adds68 | tpollard, yea as coldtom said they just a scalar | 10:04 |
| jennis | As I said before, the patch hasn't effected 'regular' rootfs tarball's | 10:04 |
| adds68 | tpollard, so was wondering if you could append strings maybe | 10:04 |
| jmac | jennis: I don't think we have any other option at the moment | 10:05 |
| jennis | jmac agreed | 10:05 |
| jmac | I'm waiting to see if the CI passes. I've put in the str() fix you suggested | 10:05 |
| jmac | Then I think we can merge it | 10:05 |
| jennis | :) | 10:05 |
| jennis | jmac, it'll merge when the pipeline succeeds | 10:12 |
| jmac | Thanks! | 10:12 |
| jennis | No, thank you! | 10:13 |
| gitlab-br-bot | buildstream: merge request (jjardon/ci_show_timings->master: .gitlab-ci.yml: Show timing of the 20 slowest tests) #716 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/716 | 10:15 |
| *** Benjamin has left #buildstream | 10:19 | |
| *** Benjamin has joined #buildstream | 10:20 | |
| gitlab-br-bot | buildstream: merge request (chandan/pip-install-instructions->master: doc: Add instructions to install BuildStream via PyPI) #717 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/717 | 10:20 |
| *** benschubert has joined #buildstream | 10:21 | |
| *** benschubert has quit IRC | 10:22 | |
| *** benschubert has joined #buildstream | 10:23 | |
| *** Benjamin has quit IRC | 10:26 | |
| gitlab-br-bot | buildstream: merge request (jmac/tempfile-extraction-bug->master: Correct crash after staging tars with read-only directories) #713 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/713 | 10:31 |
| jmac | woo | 10:32 |
| jennis | <o/ | 10:32 |
| *** tristan has quit IRC | 10:32 | |
| jennis | Like a salute | 10:33 |
| *** tristan has joined #buildstream | 10:33 | |
| *** ChanServ sets mode: +o tristan | 10:33 | |
| gitlab-br-bot | buildstream: merge request (jennis/correct_HACKING->master: '-k' flag not needed to run individual tests) #714 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/714 | 10:34 |
| Nexus | what was the fix for pylint tests starting to fail a couple of days ago? | 10:37 |
| tristan | valentind, jjardon ... I think you guys upgraded the freedesktop-sdk artifact cache yesterday... can you please ensure that the GNOME artifact cache also gets an upgrade ? | 10:38 |
| tristan | Nexus, it was to pin the exact version of pylint to use, and to require a newer version of pytest (I *think* it was >= 3.7) | 10:38 |
| tristan | Nexus, the problem was not happening in CI afaik, but it seemed that that version of pytest worked with pylint for most/all users, if it's failing in another setup then we need to investigate more | 10:40 |
| tristan | pinning pylint to an exact version is pretty important, though | 10:40 |
| benschubert | Hey everyone! I'd be looking for an issue to pick, is there one that would be more important/urgent/better than others? :) | 10:41 |
| Nexus | kk, once i've finished this test run, i'll rebase and upgrade to 3.7 and see if that fixes it for me | 10:41 |
| qinusty | Nexus, something something should've used emacs ;) | 10:41 |
| Nexus | benschubert: how big a project you wanting? | 10:42 |
| benschubert | Ideally something that could get implemented in half a day or something that can take longer but is not very urgent | 10:43 |
| valentind | tristan, I think jjardon can do that. I do not have access. | 10:44 |
| Nexus | issue 594 maybe? | 10:44 |
| benschubert | nexus, that seems good! The issue is _just_ about adding the correct logging correct? | 10:45 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-287->master: Add validation of configuration variables) #678 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/678 | 10:45 |
| Nexus | i believe so | 10:45 |
| benschubert | perfect, thanks! | 10:46 |
| Nexus | np, best of luck | 10:46 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-287->master: Add validation of configuration variables) #678 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/678 | 10:46 |
| Nexus | holla if you need help | 10:46 |
| benschubert | tristan, also I had to add another patch for https://gitlab.com/BuildStream/buildstream/merge_requests/702 and I don't know if that's something you'd like to see in the codebase when you have time to give it a look :) | 10:47 |
| Nexus | tristan: that SEEMED to fix my pylint issues :) ty | 10:52 |
| tristan | valentind, ok I will be dropping off the planet momentarily, please make sure to find jjardon or whoever has access to do that | 10:52 |
| tristan | Nexus, yeah; it's hard to tell if it works for everyone :-S | 10:52 |
| Nexus | tristan: when will you be back with us? i'll have something i'd like you to look at soon | 10:52 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #724 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/724 | 10:53 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #724 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/724 | 10:54 |
| tristan | benschubert, I've been looking through issues, and am about to go for dinner, there are a lot of hot topics but I think they are all assigned for the time being... I am *definitely* missing something but it's hard to dig right now | 10:54 |
| benschubert | Sure, thanks a lot, I'll work on 594 right now | 10:54 |
| benschubert | Also, I saw the problem with the slow tests. None of the tests are run in parallel, is there an inherent blocker for that? Would that be a wanted feature? | 10:55 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #725 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/725 | 10:57 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->mac_fixes: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #725 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/725 | 10:57 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #725 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/725 | 10:59 |
| valentind | tristan, jjardon is on holiday now. | 10:59 |
| * Nexus is getting very upset with gfitlab rn | 10:59 | |
| valentind | Maybe I should tell people on #release-team | 10:59 |
| gitlab-br-bot | buildstream: merge request (575-os-sched_getaffinity-not-supported-on-macosx-blocks-411->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #725 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/725 | 10:59 |
| gitlab-br-bot | buildstream: merge request (mac_fixes->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/726 | 11:02 |
| gitlab-br-bot | buildstream: merge request (mac_fixes->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/726 | 11:04 |
| gitlab-br-bot | buildstream: merge request (mac_fixes->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/726 | 11:06 |
| gitlab-br-bot | buildstream: merge request (mac_fixes->master: WIP: Resolve "os.sched_getaffinity() not supported on MacOSX Blocks #411") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/726 | 11:07 |
| tristan | valentind, :-/ | 11:11 |
| tristan | valentind, have we validated that jjardon did not upgrade the server yesterday ? | 11:11 |
| tristan | valentind, damn situation :-S | 11:11 |
| valentind | tristan, I have updated the freedesktop sdk cache. | 11:11 |
| valentind | But not cache server from gnome. | 11:12 |
| tristan | the client gracefully just fails to upload/download artifacts right ? | 11:13 |
| tristan | iirc the ugly stack trace is only on the server | 11:13 |
| tristan | So, I guess we just live with horrible performance for the weekend... but it would be good to find jjardon and figure out who he has given access to | 11:14 |
| tristan | Probably there is a release this weekend, so it really... sucks :'( | 11:14 |
| valentind | tristan, There are two different stacks. | 11:15 |
| valentind | One on the client, one on the server | 11:15 |
| gitlab-br-bot | buildstream: merge request (jennis/correct_HACKING->master: '-k' flag not needed to run individual tests) #714 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/714 | 11:15 |
| tristan | juergbi, the client which "doesnt work" with older artifacts... does so with a stack trace and bug ?? | 11:15 |
| tristan | ouch | 11:15 |
| tristan | talk about rushing in an unready fix at the last minute before release | 11:16 |
| valentind | It is when using the newer client by the way. | 11:16 |
| valentind | Newer client onto older server. | 11:16 |
| tristan | valentind, exactly | 11:16 |
| juergbi | the old server doesn't provide reasonable error codes, unfortunately | 11:16 |
| juergbi | I fixed this but obviously couldn't fix the old server | 11:16 |
| tristan | we just introduced a fix which breaks compat, where the new client barfs instead of elegantly failing | 11:16 |
| * tristan heads out... and hopes for the world to fall on its feet in my absence | 11:17 | |
| juergbi | I did check with jjardon yesterday, though :/ | 11:18 |
| benschubert | is there any place in the tests where the cli is tested with a real artifact cache that I could get inspired by? | 11:19 |
| juergbi | benschubert: depends on what you mean with real. the CI tests spin up their own local artifact server, they don't contact external ones | 11:19 |
| juergbi | e.g., tests/frontend/push.py and tests/frontend/pull.py | 11:20 |
| benschubert | I want to make sure that a SKIPPED is sent when the object to build is not in the cache, what would be the best way for it? | 11:20 |
| juergbi | yes, push.py should be the right place for this | 11:20 |
| benschubert | ok perfect :) thanks! | 11:20 |
| gitlab-br-bot | buildstream: merge request (chandan/pip-install-instructions->master: doc: Add instructions to install BuildStream via PyPI) #717 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/717 | 11:22 |
| gitlab-br-bot | buildstream: merge request (chandan/setup.py-metadata->master: setup.py: Add more metadata useful for PyPI) #718 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/718 | 11:25 |
| *** cs-shadow has joined #buildstream | 11:40 | |
| qinusty | Are we able to pipe the output of buildstream? E.g. `bst build hello.bst | something.sh` ?? `bst build hello.bst > my_log.txt` doesn't seem to work | 11:45 |
| qinusty | Wondering if that's intentional | 11:45 |
| juergbi | valentind: regarding #461, a better solution might be to always return False in _pull_pending() for workspaced elements | 11:46 |
| juergbi | I haven't had a chance to verify that this works, though | 11:46 |
| *** finn has quit IRC | 11:46 | |
| *** finn has joined #buildstream | 11:46 | |
| juergbi | this should have the effect that the cache key is immediately invalidated after checking the local cache | 11:47 |
| juergbi | and thus reverse dependencies will never use the incorrect cache key | 11:47 |
| valentind | juergbi, OK, I can try that. | 11:52 |
| valentind | I am afraid there are more corner cases though. | 11:52 |
| valentind | I am looking at another issue. And there are weird things happening in non strict mode with slow artifact server. It seems that whether you have an artifact server or not changes behavior a lot. | 11:53 |
| valentind | Also found a regression in master. | 11:53 |
| valentind | I have to report that. | 11:53 |
| gitlab-br-bot | buildstream: merge request (chandan/pip-install-instructions->master: doc: Add instructions to install BuildStream via PyPI) #717 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/717 | 12:01 |
| gitlab-br-bot | buildstream: merge request (jjardon/doc_fix_deprecations->master: doc/bst2html.py: Fix deprecation warning) #727 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/727 | 12:07 |
| gitlab-br-bot | buildstream: merge request (chandan/setup.py-metadata->master: setup.py: Add more metadata useful for PyPI) #718 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/718 | 12:10 |
| valentind | juergbi, There is behavior for example. If you have configured an artifact server. And you build in non strict mode. Dependencies will show with no strong keys. They will be pulled. Even if we already have the weak key cached. However builds depending on it will still build before the artifact is pulled. If the build finishes before the artifact it depended failed, then it will break an assertion. If however it does it after, it will be cached | 12:10 |
| valentind | with the wrong strong key which came from the artifact server. | 12:10 |
| valentind | juergbi, https://gitlab.com/BuildStream/buildstream/issues/316 | 12:20 |
| gitlab-br-bot | buildstream: merge request (jjardon/ci_show_timings->master: .gitlab-ci.yml: Show timing of the 20 slowest tests) #716 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/716 | 12:21 |
| gitlab-br-bot | buildstream: merge request (jjardon/doc_fix_deprecations->master: doc/bst2html.py: Fix deprecation warning) #727 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/727 | 12:23 |
| gitlab-br-bot | buildstream: issue #606 ("Mangled symlinks when importing freedesktop BasePlatform") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/606 | 12:25 |
| gitlab-br-bot | buildstream: merge request (tpollard/483->master: plugins/git.py: Warn if ref is not in given track) #564 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/564 | 12:25 |
| gitlab-br-bot | buildstream: merge request (tpollard/591->master: buildstream/_project.py: Report if project.conf is missing name) #680 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/680 | 12:26 |
| valentind | juergbi, created also https://gitlab.com/BuildStream/buildstream/issues/607 | 12:29 |
| valentind | Which is another issue with the key calculations. But only in master. | 12:29 |
| *** shibualex has quit IRC | 12:31 | |
| juergbi | that might be related to the feature of caching failed builds | 12:31 |
| juergbi | valentind: regarding pulling when weak cache key is already available in local cache: this will attempt to pull the artifact based on the strict cache key (i.e., a better match). this was decided as desired some time ago | 12:32 |
| juergbi | (to reduce potential issues due to use of non-strict mode) | 12:33 |
| valentind | juergbi, OK, but we need to make sure that non strict build depends on the pull. | 12:33 |
| valentind | And I do not think this is the case. | 12:33 |
| *** shibualex has joined #buildstream | 12:33 | |
| juergbi | yes, reverse dependencies should not be built or pulled while pull is still pending | 12:34 |
| juergbi | the whole thing got way more complex than desired. I still regret the workspace cache key decision (might be able to simplify this in the future) | 12:34 |
| valentind | I do not think we have enough test for the complexity of the combination of features. | 12:37 |
| valentind | There are people who use a cache server. That works. There are people who use workspaces. That works. There are people using non-strict mode. That works. But when you use a combination you have a completely different behavior that not many have tested. | 12:38 |
| valentind | Also, do we have any test against using a cache server? | 12:40 |
| juergbi | valentind: yes, we have push/pull tests | 12:41 |
| juergbi | this includes regression tests against earlier cache key issues | 12:41 |
| valentind | OK great. | 12:41 |
| juergbi | but the combinatorial complexity is indeed too large for my taste | 12:43 |
| valentind | Yes. I see there is some mock server. I would like to use that to test with a slow server. | 12:44 |
| *** leopi has quit IRC | 12:44 | |
| *** finn has quit IRC | 12:48 | |
| qinusty | jmac, you were right. |& is what I was looking for. Piping combined stdout and stderr | 12:49 |
| *** solid_black has joined #buildstream | 12:51 | |
| *** shibualex has quit IRC | 12:56 | |
| *** shibualex has joined #buildstream | 12:59 | |
| *** ChanServ sets mode: +o ironfoot | 13:01 | |
| gitlab-br-bot | buildstream: merge request (jjardon/ci_show_timings->master: .gitlab-ci.yml: Show timing of the 20 slowest tests) #716 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/716 | 13:04 |
| jonathanmaw | jennis: can you sanity-check https://gitlab.com/BuildStream/bst-external/merge_requests/46 please? | 13:06 |
| gitlab-br-bot | buildstream: merge request (jjardon/ci_show_timings-bst-1.2->bst-1.2: [bst-1.2] .gitlab-ci.yml: Show timing of the 20 slowest tests) #728 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/728 | 13:06 |
| jonathanmaw | it fixes a problem with running the bst-external tests (can't access plugins with ".."), but I'm not confident that I'm being sane about how I do it. | 13:07 |
| jennis | jonathanmaw, I'll have a look | 13:07 |
| gitlab-br-bot | buildstream: merge request (jjardon/ci_show_timings-bst-1.2->bst-1.2: [bst-1.2] .gitlab-ci.yml: Show timing of the 20 slowest tests) #728 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/728 | 13:08 |
| *** shibualex has quit IRC | 13:23 | |
| *** leopi has joined #buildstream | 13:29 | |
| benschubert | nexus: am I correct: there is currently no way for _scheduler.jobs.job.Job to tell whether its task was skipped or not? So it's impossible to log the job as Skipped. The only workaround I can see is logging in the pull task, then marking the job as success. Does that seem good-ish? Otherwise, adding a new exception to raise when a job is skipped would do, but that's not clean. | 14:01 |
| benschubert | Any other suggestion? | 14:01 |
| benschubert | mainly https://gitlab.com/BuildStream/buildstream/blob/master/buildstream/_scheduler/jobs/job.py#L435 for reference | 14:06 |
| Nexus | benschubert: i don't see where job.py would store that, but i'm not the best person for scheduler things. skullman, jonathanmaw either of you touched jobs recently? | 14:17 |
| benschubert | We only get the return code from the task in Job, which means we have no way of marking an entire job as skipped yeah :/ So I can get a double message (Skipped, then Success) which would work but seems patchy | 14:19 |
| benschubert | I'm alsmot done with the MR so you'll get better context | 14:19 |
| gitlab-br-bot | buildstream: merge request (bschubert/log-missed-cache->master: Log not-found objects in the cache as SKIPPED) #729 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/729 | 14:26 |
| benschubert | Nexus: is that what you had in mind? | 14:26 |
| Nexus | that seems to look right, jjardon posted the original issue, so he might have some input | 14:31 |
| qinusty | https://gitlab.com/BuildStream/buildstream/issues/507 appears to have regressed | 14:33 |
| gitlab-br-bot | buildstream: issue #507 ("Some log lines appear to be duplicates") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/507 | 14:33 |
| benschubert | great! Any other issue you/anyone else would have in mind? | 14:34 |
| qinusty | You could investigate https://gitlab.com/BuildStream/buildstream/issues/507 if you're looking for a bug benschubert | 14:36 |
| benschubert | ok! I'll give it a look | 14:37 |
| qinusty | It has regressed somewhere between cb8c99e52a713abfee18c4cce9893c6371df0bbf and master | 14:37 |
| qinusty | Bisecting is a great way to figure out when it happened :D | 14:37 |
| qinusty | psssst benschubert https://gitlab.com/BuildStream/buildstream/commit/d14d8ee29b5fcaadcfd05934de71b46221243fcd Someone overwrote tlater's commit in a recent merge | 14:41 |
| benschubert | you mean the commit preventing the double log? x) | 14:43 |
| qinusty | yup | 14:43 |
| qinusty | Luckily for tristan, 1.2 is unharmed | 14:43 |
| benschubert | ok, will add the previous behavior back :) | 14:44 |
| qinusty | Nice! I thought I was seeing a lot of unexpected text on my builds | 14:45 |
| gitlab-br-bot | buildstream: merge request (bschubert15/fix-double-log->master: buildelement.py: remove double logging (again) as in #507) #730 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/730 | 14:55 |
| benschubert | done :) | 14:55 |
| gitlab-br-bot | buildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/626 | 14:58 |
| *** shibualex has joined #buildstream | 15:00 | |
| gitlab-br-bot | buildstream: merge request (bschubert15/fix-double-log->master: buildelement.py: remove double logging (again) as in #507) #730 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/730 | 15:00 |
| qinusty | Looks good :D I've left a note in the MR which caused the regression to avoid it getting backported without this fix | 15:03 |
| *** shibualex has quit IRC | 15:04 | |
| *** shibualex has joined #buildstream | 15:05 | |
| *** shibualex has quit IRC | 15:09 | |
| *** shibualex has joined #buildstream | 15:09 | |
| *** shibualex has quit IRC | 15:14 | |
| *** noisecell has quit IRC | 15:19 | |
| gitlab-br-bot | buildstream: merge request (bschubert15/fix-double-log->master: buildelement.py: remove double logging (again) as in #507) #730 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/730 | 15:33 |
| *** shibualex has joined #buildstream | 15:34 | |
| gitlab-br-bot | buildstream: merge request (coldtom/autotools-libtool->master: Upstream freedesktop-sdk autotools config) #683 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/683 | 15:49 |
| * WSalmon wonders what tristan will think of https://gitlab.com/BuildStream/buildstream/commit/b74ff348ce7a8e2865b983145755de7c02aedfcc | 15:50 | |
| *** jonathanmaw has quit IRC | 15:53 | |
| *** tpollard has quit IRC | 15:59 | |
| gitlab-br-bot | buildstream: issue #417 ("Create a CAS-backed virtual directory implementation") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/417 | 16:01 |
| *** leopi has quit IRC | 16:01 | |
| *** toscalix has quit IRC | 16:10 | |
| *** shibualex has quit IRC | 16:39 | |
| *** WSalmon has quit IRC | 16:40 | |
| *** bochecha has joined #buildstream | 16:56 | |
| *** solid_black has quit IRC | 16:57 | |
| *** leopi has joined #buildstream | 17:14 | |
| *** rdale has quit IRC | 17:16 | |
| *** ptomato[m] has left #buildstream | 18:35 | |
| *** craig has joined #buildstream | 19:02 | |
| *** craig has quit IRC | 19:03 | |
| *** valan has joined #buildstream | 20:07 | |
| *** kim has joined #buildstream | 20:35 | |
| *** kim has quit IRC | 20:36 | |
| *** alatiera_ has quit IRC | 20:46 | |
| *** leopi has quit IRC | 20:54 | |
| *** valan has quit IRC | 20:55 | |
| *** valan has joined #buildstream | 20:58 | |
| *** valan has quit IRC | 21:00 | |
| *** valan has joined #buildstream | 21:00 | |
| *** kim has joined #buildstream | 21:03 | |
| *** kim has quit IRC | 21:10 | |
| gitlab-br-bot | buildstream: merge request (chandan/automate-pypi-release->master: .gitlab-ci.yml: Publish to PyPI when new tags are pushed) #731 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/731 | 21:20 |
| gitlab-br-bot | buildstream: merge request (chandan/automate-pypi-release->master: WIP: .gitlab-ci.yml: Publish to PyPI when new tags are pushed) #731 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/731 | 21:21 |
| gitlab-br-bot | buildstream: merge request (chandan/automate-pypi-release->master: WIP: .gitlab-ci.yml: Publish to PyPI when new tags are pushed) #731 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/731 | 21:22 |
| *** valan has quit IRC | 21:33 | |
| *** valan has joined #buildstream | 21:36 | |
| *** valan has left #buildstream | 22:03 | |
| *** bochecha has quit IRC | 22:27 | |
| *** tristan has quit IRC | 23:31 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!