| *** ynyounuo has joined #buildstream | 01:52 | |
| ynyounuo | <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth | 01:52 |
|---|---|---|
| *** ynyounuo has quit IRC | 01:52 | |
| *** mquin has joined #buildstream | 02:57 | |
| mquin | <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth | 02:57 |
| *** mquin has quit IRC | 02:57 | |
| *** ernestask has joined #buildstream | 03:29 | |
| *** Evel-Knievel has joined #buildstream | 04:22 | |
| Evel-Knievel | <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth | 04:22 |
| *** Evel-Knievel has quit IRC | 04:22 | |
| *** leopi has joined #buildstream | 04:58 | |
| *** bochecha has joined #buildstream | 05:50 | |
| *** mort4 has joined #buildstream | 07:47 | |
| mort4 | <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth | 07:47 |
| *** mort4 has quit IRC | 07:47 | |
| *** coldtom has joined #buildstream | 07:52 | |
| *** phildawson has joined #buildstream | 07:56 | |
| *** tanuki has joined #buildstream | 08:02 | |
| tanuki | <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth | 08:02 |
| *** tanuki has quit IRC | 08:02 | |
| gitlab-br-bot | buildstream: merge request (phil/437-workspaces-tutorial->master: Phil/437 workspaces tutorial) #519 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/519 | 08:05 |
| gitlab-br-bot | buildstream: merge request (phil/437-workspaces-tutorial->master: Phil/437 workspaces tutorial) #519 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/519 | 08:05 |
| gitlab-br-bot | buildstream: merge request (phil/437-workspaces-tutorial->master: Phil/437 workspaces tutorial) #519 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/519 | 08:06 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 08:23 |
| *** leopi has quit IRC | 08:23 | |
| mablanch | I've got two (small) newcomer MR that need reviewing: !590 & !592. Would really appreciate any comments I could get on them. | 08:27 |
| gitlab-br-bot | buildstream: issue #533 ("Warning instead of error when failing to write tracking results") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/533 | 08:27 |
| qinusty | mablanch, I'll take a look | 08:30 |
| mablanch | Thank you qinusty! | 08:31 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 08:35 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 08:38 |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 08:38 |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 08:38 |
| qinusty | I'm fine for !590 to be merged. It fixes the original issue and seems fine to me. Rebase to be up to date with master and it should be alright | 08:39 |
| *** leopi has joined #buildstream | 08:41 | |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 08:51 |
| mablanch | Cheers qinusty, rebased now. | 08:52 |
| jmac | laurence: The description you've put on the 'review' label is not what I intended | 08:53 |
| jmac | I wanted it to be for things which need review, not things which are being reviewed | 08:53 |
| *** noisecell has joined #buildstream | 08:54 | |
| qinusty | it'll merge on pipeline completion mablanch, it might need another rebase if your other MR merges first :P | 09:01 |
| qinusty | gitlab bugs :/ | 09:01 |
| mablanch | qinusty: Will rebase as many times as required then. | 09:03 |
| qinusty | I'm currently looking into generating some sort of 'manifest' file after a build for https://gitlab.com/BuildStream/buildstream/issues/235. This manifest will contain every element, each of their sources and some build meta data like bst version, build time etc. | 09:03 |
| qinusty | With DownloadableFileSource sources, it's easy. You grab the url and ref, but with other sources what information could be included? | 09:04 |
| gitlab-br-bot | buildstream: issue #437 ("Improve documentation for advanced features of BuildStream") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/437 | 09:04 |
| gitlab-br-bot | buildstream: merge request (phil/437-workspaces-tutorial->master: Phil/437 workspaces tutorial) #519 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/519 | 09:04 |
| Kinnison | Why not the url and ref of all sources, and the strict cache-key of the generated artifact ? | 09:05 |
| qinusty | Any information is useful. I'm throwing it out as YAML so users could just have a script to strip the bits they don't want out and format as they like | 09:06 |
| Kinnison | In Baserock (A similar project from a while ago) each artifact stored a metadata file which was essentially its fully resolved element including commands, dependencies, etc. The final constructed deliverable contained all those in a /baserock/ folder | 09:09 |
| Kinnison | Perhaps something similar (though as a single file with multiple yaml documents) could be constructed for this? | 09:09 |
| gitlab-br-bot | buildstream: issue #534 ("Failed builds not pushing artifacts on quit") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/534 | 09:12 |
| gitlab-br-bot | buildstream: issue #437 ("Improve documentation for advanced features of BuildStream") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/437 | 09:14 |
| tlater | Nexus: Have you created an issue for what laurence mentions yet? | 09:16 |
| * tlater is curious | 09:16 | |
| Nexus | 10:12 <gitlab-b > buildstream: issue #534 ("Failed builds not pushing artifacts on quit") changed state ("opened") | 09:16 |
| Nexus | https://gitlab.com/BuildStream/buildstream/issues/534 | 09:16 |
| tlater | Ah, right | 09:17 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 09:23 |
| laurence | jmac, aha, can you amend the description or do i have to do it? | 09:24 |
| laurence | jmac, amended it anyway | 09:25 |
| laurence | thanks | 09:25 |
| jmac | Thanks laurence - I just wanted to check we agreed on it | 09:26 |
| gitlab-br-bot | buildstream: issue #535 ("BuildStream doesn't fix the version of its dependencies") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/535 | 09:27 |
| gitlab-br-bot | buildstream: merge request (tpollard/483->master: plugins/git.py: Fail if ref is not in given track) #564 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/564 | 09:34 |
| tlater | Hm, our old artifact cache key image supported displaying uploaded artifacts with nginx | 09:36 |
| tlater | I suppose we'd need to write something special to do this with CAS? | 09:36 |
| tlater | (The artifact cache docker image was never updated to CAS) | 09:36 |
| qinusty | Probably | 09:38 |
| gitlab-br-bot | buildstream: issue #386 ("Don't print failure summary when there are no failures") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/386 | 09:40 |
| tlater | I'll create a separate CAS image for now, since that's technically a regression | 09:40 |
| mablanch | qinusty, Seems like the automatic merge failed for !590 (as you were expecting right?)... | 09:42 |
| Nexus | Auto merge has been acting oddly, should we manually merge https://gitlab.com/BuildStream/buildstream/merge_requests/590 now? | 09:43 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 09:43 |
| qinusty | Yup, | 09:43 |
| mablanch | Thanks! | 09:43 |
| Nexus | cool | 09:43 |
| qinusty | Cancelled merge, rebased. Now to merge again and hope noone elses merge goes through while you're in the pipeline :P | 09:44 |
| Nexus | :D | 09:44 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 09:44 |
| qinusty | Hey tlater, is https://gitlab.com/BuildStream/buildstream/issues/456 a WIP? | 09:44 |
| tlater | qinusty: Yup | 09:45 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 09:45 |
| qinusty | Sounds good :P I'm just having to use context now and went looking for a related issue :P | 09:45 |
| tlater | My MR for that is here: https://gitlab.com/BuildStream/buildstream/merge_requests/527 | 09:46 |
| qinusty | cool! The message api is fairly spread out currently so it makes sense | 09:47 |
| tlater | Yep, it's a massive annoyance when debugging | 09:48 |
| jmac | oooook, toscalix has just removed the review label apparently | 09:49 |
| toscalix | jmac: I did. For now, my suggestion is,when you want somebody to review your code, assign the MR to that person | 09:50 |
| toscalix | adding the state Review complicates our workflow. I would prefer to create a reviewers group and assign it to the group if the assignee to a specific person does not scale | 09:51 |
| jmac | I strongly disagree | 09:51 |
| phildawson | toscalix, that doesn't help when someone wants to search for MRs that are in need of reviewers | 09:51 |
| jmac | I don't want any particular person to review my MRs | 09:51 |
| toscalix | if the asssignee field does not work, I am open to reconsider and create the label. | 09:51 |
| jmac | Also, I proposed this use of the Review tag and you agreed to it on the mailing list | 09:52 |
| toscalix | jmac: I think it is a good idea | 09:52 |
| toscalix | but I would like to first make proper use of the assignee field. | 09:52 |
| toscalix | phildawson: you can search for MR assigned to the reviewer | 09:52 |
| jmac | The assignee field does not work, that's what we just said | 09:52 |
| toscalix | jmac: so you have used it extensively? | 09:53 |
| jmac | No, I don't want to use it the way you suggest | 09:53 |
| jmac | I think it will lead to longer review times | 09:53 |
| * tlater agrees with jmac here, small, unimportant MRs that I don't need to tell someone to go review want the "review" tag, not prodding someone | 09:54 | |
| * Nexus also agrees with jmac | 09:54 | |
| toscalix | creating a new state has further implications | 09:55 |
| toscalix | but fine, I will take it in consideration again and talk to the guys upstream about it | 09:55 |
| jmac | What are the implications? | 09:55 |
| toscalix | let's see how expensive it is | 09:55 |
| Nexus | i suggest we have the review label and when sonmeone picks it up, they can assign it to themselves then | 09:55 |
| tlater | toscalix: I feel that the "review" tag is for anything where we don't care about how long it takes to review. | 09:56 |
| jmac | To be clear, I'm not suggesting we use the review tag for issues, just MRs | 09:57 |
| toscalix | tlater: that is not a state, that is severity | 09:57 |
| toscalix | how ou say it, you are asking to add the existing severity labels to the MR | 09:57 |
| Nexus | toscalix: what if i don't know who's best to review it? | 09:57 |
| Nexus | or they go away | 09:57 |
| toscalix | jmac: that is my understanding. | 09:58 |
| tlater | So you suggest to instead assign "low" priority, and then assign someone for the review? | 09:58 |
| toscalix | Nexus: that is when the group approach comes to place | 09:58 |
| adds68 | jmac, i agree the assignee thing is cumbersome to use | 09:58 |
| toscalix | you can assign something to several individuals or to a group | 09:58 |
| Nexus | or avoid the wole issue with a review label | 09:58 |
| toscalix | I will dig into this case a little. Please give me some time | 09:58 |
| toscalix | Nexus: labels are expensive. For example, Gitlab uses 7. We already have more than that | 09:59 |
| *** phildawson has quit IRC | 10:00 | |
| *** phildawson has joined #buildstream | 10:00 | |
| toscalix | the key abou the labels is to have very few but everybody use them correctly and extensively | 10:00 |
| toscalix | I see the use case, we are not convering, let me find out how we can do it. I would like to avoid a new label in general, not just in this case, so you will see me reluctant to create more labels in general | 10:01 |
| toscalix | Sometimes is unavoidable though | 10:01 |
| adds68 | I see how important the "important" tag is... | 10:03 |
| qinusty | ^ | 10:07 |
| toscalix | adds68: can you develop? | 10:14 |
| adds68 | toscalix, IMO all issues are important, if they are not they should be elevated or closed, it's a cumbersome tag | 10:22 |
| tlater | Something something severity not a state ;p | 10:25 |
| toscalix | adds68: not all of the issues are important. There are those who do not have any severity label at all | 10:25 |
| toscalix | so no label is the lower severity label and important is the default one, as the policy states | 10:26 |
| toscalix | but if you think you have a better proposal in terms of severity labels, I am open to hear it and discuss it. I do not think there is a perfect solution. | 10:28 |
| toscalix | just complaining does not seem like a productive approach | 10:29 |
| tlater | Hm, our old artifact cache key image supported displaying uploaded artifacts with nginx | 10:42 |
| tlater | I suppose we'd need to write something special to do this with CAS? | 10:42 |
| tlater | (The artifact cache docker image was never updated to CAS) | 10:42 |
| jmac | I'm sure we could do something that just iterates the refs occasionally | 10:44 |
| tlater | Sorry, I'm not sure why I sent that again... Some odd history paste? | 10:45 |
| adds68 | toscalix, i don't think that is an obvious assumption to make about severity, my proposal is to accept what developers who are using the tool every day want to use, user naturally find optimal ways to use tools | 10:46 |
| tlater | jmac: That said, I think we could write a web server that serves up the artifacts through the CAS API instead | 10:47 |
| tlater | It would keep us from duplicating the whole CAS | 10:47 |
| toscalix | adds68: I think you are ignoring that the tool is being and will be used by non developers and you are not considering the management costs associated with using these kind of tools. | 10:48 |
| toscalix | so there needs to be a balance between what is needed in a specific moment and the long terms costs and risks associated to it, specially in cases in which, reverting a decision, is almost impossible | 10:49 |
| toscalix | you do not have to manage the issues nor the MR so I do not expect you to support my view. I just would appreciate if you provide some credit to experience in this field | 10:50 |
| toscalix | expanding the features we use comes with a cost | 10:51 |
| toscalix | and new risks. That's all | 10:52 |
| adds68 | toscalix, i understand your frustration, but i feel the tool is the problem and removing labels because they don't work for you, is not the solution, my single MR got stale on buildstream because nobody knew it needed to be reviewed | 10:53 |
| toscalix | adds68: I am not frustrated | 10:53 |
| toscalix | adds68: creating a new label should go through the mailing list | 10:54 |
| jmac | It did go through the mailing list | 10:54 |
| toscalix | so there is a process to change how we all work | 10:54 |
| toscalix | jmac: no, it didn't. You propose it as an answer to another thread. | 10:54 |
| adds68 | toscalix, it's a sensible approach, but not everyone is on the mailing list, and Gitlab is supposed to stop people using multiple tools to manage a project | 10:55 |
| toscalix | even if that is the right way, just simply go and create it is not the right approach | 10:55 |
| jmac | So I have to make a new thread to propose the label? | 10:55 |
| *** slaf has quit IRC | 10:55 | |
| toscalix | like I did to propose to rename it, like tristan did to propose to change the default.... | 10:55 |
| adds68 | How about an issue is raised for a new label? i think that is what Gitlab is trying to get at, as a tool | 10:56 |
| adds68 | To avoid situations like this | 10:56 |
| toscalix | adds68: we are using the mailing list for enhancements and policy changes at this point | 10:56 |
| toscalix | I do not think it is creating such a problem that we need to open a second process for that | 10:56 |
| toscalix | I am fine with somebody creating a ticket for this. I will then take it to the mailing list if it is a matter of policy | 10:57 |
| adds68 | toscalix, i'm pointing out that Gitlabs goal is to stop the use of multiple tools, in order avoid confusion | 10:57 |
| toscalix | adds68: avoid situations like this? You avoid them by following the example others have created | 10:57 |
| adds68 | "GitLab is the first single application built from the ground up for all stages of the DevOps lifecycle for Product, Development, QA, Security, and Operations teams to work concurrently on the same project" | 10:58 |
| toscalix | and I am telling you that we do not use gitlab in substitution of the mailing list for certain kind of discussions | 10:58 |
| adds68 | That's my take away from this matter, but i am only commenting from my experience with one trivial MR | 10:58 |
| *** slaf has joined #buildstream | 10:59 | |
| toscalix | adds68: I guess you have not realised we are in an open source project. Mailing lists are the main discussion tool | 10:59 |
| toscalix | mailing lists are | 10:59 |
| toscalix | for good reasons | 11:00 |
| adds68 | toscalix, ? that is one way, not every way | 11:00 |
| toscalix | agree, but is the way we have defined and I think it is mostly working in this regard | 11:00 |
| *** slaf has joined #buildstream | 11:01 | |
| *** slaf has joined #buildstream | 11:01 | |
| *** bethwhite_ has joined #buildstream | 11:03 | |
| *** phildawson has quit IRC | 11:04 | |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 11:05 |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 11:05 |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 11:08 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-195->master: Tiagogomes/issue 195) #593 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/593 | 11:10 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-195->master: Add validation for project paths) #593 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/593 | 11:11 |
| Nexus | Someone please just make a thread so we can say yay or nay to it? | 11:18 |
| gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 11:19 |
| tlater | Hmm... I'm really struggling to get an artifact cache to work | 11:21 |
| tlater | I get "Error loading user configuration: userconfig.yaml [line 9 column 15]: Unexpected key: server-cert" | 11:21 |
| tlater | In an "artifacts:" block | 11:22 |
| * tlater is very confused since he copy-pasted the example from the docs | 11:22 | |
| jmac | In user config? I would usually put it in project config | 11:22 |
| tlater | I've tried that also, though not with a literal copy paste | 11:22 |
| tlater | In either case, the docs tell me to put this in user config | 11:23 |
| * tlater thinks that's probably not right, but follows docs for now | 11:23 | |
| jmac | Hmm, indeed it is | 11:23 |
| tlater | jmac: Referring to this: https://buildstream.gitlab.io/buildstream/install_artifacts.html#user-configuration | 11:23 |
| adds68 | tlater, is this on the same indentation level as the URL you are specifying in the project.conf ? | 11:24 |
| tlater | Yes - as I said, literal copy paste from the docs | 11:24 |
| tlater | (Knowing that the url won't work) | 11:24 |
| tlater | (I just want to get this to *parse*) | 11:24 |
| adds68 | tlater, that's odd as i used the same docs yesterday and did not see that error | 11:25 |
| tlater | I'm using a very old branch, same behavior before and after rebasing | 11:25 |
| tlater | So it's not a recent regression | 11:25 |
| * tlater is stumped | 11:25 | |
| adds68 | tlater, but i added this is project.conf | 11:25 |
| adds68 | in* | 11:25 |
| tlater | adds68: I just copy-pasted to project.conf | 11:26 |
| tlater | Also doesn't parse there | 11:26 |
| tlater | "artifacts" is supposed to be a top level key? | 11:26 |
| adds68 | tlater, correct | 11:27 |
| adds68 | tlater, http://termbin.com/33ku | 11:28 |
| tlater | adds68: Wait, the docs say to add "server-key", not key | 11:29 |
| tlater | server-cert, even | 11:29 |
| adds68 | tlater, sorry i was doing it from memory, that is correct | 11:30 |
| adds68 | tlater, we use verified certs, so no longer have to specify that | 11:30 |
| adds68 | it more just to show the indentation that we used | 11:30 |
| tlater | adds68: These are the literal contents of my userconfig.yaml: https://hastebin.com/oguhuditux.shell | 11:32 |
| tlater | I've tried moving those to project.conf and removing them from userconfig with no changes | 11:32 |
| tlater | Neither successfully parses | 11:32 |
| tlater | I know the configuration won't *work*, but it should at least not complain about keys | 11:32 |
| * tlater goes code digging | 11:32 | |
| adds68 | tlater, 0_0 i am not sure then, it looks fine | 11:33 |
| tlater | I'd think so, since I literally copied that from the docs ;p | 11:33 |
| tlater | This can't work: https://gitlab.com/BuildStream/buildstream/blob/master/buildstream/_artifactcache/artifactcache.py#L175 | 11:36 |
| tlater | Oh, nevermind... | 11:36 |
| Nexus | go home tlater, you're drunk | 11:36 |
| gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 11:37 |
| laurence | can anyone review https://gitlab.com/BuildStream/defs2bst/merge_requests/5 ? | 11:46 |
| Nexus | i'm waitinf on tests, i can have a look | 11:46 |
| tlater | Somehow `touch`-ing _artifactcache/artifactcache.py solved it | 11:49 |
| * tlater wonders if he had old pycache files lying around | 11:49 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/331_include->master: WIP: Add support for include in project.conf) #471 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/471 | 11:50 |
| gitlab-br-bot | buildstream: merge request (valentindavid/331_include->master: Add support for include in project.conf) #471 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/471 | 11:50 |
| Nexus | tlater: touching things always makes things better | 11:50 |
| gitlab-br-bot | buildstream: issue #536 ("UI for inspecting build logs and failed builds from the artifact cache") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/536 | 11:50 |
| Nexus | laurence: reviewed and commented | 11:51 |
| *** phildawson has joined #buildstream | 11:53 | |
| tiagogomes | tlater did you change the time on your system? | 11:56 |
| Nexus | qinusty: looks like 592 is ready to be merged | 11:59 |
| laurence | Nexus, tvm | 11:59 |
| tlater | tiagogomes: Not deliberately, but I am running buildstream in a container | 12:00 |
| tlater | It's possible that something odd filesystem-related happened | 12:00 |
| qinusty | I didn't review !592 Nexus, do you or phildawson want to merge it? | 12:00 |
| gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: WIP: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 12:02 |
| jjardon | tpollard: I have commented in the ref/track issue to try to explain the use case we tried to fix, but we could wait for the configurable parameter; thanks for working on it though! | 12:03 |
| gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 12:03 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 12:04 |
| tlater | qinusty: On the topic of mergeable MRs, I just finished reviewing https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 12:04 |
| tlater | Just rebase it and you're good to go :) | 12:05 |
| * tlater will see about pushing up his CAS docker changes later today. | 12:05 | |
| gitlab-br-bot | buildstream: merge request (mablanch/448-autocompletion-broken-defaults->master: Fix autocompletion for elements in sub-folders) #592 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/592 | 12:05 |
| tpollard | jjardon: I 100% understand your use case, it's a tricky one | 12:06 |
| qinusty | alright tlater cheers! I'll wait for all these other MR's to go through this morning or I'll be rebasing like 4 times :D | 12:06 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 12:06 |
| tpollard | jjardon: the logic is there though, it only needs tweaks either way I think | 12:07 |
| jjardon | tpollard: yup, any idea if someone is working in the configurability part already? Also, any idea if this is meant to land in 1.2 or 1.4? | 12:09 |
| tpollard | jjardon: I do not | 12:14 |
| jjardon | Hi, any idea if the gpg-key: parameter from the ostree source plugin is part of the cache-key calculation? | 12:17 |
| jjardon | docs doesn't mention: https://buildstream.gitlab.io/buildstream/sources/ostree.html | 12:17 |
| *** CyBeR has left #buildstream | 12:20 | |
| gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 12:26 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-195->master: Add validation for project paths) #593 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/593 | 12:28 |
| jjardon | Hi, is there a way to disable gpg verification for ostree sources? | 12:51 |
| tiagogomes | jjardon removing the gpg-key field? | 13:00 |
| mablanch | qinusty: CI passed for !590, ready to be merged I think. | 13:00 |
| tiagogomes | The ostree plugin doesn't require that to be specified | 13:00 |
| jjardon | tiagogomes: yep, just tried; seems to work fine, thanks | 13:00 |
| *** edb has joined #buildstream | 13:13 | |
| gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 13:16 |
| *** xjuan has joined #buildstream | 13:17 | |
| *** gitlab-br-bot has quit IRC | 13:18 | |
| *** gitlab-br-bot has joined #buildstream | 13:18 | |
| tiagogomes | bah python 3.5 vs 3.6 | 13:25 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 13:25 |
| flatmush | better to remove the python dependency all together | 13:26 |
| *** tpollard has quit IRC | 13:27 | |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-195->master: Add validation for project paths) #593 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/593 | 13:42 |
| *** tpollard has joined #buildstream | 13:45 | |
| *** Kinnison has quit IRC | 13:46 | |
| *** Kinnison has joined #buildstream | 13:47 | |
| *** ernestask has quit IRC | 13:56 | |
| *** tpollard has quit IRC | 13:58 | |
| *** tpollard has joined #buildstream | 13:59 | |
| noisecell | laurence, I've added a comment on https://gitlab.com/BuildStream/buildstream/issues/536 because I think this is part of the "bst artifact" UI, tristan suggested in the mailing list. | 14:00 |
| laurence | noisecell, aha, thanks for that | 14:13 |
| noisecell | laurence, you are welcome | 14:13 |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-195->master: Add validation for project paths) #593 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/593 | 14:17 |
| gitlab-br-bot | buildstream: merge request (Qinusty/481->master: Add SKIPPED message type for actions being skipped) #562 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 14:17 |
| *** edb has left #buildstream | 14:24 | |
| *** edb has joined #buildstream | 14:24 | |
| laurence | Anyway have capacity to review cs_shadow's pip source plug in ? | 14:33 |
| laurence | https://gitlab.com/BuildStream/buildstream/merge_requests/568#note_91815480 | 14:33 |
| phildawson | I'm planning on reviewing it once I've done !580. It would obviously be good to have some attention from people who've been around longer too. | 14:35 |
| phildawson | I suspect Tristan will want to have a look. | 14:35 |
| gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 14:44 |
| *** bochecha has quit IRC | 14:50 | |
| *** bochecha has joined #buildstream | 14:50 | |
| *** bochecha has quit IRC | 14:55 | |
| *** bochecha has joined #buildstream | 14:55 | |
| laurence | phildawson, thanks a lot | 14:57 |
| gitlab-br-bot | buildstream: merge request (Qinusty/481->master: Add SKIPPED message type for actions being skipped) #562 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 15:01 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:02 |
| qinusty | !562 is now merged, ty tlater | 15:10 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 15:16 |
| *** leopi has quit IRC | 15:27 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/331_include->master: Add support for include in project.conf) #471 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/471 | 15:31 |
| *** ernestask has joined #buildstream | 15:33 | |
| gitlab-br-bot | buildstream: issue #537 ("Mirror fallback does not work for git") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/537 | 15:35 |
| gitlab-br-bot | buildstream: issue #538 ("ostree mirror fallback breaks assertion") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/538 | 15:37 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/virtual_directories: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 15:39 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:47 |
| gitlab-br-bot | buildstream: merge request (edbaunton/executable-remote-source->master: remote.py: Add support for marking downloaded files executable) #581 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/581 | 15:50 |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:52 |
| gitlab-br-bot | buildstream: merge request (dp0/513/cas-cache-client-certs->master: WIP: Support dynamic client certificates for CAS cache) #594 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/594 | 16:00 |
| gitlab-br-bot | buildstream: merge request (phil/add-ubuntu-ci-job->master: .gitlab-ci-yml: Add ubuntu 18 test) #523 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/523 | 16:01 |
| gitlab-br-bot | buildstream: merge request (phil/add-ubuntu-ci-job->master: .gitlab-ci-yml: Add ubuntu 18.04 test) #523 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/523 | 16:02 |
| mablanch | qinusty: We've got a new open merge window for !590, if you are still willing to merge it. | 16:12 |
| qinusty | I saw the CI was having a few issues earlier | 16:13 |
| qinusty | are we good now? | 16:13 |
| mablanch | Yes we are. | 16:13 |
| gitlab-br-bot | buildstream: merge request (mablanch/447-stack-trace-checkout->master: Handle checkout failure for unbuilt elements) #590 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/590 | 16:14 |
| qinusty | Done | 16:15 |
| mablanch | Yay, cheers! | 16:15 |
| *** noisecell has quit IRC | 16:20 | |
| gitlab-br-bot | buildstream: merge request (willsalmon/CacheExpiryTest->master: expiry.py: Trying to mitigate a file system issue) #595 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/595 | 16:21 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/virtual_directories: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 16:25 |
| gitlab-br-bot | buildstream: issue #203 ("BuildStream crashes if the dependency tree is too deep") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/203 | 16:26 |
| gitlab-br-bot | buildstream: merge request (willsalmon/CacheExpiryTest->master: expiry.py: Trying to mitigate a file system issue) #595 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/595 | 16:27 |
| gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 16:30 |
| gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 16:31 |
| tpollard | Could we have the bot not post changes to WIP branches? | 16:31 |
| gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 16:31 |
| laurence | Does anyone actually use the bot? | 16:31 |
| laurence | I just ignore it | 16:31 |
| tpollard | I do, but I've only been here a couple of weeks | 16:32 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/virtual_directories: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 16:32 |
| gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 16:33 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/virtual_directories: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 16:34 |
| gitlab-br-bot | buildstream: merge request (willsalmon/CacheExpiryTest->master: expiry.py: Trying to mitigate a file system issue) #595 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/595 | 16:35 |
| gitlab-br-bot | buildstream: merge request (Qinusty/235-manifest->master: Implement generated build manifests) #596 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/596 | 16:35 |
| gitlab-br-bot | buildstream: merge request (willsalmon/CacheExpiryTest->master: Trying to mitigate a file system issue) #595 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/595 | 16:35 |
| jmac | I think we could drop the ones that just report small changes and keep ones that say 'merged'. | 16:36 |
| gitlab-br-bot | buildstream: merge request (Qinusty/235-manifest->master: Implement generated build manifests) #596 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/596 | 16:38 |
| tpollard | Yeh I'm not sure about the granularity, but getting informed of pushes/rebases of WIP branches is just noise imo | 16:39 |
| gitlab-br-bot | buildstream: merge request (phil/add-ubuntu-ci-job->master: WIP: .gitlab-ci-yml: Add ubuntu 18.04 test) #523 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/523 | 16:39 |
| tpollard | of course that relies on proper use of the WIP: tag | 16:39 |
| gitlab-br-bot | buildstream: merge request (jjardon/license->master: docs: Add license: Creative Commons Attribution 4.0 International License) #336 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/336 | 16:40 |
| *** bethwhite_ has joined #buildstream | 16:40 | |
| gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 16:41 |
| gitlab-br-bot | buildstream: merge request (jjardon/license->master: docs: Add license: Creative Commons Attribution 4.0 International License) #336 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/336 | 16:41 |
| gitlab-br-bot | buildstream: merge request (Qinusty/235-manifest->master: Implement generated build manifests) #596 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/596 | 16:43 |
| qinusty | jjardon I'm not too sure what the state of 1.2 is with the whole feature freeze. You'll have to check with tristan | 16:51 |
| gitlab-br-bot | buildstream: issue #447 ("Strack trace shown when trying to checkout an unbuilt element") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/447 | 16:51 |
| gitlab-br-bot | buildstream: issue #448 ("Autocompletion defaults to the project's root before the element path") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/448 | 16:51 |
| jjardon | qinusty: sure | 16:54 |
| *** toscalix has quit IRC | 17:07 | |
| *** coldtom has quit IRC | 17:15 | |
| *** coldtom has joined #buildstream | 17:16 | |
| gitlab-br-bot | buildstream: issue #436 ("Include install instructions for Ubuntu in the 'Install' section of the documentation") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/436 | 17:28 |
| gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 17:28 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/virtual_directories: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 17:36 |
| *** finn_ has joined #buildstream | 18:41 | |
| *** leopi has joined #buildstream | 18:59 | |
| *** Guest89349 has joined #buildstream | 18:59 | |
| *** ucfzn has joined #buildstream | 19:07 | |
| *** finn_ has joined #buildstream | 19:09 | |
| *** leopi has quit IRC | 19:10 | |
| *** leopi has joined #buildstream | 19:12 | |
| *** leopi has quit IRC | 19:23 | |
| *** leopi has joined #buildstream | 19:24 | |
| *** leopi has quit IRC | 19:28 | |
| *** ernestask has quit IRC | 20:15 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/331_include->master: Add support for include in project.conf) #471 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/471 | 20:37 |
| *** ucfzn has quit IRC | 20:50 | |
| *** edb has quit IRC | 21:03 | |
| *** Jovan has joined #buildstream | 21:24 | |
| *** xjuan has quit IRC | 21:55 | |
| *** Sigyn6 has joined #buildstream | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!