*** bochecha has quit IRC | 00:14 | |
*** xjuan has quit IRC | 01:10 | |
*** tristan has joined #buildstream | 04:15 | |
gitlab-br-bot | buildstream: merge request (tristan/temporary-failures->master: Temorary failures) #574 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/574 | 04:43 |
---|---|---|
gitlab-br-bot | buildstream: merge request (Qinusty/397->master: Modify retry behaviour to be opt-in on exceptions during job processing) #559 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/559 | 04:47 |
*** noisecell has joined #buildstream | 05:18 | |
gitlab-br-bot | buildstream: merge request (tristan/temporary-failures-backport->bst-1.2: Tristan/temporary failures backport) #575 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/575 | 05:33 |
*** noisecell has quit IRC | 05:51 | |
*** leopi has joined #buildstream | 06:04 | |
gitlab-br-bot | buildstream: issue #397 ("Should not retry successfully downloaded files with bad checksums") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/397 | 06:13 |
gitlab-br-bot | buildstream: merge request (tristan/temporary-failures->master: Temorary failures) #574 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/574 | 06:13 |
*** ernestask has joined #buildstream | 06:27 | |
gitlab-br-bot | buildstream: merge request (tristan/temporary-failures-backport->bst-1.2: Tristan/temporary failures backport) #575 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/575 | 06:55 |
*** noisecell has joined #buildstream | 07:12 | |
*** tristan has quit IRC | 07:27 | |
*** tristan has joined #buildstream | 07:55 | |
*** qinusty has joined #buildstream | 08:02 | |
gitlab-br-bot | buildstream: merge request (Qinusty/502->master: cascache.py: Raise ArtifactError on grpc error) #576 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/576 | 08:19 |
qinusty | One'ish liner following up from the temporary failure MR. Ready for review. | 08:19 |
gitlab-br-bot | buildstream: merge request (Qinusty/502->master: cascache.py: Raise ArtifactError on grpc error) #576 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/576 | 08:25 |
gitlab-br-bot | buildstream: merge request (Qinusty/481->master: Skipped sessions will no longer be reported as SUCCESS) #562 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 08:26 |
tristan | qinusty, gotcha | 08:31 |
qinusty | Phil spotted a typo but that has been resolved. | 08:32 |
gitlab-br-bot | buildstream: merge request (phil/437-junction-tutorial->master: Phil/437 junction tutorial) #550 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/550 | 08:32 |
* tristan just asks for 'from e' whenever raising a more refined error from another error | 08:33 | |
gitlab-br-bot | buildstream: merge request (Qinusty/481->master: Add SKIPPED message type for actions being skipped) #562 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 08:33 |
*** bochecha has joined #buildstream | 08:36 | |
* qinusty will sort that | 08:38 | |
*** jonathanmaw has joined #buildstream | 08:47 | |
gitlab-br-bot | buildstream: merge request (Qinusty/502->master: cascache.py: Raise ArtifactError on grpc error) #576 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/576 | 08:51 |
gitlab-br-bot | buildstream: merge request (507-some-log-lines-appear-to-be-duplicates->master: Resolve "Some log lines appear to be duplicates") #573 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 08:52 |
gitlab-br-bot | buildstream: merge request (Qinusty/502->master: cascache.py: Raise ArtifactError on grpc error) #576 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/576 | 08:53 |
gitlab-br-bot | buildstream: merge request (507-some-log-lines-appear-to-be-duplicates->master: Resolve "Some log lines appear to be duplicates") #573 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 08:57 |
gitlab-br-bot | buildstream: merge request (edbaunton/doc-typo->master: element.py (docs): dashes not underscores for build and install root) #577 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/577 | 08:59 |
tpollard | tristan: I think 561 should be ready to merge | 09:04 |
jonathanmaw | tristan: I gather the conclusion from your comments on translate_url is that it should have the Since noted for the new arg, and should also be a keyword arg | 09:07 |
jonathanmaw | or is it being a keyword arg only required if it was an internal arg? | 09:07 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache size is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 09:12 |
laurence | Re the bug about spurious test failures seen since we landed CAS, I will add the label 'important' on gitlab, unless anyone opposes | 09:13 |
laurence | https://gitlab.com/BuildStream/buildstream/issues/503 | 09:13 |
qinusty | Sounds good to me, I had a look but had no luck getting to the cause | 09:14 |
laurence | qinusty, re raising an ArtifactError on grpc error - https://gitlab.com/BuildStream/buildstream/merge_requests/576#note_90732032 | 09:16 |
laurence | you can hit the merge button :) | 09:16 |
laurence | you should have permissions - let me know if not | 09:17 |
tiagogomes | juergbi I am getting an odd error when trying to build the freedesktop-sdk possibly related to the introduction of cas: https://gitlab-artifacts.s3.amazonaws.com/37/92/3792f780bdc299ccc06d417d7957eb60befcd2c7b78980899c4cd73e3a9ca65a/2018_07_27/84724566/71557148/job.log?response-content-type=text/plain%3B%20charset%3Dutf-8&response-content-disposition=inline&X-Amz-Expires=600&X-Amz-Date=20180727T091559Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Cr | 09:17 |
tiagogomes | edential=AKIAJTOFWQ3GL4O3Q3FA/20180727/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=49c6e768f099abfafe1d9daf89c996c81a0f34a8dfafaf8adddda256bc2fe30d | 09:17 |
gitlab-br-bot | buildstream: merge request (507-some-log-lines-appear-to-be-duplicates->master: Resolve "Some log lines appear to be duplicates") #573 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 09:17 |
tiagogomes | Sorry https://gitlab.com/BuildStream/buildstream/-/jobs/84724566 | 09:17 |
tiagogomes | juergbi grep for FileNotFoundError | 09:18 |
qinusty | https://i.imgur.com/XJAXp3r.png I can't laurence :P | 09:18 |
* tlater gives qinusty developer access | 09:18 | |
tlater | qinusty: Tell me if that's not enough, perhaps I need to make you maintainer | 09:19 |
* qinusty realises pipeline failed, then realises it was just test_build_track -_- | 09:19 | |
qinusty | Nope, must only be maintainers who can hit merge | 09:20 |
juergbi | tiagogomes: I think that's tlater's cache expiration code, maybe he knows what's going on | 09:20 |
juergbi | I suspect the size calculation code can't deal with concurrent deletion of (temporary) files | 09:20 |
* tlater reads backlog | 09:21 | |
laurence | qinusty, will sort that, for now pls ask someone else to hit merge - tlater ? | 09:21 |
juergbi | should maybe simply ignore files that don't exist anymore and/or ignore cas/tmp | 09:21 |
qinusty | tlater: https://gitlab.com/BuildStream/buildstream/merge_requests/576 Big green button please :) | 09:22 |
tlater | laurence, qinusty: I can give maintainer access, but will merge too :) | 09:22 |
qinusty | ooooo big blue button | 09:22 |
qinusty | it just appeared, ty tlater | 09:22 |
qinusty | Do we remove branches once we merge? or leave them? | 09:22 |
laurence | tlater, ah cool ! sorry for the noise then | 09:23 |
laurence | i thought only owner's could give that permission but other maintainers can anyway, cool | 09:23 |
jonathanmaw | tristan: never mind, I'm going to make it a keyword-only arg anyway. | 09:24 |
tiagogomes | qinusty I like to delete mines, otherwise it would be way too many branches | 09:24 |
gitlab-br-bot | buildstream: issue #518 ("Backport solution for #163 (MR !541) to the bst-1.2 branch") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/518 | 09:30 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache size is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 09:32 |
gitlab-br-bot | buildstream: issue #496 ("Plugin facing API does not provide access to PluginError") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/496 | 09:35 |
gitlab-br-bot | buildstream: merge request (edbaunton/doc-typo->master: element.py (docs): dashes not underscores for build and install root) #577 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/577 | 09:37 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache size is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 09:41 |
laurence | there are so many bugs with 'important' label | 09:51 |
laurence | it de-values the label somewhat | 09:52 |
qinusty | tlater: Were you happy with https://gitlab.com/BuildStream/buildstream/merge_requests/563 in the end? The elif to if change is going through the pipeline now | 09:54 |
tlater | qinusty: I've been unable to produce a system that broke | 09:55 |
tlater | I think I'd like to spend more time testing, but really, I probably shouldn't | 09:55 |
* tlater approves it | 09:55 | |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache size is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 09:55 |
gitlab-br-bot | buildstream: issue #520 ("Race condition when calculating disk usage") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/520 | 09:55 |
tlater | Feel free to merge! | 09:55 |
tlater | You have permissions now ;) | 09:55 |
qinusty | Will once the pipeline succeeds, I was also unable to produce these edge cases. | 09:57 |
qinusty | However these checks should cover the majority of cases where issues would arise :) | 09:57 |
tlater | noisecell: Have you tried re-running that CI? | 10:05 |
tlater | Well, regardless, I think we can make those checks more resistant to such changes... | 10:05 |
qinusty | did you fix the regression tlater? | 10:05 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer users to our tutorail before referring them to other bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 10:05 |
tlater | qinusty: Do you mean the duplicate regression? | 10:05 |
qinusty | Yes | 10:05 |
tlater | I'd like for you to review, actually: https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 10:06 |
noisecell | tlater, re-running CI for? | 10:06 |
qinusty | I'll take a look :) re cache quota: If you think we can make it more resistant, we shouldn't merge until we're happy | 10:06 |
tlater | qinusty: Actually, second, there's something wrong with that branch | 10:07 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer users to our tutorail before referring them to other bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 10:07 |
tlater | qinusty: Hrm | 10:07 |
tlater | This is actually separate from your code there, but we could land it with that | 10:07 |
tlater | I'm talking about: https://gitlab.com/BuildStream/buildstream/-/jobs/84724566 | 10:08 |
tlater | Search for "FileNotFoundError" | 10:08 |
tlater | Oh, actually, nevermind | 10:08 |
tiagogomes | tlater I filed that as #563 | 10:08 |
tlater | That's part of the cascache | 10:08 |
tlater | qinusty: Yeah, it's entirely unrelated :) | 10:09 |
tlater | qinusty: Also, nevermind, the branch is correct | 10:09 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer readers to our tutorial before referring them to existing bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 10:09 |
jennis2 | If anyone has time for a pretty trivial review: https://gitlab.com/BuildStream/buildstream/merge_requests/578 I would really appreciate that | 10:09 |
*** noisecell has quit IRC | 10:10 | |
tlater | tiagogomes: Thanks! | 10:10 |
qinusty | tlater: Is detail enabled by default? | 10:12 |
tlater | qinusty: Yes - is detail not showing for you? | 10:12 |
qinusty | Haven't executed it yet :P Just wondering looking at the diff | 10:12 |
* tlater is paranoid | 10:13 | |
tlater | heh | 10:13 |
qinusty | I'll check | 10:13 |
qinusty | AH | 10:14 |
qinusty | the detail is the next line in grey | 10:14 |
qinusty | I seeeeeeeeeeeeee | 10:14 |
tiagogomes | jennis2 I left a comment | 10:14 |
gitlab-br-bot | buildstream: merge request (507-some-log-lines-appear-to-be-duplicates->master: Resolve "Some log lines appear to be duplicates") #573 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 10:15 |
jennis2 | thanks tiagogomes | 10:15 |
*** jennis2 is now known as jennis | 10:15 | |
tlater | qinusty: I double checked with a version of the codebase before I made my changes, so I think the output format there is correct | 10:16 |
tlater | At any rate, it looks pretty enough | 10:16 |
qinusty | I agree :) | 10:16 |
qinusty | I do think we should encourage the inclusion of screenshots into visual changes though :P It makes viewing an MR/issue clearer | 10:16 |
qinusty | and gitlab allows you to embed into comments easily | 10:17 |
* qinusty wonders if he can bypass the "merge once pipeline succeeds due to the test_build_track issue | 10:18 | |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer readers to our tutorial before referring them to existing bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 10:20 |
* tlater has been hearing about this issue | 10:20 | |
tlater | Does anyone have the bandwidth to deal with it? | 10:20 |
* qinusty was unable to solve it | 10:20 | |
tlater | It seems to be blocking a bunch of people... | 10:20 |
tlater | qinusty: Thanks nonetheless. Hopefully someone finds the time soonish. | 10:20 |
jennis | tiagogomes, Phil thanks for spotting those | 10:21 |
gitlab-br-bot | buildstream: merge request (328-support-for-downloading-sources-from-mirrors->master: Resolve "Support for downloading sources from mirrors") #404 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/404 | 10:22 |
gitlab-br-bot | buildstream: issue #502 ("Unhandled excpetions within CASCache on grpc errors") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/502 | 10:22 |
gitlab-br-bot | buildstream: merge request (Qinusty/502->master: cascache.py: Raise ArtifactError on grpc error) #576 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/576 | 10:22 |
gitlab-br-bot | buildstream: merge request (relative_workspaces->master: WIP: Patch for issue #191 support relative workspaces) #504 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/504 | 10:23 |
gitlab-br-bot | buildstream: issue #521 ("Direct import of tar files into virtual directories") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/521 | 10:27 |
gitlab-br-bot | buildstream: merge request (507-some-log-lines-appear-to-be-duplicates->master: Resolve "Some log lines appear to be duplicates") #573 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/573 | 10:33 |
qinusty | Does anyone object to me extending the .gitignore? | 10:37 |
gitlab-br-bot | buildstream: issue #20 ("Rare exception when terminating processes") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/20 | 10:38 |
*** jonathanmaw_ has joined #buildstream | 10:41 | |
qinusty | Examples of extension include .vscode/ (ide folder) and .pytest_cache for those running pytest locally. | 10:41 |
*** jonathanmaw has quit IRC | 10:41 | |
gitlab-br-bot | buildstream: merge request (edbaunton/doc-typo->master: element.py (docs): dashes not underscores for build and install root) #577 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/577 | 10:45 |
*** jjardon sets mode: +M | 10:48 | |
*** jjardon sets mode: -M | 10:49 | |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache quota is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 10:52 |
gitlab-br-bot | buildstream: merge request (phil/add-ubuntu-ci-job->master: .gitlab-ci-yml: Add ubuntu 18 test) #523 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/523 | 10:58 |
*** patate has joined #buildstream | 11:01 | |
gitlab-br-bot | buildstream: merge request (phil/437-junction-tutorial->master: Phil/437 junction tutorial) #550 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/550 | 11:01 |
gitlab-br-bot | buildstream: merge request (phil/437-junction-tutorial->master: Phil/437 junction tutorial) #550 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/550 | 11:01 |
*** cs_shadow has joined #buildstream | 11:09 | |
cs_shadow | https://gitlab.com/BuildStream/buildstream-docker-images/-/jobs/84846081 - "At least 2MB more space needed on the / filesystem." | 11:10 |
cs_shadow | Who controls these aarch64 runners? Seems like they are running out of disk space | 11:10 |
qinusty | jjardon I believe? | 11:10 |
gitlab-br-bot | buildstream: merge request (phil/436-add-ubuntu-install-intructions->master: Add Ubuntu install intructions) #525 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/525 | 11:11 |
qinusty | tlater: I'm happy to pick up https://gitlab.com/BuildStream/buildstream/issues/515 but I'd like to land https://gitlab.com/BuildStream/buildstream/merge_requests/562 first to add the SKIPPED message type. | 11:12 |
*** noisecell has joined #buildstream | 11:12 | |
tlater | qinusty: Please keep editor/ide-specific stuff out of the codebase | 11:13 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer readers to our tutorial before referring them to existing bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 11:13 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer readers to our tutorial before referring them to existing bst projects) #578 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 11:13 |
tlater | If you want to have a small addition, I recommend moving it around with git stashes | 11:14 |
qinusty | I found a solution :) I added it to .git/info/exclude which is local repo specific | 11:14 |
tlater | Ah, nice, I didn't know about that :) | 11:14 |
qinusty | Its basically a personal .gitignore | 11:14 |
qinusty | HOWEVER .pytest_cache/ Probably should be in our .gitignore | 11:15 |
tlater | That said, if there's any debris our test suite creates that we should remove, that's definitely worth adding | 11:15 |
tlater | Yep | 11:15 |
jjardon | cs_shadow: it should be fixed now | 11:15 |
qinusty | I'll raise an issue and fix it at some point | 11:15 |
qinusty | Or maybe just do it now and avoid an issue | 11:15 |
cs_shadow | thanks jjardon | 11:15 |
tlater | qinusty: If you have a small MR feel free to push it up without an issue | 11:16 |
tlater | Really small ones are probably self-explanatoryu | 11:16 |
tlater | *explanatory | 11:16 |
tlater | Just make sure someone is aware and willing to review, so it doesn't hang around :) | 11:17 |
jjardon | mmm, seems master is broken? | 11:17 |
tlater | qinusty: About !562 | 11:17 |
jjardon | seems unix tests are failing | 11:18 |
Phil | jjardon, there is an intermittent test failure, See https://gitlab.com/BuildStream/buildstream/issues/503 | 11:18 |
qinusty | Yes tlater, I need tristans opinion on adding the MessageType.SKIPPED really. I removed the session SKIPPED message. | 11:18 |
Phil | It will tend to pass if you rerun the test | 11:18 |
qinusty | jjardon: I'd just rerun the test if its test_build_track that failed. | 11:19 |
tlater | qinusty: I think that's fine, and don't see tristan objecting | 11:19 |
qinusty | Merge? | 11:19 |
tlater | Still concerned about the duplicate message | 11:19 |
qinusty | Um, yes. That needs to be clarified | 11:19 |
jjardon | ah ok, thanks Phil qinusty | 11:19 |
qinusty | We need to distinguish the keys | 11:20 |
tlater | qinusty: Could you describe the exact problem? | 11:20 |
tlater | I can see from the screenshot that there are duplicates | 11:20 |
tlater | I'm assuming this happens because the two keys are the exact same (rather than just their short form being the same) | 11:20 |
gitlab-br-bot | buildstream: merge request (Qinusty/pytest_cache_gitignore->master: Add .pytest_cache/ to gitignore) #579 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/579 | 11:21 |
gitlab-br-bot | buildstream: merge request (Qinusty/pytest_cache_gitignore->master: Add .pytest_cache/ to gitignore) #579 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/579 | 11:21 |
tlater | That is always the case in strict mode as far as I am aware | 11:21 |
tlater | Is there a chance we could make that message per-element, rather than per-artifct? | 11:22 |
bochecha | hi, is the host arch taken into account when computing cache keys? | 11:22 |
bochecha | I'm building the freedesktop sdk for ARM on an x86_64 laptop, and bst just builds everything instead of pulling from the cache :( | 11:22 |
bochecha | the exact same revision has been built in the CI and is available in the cache, but bst computes different cache keys on my laptop | 11:23 |
*** leopi has quit IRC | 11:28 | |
*** leopi has joined #buildstream | 11:30 | |
persia | bochecha: target arch is part of the cache key for certain. I don't think host base arch should be (I'm presuming your host is configured to handle running arm binaries in some way). | 11:31 |
bochecha | persia: yes, with qemu/binfmt | 11:32 |
bochecha | I mean the arm sdk is building just fine right now on my laptop | 11:32 |
bochecha | it's just incredibly slow, and heating up my living room in a way I'm really not comfortable, especially when a heatwave is already hitting the region :) | 11:32 |
persia | Yep. That's normal for qemu/binfmt :) | 11:33 |
bochecha | and it's kind of silly to be doing so much work on my laptop, when the built bits all are in the cache | 11:33 |
persia | But my nonparenthetical point stands, that the host base arch shouldn't matter (beause there are lots of ways to run lots of different binary code in lots of different environments). | 11:33 |
persia | So if it does, I think that is a bug. | 11:33 |
persia | (but I don't know if it does) | 11:33 |
bochecha | yeah, I don't know either | 11:34 |
noisecell | bochecha, have you check that your project.conf and (Im not sure about the following but...) your buildstream.conf are the same in both machines? | 11:34 |
bochecha | and I thought the same, that it shouldn't | 11:34 |
bochecha | noisecell: project.conf is the same, yes | 11:34 |
bochecha | it's in git, I didn't modify it locally | 11:34 |
bochecha | the other one is at ~/.config/buildstream.conf right? | 11:35 |
noisecell | I think so | 11:35 |
bochecha | if so, it just contains comments here on my laptop | 11:35 |
bochecha | not sure about the CI, I'll check, thanks for the lead | 11:35 |
bochecha | after lunch, though :) | 11:35 |
noisecell | you are welcome. Enjoy your lunch :) | 11:36 |
persia | If buildstream.conf is affecting cache keys, I suspect we're doing something wrong. | 11:46 |
gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: WIP: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 11:46 |
bochecha | the buildstream.conf is indeed different in the CI | 11:51 |
bochecha | because it can push to the cache | 11:52 |
bochecha | whereas I can only pull on my laptop, so I use the cache urls (https) defined in project.conf | 11:52 |
bochecha | it also has a different config for fetchers and network retries | 11:53 |
bochecha | but that also shouldn't enter in computing the cache keys, right? | 11:53 |
gitlab-br-bot | buildstream: merge request (jennis/doc_improvements->master: Refer readers to our tutorial before referring them to existing bst projects) #578 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/578 | 11:54 |
Nexus | the new tag is crippling my tests :( | 12:03 |
bochecha | ok, so using the same buildstream.conf I still don't hit the cache | 12:08 |
bochecha | which is reassuring, the buildstream.conf had no impact on the cache key :) | 12:08 |
bochecha | any other idea? | 12:08 |
gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 12:13 |
gitlab-br-bot | buildstream: merge request (328-support-for-downloading-sources-from-mirrors->master: Resolve "Support for downloading sources from mirrors") #404 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/404 | 12:25 |
gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: WIP: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 12:29 |
gitlab-br-bot | buildstream: issue #522 ("We need to think about temporary vs. permanent failures in source mirroring") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/522 | 12:38 |
gitlab-br-bot | buildstream: merge request (phil/437-workspaces-tutorial->master: Phil/437 workspaces tutorial) #519 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/519 | 12:49 |
*** xjuan has joined #buildstream | 12:58 | |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache quota is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 13:00 |
*** qinusty has quit IRC | 13:06 | |
gitlab-br-bot | buildstream: issue #328 ("Support for downloading sources from mirrors") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/328 | 13:08 |
gitlab-br-bot | buildstream: merge request (328-support-for-downloading-sources-from-mirrors->master: Resolve "Support for downloading sources from mirrors") #404 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/404 | 13:08 |
*** qinusty has joined #buildstream | 13:14 | |
*** jonathanmaw_ is now known as jonathanmaw | 13:18 | |
qinusty | tlater I'm auto merging but it just seems to sit there once the pipeline completes | 13:56 |
Nexus | odd | 13:57 |
qinusty | I know! | 13:58 |
qinusty | It just says "Cancel automatic merge" | 13:58 |
Nexus | meh | 13:58 |
Nexus | just merge it | 13:58 |
qinusty | https://gitlab.com/BuildStream/buildstream/merge_requests/579 | 13:58 |
Nexus | is it all caught up to master? | 13:59 |
* qinusty -_- | 14:03 | |
qinusty | mybad, exrta merge commit *sighs* | 14:03 |
qinusty | Why can't gitlab merge just work when I asked it to? | 14:03 |
Nexus | :) | 14:04 |
qinusty | :( | 14:05 |
qinusty | That's really irritated me :/ | 14:05 |
* tlater really dislikes the recent influx of merge commits | 14:08 | |
* qinusty apologises | 14:08 | |
tlater | qinusty: Just be more careful next time - the gitlab button will say "rebase" instead of "merge" if your branch is caught up. | 14:09 |
* tlater should have responded to the ping | 14:09 | |
qinusty | Yes I realise now, but every time I tried to rebase, it then did the pipeline. And then the pipeline finished and it needed ANOTHER rebase | 14:09 |
qinusty | etc | 14:09 |
tlater | Yeah, it's a side effect of so many things landing | 14:10 |
tlater | The test failures probably don't help | 14:10 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache quota is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 14:10 |
tlater | It's just that now suddenly when you read the commit history about 50% is useless messages going "Oh, I merged something" | 14:10 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache quota is now restricted to available disk space) #563 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 14:10 |
tlater | And that also makes it really hard to rebase... | 14:11 |
tlater | |: | 14:11 |
qinusty | yup, fortunately only one of them is me | 14:11 |
tlater | Yeah, nw, I'm just ranting a bit ;) | 14:12 |
qinusty | So what is the ideal workflow? | 14:12 |
qinusty | Pull master up to date | 14:12 |
qinusty | Rebase X onto master? | 14:12 |
qinusty | then push to master? | 14:12 |
* tlater just rebases to origin/master | 14:12 | |
tlater | Using `git fetch` instead of `git pull` | 14:13 |
tlater | But that's probably just me | 14:13 |
qinusty | I'll avoid git merge in future | 14:13 |
WSalmon | if you set off all the tests with './setup.py test' is there a good way to kill them all? there a little slow and i dont wan to resort to closing the terminal | 14:13 |
qinusty | ctrl C? | 14:13 |
tlater | WSalmon: kill -9 <PID> | 14:13 |
WSalmon | nope | 14:13 |
WSalmon | urrr | 14:13 |
WSalmon | ok | 14:14 |
WSalmon | thanks | 14:14 |
tlater | Unfortunately that's the only thing we can do atm... | 14:14 |
* tlater wonders what catches the signal... | 14:14 | |
jmac | Ctrl-C does nothing | 14:14 |
WSalmon | also i almost never git pull, i always 'git fetch' have a look at what has changed and then decide how to merge/rebase etc | 14:14 |
qinusty | tlater, when you merge/rebase. How does gitlab know that your merge/rebase was from that MR? | 14:14 |
WSalmon | gitlab tracks the branch name | 14:15 |
tlater | ^ | 14:15 |
* noisecell won't trust that... | 14:15 | |
WSalmon | so were ever you move the branch to point at the mr will follow | 14:15 |
WSalmon | i think | 14:15 |
tlater | Yep | 14:15 |
noisecell | I would always write what Im pulling or from where Im fetching | 14:16 |
tlater | This is actually done through git shas | 14:16 |
noisecell | or you will end up with some oddities from time to time | 14:16 |
tlater | Because branches just point to shas | 14:16 |
qinusty | suggestions on what to do with https://gitlab.com/BuildStream/buildstream/merge_requests/579? | 14:16 |
tlater | So gitlab can figure out which branch contains what commits by check where in the history it is | 14:16 |
qinusty | It's the MR for the branch I merged, gitlab hasn't detected it | 14:16 |
*** ernestask has quit IRC | 14:17 | |
tlater | qinusty: Did you manually merge? | 14:17 |
tlater | I.e. without the merge button? | 14:17 |
tlater | If so you need to manually close it | 14:18 |
tlater | The idea of an MR being closed doesn't attach to its branch being in master | 14:18 |
tlater | Since the branch/master may diverge again at any point | 14:18 |
WSalmon | tlater if you move the brach to point at something that master contains is gitlabe smart enough to realise that its merge? | 14:19 |
tlater | Tristan does this frequently, he usually just mentions that it was merged from the CLI. | 14:19 |
qinusty | Ah, but if I close does it mark as MERGED or CLOSED? | 14:19 |
tlater | WSalmon: Nope, unfortunately not | 14:19 |
gitlab-br-bot | buildstream: merge request (Qinusty/pytest_cache_gitignore->master: Add .pytest_cache/ to gitignore) #579 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/579 | 14:19 |
tlater | qinusty: CLOSED, but you've already gone and done it. Best thing is to CLOSE it and mention in a comment that it was merged | 14:19 |
* tlater never manually pushes to master partially for this reason | 14:19 | |
qinusty | yup | 14:19 |
qinusty | but you rebase onto? | 14:20 |
tlater | qinusty: No - I'll rebase master onto my branch, push it to my upstream branch and use the rebase button | 14:20 |
tlater | This also makes CI work and stuff | 14:20 |
tlater | So it's really the workflow you should follow, even if it's slower. | 14:21 |
*** barschmade has joined #buildstream | 14:21 | |
* tlater realizes that we have the annoying test bug today | 14:21 | |
noisecell | tlater, who is capable to push to master? maintainers? developers? | 14:22 |
qinusty | have you encountered it yet tlater? | 14:22 |
tlater | noisecell: Maintainers | 14:22 |
tlater | qinusty: Still not, nope | 14:22 |
tlater | I seem to be the only one though and trust people that it exists | 14:22 |
noisecell | push to master shouldn't be a thing for almost anyone, IMHO | 14:23 |
tlater | noisecell: In that case you can't merge your own branches | 14:23 |
tlater | Not even with the gitlab button | 14:23 |
tlater | I agree though | 14:23 |
tlater | Preferably there was a permission that allowed you to hit the merge button but not manually push | 14:23 |
noisecell | tlater, what do you mean? can you not rebase against master and then submit that branch for review and merge? | 14:23 |
tlater | noisecell: You can, but then someone else will have to click "rebase" for you | 14:24 |
noisecell | oh, I see what you mean. I think there are enough maintainers to merge branches | 14:24 |
noisecell | so you can always ask for this to someone or we can have a label for this, though | 14:24 |
tlater | noisecell: During GUADEC some people raised the concern that merges were too slow | 14:25 |
noisecell | tlater, I think there were only one person merging at that time | 14:25 |
tlater | Two, yes | 14:25 |
noisecell | I think right now that number has increased | 14:25 |
tlater | noisecell: We decided during GUADEC that we'd allow *anyone* who's ever committed to merge though. | 14:26 |
tlater | Whether or not that policy makes sense is something we'll figure out over the next few weeks, I suppose | 14:26 |
persia | My impression was that the intent was to permit everyone to do it (to avoid being slow), but rely on everyone being sensible about it (so it wouldn't break things). | 14:27 |
persia | So the actual number of mergers can grow slowly as people develop confidence, without too much complex process blocking folk. | 14:27 |
tlater | persia: So far it has worked... ok? I feel like master has become noticeably less stable, but it's too soon to judge whether that's because of expiry/CAS merging or many maintainers. | 14:27 |
noisecell | one thing is merge through a controlled process as gitlab or anything similar, pushing to master could cause any other kind of issues... | 14:28 |
* tlater thinks we should decree that pushing to master without the gitlab interface is verboten, but otherwise this seems fine so far. | 14:28 | |
persia | Personally, I prefer the model where almost no humans are permitted to manually merge (only 2-3 special "infra management" folk), and all merges are done by tooling, and most folk have access to tell the tooling to perform the merge. | 14:28 |
persia | I'm not sure if our current tooling supports that though. | 14:28 |
persia | tlater: Not entirely verboten (sometimes things break in ways robots can't fix), but 99%, yes please. | 14:29 |
qinusty | Also tlater, the thing that confused me was that GitLab said "merged automatically when the pipeline succeeds" but when the pipeline succeeded it just sat there. What I really needed to do was "Cancel automatic merge" then "Rebase" then wait | 14:30 |
noisecell | qinusty, that is possibly a gitlab issue more than a configuration issue in our gitlab, though | 14:32 |
tlater | qinusty: Ideally, the response to that *could* not be "oh, let's try to manually push" | 14:34 |
tlater | Although I find it understandable, it's an evil temptation | 14:34 |
tlater | And it would be nice if our tools prohibited it (except for a few really experienced guys who save everything in the rare cases that the tool breaks) | 14:35 |
tlater | Just to clarify, this is no critique to you personally, this is thinking about how our tooling should work in the long run. | 14:35 |
tlater | It's easy enough to *accidentally* push to the wrong branch, I've done it before. | 14:36 |
gitlab-br-bot | buildstream: merge request (relative_workspaces->master: WIP: Patch for issue #191 support relative workspaces) #504 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/504 | 14:39 |
noisecell | qinusty, tlater, yeah, not criticising here either, just discussing which is the normal workflow we want to adopt | 14:40 |
qinusty | I agree now that I see what has happened. In my mind, Gitlab would have followed the merge and my merge wouldn't have made two merge commits | 14:42 |
gitlab-br-bot | buildstream: merge request (chandan/sourcetransform->master: WIP: Allow source plugins to access previous sources) #568 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/568 | 14:49 |
gitlab-br-bot | buildstream: merge request (relative_workspaces->master: WIP: Patch for issue #191 support relative workspaces) #504 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/504 | 14:53 |
laurence | anyone got time to look at this MR in defs2bst? | 14:53 |
laurence | https://gitlab.com/BuildStream/defs2bst/merge_requests/5 | 14:53 |
gitlab-br-bot | buildstream: merge request (Qinusty/491->master: Cache quota is now restricted to available disk space) #563 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/563 | 14:57 |
qinusty | tlater, I just did the merge the gitlab way and it places a merge commit in anyway (for the one branch) Without rebasing manually I can't see a way of avoiding this | 15:00 |
gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:00 |
tlater | qinusty: Yep, you need to rebase manually | 15:00 |
qinusty | so gitlab's big REBASE button, merges? | 15:01 |
tlater | No, if it says REBASE it won't merge | 15:01 |
tlater | But if it says MERGE it will merge | 15:01 |
qinusty | Okay but, when you say "Merge after pipeline" or whatever | 15:01 |
qinusty | You can't rebase that can you? | 15:02 |
tlater | Then it will merge | 15:02 |
tlater | You have to *first* rebase | 15:02 |
qinusty | But you'd prefer if we didn't? | 15:02 |
tlater | And then tell i to "rebase after pipeline" | 15:02 |
qinusty | I've never seen "rebase after pipeline" I must be doing something wrong :P | 15:02 |
tlater | qinusty: Hrm, let me see how to explain this... | 15:03 |
tlater | When you're finally done with your changes and have had them reviewed | 15:03 |
tlater | You should go back to your terminal | 15:03 |
tlater | And on your branch go `git rebase -i origin/master` | 15:03 |
tlater | This will make your branch up-to-date with master | 15:03 |
tlater | You the `git push --force` that to your upstream branch | 15:03 |
tlater | And *then* gitlab will tell you it can "rebase after pipeline" | 15:03 |
qinusty | Ah, I have rebased before but onto my local master, which must've been slightly out of date | 15:04 |
gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:04 |
tlater | qinusty: That's probably what happened :) | 15:04 |
*** noisecell has quit IRC | 15:05 | |
gitlab-br-bot | buildstream: merge request (edbaunton/doc-typo->master: element.py (docs): dashes not underscores for build and install root) #577 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/577 | 15:05 |
gitlab-br-bot | buildstream: merge request (relative_workspaces->master: WIP: Patch for issue #191 support relative workspaces) #504 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/504 | 15:06 |
tpollard | anyone happy to merge https://gitlab.com/BuildStream/buildstream/merge_requests/561 ? | 15:10 |
qinusty | Maybe this is the issue I saw tlater https://gitlab.com/gitlab-org/gitlab-ce/issues/30805 | 15:12 |
gitlab-br-bot | buildstream: merge request (relative_workspaces->master: WIP: Patch for issue #191 support relative workspaces) #504 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/504 | 15:13 |
tlater | qinusty: Yup, I think that's part of the reason | 15:13 |
tlater | Though the "rebase when pipeline succeeds" button does seem to be guaranteed to do the right thing | 15:14 |
gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:14 |
gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:14 |
gitlab-br-bot | buildstream: merge request (willsalmon/trackWarning->master: git.py: Add warning to git track if track and ref are not present) #580 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/580 | 15:15 |
gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 15:17 |
gitlab-br-bot | buildstream: merge request (Qinusty/481->master: Add SKIPPED message type for actions being skipped) #562 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 15:29 |
qinusty | tlater re SKIPPED: I have produced a solution which only shows the message if both the strong and weak keys are already cached on the server. https://gitlab.com/BuildStream/buildstream/merge_requests/562 | 15:30 |
gitlab-br-bot | buildstream: issue #523 ("BuildStream doesn't hit the cache when building foreign arches") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/523 | 15:40 |
gitlab-br-bot | buildstream: merge request (adamjones/systemd-cas->juerg/googlecas: Include systemd file examples for google-cas cache) #524 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/524 | 15:56 |
gitlab-br-bot | buildstream: merge request (adamjones/systemd-cas->master: Include systemd file examples for google-cas cache) #524 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/524 | 15:56 |
gitlab-br-bot | buildstream: merge request (adamjones/systemd-cas->master: Include systemd file examples for google-cas cache) #524 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/524 | 15:59 |
gitlab-br-bot | buildstream: merge request (edbaunton/executable-remote-source->master: remote.py: Add support for marking downloaded files executable) #581 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/581 | 16:14 |
*** tpollard has quit IRC | 16:18 | |
gitlab-br-bot | buildstream: merge request (edbaunton/executable-remote-source->master: remote.py: Add support for marking downloaded files executable) #581 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/581 | 16:20 |
gitlab-br-bot | buildstream: merge request (richardmaw/cache-fail->master: WIP: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/475 | 16:44 |
gitlab-br-bot | buildstream: merge request (edbaunton/executable-remote-source->master: remote.py: Add support for marking downloaded files executable) #581 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/581 | 16:46 |
gitlab-br-bot | buildstream: merge request (richardmaw/cache-fail->master: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/475 | 16:50 |
persia | Is it possible to get gitlab-br-bot to also report new/changed issues here? | 16:50 |
*** finn has quit IRC | 16:51 | |
*** finn has joined #buildstream | 16:52 | |
*** edb has joined #buildstream | 16:54 | |
*** jonathanmaw has quit IRC | 17:09 | |
*** bochecha has quit IRC | 17:12 | |
*** edb has quit IRC | 17:27 | |
jjardon | persia: yes, but I'm afraid that would increase the amount of noise in the channel? | 17:29 |
persia | I think there are a similar number of issues and merge requests. I also think merge requests get updated more often. | 17:30 |
persia | I agree that it would increase traffic in the channel. I'm unsure if it would be noise, considering how much of the substantive discussion in BuildStream happens in issues. | 17:31 |
persia | Knowing it is possible is good (thanks). Proper discussion of whether to do it should probably be reserved for something other than Friday night :) | 17:32 |
*** tiagogomes has quit IRC | 17:40 | |
*** cs_shadow has quit IRC | 17:49 | |
*** leopi has quit IRC | 17:50 | |
*** xjuan has quit IRC | 18:29 | |
*** xjuan_ has joined #buildstream | 18:29 | |
*** bochecha has joined #buildstream | 18:51 | |
*** wols has joined #buildstream | 20:11 | |
*** Natechip has joined #buildstream | 20:26 | |
gitlab-br-bot | buildstream: issue #524 ("fetching from ostree repos sometimes fails with a gpg error") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/524 | 20:40 |
*** ernestask has joined #buildstream | 20:49 | |
*** SebastianFlyte has joined #buildstream | 21:21 | |
*** tristan has quit IRC | 21:22 | |
*** Slumlord_ has joined #buildstream | 21:59 | |
*** ernestask has quit IRC | 22:56 | |
*** bochecha has quit IRC | 23:21 | |
*** Auctus has joined #buildstream | 23:26 | |
*** shah has joined #buildstream | 23:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!