| *** Prince781 has joined #buildstream | 00:24 | |
| *** Prince781 has quit IRC | 01:56 | |
| *** Prince781 has joined #buildstream | 01:57 | |
| *** Prince781 has quit IRC | 03:11 | |
| *** Prince781 has joined #buildstream | 03:13 | |
| *** Prince781 has quit IRC | 03:18 | |
| *** Prince781 has joined #buildstream | 03:20 | |
| *** Trevinho has quit IRC | 03:39 | |
| *** Trevinho has joined #buildstream | 03:39 | |
| *** csoriano has quit IRC | 03:39 | |
| *** csoriano has joined #buildstream | 03:39 | |
| *** csoriano has quit IRC | 03:43 | |
| *** Trevinho has quit IRC | 03:45 | |
| *** Trevinho has joined #buildstream | 03:46 | |
| *** csoriano has joined #buildstream | 03:46 | |
| *** jjardon has quit IRC | 03:48 | |
| *** Trevinho has quit IRC | 03:49 | |
| *** csoriano has quit IRC | 03:49 | |
| *** Prince781 has quit IRC | 05:00 | |
| *** toscalix has joined #buildstream | 05:25 | |
| *** Trevinho has joined #buildstream | 05:31 | |
| *** toscalix has quit IRC | 05:32 | |
| *** toscalix has joined #buildstream | 05:34 | |
| *** toscalix has quit IRC | 05:44 | |
| *** Trevinho has quit IRC | 05:46 | |
| *** Trevinho has joined #buildstream | 05:46 | |
| *** csoriano has joined #buildstream | 05:47 | |
| *** Trevinho has quit IRC | 05:50 | |
| *** Trevinho has joined #buildstream | 05:50 | |
| *** csoriano has quit IRC | 05:51 | |
| *** csoriano has joined #buildstream | 05:51 | |
| *** Trevinho has quit IRC | 05:54 | |
| *** csoriano has quit IRC | 05:55 | |
| *** Prince781 has joined #buildstream | 06:02 | |
| *** csoriano has joined #buildstream | 06:09 | |
| *** csoriano has quit IRC | 06:10 | |
| *** csoriano has joined #buildstream | 06:10 | |
| *** Trevinho has joined #buildstream | 06:11 | |
| *** jjardon has joined #buildstream | 06:20 | |
| *** mohan43u has joined #buildstream | 06:25 | |
| *** ernestask has joined #buildstream | 06:32 | |
| *** Prince781 has quit IRC | 06:34 | |
| *** mohan43u has quit IRC | 06:42 | |
| *** toscalix has joined #buildstream | 07:31 | |
| *** toscalix has quit IRC | 07:31 | |
| gitlab-br-bot | buildstream: merge request (dp0/pylint_restrict->master: Restrict version of pylint) #509 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/509 | 07:33 |
|---|---|---|
| gitlab-br-bot | buildstream: merge request (dp0/pylint_restrict->master: Restrict version of pylint) #503 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/503 | 07:34 |
| *** coldtom has joined #buildstream | 07:50 | |
| *** Phil has joined #buildstream | 08:09 | |
| gitlab-br-bot | buildstream: merge request (430-buildstream-doap-is-incorrectly-included-in-manifest-in->master: Resolve "BuildStream.doap is incorrectly included in MANIFEST.in") #508 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/508 | 08:17 |
| gitlab-br-bot | buildstream: issue #431 ("BuildStream and BuildGrid clash over use of protobuf") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/431 | 08:47 |
| *** tiago has joined #buildstream | 08:49 | |
| *** aday has joined #buildstream | 08:51 | |
| *** jonathanmaw has joined #buildstream | 09:09 | |
| *** dominic has joined #buildstream | 09:22 | |
| *** bethw has joined #buildstream | 09:39 | |
| *** tiago has quit IRC | 09:49 | |
| *** tiago has joined #buildstream | 09:53 | |
| *** aday has quit IRC | 10:43 | |
| *** aday has joined #buildstream | 10:44 | |
| *** aday has quit IRC | 10:48 | |
| *** aday has joined #buildstream | 10:49 | |
| laurence | coldtom, potentially an overly challenging one, but see what you make of this issue - aborting bst push command causes stack trace - https://gitlab.com/BuildStream/buildstream/issues/138 | 10:55 |
| coldtom | will look into it, thanks | 10:57 |
| *** coldtom has quit IRC | 11:02 | |
| *** aday has quit IRC | 11:13 | |
| *** aday has joined #buildstream | 11:15 | |
| *** cs_shadow has joined #buildstream | 11:17 | |
| *** aday has quit IRC | 11:18 | |
| *** aday has joined #buildstream | 11:20 | |
| *** coldtom has joined #buildstream | 11:25 | |
| *** coldtom has quit IRC | 11:28 | |
| *** cold-tom has joined #buildstream | 11:28 | |
| *** Prince781 has joined #buildstream | 13:23 | |
| *** Prince781 has quit IRC | 13:37 | |
| laurence | tlater, not urgent, but please remind me, the changes to the scheduler that you had to do which came out of the local cache expiry work... | 13:38 |
| laurence | where they captured in this MR? Resolve "Allow queues to run auxilliary jobs after an element's job finishes" https://gitlab.com/BuildStream/buildstream/merge_requests/433 | 13:38 |
| laurence | or just in 'expire artifacst in local cache' ?? https://gitlab.com/BuildStream/buildstream/merge_requests/347 | 13:39 |
| tlater | laurence: I dislike this answer, but it's both. The up-to-date version is in !347. | 13:40 |
| tlater | This happened because I realized landing this as a separate MR wouldn't make sense | 13:40 |
| tlater | On that note, I thought I had closed that | 13:40 |
| tlater | So I should close it again | 13:40 |
| tlater | (Close !433, land !347 asap) | 13:40 |
| gitlab-br-bot | buildstream: merge request (372-allow-queues-to-run-auxilliary-jobs-after-an-element-s-job-finishes->master: WIP: Resolve "Allow queues to run auxilliary jobs after an element's job finishes") #433 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/433 | 13:41 |
| laurence | tlater, tvm | 13:41 |
| *** ernestask has quit IRC | 14:38 | |
| gitlab-br-bot | buildstream: issue #432 ("Developing applications and libraries at the same time should be easier") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/432 | 14:40 |
| *** Prince781 has joined #buildstream | 14:43 | |
| *** tristan has joined #buildstream | 14:44 | |
| gitlab-br-bot | buildstream: issue #433 ("Allow incremental builds when retrying builds") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/433 | 14:46 |
| *** Prince781 has quit IRC | 14:50 | |
| *** Prince781 has joined #buildstream | 15:04 | |
| *** bochecha_ has joined #buildstream | 15:04 | |
| *** Prince781 has quit IRC | 15:07 | |
| *** dominic has quit IRC | 15:16 | |
| *** dominic has joined #buildstream | 15:17 | |
| *** Prince781 has joined #buildstream | 15:38 | |
| *** Prince781 has quit IRC | 15:41 | |
| tlater | Does have a clue what's going on with my statvfs call? https://gitlab.com/BuildStream/buildstream/-/jobs/74064375 | 15:52 |
| tlater | i.e.: AttributeError: 'statvfs_result' object has no attribute 'f_bavail' | 15:52 |
| tlater | I haven't changed the way that's called, it has worked before and according to all documentation under the sun it's just supposed to have that attribute | 15:53 |
| tlater | In fact, when manually trying it in a shell it works fine |: | 15:53 |
| jennis | long shot but I hope this has nothing to do with me mocking this call in my tests | 16:01 |
| jennis | os.statvfs() | 16:01 |
| jennis | I suspect that's not the case | 16:01 |
| tlater | Ah | 16:02 |
| tlater | That would explain it | 16:02 |
| tlater | ta jennis | 16:02 |
| jennis | Also, is it not f_bfree? | 16:03 |
| tlater | jennis: That's the issue, I suspect you didn't use bavail | 16:03 |
| tlater | And hence didn't mock it | 16:03 |
| jennis | I did not | 16:03 |
| * tlater recommends fully sticking to the mocked interface, and not just picking out what you use | 16:03 | |
| tlater | But then again, that's not always easy | 16:03 |
| jennis | os.statvfs = MagicMock(return_value=statvfs_result(f_blocks=int(10e9), | 16:03 |
| jennis | f_bfree=(int(12e6) + int(2e9)), | 16:03 |
| jennis | f_bsize=1)) | 16:03 |
| jennis | Yes, I just mocked the above ^^ | 16:04 |
| tlater | Hm, how can we make this better... | 16:04 |
| tlater | I suppose we could get the real return value, and just overwrite the ones you require for your test | 16:04 |
| jennis | I thought the whole point was that the mocking would only occur in the tests | 16:05 |
| jennis | on a test by test basis | 16:05 |
| *** bochecha_ has quit IRC | 16:06 | |
| tlater | jennis: Yep, and this only occurs in specific tests | 16:06 |
| tlater | Those tests, however, also run through a portion of code that otherwise uses the mocked function | 16:07 |
| tlater | (I should have guessed something along these lines, probably was about to discover it anyway) | 16:07 |
| gitlab-br-bot | buildstream: merge request (135-expire-artifacts-in-local-cache->master: WIP: Resolve "Expire artifacts in local cache") #347 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/347 | 16:33 |
| tlater | tristan: Would you mind having a look at https://gitlab.com/BuildStream/buildstream/merge_requests/347 ? jennis has reviewed it, and I haven't quite finished up cleaning it yet, but I'd like to know if there are any larger discrepancies in design or somesuch | 16:34 |
| tristan | tlater, yup, will do | 16:35 |
| *** Phil has quit IRC | 16:38 | |
| tlater | ty :) | 16:43 |
| *** tristan has quit IRC | 16:45 | |
| *** bethw has quit IRC | 16:53 | |
| *** dominic has quit IRC | 16:58 | |
| *** cold-tom has quit IRC | 17:08 | |
| *** Prince781 has joined #buildstream | 17:14 | |
| *** Prince781 has quit IRC | 17:31 | |
| *** Prince781 has joined #buildstream | 17:34 | |
| *** tristan has joined #buildstream | 17:35 | |
| *** jonathanmaw has quit IRC | 17:43 | |
| *** Prince781 has quit IRC | 18:07 | |
| *** kelli365 has joined #buildstream | 19:22 | |
| *** kelli365 has quit IRC | 19:25 | |
| *** kelli365 has joined #buildstream | 19:25 | |
| *** kelli365 has joined #buildstream | 19:26 | |
| *** tristan has quit IRC | 19:30 | |
| *** aday has quit IRC | 20:51 | |
| *** cs_shadow has quit IRC | 20:56 | |
| *** tristan has joined #buildstream | 21:30 | |
| gitlab-br-bot | buildstream: merge request (dp0/pylint_restrict->master: Restrict version of pylint) #509 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/509 | 22:05 |
| gitlab-br-bot | buildstream: issue #427 ("pylint version too permissive") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/427 | 22:44 |
| gitlab-br-bot | buildstream: merge request (dp0/pylint_restrict->master: Restrict version of pylint) #509 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/509 | 22:44 |
| *** Prince781 has joined #buildstream | 23:12 | |
| *** Prince781 has quit IRC | 23:19 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!