| *** Prince781 has joined #buildstream | 00:33 | |
| *** tristan has joined #buildstream | 02:04 | |
| *** tristan has quit IRC | 02:50 | |
| *** Prince781 has quit IRC | 04:52 | |
| *** toscalix has joined #buildstream | 07:29 | |
| *** Phil has joined #buildstream | 08:13 | |
| *** jennis has joined #buildstream | 08:13 | |
| *** toscalix has quit IRC | 08:21 | |
| *** slaf_ has joined #buildstream | 08:32 | |
| *** slaf_ has joined #buildstream | 08:32 | |
| *** slaf_ has joined #buildstream | 08:32 | |
| *** slaf_ has joined #buildstream | 08:33 | |
| *** slaf_ has joined #buildstream | 08:33 | |
| *** slaf_ has joined #buildstream | 08:33 | |
| *** slaf_ has joined #buildstream | 08:34 | |
| *** slaf_ has joined #buildstream | 08:34 | |
| *** slaf has quit IRC | 08:34 | |
| *** slaf has joined #buildstream | 08:34 | |
| *** slaf has joined #buildstream | 08:34 | |
| *** slaf has joined #buildstream | 08:35 | |
| *** slaf has joined #buildstream | 08:35 | |
| *** slaf has joined #buildstream | 08:35 | |
| *** slaf has joined #buildstream | 08:35 | |
| *** slaf has joined #buildstream | 08:36 | |
| *** slaf has joined #buildstream | 08:36 | |
| *** slaf has joined #buildstream | 08:36 | |
| *** slaf has joined #buildstream | 08:36 | |
| *** jonathanmaw has joined #buildstream | 09:03 | |
| *** dominic has joined #buildstream | 09:06 | |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 09:16 |
|---|---|---|
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 09:17 |
| jonathanmaw | jennis: Are you sure about the self.error changes in https://gitlab.com/BuildStream/bst-external/merge_requests/25 > | 10:06 |
| jonathanmaw | ? | 10:06 |
| *** lantw44 has quit IRC | 10:06 | |
| jonathanmaw | I can't even find a self.error | 10:06 |
| jennis | jonathanmaw, mhmm let me double check | 10:08 |
| jonathanmaw | also, in DpkgElement._get_packages(), you have `raise self.error` then `continue` | 10:09 |
| jennis | jonathanmaw, good point, it doesn't look like this attribute exists | 10:09 |
| jennis | Ok, i'll get confirmation about why this change was made, I assumed it was to stop buildstream crashing | 10:10 |
| jonathanmaw | jennis: I think at one point we went around replacing `self.error` with `raise ElementError` because the message handling got complicated | 10:10 |
| jennis | ahh so we used to use self.error? | 10:10 |
| jonathanmaw | jennis: if you're getting these changes on behalf of someone else, it's possible they're using an older version of buildstream, if they still have self.error | 10:10 |
| jennis | jonathanmaw, that's got to be it | 10:11 |
| jennis | I'll kill the commits | 10:11 |
| jonathanmaw | I'm also not sure what the FIXME in the comment means | 10:11 |
| jonathanmaw | if it's a notice that there ought to be some future functionality changed, I'd rather have an issue raised than a comment added | 10:12 |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: WIP: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 10:14 |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: WIP: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 10:16 |
| jennis | jonathanmaw, for now we read the Packages of the debian/control file regardless of the architecture | 10:19 |
| jennis | The FIXME is to ensure that we only append binary packages that are compatible with architectures specified in project.conf options | 10:19 |
| jennis | But yes, maybe an issue is better, however I *think* there is a way to do this, I just need to re-raise the issue on here | 10:20 |
| jonathanmaw | jennis: another point is that pre-* and post-* commands were made redundant by list prepend and list append | 10:30 |
| jonathanmaw | (see doc/source/formatintro.rst) | 10:30 |
| jennis | Thanks jonathanmaw, I'll re-review! | 10:31 |
| *** Phil has quit IRC | 10:31 | |
| *** Phil has joined #buildstream | 10:31 | |
| *** finn has quit IRC | 10:32 | |
| *** jonathanmaw has quit IRC | 10:33 | |
| *** bethw has joined #buildstream | 10:40 | |
| *** jonathanmaw has joined #buildstream | 10:49 | |
| *** Phil has quit IRC | 11:00 | |
| *** Phil has joined #buildstream | 11:00 | |
| *** finn has joined #buildstream | 11:01 | |
| *** Phil has quit IRC | 11:03 | |
| *** bethw has quit IRC | 11:39 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/workspacedir_config->master: Add 'workspacedir' configuration.) #444 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/444 | 11:43 |
| gitlab-br-bot | buildstream: merge request (valentindavid/workspacedir_config->master: Add 'workspacedir' configuration.) #444 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/444 | 11:52 |
| *** Prince781 has joined #buildstream | 12:10 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/workspacedir_config->master: Add 'workspacedir' configuration.) #444 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/444 | 12:16 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 12:19 |
| *** xjuan has joined #buildstream | 12:21 | |
| *** Phil has joined #buildstream | 12:30 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/workspacedir_config->master: Add 'workspacedir' configuration.) #444 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/444 | 12:43 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 12:43 |
| jonathanmaw | jennis: I've added some review comments to your MR. there doesn't seem to be much that passes review :S | 12:49 |
| jennis | jonathanmaw, yes I've just seen, I think I'll close the MR and have another look at some of the changes | 12:50 |
| jennis | thanks | 12:50 |
| jonathanmaw | righto jennis | 12:50 |
| jonathanmaw | I also really need to improve the test coverage of these plugins :/ | 12:50 |
| jennis | jonathanmaw: aha agreed, when time allows! | 12:52 |
| gitlab-br-bot | buildstream: merge request (380-untagged-bst->master: Resolve "Uncaught ValueError when tags are not pulled into local repository") #491 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/491 | 12:53 |
| jmac | I'm broadly happy with MR !481 for now and it's ready for a first review. I think finn is going to look at it when he's finished with the remote execution work. | 12:54 |
| jmac | I'm going to start reading up on the work he's been doing now | 12:55 |
| finn | If you give me roughly another hour or so - I'll have updated the demo instructions | 12:55 |
| jmac | I'm in no rush finn | 12:55 |
| jmac | I have plenty of CAS-based things which I should have read ages ago | 12:55 |
| finn | I'd recommend also reading over the REAPI RWAPI docs | 13:00 |
| finn | I have them printed out when you need | 13:01 |
| *** jennis has quit IRC | 13:02 | |
| *** jennis has joined #buildstream | 13:19 | |
| finn | and it's in | 13:57 |
| finn | checkout my branch jmac | 13:57 |
| *** Prince781 has quit IRC | 14:07 | |
| jmac | Ta | 14:14 |
| gitlab-br-bot | buildstream: merge request (valentindavid/331_include->master: WIP: Add support for include in project.conf) #471 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/471 | 14:25 |
| gitlab-br-bot | buildstream: merge request (juerg/googlecas->master: WIP: Remote Execution CAS-based artifact cache) #337 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/337 | 15:00 |
| gitlab-br-bot | buildstream: merge request (jmac/cas_virtual_directory->jmac/googlecas_and_virtual_directories_1: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/481 | 15:07 |
| jmac | ^ I've changed the 'target' branch for !481 to jmac/googlecas_and_virtual_directories_1 which is my merge of juergbi's CAS artifact cache and my previous virtual directory work, to make it easier to review | 15:09 |
| *** lantw44 has joined #buildstream | 15:11 | |
| juergbi | ta | 15:14 |
| jmac | juergbi: I'll rebase !337 as soon as I can get buildstream working in general again - something odd has gone wrong with the protocol buffers module on my machine | 15:24 |
| gitlab-br-bot | buildstream: merge request (380-untagged-bst->master: Resolve "Uncaught ValueError when tags are not pulled into local repository") #491 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/491 | 15:24 |
| gitlab-br-bot | buildstream: issue #307 ("Follow-up from "Add getting started section"") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/307 | 15:28 |
| *** Phil has quit IRC | 15:50 | |
| gitlab-br-bot | buildstream: merge request (jmac/virtual_directories->master: WIP: Abstract directory class and filesystem-backed implementation) #445 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/445 | 15:57 |
| jennis | jonathanmaw, the MR has been updated, just two very small changes now | 16:15 |
| jonathanmaw | ta jennis | 16:16 |
| jonathanmaw | mashed approve, CI's not reponding at the moment. I'll merge on monday morning if it doesn't happen automatically. | 16:17 |
| *** jonathanmaw has quit IRC | 16:59 | |
| *** xjuan has quit IRC | 17:20 | |
| *** tristan has joined #buildstream | 17:36 | |
| theawless[m] | How do I manually run the build commands in the bst shell? Say I have to do make distcheck? | 17:42 |
| *** dominic has quit IRC | 17:46 | |
| tristan | theawless[m], you would want to use `bst shell --build <element.bst>` | 17:59 |
| tristan | theawless[m], which will probably say, that you first have to build it's dependencies | 17:59 |
| tristan | so first build it, then `bst shell --build` | 17:59 |
| tristan | theawless[m], you might also use the `--mount` option to `bst shell` to make it easy to copy the created dist tarball out of there | 18:00 |
| theawless[m] | tristan: Oh thanks that's really helpful | 18:02 |
| *** tristan has quit IRC | 19:38 | |
| *** tristan has joined #buildstream | 19:39 | |
| *** tristan_ has joined #buildstream | 19:39 | |
| gitlab-br-bot | buildstream: merge request (tristan/no-regen-configure->master: autotools plugin: Dont regenerate existing configure scripts) #492 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/492 | 19:52 |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: WIP: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 20:07 |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 20:07 |
| gitlab-br-bot | buildstream: issue #256 ("bst should not run autogen or autoreconf for autotools tarballs") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/256 | 20:26 |
| gitlab-br-bot | buildstream: issue #256 ("bst should not run autogen or autoreconf for autotools tarballs") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/256 | 20:26 |
| gitlab-br-bot | buildstream: merge request (tristan/no-regen-configure->master: autotools plugin: Dont regenerate existing configure scripts) #492 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/492 | 20:26 |
| *** solid_black has joined #buildstream | 20:44 | |
| *** solid_black has quit IRC | 21:06 | |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 21:07 |
| *** tristan_ is now known as tristan | 21:27 | |
| *** cs_shadow has quit IRC | 21:27 | |
| gitlab-br-bot | buildstream: issue #359 ("Allow working with cross-junction elements") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/359 | 21:38 |
| gitlab-br-bot | buildstream: merge request (valentindavid/359_cross_junction_elements->master: Allow names for cross junction elements) #454 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/454 | 21:38 |
| *** tristan has quit IRC | 21:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!