IRC logs for #buildstream for Tuesday, 2018-06-05

*** ironfoot has quit IRC02:06
*** ironfoot has joined #buildstream02:06
*** finn has joined #buildstream07:50
*** finn_ has joined #buildstream07:52
*** finn has quit IRC07:54
*** bochecha_ has joined #buildstream08:29
*** jonathanmaw has joined #buildstream08:41
gitlab-br-botbuildstream: merge request (richardmaw/cache-fail->master: WIP: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47508:46
gitlab-br-botbuildstream: merge request (tlater/context-trailing-slash->master: tests/context/context.py: Don't break with trailing slashes) #470 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47008:47
*** bethw has joined #buildstream08:54
gitlab-br-botbuildstream: merge request (tlater/context-trailing-slash->master: tests/context/context.py: Don't break with trailing slashes) #470 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/47009:17
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48109:22
gitlab-br-botbuildstream: merge request (caching_build_trees->master: WIP: Caching buildtrees) #474 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47409:22
*** dominic has joined #buildstream09:24
*** finn_ has quit IRC09:38
*** finn has joined #buildstream09:38
*** finn has quit IRC09:41
*** finn has joined #buildstream09:43
tlaterta for the merge juergbi :)09:44
tlaterNexus: Any branch that's up-to-date with master will no longer cause those annoying context failures09:45
tlaterSo knock yourself out using docker for testing...09:45
Nexuswoo!!!09:46
* Nexus can stop pushing test code up to the CI09:46
*** finn has quit IRC09:50
jmacjuergbi: Do you know where I can find a list of methods which operate on `repeated` fields in protocol buffers? Google isn't helping much.10:45
jmacjuergbi: Nevermind, think I've found it (google.protobuf.pyext._message.RepeatedCompositeContainer)10:49
juergbijmac: the official documentation is here: https://developers.google.com/protocol-buffers/docs/reference/python-generated#repeated-fields10:57
jmacYes, I'd found that, but it doesn't list all the methods10:59
juergbiyes, it's a bit lacking10:59
*** finn has joined #buildstream11:02
noisecelltristan, continuing with or discussion yesterday regarding to know the dependencies using some commands or the logs. I've run "bst show --deps run" on my element and it only shows itself, is this the expected output?11:06
noisecellhttps://gitlab.com/baserock/definitions/blob/master/elements/systems/minimal-system-image-x86_64.bst11:06
noisecellhttps://paste.baserock.org/uyexeraqax11:06
noisecellI've posted this 2 links for reference ^^11:07
noisecellare there any command that shows the files installed from an element and which element comes from (if the element depends on others)?11:08
*** jsgrant has quit IRC11:29
*** mohan43u has quit IRC11:41
*** mohan43u has joined #buildstream11:44
*** toscalix has joined #buildstream11:48
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48111:52
*** toscalix has quit IRC11:58
*** jsgrant has joined #buildstream12:08
gitlab-br-botbuildstream: merge request (caching_build_trees->master: WIP: Caching buildtrees) #474 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47412:12
*** bethw has quit IRC12:27
*** finn has quit IRC12:38
*** finn has joined #buildstream12:38
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48113:26
*** bethw has joined #buildstream13:28
noisecelltristan, https://gitlab.com/baserock/definitions/blob/master/elements/systems/minimal-system-image-x86_64.bst is probably an special case. It does uses a plugin, so it seems that its dependencies are only build-dependencies. But to me it should use the "config: base: input:" information to get the runtime dependencies, IMO.13:45
noisecelland if we look at https://gitlab.com/baserock/definitions/blob/master/elements/systems/minimal-system.bst -- something similar happens. Its dependencies are only build dependencies but its configuration mark its output as runtime. But "bst show --deps run systems/minimal-system.bst" only shows itself as runtime dependency.13:59
noisecellReading about the compose element: https://buildstream.gitlab.io/buildstream/elements/compose.html#module-elements.compose -- it says that this is a typical case.13:59
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48114:06
gitlab-br-botbuildstream: merge request (richardmaw/cache-fail->master: WIP: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47514:12
*** xjuan has joined #buildstream14:24
*** ernestask has joined #buildstream14:33
gitlab-br-botbuildstream: issue #404 ("Context directories may contain double slashes") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/40415:03
gitlab-br-botbuildstream: merge request (reduce_history_in_cache->master: WIP: Reduce history in cache) #482 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48215:09
gitlab-br-botbuildstream: merge request (caching_build_trees->master: WIP: Caching buildtrees) #474 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47415:13
gitlab-br-botbuildstream: issue #418 ("Should we use a CAS-based source cache as a mirror?") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/41815:14
gitlab-br-botbuildstream: merge request (reduce_history_in_cache->master: WIP: Reduce history in cache) #482 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48215:14
*** Phil has joined #buildstream15:17
noisecellI've updated https://gitlab.com/BuildStream/buildstream/issues/406 which is something similar that I have been looking in the previous discussion with tristan15:24
*** xjuan has quit IRC15:47
*** tristan has joined #buildstream15:50
*** xjuan has joined #buildstream15:56
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48116:01
gitlab-br-botbuildstream: merge request (jmac/cas_virtual_directory->master: WIP: CAS-backed virtual directory implementation) #481 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48116:01
jennistristan, hi, whenever you have some time, !477 (remote expiry - using disk space available on the filesystem) is ready for maintainer review :)16:17
gitlab-br-botbuildstream: merge request (richardmaw/cache-fail->master: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47516:22
gitlab-br-botbuildstream: merge request (gokcen/sandbox_cleanup_fix->master: Fix post-bwrap cleanup behaviour) #480 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48016:23
gitlab-br-botbuildstream: merge request (gokcen/sandbox_cleanup_fix->master: Fix post-bwrap cleanup behaviour) #480 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48016:23
gitlab-br-botbuildstream: merge request (gokcen/sandbox_cleanup_fix->master: Fix post-bwrap cleanup behaviour) #480 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/48016:23
*** dominic has quit IRC16:30
*** jsgrant has quit IRC16:41
*** Phil has quit IRC16:50
jonathanmawvalentind: if you haven't gotten round to reviewing my mirrored fetching code yet, I'm just about to push some changes that makes it a bit nicer16:54
jonathanmaw(when I rolled back some commits I lost the nice tidying of an algorithm that had previously been vexing me)16:54
*** jonathanmaw has quit IRC17:00
gitlab-br-botbuildstream: merge request (328-support-for-downloading-sources-from-mirrors->master: WIP: Resolve "Support for downloading sources from mirrors") #404 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/40417:02
gitlab-br-botbuildstream: issue #379 ("_sandboxbwrap.py: Post-bwrap cleanup shouldn't attempt to remove preexisting folders") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/37917:02
gitlab-br-botbuildstream: merge request (gokcen/sandbox_cleanup_fix->master: Fix post-bwrap cleanup behaviour) #480 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/48017:02
*** bethw has quit IRC17:06
tristanjennis, how come we are using PushException for indicating the artifact is too big now ?17:09
tristanjennis, did it happen that the only error which the receiver recognizes is the artifact too big error ?17:10
tristantlater, ^^^ ?17:12
tristanjennis, using ansii2html (from pip), I can render bst output with colors in docs :)17:22
*** awacheux has quit IRC17:42
*** tristan has quit IRC17:52
*** ernestask has quit IRC17:53
*** tristan has joined #buildstream17:57
*** jsgrant has joined #buildstream17:57
gitlab-br-botbuildstream: merge request (correcting_typo->master: Correcting a typo in safe_remove's comment) #472 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47218:00
gitlab-br-botbuildstream: merge request (correcting_typo->master: Correcting a typo in safe_remove's comment) #472 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/47218:35
gitlab-br-botbuildstream: merge request (chandan/add-argument-bst-pushreceive->master: _artifactcache/pushreceive.py: Add Click type for CLI argument 'repo') #476 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47619:34
tlatertristan: Sorry, didn't keep up to date on that branch19:42
tlaterI think I recommended that because the ArtifactTooBigError seemed a bit specific?19:43
tristantlater, right, that is intentionally specific19:49
tristantlater, the program was otherwise returning !0 exit status and spitting a useful stack trace in the case of errors19:50
tlaterAh, I didn't realize19:50
tristannow it assumes all errors are caused by a gracefully ignorable "artifact too big" state19:50
tristans/state/condition19:50
tristan:)19:50
tlaterHm, in my mind Buildstream shouldn't crash when a network error occurs19:51
tlaterOh, wait, it's just the subprocess that returns !019:51
tristanyou mean BuildStream :)19:51
tlaterDarnit, my mobile phone has the wrong spelling19:52
* tlater corrects it19:52
tristantlater, right, it's easy enough to deal with a stack trace for things that really brake, we could go one further and detail the really recognizable system errors without the stack trace19:52
tristanbut anyway, returning 0 with a warning on every error is not bright19:53
tlaterYep, agreed, sorry jennis for screwing you over here19:53
gitlab-br-botbuildstream: issue #409 ("bst-artifact-receive: CLI should not throw stacktrackes when repo argument is invalid") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/40920:07
gitlab-br-botbuildstream: merge request (chandan/add-argument-bst-pushreceive->master: _artifactcache/pushreceive.py: Add Click type for CLI argument 'repo') #476 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/47620:07
*** tristan has quit IRC20:30
*** xjuan has quit IRC20:48
*** bochecha_ has quit IRC20:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!