IRC logs for #buildstream for Friday, 2018-03-16

« Thursday, 2018-03-15 Index Saturday, 2018-03-17 »
*** tristan has joined #buildstream06:05
*** ernestask has joined #buildstream06:13
*** valentind has joined #buildstream08:26
*** jonathanmaw has joined #buildstream09:13
*** dominic has joined #buildstream09:16
*** valentind has quit IRC09:21
*** aday has joined #buildstream09:27
tristanuhhh, tlater jennis ... not only does the linter fail to run at ./setup.py test time... I am also now missing the pep8 checks :-S09:41
tlatertristan: Yep, we did this to make the nice linting job in CI, forgot to enable it again for ./setup.py... Workaround currently is to `./setup.py test --addopts '--pylint --pep8`09:43
tlaterIt's a PITA, I'll try to resolve it asap09:44
tristanCan we just remove the "nice linting job" and run it in both tests ? We didnt do that for pep8 either09:50
tristanWill it make the output more difficult to read or smth ?09:50
tlaterHm, I thought it wasn't the nicest, but that was when we still had lots of pylint errors09:51
tristanseems like doing it conditionally is a bit of a pita09:51
tristantlater, is there --no-pylint and --no-pep8 options ? which will supersede existing default --pylint and --pep8 options found in the default addopts ?09:52
tristanWe could do it that way if we really wanted it, I think it's more important that developers automatically catch errors locally before wasting time pushing branches to CI09:53
tlaterafaik there's no way to disable them after they were enabled.09:53
tlaterMyegh, I suppose we should just enable both of those tests unconditionally09:54
gitlab-br-botbuildstream: merge request (tristan/project-refs->master: WIP: Optionally load and store source references in project.refs) #314 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31410:04
tristanjuergbi, Beautifully rebased with sexy commit order... documentation added; now you can feel free to review, although note: I still need to add tests10:05
tristanthe one test there is not enough; I need to get the hang of junctionized tests10:06
tristanwhich is really the part more in need of testing10:06
tristantlater, I'll stop whining about it and change that straight away...10:07
tlatertristan: I found something that might do it10:09
tlaterBasically waiting for this pipeline to see if it works: https://gitlab.com/BuildStream/buildstream/commit/7e6b5f26603dc98728e3b5cbcc61275f2f14ff1d/pipelines10:10
tristantlater, I'll wait, I just pushed this to CI too: https://gitlab.com/BuildStream/buildstream/commit/14bb2356a918cecf1b07835af93a045c45e965ba/pipelines10:14
tristanif yours works, it is indeed better :)10:14
tlaterLet's hope :) Not sure if the expression is correct though, might need a second try.10:15
tlaterUnfortunately mark expressions aren't documented very well..10:15
tristannope10:15
tristantlater, option -m not recognized10:16
tlaterOh, whoops, yeah10:16
tlaterThat definitely doesn't work if it's not part of --addopts10:16
tristanAh yeah I see10:17
tristanhave to add them in context before you can filter them out10:17
tlatertristan: No, looks like the "not" thing doesn't actually work as the documentation suggests :|10:20
tlaterOr perhaps pylint doesn't mark its tests correctly10:20
tlaterEither way, looks like your fix will have to do10:20
*** aday has quit IRC10:22
*** aday has joined #buildstream10:24
*** aday has left #buildstream10:29
jennismhmm tristan you're jobs have failed re OSTree. I've also had some failed tests for that today10:29
jennishttps://gitlab.com/BuildStream/buildstream/-/jobs/5777905610:29
jennis^^ your tests.  My tests: https://gitlab.com/BuildStream/bst-external/-/jobs/5777561810:29
*** aday has joined #buildstream10:34
tristanjennis, that is a linting error; how come this was not caught before ?10:34
tristantlater, is it possible that the linting fails to catch everything unless ran with a full test run ?10:35
jennisThe second error I sent you was for the integration tests I've been doing for bst-external10:35
jennisSeems a weird coincidence10:35
tlatertristan: It's not possible afaik10:35
tristanthe first error is for a commit which does not modify any of the files it's complaining about.10:35
jennisI don't think it's a linting error10:35
tristanthey all say [pylint]10:35
tlaterYeah, definitely a linting error10:36
tristanand report in the pylint style of line number10:36
tristan "no-name-in-module"10:36
* jennis looked at the wrong one >.<10:37
jennisYes that is definitely a linting error10:37
tlaterjennis: This is very similar to the no-member issues10:37
jennisIt is10:37
tlaterWe need to add gi.repository to that unchecked modules variable10:37
* jennis wonders why didn't the linting catch this before10:37
jennisYes I can do this ASAP10:38
* tristan wonders the same; spurious errors are bad10:38
tlaterIt looks like the covered files changed10:38
tlatersetup.py didn't use to be covered10:39
tlaterI think10:39
jennisMust be, because my branch went through ~40 pipelines and that linting error never came up10:40
jennis*3510:40
tristanThe covered files should not sporadically change10:40
tristanAre we pinning the version of pylint ?10:40
tlatertristan: I suspect the files changed with you modifying the setup.cfg10:41
tlaterNot sure why, or how10:41
tristanok, lets sweep it under the rug and fix it in the way you describe "We need to add gi.repository to that unchecked modules variable"10:42
tristanAnd then we can flail our arms and cry fire if it ever bites us again.10:42
gitlab-br-botbuildstream: merge request (issue-243_dpkg_import_source_plugin->master: WIP: Created DPKG Source plugin for Issue #10) #305 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/30510:56
ltuNexus, reading !305, there seem to be some un-resolved discussions, are you sure you have satisfied all of the concerns from the reviewers?10:59
ltuthere's something about adding documentation for base-dir, has that been done?10:59
ltuapologies if you've already addressed these and i've not seen it, but best to catch them before skullman's review if not already11:00
Nexusi think i just didnt close the discussions, 1 min11:00
Nexusall resolved11:01
ltudocs added?11:02
Nexuswell noticed ltu11:02
Nexusyup11:02
ltucool, thanks Nexus11:02
jennisok tristan I will deal with that now11:03
jennisjonathanmaw, when you have time, can you review !22 in bst-external please11:03
jennis?11:04
* jonathanmaw has a look11:04
jennisty (:11:04
gitlab-br-botbuildstream: merge request (issue-243_dpkg_import_source_plugin->master: WIP: Created DPKG Source plugin for Issue #10) #305 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/30511:07
tristanjennis, thanks !11:09
gitlab-br-botbuildstream: merge request (jjardon/install_fixes->master: doc/source/install.rst: Divide in two sections) #322 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32211:10
gitlab-br-botbuildstream: merge request (jjardon/getting_started->master: Add getting started section) #323 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32311:19
gitlab-br-botbuildstream: issue #303 ("Document how to contribute to the official documentation") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/30311:31
gitlab-br-botbuildstream: issue #303 ("Document how to contribute to the official documentation") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/30311:40
jennisok tristan, I've included the changes you made in "make pylint and pep8 tests run by deafult" into my branch and set gi.repository to ignore11:54
jennishttps://gitlab.com/BuildStream/buildstream/pipelines/1901116911:54
jennispipeline has passed ^^11:54
*** tristan has quit IRC11:57
gitlab-br-botbuildstream: merge request (jjardon/install_fixes->master: doc/source/install.rst: Divide in two sections) #322 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32212:00
gitlab-br-botbuildstream: merge request (jennis/add_gi.repository_to_ignored_pylint_modules->master: Jennis/add gi.repository to ignored pylint modules) #324 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32412:02
gitlab-br-botbuildstream: merge request (jennis/add_gi.repository_to_ignored_pylint_modules->master: Jennis/add gi.repository to ignored pylint modules) #324 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32412:02
gitlab-br-botbuildstream: merge request (jennis/add_gi.repository_to_ignored_pylint_modules->master: Jennis/add gi.repository to ignored pylint modules) #324 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32412:03
jennisAnyone got a second to review this please? https://gitlab.com/BuildStream/buildstream/merge_requests/32412:10
gitlab-br-botbuildstream: merge request (jennis/add_gi.repository_to_ignored_pylint_modules->master: Jennis/add gi.repository to ignored pylint modules) #324 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/32412:15
jennis:)12:16
gitlab-br-botbuildstream: merge request (jjardon/install_fixes->master: doc/source/install.rst: Divide in two sections) #322 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32212:16
*** dominic has quit IRC12:16
gitlab-br-botbuildstream: merge request (jjardon/install_fixes->master: doc/source/install.rst: Divide in two sections) #322 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32212:16
*** tristan has joined #buildstream12:33
gitlab-br-botbuildstream: merge request (214-filter-workspacing->master: WIP: Make workspace commands on a filter element transparently pass through to their build-dependency) #317 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31713:22
jonathanmawjennis: your MR (https://gitlab.com/BuildStream/bst-external/merge_requests/22) seems okay to me13:31
jonathanmawdo you want any more discussion around it, or shall I hit the merge button?13:31
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: WIP: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31313:31
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: WIP: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31313:31
*** Nexus_ has joined #buildstream13:35
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: WIP: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31313:37
*** Nexus has quit IRC13:37
gitlab-br-botbuildstream: merge request (jjardon/install_fixes->master: doc/source/install.rst: Divide in two sections) #322 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/32213:55
*** Nexus_ has quit IRC13:57
*** Nexus has joined #buildstream13:58
*** Nexus_ has joined #buildstream13:59
*** Nexus_ has quit IRC14:00
jennisjonathanmaw, yes I think it's ok to merge, however we need to consider another way to import test utils14:02
tlaterjennis: That would be https://gitlab.com/BuildStream/buildstream/issues/28114:04
jonathanmawjennis: okay, the task to properly import test utils exists, but I don't think it should be a blocker on merging your work14:06
jennisok thanks tlater. jonathanmaw, regarding this I guess we can merge it now and when #281 is resolved we can make the changes then?14:06
jonathanmawso I'll hit the button14:06
jennisYes :)14:06
jonathanmawmy condolences, Nexus, I've just merged a change to how we do tests14:06
jonathanmawif you have difficulty figuring out how to adapt your tests, ask me or jennis for pointers14:07
jennisIs Nexus not working on quilt? There is a quilt test14:07
jonathanmawhrm14:07
jonathanmawjennis: yep, there is14:08
* jonathanmaw checks the history14:09
Nexuserrm14:09
Nexuswut14:09
Nexusam i going to cry?14:09
jennisThe old quilt test is the same instead now it runs with pytest and not with bash14:12
jennisSo you should be ok Nexus14:12
Nexusphew14:12
jonathanmawNexus: I believe an old version of your changes might have been previously merged, looking at what the "quilt" branch currently contains14:12
jonathanmaw(i.e. I see improved documentation, and some new dependencies for the test (probably to fix a broken test))14:13
jennisFrom looking at your changes it looks like all you'll have to do is rebase to master and then make sure `dependencies/base-*.bst` -> `base/base-*.bst`14:20
*** mcatanzaro has joined #buildstream14:20
Nexusif i have to re-do what i've just done, imma kill you :)14:22
jennisAre you making changes to files within bst-external/integration-tests/?14:24
jennisBecause that directory no longer exists14:24
Nexusi WAS14:24
Nexusi dunno what i'm doing anympore14:24
Nexusassuming what you did works, i can delete the dir i have and run yours14:25
* Nexus runs tests14:25
Nexusthat seemed to pass ok14:45
jennis\o/14:45
jonathanmaw\o/14:46
gitlab-br-botbuildstream: merge request (issue-243_dpkg_import_source_plugin->master: WIP: Created DPKG Source plugin for Issue #10) #305 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/30514:50
gitlab-br-botbuildstream: merge request (issue-89_unique_build_dirs->master: WIP: Made modification to generate unique subdirs for built elements) #310 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31014:57
gitlab-br-botbuildstream: merge request (215-workspace-builds-might-not-rebuild-correctly-when-dependecies-are-updated->master: WIP: Resolve "Workspace builds might not rebuild correctly when dependecies are updated") #315 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31514:57
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: WIP: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31315:07
gitlab-br-botbuildstream: merge request (214-filter-workspacing->master: WIP: Make workspace commands on a filter element transparently pass through to their build-dependency) #317 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31715:08
Nexusgetting: `cp: cannot stat 'dist/bst-external/.coverage.*': No such file or directory` on the unix test for bst-external :/15:12
jennisCan you link the pipeline15:14
Nexushttps://gitlab.com/BuildStream/bst-external/-/jobs/5784105715:14
gitlab-br-botbuildstream: merge request (215-workspace-builds-might-not-rebuild-correctly-when-dependecies-are-updated->master: WIP: Resolve "Workspace builds might not rebuild correctly when dependecies are updated") #315 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31515:16
jennismhm15:17
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: WIP: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31315:18
jennis1 sec15:19
jennisIt's possible that we may also require this: https://gitlab.com/BuildStream/bst-external/blob/master/.gitlab-ci.yml#L77  in our unix tests15:19
jennisjonathanmaw, do you agree?15:20
gitlab-br-botbuildstream: merge request (richardmaw-271-workspaces-versioning->master: Add versioning to workspaces yaml configuration) #313 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31315:20
jonathanmawhrm15:22
tlaterjennis: No, unix tests run as root15:23
tlaterAs far as I can see pycoverage is simply not outputting its logs correctly15:24
jennisright ok, then Nexus don't bother with that then15:24
gitlab-br-botbuildstream: merge request (214-filter-workspacing->master: Make workspace commands on a filter element transparently pass through to their build-dependency) #317 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31715:24
tlaterNexus: You can try to restart the test, it's possible this is just a fluke from pycoverage15:25
jennistlater, you think it may not be outputting logs of the form ".coverage.*"?15:25
tlaterBut I think there is some path shenanegans going on here15:25
jennisOr just not outputting at all?15:25
tlaterI think it's going to the wrong directory, but I haven't had a closer look15:26
tlaterIt looks like everything is set up correctly at a glance15:26
jennislol15:26
jennisone sec15:26
jennisThis? https://gitlab.com/BuildStream/bst-external/blob/master/setup.cfg#L515:27
jennis--cov=buildstream15:27
gitlab-br-botbuildstream: merge request (215-workspace-builds-might-not-rebuild-correctly-when-dependecies-are-updated->master: WIP: Resolve "Workspace builds might not rebuild correctly when dependecies are updated") #315 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31515:29
tlaterHm, that might be it15:30
gitlab-br-botbuildstream: merge request (issue-89_unique_build_dirs->master: WIP: Made modification to generate unique subdirs for built elements) #310 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31015:32
Nexusyou guys decide on something?15:32
tlaterjennis: Yep, probably should be bst-external15:33
tlaterOr whatever module that repo uses15:33
tlaterCurious why that doesn't break in the linux tests15:33
jennisme to15:33
jennisOk i've made a branch with that patch, we'll see if it passes15:33
* Nexus waits 15:34
jennismhmm not it's not that15:38
jennishttps://gitlab.com/BuildStream/bst-external/-/jobs/5785489215:38
Nexusi found the solution...15:40
jennisgo on?15:40
Nexus15:25 <tlater   > Nexus: You can try to restart the test, it's possible this is just a fluke from pycoverage15:40
jennisloooool15:40
Nexusworked second time15:40
Nexusjonathanmaw: pls can you merge my quilt change?15:41
* tlater hates these CI tools that just break under our fingers15:41
Nexusalso, i've had A LOT of  `The requested URL returned error: 500 Internal Server Error`15:41
Nexustoday15:41
* jonathanmaw mashes the merge button15:41
Nexusyay zo/15:41
Nexus\o/15:42
tlaterzoz15:42
jennisa good day for the bst-external repo15:42
Nexusplease can someone review     - chown -R buildstream:buildstream bst-external15:44
Nexusno not that15:44
Nexushttps://gitlab.com/BuildStream/buildstream/merge_requests/31015:44
Nexusthat15:44
* jonathanmaw has a look15:44
Nexusty15:44
Nexusskullman: did you give 305 the go ahead?15:57
Nexus(DPKG)15:58
skullmanI have no objections. It's possible I missed some project conventions but everything I saw looked ok. Given the bits copied from elsewhere and bits I helped you work on I may be too familiar to catch things, but if it passes tests it should be good.16:00
gitlab-br-botbuildstream: merge request (issue-243_dpkg_import_source_plugin->master: Created DPKG Source plugin for Issue #10) #305 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/30516:00
Nexuskk16:00
NexusI had a look at "https://gitlab.com/BuildStream/buildstream/merge_requests/318" everything seems ok to me other than a comment which i think could be clearer16:01
NexusWas anything else in need of review?16:04
gitlab-br-botbuildstream: merge request (215-workspace-builds-might-not-rebuild-correctly-when-dependecies-are-updated->master: WIP: Resolve "Workspace builds might not rebuild correctly when dependecies are updated") #315 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31516:09
gitlab-br-botbuildstream: merge request (215-workspace-builds-might-not-rebuild-correctly-when-dependecies-are-updated->master: WIP: Resolve "Workspace builds might not rebuild correctly when dependecies are updated") #315 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31516:09
gitlab-br-botbuildstream: merge request (issue-89_unique_build_dirs->master: WIP: Made modification to generate unique subdirs for built elements) #310 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31016:15
gitlab-br-botbuildstream: merge request (issue-89_unique_build_dirs->master: WIP: Made modification to generate unique subdirs for built elements) #310 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/31016:25
gitlab-br-botbuildstream: merge request (146-use-minimum-python-version-3-4-for-integration-tests->master: Resolve "Use minimum python version (3.4) for integration tests") #266 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/26616:29
gitlab-br-botbuildstream: merge request (146-use-minimum-python-version-3-4-for-integration-tests->master: Resolve "Use minimum python version (3.4) for integration tests") #266 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/26616:32
gitlab-br-botbuildstream: merge request (146-use-minimum-python-version-3-4-for-integration-tests->master: Resolve "Use minimum python version (3.4) for integration tests") #266 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/26616:45
gitlab-br-botbuildstream: merge request (146-use-minimum-python-version-3-4-for-integration-tests->master: Resolve "Use minimum python version (3.4) for integration tests") #266 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/26616:48
*** tiago has quit IRC17:34
gitlab-br-botbuildstream: issue #304 ("'read: Illegal option -n' in strip-commands") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/30417:37
*** valentind has joined #buildstream18:08
*** jonathanmaw has quit IRC18:19
*** ernestask has quit IRC19:33
*** ernestask has joined #buildstream19:35
*** xjuan has joined #buildstream20:11
*** aday has quit IRC20:54
*** ernestask has quit IRC20:56
*** xjuan has quit IRC22:01
*** tristan has quit IRC22:41
*** Prince781 has joined #buildstream23:16
*** valentind has quit IRC23:49
« Thursday, 2018-03-15 Index Saturday, 2018-03-17 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!