| *** mcatanzaro has joined #buildstream | 00:00 | |
| *** mcatanzaro has quit IRC | 01:56 | |
| *** Prince781 has joined #buildstream | 03:30 | |
| *** hase has joined #buildstream | 04:17 | |
| *** Prince781 has quit IRC | 04:20 | |
| *** Prince781 has joined #buildstream | 04:21 | |
| *** hase has quit IRC | 04:24 | |
| *** Prince781 has quit IRC | 04:36 | |
| *** Prince781 has joined #buildstream | 04:37 | |
| *** tristan has joined #buildstream | 06:01 | |
| *** Prince781 has quit IRC | 06:42 | |
| *** Prince781 has joined #buildstream | 06:43 | |
| *** hase has joined #buildstream | 06:59 | |
| *** hase has quit IRC | 07:43 | |
| *** hase has joined #buildstream | 07:44 | |
| gitlab-br-bot | buildstream: issue #211 ("Implement the Bazel event protocol") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/211 | 08:22 |
|---|---|---|
| *** aday has joined #buildstream | 08:22 | |
| gitlab-br-bot | buildstream: issue #210 ("Make build artifacts of workspaced dependencies visible") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/210 | 08:27 |
| *** hase has quit IRC | 08:46 | |
| *** Prince781 has quit IRC | 08:52 | |
| gitlab-br-bot | buildstream: merge request (sam/267-integration-cache->master: Make integration-tests work by default, and tweak how INTEGRATION_CACHE is interpreted) #294 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/294 | 09:17 |
| gitlab-br-bot | buildstream: issue #108 ("Integration tests not idempotent and self contained") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/108 | 09:20 |
| gitlab-br-bot | buildstream: issue #267 ("Integration tests dont work by default, and write outside of repo") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/267 | 09:34 |
| gitlab-br-bot | buildstream: merge request (sam/267-integration-cache->master: Make integration-tests work by default, and tweak how INTEGRATION_CACHE is interpreted) #294 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/294 | 09:34 |
| *** ssam2 has joined #buildstream | 09:58 | |
| *** noisecell has joined #buildstream | 10:07 | |
| *** dominic has joined #buildstream | 10:10 | |
| *** jonathanmaw has joined #buildstream | 10:17 | |
| tristan | juergbi, So I have bind mounted /etc/group and /etc/passwd... and /dev/dri... on the host /dev/dri/* shows up as root:video, and in the `bst shell` they show up as nobody:nogroup | 10:25 |
| tristan | juergbi, any idea why ? or clue what to look for ? | 10:26 |
| tristan | ah, I think it's sandboxing that is still too strict without --isolate specified | 10:27 |
| * tristan tests some things | 10:27 | |
| juergbi | tristan: anything that is not explicitly mapped into the user namespace gets the 'overflow' uid/gid | 10:27 |
| juergbi | as the video group is not mapped, you don't have access to that, hm | 10:27 |
| tristan | right, --unshare-user causes that | 10:27 |
| juergbi | yes but that's required for operating bwrap without having it setuid root | 10:28 |
| juergbi | which is a nice aspect | 10:28 |
| tristan | Hrrrrm | 10:28 |
| tristan | Even with that though; I still get `libGL error: failed to open drm device: Permission denied` | 10:29 |
| juergbi | i don't think even subuids would help here | 10:29 |
| juergbi | wondering how flatpak handles that | 10:29 |
| tristan | I guess I'll try digging there | 10:29 |
| tristan | In separate news, I have a patch which adds a `--mount` option to `bst shell`... but it's still not ready :-S | 10:30 |
| tristan | Or, maybe it's a separate problem, but I have to fix it pretty much immediately | 10:30 |
| tristan | the code block which cleans up debris left behind by bwrap is failing: https://gitlab.com/BuildStream/buildstream/blob/master/buildstream/sandbox/_sandboxbwrap.py#L192 | 10:31 |
| tristan | if you choose to mount anything underneath one of the dirs which bwrap creates as debris | 10:32 |
| tristan | tricky problem | 10:32 |
| tristan | guess I wont land it today, as I have an appointment and leaving soon | 10:32 |
| *** hase has joined #buildstream | 10:42 | |
| jonathanmaw | ssam2: :/ my build of buildstream overnight failed, seems the build of python3 is failing with "Fatal Python error: getentropy() failed" | 10:44 |
| ssam2 | wow, i've never seen that before | 10:44 |
| ssam2 | build of buildstream ? | 10:44 |
| tiago | /dev/(u)?random missing in the sandbox? | 10:46 |
| tristan | That sounds like an attempt to build without /dev/random | 10:46 |
| tristan | right | 10:47 |
| ssam2 | indeed; but it's hardcoded to be there | 10:47 |
| tristan | Hrrrrm perhaps it is not; it was at one point | 10:47 |
| tristan | ah no, it's hard coded and there | 10:47 |
| * tristan only recalled we use a generic bwrap option, but that's only in interactive shells | 10:48 | |
| tristan | i.e. `--dev /dev` | 10:48 |
| aiden | `rng-tools`? | 10:49 |
| *** hase has quit IRC | 11:03 | |
| *** tristan has quit IRC | 11:04 | |
| gitlab-br-bot | buildstream: issue #213 ("Dpkg-build should be able to use quilt from host-tools") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/213 | 11:09 |
| gitlab-br-bot | buildstream: issue #276 ("Downloading times out; doesn't resume: "[28] Timeout was reached"") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/276 | 11:45 |
| *** ssam2 has quit IRC | 12:03 | |
| jonathanmaw | ssssam[m]: no problem, I've figured out how to get the image from docker, so I should be able to test x86image | 12:08 |
| *** ssam2 has joined #buildstream | 12:23 | |
| *** mcatanzaro has joined #buildstream | 12:37 | |
| gitlab-br-bot | buildstream: merge request (239-use-pylint-for-linting->master: WIP: Resolve "Use pylint for linting") #283 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/283 | 12:39 |
| *** ernestask has joined #buildstream | 12:48 | |
| gitlab-br-bot | buildstream: merge request (214-we-need-a-way-to-make-elements-depend-on-a-subset-of-an-element-s-output->master: Resolve "We need a way to make elements depend on a subset of an element's output") #284 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/284 | 13:27 |
| *** aday has quit IRC | 13:33 | |
| *** jyothiraditya has joined #buildstream | 13:48 | |
| *** jyothiraditya has quit IRC | 13:50 | |
| *** jyothiraditya has joined #buildstream | 13:52 | |
| *** jyothiraditya has quit IRC | 13:56 | |
| *** aday has joined #buildstream | 14:17 | |
| jmac | MR !300 is weird | 14:19 |
| jmac | I'm going to have to do some experiments to figure out how that change works | 14:19 |
| *** mcatanzaro has quit IRC | 14:25 | |
| jennis_ | jmac, which change specifically? | 14:27 |
| jmac | Oh, it's the commas on the end of the line, got it | 14:29 |
| jmac | I remember you mentioning this somewhere but it's not obvious in the commit messages | 14:29 |
| jennis_ | ahh whoops, I made it obvious in the issue | 14:30 |
| jennis_ | Would you like me to change the commit message and push again? | 14:30 |
| jmac | No, it's fine | 14:31 |
| jmac | I'll have to remember that comma trick in case I need to write any underhanded Python | 14:32 |
| jennis_ | To have the description show that this closes issue #266, do I literally just add, "Closes #266"? | 14:33 |
| ssam2 | yeah, it's "magic" | 14:34 |
| gitlab-br-bot | buildstream: merge request (changing_the_dictionary_in_get_unique_key->master: Changing the dictionary in `get_unique_key()`) #300 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/300 | 14:34 |
| ssam2 | so be careful using a sentence in a commit message like "this does not and will never fix #2052" | 14:34 |
| ssam2 | which will probably result in issue #2052 getting auto-closed by the MR that explicitly says it doesn't fix it | 14:34 |
| jmac | I'm happy with MR !300 but I don't know if I have authority to merge it | 14:35 |
| ssam2 | my understanding is that we leave merging to tristan or juergbi in general | 14:35 |
| ssam2 | i just comment to say I have reviewed something and spotted no issues | 14:35 |
| * jmac leaves it there then | 14:36 | |
| jennis_ | thanks jmac | 14:37 |
| jonathanmaw | juergbi: do you have time to review https://gitlab.com/BuildStream/buildstream/merge_requests/284 for me? | 14:44 |
| jonathanmaw | ssam2: finally got the x86image tested, using that buildstream-examples branch | 14:59 |
| jonathanmaw | I had to manually extract the docker image and assemble it into a tar, which I suspect is what tlater was doing, also | 14:59 |
| ssam2 | cool | 15:00 |
| ssam2 | weird that the docker source plugin didn't work there, it's worked fine for other purposes ... | 15:00 |
| ssam2 | i think i've only ever used it to pull images with library/ prefix | 15:00 |
| ssam2 | Docker Hub doesn't make it too easy to discover the actual URL endpoints that we need to pass in, sadly | 15:01 |
| ssam2 | maybe we could write a simple python script that does a search using the API and outputs the actual image URL that you'd need to use in the 'sources' field | 15:01 |
| gitlab-br-bot | buildstream: merge request (sam/document-profiling-and-benchmarks->master: WIP: HACKING.rst: Mention benchmarking and profiling tools) #267 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/267 | 15:14 |
| gitlab-br-bot | buildstream: merge request (sam/document-profiling-and-benchmarks->master: HACKING.rst: Mention benchmarking and profiling tools) #267 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/267 | 15:14 |
| jonathanmaw | ssam2: okay, I'll look into it . first, though, I'll rebase the x86image merge request so I can get it merged | 15:26 |
| *** noisecell has quit IRC | 16:05 | |
| *** noisecell has joined #buildstream | 16:19 | |
| gitlab-br-bot | buildstream: merge request (changing_the_dictionary_in_get_unique_key->master: Changing the dictionary in `get_unique_key()`) #300 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/300 | 16:30 |
| jennis_ | No tristan? | 16:32 |
| ssam2 | it's been known | 16:33 |
| jennis_ | in which case, juergbi, I think !300 is ready to be merged | 16:33 |
| *** noisecell has quit IRC | 16:35 | |
| gitlab-br-bot | buildstream: merge request (sam/compose-symlinks-issue->master: WIP: Avoid compose element dropping files that are staged inside directory symlinks) #295 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/295 | 16:37 |
| gitlab-br-bot | buildstream: merge request (sam/compose-symlinks-issue->master: Avoid compose element dropping files that are staged inside directory symlinks) #295 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/295 | 16:37 |
| jennis_ | mhmm the tests failed in the CI, however running the tests locally (`./setup.py test`) seems to work | 16:39 |
| ssam2 | a common issue | 16:40 |
| jennis_ | Is there a common reason? | 16:41 |
| ssam2 | no | 16:41 |
| ssam2 | look at the logs and see | 16:41 |
| juergbi | jennis_: !300: need a small tweak of the commit message, see comment | 16:42 |
| juergbi | btw: i was surprised that you changed the initialization style of the dictionary instead of just removing the commas. but it's fine with me either way | 16:42 |
| jennis_ | Yeah, I just followed the recommended pep8 style | 16:42 |
| gitlab-br-bot | buildstream: merge request (changing_the_dictionary_in_get_unique_key->master: Changing the dictionary in `get_unique_key()`) #300 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/300 | 16:47 |
| jennis_ | all done, juergbi | 16:47 |
| juergbi | ah, great, thanks | 16:48 |
| juergbi | jennis_: CI issue might be because the branch is in your repo, not the main buildstream repo | 16:48 |
| juergbi | we have separate runners setup that work more reliably | 16:48 |
| jennis_ | ok, thanks | 16:49 |
| juergbi | i don't have a "merge when the pipeline succeeds" button with this CI error message | 16:50 |
| juergbi | might need to wait a bit to have gitlab resolve their CI issue. let me know if it's working again | 16:50 |
| juergbi | otherwise we'll have to push it to a new branch in the main repo. unfortunately, that requires opening a new MR as the branch can't be changed in the existing MR | 16:51 |
| jennis_ | Yeah I re-ran the failed test and its passed it now | 16:52 |
| juergbi | i've enabled automatic merge | 16:53 |
| juergbi | btw: i've added you to the buildstream project. you can push future branches directly to the main repo, which is hopefully more convenient for CI | 16:53 |
| jennis_ | glad to hear it | 16:54 |
| *** noisecell has joined #buildstream | 17:05 | |
| *** mcatanzaro has joined #buildstream | 17:07 | |
| gitlab-br-bot | buildstream: merge request (sam/compose-symlinks-issue->master: Avoid compose element dropping files that are staged inside directory symlinks) #295 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/295 | 17:09 |
| gitlab-br-bot | buildstream: merge request (sam/compose-symlinks-issue->master: Avoid compose element dropping files that are staged inside directory symlinks) #295 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/295 | 17:10 |
| *** xjuan has joined #buildstream | 17:35 | |
| *** ssam2 has quit IRC | 17:36 | |
| gitlab-br-bot | buildstream: merge request (jmac/configurable-logging->master: Configurable log line formatting) #282 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/282 | 17:40 |
| gitlab-br-bot | buildstream: merge request (jmac/configurable-logging->master: Configurable log line formatting) #282 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/282 | 17:42 |
| gitlab-br-bot | buildstream: issue #266 ("`get_unique_key()` only works with an incorrectly initialised dictionary") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/266 | 17:43 |
| gitlab-br-bot | buildstream: merge request (changing_the_dictionary_in_get_unique_key->master: Changing the dictionary in `get_unique_key()`) #300 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/300 | 17:43 |
| *** dominic has quit IRC | 17:45 | |
| *** persia has quit IRC | 17:45 | |
| *** waltervargas[m] has quit IRC | 17:45 | |
| *** ernestask[m] has quit IRC | 17:46 | |
| *** persia has joined #buildstream | 17:47 | |
| *** ernestask[m] has joined #buildstream | 17:48 | |
| *** ernestask[m] is now known as Guest12457 | 17:49 | |
| *** waltervargas[m] has joined #buildstream | 17:49 | |
| *** Prince781 has joined #buildstream | 17:56 | |
| *** Guest12457 is now known as ernestask[m] | 17:57 | |
| jmac | ^ doing some better commit messages for !282, don't review it yet | 17:57 |
| *** jonathanmaw has quit IRC | 17:59 | |
| gitlab-br-bot | buildstream: merge request (jmac/configurable-logging->master: Configurable log line formatting) #282 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/282 | 18:09 |
| jmac | Done | 18:09 |
| *** Prince781 has quit IRC | 18:37 | |
| *** valentind has joined #buildstream | 18:40 | |
| *** hase has joined #buildstream | 18:45 | |
| *** hase has quit IRC | 18:51 | |
| *** mcatanzaro has quit IRC | 19:57 | |
| *** mcatanzaro has joined #buildstream | 20:10 | |
| *** ernestask has quit IRC | 20:22 | |
| *** mcatanzaro has quit IRC | 20:25 | |
| *** xjuan has quit IRC | 21:02 | |
| *** tristan has joined #buildstream | 21:22 | |
| *** mcatanzaro has joined #buildstream | 21:46 | |
| *** Prince781 has joined #buildstream | 22:01 | |
| *** aday has quit IRC | 22:43 | |
| *** tristan has quit IRC | 22:51 | |
| *** csoriano has quit IRC | 23:21 | |
| *** csoriano has joined #buildstream | 23:23 | |
| *** csoriano has quit IRC | 23:24 | |
| *** Prince781 has quit IRC | 23:24 | |
| *** valentind has quit IRC | 23:24 | |
| *** csoriano has joined #buildstream | 23:25 | |
| *** xjuan has joined #buildstream | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!