*** mcatanzaro has quit IRC | 01:17 | |
*** valentind has joined #buildstream | 08:29 | |
jmac | Yes, the problem is saw was that by the time you'd gotten to node.get() you'd already got an integer for 'track', AIUI | 08:29 |
---|---|---|
jmac | Sorry, wrong window | 08:29 |
aiden | is buildstream interpreter agnostic? is it intended to run on cpython only? | 08:30 |
tlater | aiden: We don't currently test with any other interpreters, but I don't see why it shouldn't run under something like ipython. Is there something in specific you're trying to run it with? | 08:38 |
aiden | tlater, i was just curious really... | 08:41 |
*** cs_shadow has quit IRC | 08:42 | |
jmac | This makes sense now I've seen the solution but it looked like from the issue you were referring to this conversion in node_get as the 'loader', which I now know refers to RoundTripConstructor | 08:45 |
jmac | Sorry, wrong window again :| | 08:45 |
jmac | Is there a schema for the fields in .bst files defined somewhere? (right window this time) | 08:51 |
tlater | There's this: https://buildstream.gitlab.io/buildstream/format.html#format | 08:52 |
tlater | And there are default .bst files in /buildstream/data | 08:53 |
tlater | But no strict definition, afaik | 08:53 |
tlater | Hm, no, not in /buildstream/data, in /buildstream/plugins | 08:54 |
jmac | I was wondering if I could write something in pykwalify which would validate them | 08:59 |
jmac | I ran into a problem with valid values for a field in project.conf which took a while to figure out | 09:00 |
gitlab-br-bot | buildstream: merge request (issue-166_yaml_removing_underscores->master: WIP: Issue 166 yaml removing underscores) #245 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/245 | 09:03 |
*** adds68 has joined #buildstream | 09:07 | |
*** ssam2 has joined #buildstream | 09:31 | |
*** jonathanmaw has joined #buildstream | 09:40 | |
*** valentind has quit IRC | 09:49 | |
*** adds68 has quit IRC | 10:09 | |
*** adds68 has joined #buildstream | 10:09 | |
*** tristan has joined #buildstream | 10:42 | |
jmac | Any ideas on how to cause an exception to happen in the main buildstream app, for a test? | 11:01 |
nexus | i can't think of anything without changing code | 11:11 |
ssam2 | what kind of exception ? | 11:11 |
ssam2 | an invalid bst file would trigger a LoadError | 11:11 |
nexus | i'm assuming unhandled | 11:12 |
nexus | invalid pipeline is fairly easy to achieve | 11:12 |
nexus | *Inconsistent pipeline | 11:13 |
* nexus just tried various command combos, hopnig to break something | 11:14 | |
* tlater wonders about #146 - it seems like running all tests with python3.4 should happen to *all* platforms | 11:15 | |
tlater | Yet tristan suggests adding a separate runner to test python3.4, I think? | 11:15 |
tristan | tlater, a runner would not be necessary for that; a docker image yes | 11:18 |
ssam2 | which distro causes the python3.4 requirement? would make sense to just run the tests on that distro | 11:18 |
ssam2 | either instead of or in addition to the Fedora 27 base we currently use | 11:19 |
ssam2 | probably in addition to | 11:19 |
* tlater thinks it's debian, considering jonathanmaw's frequent protest | 11:19 | |
*** cs_shadow has joined #buildstream | 11:19 | |
jonathanmaw | tlater: I'm on an old version of debian, I think the newest version of debian is 3.5 now | 11:20 |
tlater | I wonder if there's a way to create all those docker images without having to add an entirely new image for each system | 11:20 |
tlater | Maybe tags could work? | 11:20 |
ssam2 | what do you mean by "create a new image" ? | 11:20 |
ssam2 | there's no way to create images without ... creating images | 11:20 |
* tlater isn't sure what docker calls it... branch? | 11:21 | |
ssam2 | we could use tags to have a 'testsuite' image with tags like :fedora27, :debian6, etc. | 11:21 |
ssam2 | but i think that's abuse of tags | 11:21 |
ssam2 | they are generally used to denote different versions of the same conceptual thing | 11:21 |
ssam2 | automation in the buildstream-docker-images repo makes it pretty easy to build different images and push the in whatever way we want | 11:22 |
tlater | Hrm, I guess scripting the .gitlab-ci.yaml to do things in loop isn't too bad | 11:22 |
tristan | jmac, I have a good approach for that... sec | 11:22 |
ssam2 | *push them | 11:22 |
ssam2 | e.g. you could add a testsuite-debian image pretty easily | 11:22 |
tlater | Yeah, that seems fine | 11:22 |
ssam2 | requires someone who is an admin on the Docker hub to create the new image, but i'd be happy to give you the priviliges | 11:23 |
tlater | That would be nice :) | 11:23 |
tristan | jmac, see this commit: 60d5e070c17ef15caa42a847b0f9957432bd6468 | 11:23 |
* tlater needs a docker hub account for that, I suppose | 11:23 | |
ssam2 | yes, create an account and then I can add you to the buildstream group | 11:23 |
tristan | jmac, something like that which raises an exception that does not inherit from BstError should cause an unhandled exception at preflight time | 11:24 |
jmac | tristan: Yep, that looks good | 11:52 |
*** jude has quit IRC | 12:01 | |
*** jude has joined #buildstream | 12:02 | |
*** tristan has quit IRC | 13:46 | |
*** xjuan has joined #buildstream | 14:25 | |
gitlab-br-bot | buildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/246 | 14:26 |
gitlab-br-bot | buildstream: merge request (sam/symlinks-2->master: Avoid unnecessary os.path.realpath() calls in _ensure_real_directory()) #201 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/201 | 14:27 |
gitlab-br-bot | buildstream: merge request (sam/symlinks->master: WIP: Add test for symlinks edge case, remove check for absolute symlinks when staging artifacts) #198 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/198 | 14:27 |
gitlab-br-bot | buildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/246 | 14:28 |
gitlab-br-bot | buildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/246 | 14:44 |
gitlab-br-bot | buildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/246 | 15:17 |
*** ernestask has joined #buildstream | 15:18 | |
gitlab-br-bot | buildstream: merge request (sam/symlink-speedup->master: utils.py: Wrap calls to os.path.realpath() in an LRU cache) #247 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/247 | 15:19 |
gitlab-br-bot | buildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/246 | 15:21 |
*** tlaxkit has joined #buildstream | 15:26 | |
gitlab-br-bot | buildstream: merge request (jmac/exception-hook->master: WIP: Add a handler for otherwise unhandled exceptions in the main BuildStream app) #248 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/248 | 15:31 |
gitlab-br-bot | buildstream: merge request (jmac/exception-hook->master: WIP: Add a handler for otherwise unhandled exceptions in the main BuildStream app) #248 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/248 | 15:44 |
*** jude has quit IRC | 16:06 | |
*** jude has joined #buildstream | 16:22 | |
*** adds68 has quit IRC | 16:33 | |
ssam2 | so https://buildstream.gitlab.io/buildstream/format.html#format could perhaps be changed to make it more obvious that a binary sysroot is needed at the base of the dependency graph in all cases | 16:34 |
persia | Indeed. WIthout a binary sysroot, it's hard to do anything. | 16:35 |
ssam2 | instead of this meaningless elements/element1.bst example, perhaps a elements/base.bst and a comment explaining that it contains a toolchain etc. | 16:35 |
persia | Do I recall correctly that even in the case of bootstrapping a new sysroot, one has to start with one? | 16:35 |
ssam2 | yes | 16:35 |
persia | Then yes, that sounds like a useful patch. | 16:35 |
*** tlater has left #buildstream | 16:36 | |
*** tlater has joined #buildstream | 16:36 | |
*** adds68 has joined #buildstream | 16:40 | |
*** mcatanzaro has joined #buildstream | 16:44 | |
*** jonathanmaw has quit IRC | 16:57 | |
*** jude has quit IRC | 16:58 | |
gitlab-br-bot | buildstream: merge request (skip-configure-tests->master: WIP: Workspaced builds only run configure commands once) #191 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/191 | 17:05 |
*** adds68 has quit IRC | 17:33 | |
*** jude has joined #buildstream | 17:36 | |
*** valentind has joined #buildstream | 17:49 | |
*** ssam2 has quit IRC | 17:56 | |
gitlab-br-bot | buildstream: merge request (sam/integration-tests-alpine->master: WIP: Use a custom base sysroot for the integration tests) #243 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/243 | 17:57 |
gitlab-br-bot | buildstream: merge request (version-read-no-pkg_res->master: Get version number w/o pkg_resources) #234 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/234 | 17:59 |
gitlab-br-bot | buildstream: merge request (sam/integration-tests-alpine->master: Use a custom base sysroot for the integration tests) #243 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/243 | 18:03 |
*** mcatanzaro has quit IRC | 18:43 | |
*** tlaxkit has quit IRC | 19:13 | |
*** xjuan has quit IRC | 20:23 | |
*** ernestask has quit IRC | 21:16 | |
*** tristan has joined #buildstream | 21:19 | |
*** cs_shadow has quit IRC | 22:14 | |
*** valentind has quit IRC | 22:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!