IRC logs for #buildstream for Friday, 2018-01-19

*** mcatanzaro has quit IRC01:17
*** valentind has joined #buildstream08:29
jmacYes, the problem is saw was that by the time you'd gotten to node.get() you'd already got an integer for 'track', AIUI08:29
jmacSorry, wrong window08:29
aidenis buildstream interpreter agnostic? is it intended to run on cpython only?08:30
tlateraiden: We don't currently test with any other interpreters, but I don't see why it shouldn't run under something like ipython. Is there something in specific you're trying to run it with?08:38
aidentlater, i was just curious really...08:41
*** cs_shadow has quit IRC08:42
jmacThis makes sense now I've seen the solution but it looked like from the issue you were referring to this conversion in node_get as the 'loader', which I now know refers to RoundTripConstructor08:45
jmacSorry, wrong window again :|08:45
jmacIs there a schema for the fields in .bst files defined somewhere? (right window this time)08:51
tlaterThere's this: https://buildstream.gitlab.io/buildstream/format.html#format08:52
tlaterAnd there are default .bst files in /buildstream/data08:53
tlaterBut no strict definition, afaik08:53
tlaterHm, no, not in /buildstream/data, in /buildstream/plugins08:54
jmacI was wondering if I could write something in pykwalify which would validate them08:59
jmacI ran into a problem with valid values for a field in project.conf which took a while to figure out09:00
gitlab-br-botbuildstream: merge request (issue-166_yaml_removing_underscores->master: WIP: Issue 166 yaml removing underscores) #245 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24509:03
*** adds68 has joined #buildstream09:07
*** ssam2 has joined #buildstream09:31
*** jonathanmaw has joined #buildstream09:40
*** valentind has quit IRC09:49
*** adds68 has quit IRC10:09
*** adds68 has joined #buildstream10:09
*** tristan has joined #buildstream10:42
jmacAny ideas on how to cause an exception to happen in the main buildstream app, for a test?11:01
nexusi can't think of anything without changing code11:11
ssam2what kind of exception ?11:11
ssam2an invalid bst file would trigger a LoadError11:11
nexusi'm assuming unhandled11:12
nexusinvalid pipeline is fairly easy to achieve11:12
nexus*Inconsistent pipeline11:13
* nexus just tried various command combos, hopnig to break something11:14
* tlater wonders about #146 - it seems like running all tests with python3.4 should happen to *all* platforms11:15
tlaterYet tristan suggests adding a separate runner to test python3.4, I think?11:15
tristantlater, a runner would not be necessary for that; a docker image yes11:18
ssam2which distro causes the python3.4 requirement? would make sense to just run the tests on that distro11:18
ssam2either instead of or in addition to the Fedora 27 base we currently use11:19
ssam2probably in addition to11:19
* tlater thinks it's debian, considering jonathanmaw's frequent protest11:19
*** cs_shadow has joined #buildstream11:19
jonathanmawtlater: I'm on an old version of debian, I think the newest version of debian is 3.5 now11:20
tlaterI wonder if there's a way to create all those docker images without having to add an entirely new image for each system11:20
tlaterMaybe tags could work?11:20
ssam2what do you mean by "create a new image" ?11:20
ssam2there's no way to create images without ... creating images11:20
* tlater isn't sure what docker calls it... branch?11:21
ssam2we could use tags to have a 'testsuite' image with tags like :fedora27, :debian6, etc.11:21
ssam2but i think that's abuse of tags11:21
ssam2they are generally used to denote different versions of the same conceptual thing11:21
ssam2automation in the buildstream-docker-images repo makes it pretty easy to build different images and push the in whatever way we want11:22
tlaterHrm, I guess scripting the .gitlab-ci.yaml to do things in loop isn't too bad11:22
tristanjmac, I have a good approach for that... sec11:22
ssam2*push them11:22
ssam2e.g. you could add a testsuite-debian image pretty easily11:22
tlaterYeah, that seems fine11:22
ssam2requires someone who is an admin on the Docker hub to create the new image, but i'd be happy to give you the priviliges11:23
tlaterThat would be nice :)11:23
tristanjmac, see this commit: 60d5e070c17ef15caa42a847b0f9957432bd646811:23
* tlater needs a docker hub account for that, I suppose11:23
ssam2yes, create an account and then I can add you to the buildstream group11:23
tristanjmac, something like that which raises an exception that does not inherit from BstError should cause an unhandled exception at preflight time11:24
jmactristan: Yep, that looks good11:52
*** jude has quit IRC12:01
*** jude has joined #buildstream12:02
*** tristan has quit IRC13:46
*** xjuan has joined #buildstream14:25
gitlab-br-botbuildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24614:26
gitlab-br-botbuildstream: merge request (sam/symlinks-2->master: Avoid unnecessary os.path.realpath() calls in _ensure_real_directory()) #201 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/20114:27
gitlab-br-botbuildstream: merge request (sam/symlinks->master: WIP: Add test for symlinks edge case, remove check for absolute symlinks when staging artifacts) #198 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/19814:27
gitlab-br-botbuildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24614:28
gitlab-br-botbuildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling, and speed up artifact staging) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24614:44
gitlab-br-botbuildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24615:17
*** ernestask has joined #buildstream15:18
gitlab-br-botbuildstream: merge request (sam/symlink-speedup->master: utils.py: Wrap calls to os.path.realpath() in an LRU cache) #247 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24715:19
gitlab-br-botbuildstream: merge request (sam/symlinks-optimization->master: Improve tests for symlink handling) #246 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24615:21
*** tlaxkit has joined #buildstream15:26
gitlab-br-botbuildstream: merge request (jmac/exception-hook->master: WIP: Add a handler for otherwise unhandled exceptions in the main BuildStream app) #248 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24815:31
gitlab-br-botbuildstream: merge request (jmac/exception-hook->master: WIP: Add a handler for otherwise unhandled exceptions in the main BuildStream app) #248 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24815:44
*** jude has quit IRC16:06
*** jude has joined #buildstream16:22
*** adds68 has quit IRC16:33
ssam2so https://buildstream.gitlab.io/buildstream/format.html#format could perhaps be changed to make it more obvious that a binary sysroot is needed at the base of the dependency graph in all cases16:34
persiaIndeed.  WIthout a binary sysroot, it's hard to do anything.16:35
ssam2instead of this meaningless elements/element1.bst example, perhaps a elements/base.bst and a comment explaining that it contains a toolchain etc.16:35
persiaDo I recall correctly that even in the case of bootstrapping a new sysroot, one has to start with one?16:35
ssam2yes16:35
persiaThen yes, that sounds like a useful patch.16:35
*** tlater has left #buildstream16:36
*** tlater has joined #buildstream16:36
*** adds68 has joined #buildstream16:40
*** mcatanzaro has joined #buildstream16:44
*** jonathanmaw has quit IRC16:57
*** jude has quit IRC16:58
gitlab-br-botbuildstream: merge request (skip-configure-tests->master: WIP: Workspaced builds only run configure commands once) #191 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19117:05
*** adds68 has quit IRC17:33
*** jude has joined #buildstream17:36
*** valentind has joined #buildstream17:49
*** ssam2 has quit IRC17:56
gitlab-br-botbuildstream: merge request (sam/integration-tests-alpine->master: WIP: Use a custom base sysroot for the integration tests) #243 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24317:57
gitlab-br-botbuildstream: merge request (version-read-no-pkg_res->master: Get version number w/o pkg_resources) #234 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/23417:59
gitlab-br-botbuildstream: merge request (sam/integration-tests-alpine->master: Use a custom base sysroot for the integration tests) #243 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/24318:03
*** mcatanzaro has quit IRC18:43
*** tlaxkit has quit IRC19:13
*** xjuan has quit IRC20:23
*** ernestask has quit IRC21:16
*** tristan has joined #buildstream21:19
*** cs_shadow has quit IRC22:14
*** valentind has quit IRC22:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!