IRC logs for #buildstream for Wednesday, 2017-12-20

*** mcatanzaro has joined #buildstream00:31
*** tristan has joined #buildstream02:13
*** tristan has quit IRC02:30
*** mcatanzaro has quit IRC02:45
*** bochecha has quit IRC04:53
*** bochecha has joined #buildstream04:53
*** bochecha has quit IRC04:58
*** bochecha has joined #buildstream04:58
*** tiago has joined #buildstream09:52
*** ssam2 has joined #buildstream10:16
gitlab-br-botbuildstream: merge request (juerg/cache-key-doc->master: Add cache key documentation) #197 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19710:24
gitlab-br-botbuildstream: merge request (juerg/cache-key-doc->master: Add cache key documentation) #197 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19711:15
gitlab-br-botbuildstream: issue #175 ("Refactor integration tests") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/17511:52
*** tristan has joined #buildstream12:31
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18313:12
tlatertristan: Do you think creating elements in test cases is better than having template files for test cases?14:02
*** tpollard has quit IRC14:32
*** tpollard has joined #buildstream14:34
*** semanticdesign_ has joined #buildstream14:55
tristantlater, I'm mostly ambivalent, I've used both - I think I'm growing a tendency towards preferring to generate them14:56
tristanmostly because doing that in conjunction with parameterized tests is powerful14:56
tristanreadability is important to preserve when doing generation (i.e. making it clear what it is we are testing)14:57
*** zbrown has joined #buildstream15:01
*** tpollard has quit IRC15:04
*** zbrown has quit IRC15:08
*** tpollard has joined #buildstream15:08
*** zbrown has joined #buildstream15:18
*** zbrown has quit IRC15:37
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18315:38
tlaterIs root-read-only supposed to be True by default?15:40
tlaterIn script elements, that is15:41
tristantlater, it's not16:40
* tlater thinks there was a regression in the tests then at some point, that's fixed :)16:41
nexustristan: i've had a look at some of the comments you gave, and while i think that what you've written is good [in reference to forward describing] i think it's too much detail for a getting started guide, but would be good for a more detailed tutorial16:43
persiaWhen it comes to docs, I've always been in favour of committing first and fixing later.  Docs wandering between scopes are far preferable to no docs16:44
persiaMind you, spelling/grammar/factual errors should be avoided as a result of review :)16:44
gitlab-br-botbuildstream: merge request (quiet-output->master: frontend/main: Add a --quiet option) #190 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/19016:50
gitlab-br-botbuildstream: merge request (juerg/cache-key-doc->master: Add cache key documentation) #197 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/19716:52
*** zbrown has joined #buildstream16:59
tristannexus, my intention was to simplify it and to keep the discussion abstract17:03
tristanIt can be simplified more17:03
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18317:05
nexustristan: I think a good way to go would be to have a "next we're going to" followed by steps and then a brief explaination afterwards17:08
nexuswas that the kind of thing you had in mind?17:08
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18317:09
tristannexus, I was rather thinking of a series of "how do I ?" standalone documents17:10
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18317:11
tristana hand held lesson/tutorial is probably a bit more work, not sure it's better17:11
* tristan has to get into a lift and will be online couple hours later17:11
nexusok no problem, we probably need more time to discuss this and brainstortm what to work on17:12
tristanshort standalone howto documents tend to A.) be more sortable into our existing TOC   B.) Be more directly linkable17:13
tristanas in, it's always handy to link to "how that is done", more so than "how this step in that works"17:13
tristananyway think about it...17:14
gitlab-br-botbuildstream: merge request (sam/symlinks->master: Don't check symlink targets when staging artifacts) #198 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19817:17
*** tristan has quit IRC17:17
*** mcatanzaro has joined #buildstream17:17
gitlab-br-botbuildstream: merge request (sam/symlinks->master: Don't check symlink targets when staging artifacts) #198 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19817:17
*** valentind has joined #buildstream17:32
*** zbrown has quit IRC17:42
gitlab-br-botbuildstream: merge request (sam/symlinks->master: Don't check symlink targets when staging artifacts) #198 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19817:45
gitlab-br-botbuildstream: merge request (sam/savefile-utility->master: utils.py: Add SaveFile utility class) #179 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/17917:50
gitlab-br-botbuildstream: merge request (master->master: WIP: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18317:53
gitlab-br-botbuildstream: merge request (master->master: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18317:59
*** jonathanmaw has joined #buildstream18:00
*** mcatanzaro has quit IRC18:12
*** mcatanzaro has joined #buildstream18:14
gitlab-br-botbuildstream: merge request (master->master: Documentation improvements) #183 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18318:17
*** jonathanmaw has quit IRC18:18
*** ssam2 has quit IRC18:19
*** xjuan has joined #buildstream18:32
*** jonathanmaw has joined #buildstream18:34
*** jonathanmaw has quit IRC18:37
*** mcatanzaro has quit IRC18:44
*** tristan has joined #buildstream18:45
gitlab-br-botbuildstream: merge request (fix-type-error-plugincontext->master: Fix a "TypeError: 'dict' object is not callable" in _plugincontext.py) #199 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/19918:57
*** xjuan has quit IRC20:01
gitlab-br-botbuildstream: merge request (fix-type-error-plugincontext->master: Fix a "TypeError: 'dict' object is not callable" in _plugincontext.py) #199 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/19920:58
gitlab-br-botbuildstream: merge request (project-name->master: project: Export the name as a variable) #182 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/18221:03
*** tristan has quit IRC21:42
*** zbrown has joined #buildstream21:45
*** tristan has joined #buildstream22:00
gitlab-br-botbuildstream: merge request (project-name->master: project: Export the name as a variable) #182 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/18222:17
*** semanticdesign_ has quit IRC22:41
*** zbrown has quit IRC23:07
*** zbrown has joined #buildstream23:35
*** zbrown has quit IRC23:39

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!