IRC logs for #buildstream for Wednesday, 2017-11-15

*** juergbi has quit IRC00:12
*** mcatanzaro has quit IRC03:21
*** tristan has joined #buildstream06:23
persiatristan: I'm watching a presentation on Kubernetes, and the speaker mentioned that they currently have a 2-week window in each quarterly release before feature freeze.  Features to be included in the next release need to be submitted and agreed prior to the close of that window in order to be included.  For a biannual release cycle, that would map to about a month.07:43
persiaThe idea being that features proposed early in the cycle would be expected to be able to mature by end of cycle.  I don't know if that would be a useful tool, but figured I'd share in case you liked it as a model.07:44
*** juergbi has joined #buildstream07:52
* paulsherwood wonders when 1.0 is07:59
persiapaulsherwood: When it's ready.  We've agreed that it isn't part of the GNOME release, but there are still a couple outstanding blockers.08:01
paulsherwoodack08:01
persiahttps://gitlab.com/BuildStream/buildstream/issues?label_name[]=Blocker is the current outstanding list of blockers08:01
persiaFrom the meeting yesterday (http://meetbot.gnome.org/buildstream-meetings/2017/buildstream-meetings.2017-11-14-14.04.html), I had the impression that these were close to being resolved.08:02
persiaFull meeting log at http://meetbot.gnome.org/buildstream-meetings/2017/buildstream-meetings.2017-11-14-14.04.log.html if you want more context08:02
paulsherwoodthanks, persia08:06
tristanpersia, I think our feature freeze is one month, two weeks seems a bit tight no ?08:19
* tristan checks the schedule08:19
tristanpaulsherwood, the idea is to follow the GNOME release schedule, but to ignore some of the freezes which dont really apply to us (i.e. string freeze is pointless unless we implement i18n first)08:20
tristanThat, and to skip the next release in February/March, since we're late to the table anyway; relaxing the first cycle a bit08:20
tristanpersia, We can make exceptions for special cases, it's not set in stone - but indeed our feature freeze -> code freeze period is 1 month; https://wiki.gnome.org/Schedule08:22
tristanGNOME will have feature freeze Feb 5 until March 508:22
* tristan is in the midst of buildstream smoke testing the first GNOME dev release to be made with buildstream; 3.27.208:23
tristanits a bit scary ;-)08:23
tristannexus, I said I wouldnt be available to "talk" today, and it's true; but if you're around and you want to get started on the docs stuff you were going to do... I have some suggestions08:24
tristannexus, first of all; we are most in need of better guidance on the user side08:25
tristannexus, the first project I think jonathan started on was more focused on creating docs about how to author projects, I think that is a separate activity08:25
tristannexus, so I *think* a good place to start; would be human readable breakdown of stuff in: http://buildstream.gitlab.io/buildstream/invoking.html#invoking08:26
tristannexus, that is currently generated by: https://gitlab.com/BuildStream/buildstream/blob/master/doc/source/invoking.rst08:27
tristan(click the little </> sign to view the page source instead of the rendered rst)08:28
*** jude has joined #buildstream08:28
tristannexus, note that it does :show-nested:, I suggest that we remove :show-nested: from there, and refer to the autogenerated docs for each command separately; allowing us to add some free form text and explanations of what can be done08:29
tristanHowever, that might be backwards08:29
tristannexus, a different approach is to drill down from what kind of activity the user wants to achieve; and refer to the commands from a separate page08:29
tristanlike "How do I develop my module", think about the questions csoriano was asking the other day, the meaning of tracking sources; how developer workspaces work, etc08:30
tristannexus, it's probably extremely early in the morning wherever you are... but just leaving this text for you when you get a chance to read it; as I had a moment to scribble it down whilst things build in the background08:31
tristan... and WebKit starts to build ...09:07
gitlab-br-botbuildstream: issue #155 ("Stack trace encountered when staging a tarball") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/15509:22
*** bethw has joined #buildstream09:26
*** nexus has left #buildstream09:40
*** nexus has joined #buildstream09:41
csorianohey, what' the name of gtk4?09:41
csorianowell, just gtk master09:41
csorianoI'm trying bst track --deps all --except base.bst core-deps/gtk+.bst09:43
csorianobut it says module not found09:43
tristanIt doesnt appear to be in the conversions09:43
tristanThat would be because the conversions currently need to take targets09:44
tristanSo the targets currently used are the meta ones09:44
tristanA fix would be to include GTK+ master in meta-gnome-core, or; to add some things to https://gitlab.com/BuildStream/jhbuild2bst/blob/master/autoconvert/autoconvert.sh#L21309:45
csorianoargh....09:45
csorianoI was convinced I could use buildstream so show gtk+ in a presentation I do in 1 hour :D09:45
tristanIn fact, just adding them to that file, will cause the next conversion (every 10 minutes I think), will cause it to appear09:46
tristanWell09:47
tristancsoriano, what do you need to build, just GTK+ ? or something that depends on the new GTK+ that is already in the modulesets ?09:47
csorianotristan: just gtk+, so show the recorder basically09:47
*** anahuelamo has joined #buildstream09:47
csorianothe GktInspector recorder09:47
tristanYou could easily `cp elements/core-deps/gtk+-3.bst elements/core-deps/gtk+.bst` and edit the file09:48
tristanjust make it `track: master`09:48
tristanand do `bst track core-deps/gtk+.bst` and `bst build core-deps/gtk+.bst`09:49
tristanAssuming it doesnt depend on anything new09:49
*** bethw has quit IRC09:49
tristanOk some few issues with first time building the dang tarballs09:58
tristanhttps://gitlab.com/BuildStream/buildstream/issues/155 probably the worst of it09:58
tristanI can work around for this release, the rest I'll have to inspect and see; but probably just the fact that we always build from git, and now that we try the tarballs, many things are just totally different09:59
*** ssam2 has joined #buildstream09:59
*** tpollard has joined #buildstream10:03
*** jonathanmaw has joined #buildstream10:05
*** givascu has joined #buildstream10:14
jonathanmawtristan: is https://gitlab.com/BuildStream/buildstream/merge_requests/127 fixed to your satisfaction?10:15
tristanjonathanmaw, no time right now10:20
jonathanmawtristan: okie doke. I'll focus on the errors in overlaps stuff for now, then.10:21
*** bethw has joined #buildstream10:28
tlaterI think the base-system element in the current gnome-modulesets might bebroken.11:06
ssam2jonathanmaw, did you get anywhere with https://gitlab.com/BuildStream/buildstream/merge_requests/125 ?11:08
tristantlater, why would you think that ?11:09
jonathanmawssam2: I haven't picked it up11:09
tlatertristan: Just pulling a fresh copy it gave me the 'no sources' error - it looks like buildstream doesn't resolve the conditional before it checks that11:09
ssam2jonathanmaw, so you didn't start work on it in the end ?11:09
tlaterBut my buildstream may be outdated, not sure what this docker image runs11:10
ssam2the docker image has a really old version of buildstream11:10
jonathanmawssam2: no. tbh I don't remember opening the merge request. maybe I mis-clicked.11:10
tlaterAh, right11:10
* tlater attemtps with master11:10
ssam2in CI we manually install a specific (and newer) version11:10
ssam2jonathanmaw, ah ok11:11
tlaterYeah, nevermind, the current version of buildstream handles it just fine11:12
ssam2hmm, the Docker image was supposed to auto update though11:12
bethwssam2, jonathanmaw, is one of you able to pick up MR!125? From what I understand, it's necessary for 1.0, but please correct me if I'm wrong11:13
jonathanmawbethw: the attached issue is a blocker, so that's my understanding, too11:13
* tlater can also pick it up once I get around to finishing the two I'm on right now - I wrote the external plugin support in the first place11:14
ssam2jonathanmaw, could you look at that before starting errors on overlaps? better to fix bugs before doing new features11:15
ssam2review of https://gitlab.com/BuildStream/bst-external/merge_requests/7 would also be appreciated11:15
jonathanmawssam2: yep, errors on overlaps isn't a blocker, AIUI11:15
bethwjonathanmaw, that would be great, thanks11:16
bethwAnd cheers ssam211:16
ssam2It turns out the Docker image is being updated perfectly fine11:17
ssam2but for some reason I thought `docker run` checked for updates, when it actually doesn't11:18
ssam2so tlater you just need to `docker pull buildstream/buildstream-fedora`11:18
ssam2I should note this in the bst documentation too11:18
* tlater forgot that docker didn't do that, ta ssam2 11:18
tristanfwiw: GNOME 3.27.2 released: https://mail.gnome.org/archives/desktop-devel-list/2017-November/msg00059.html11:22
tristanNow with snapshot project: https://download.gnome.org/teams/releng/3.27.2/gnome-3.27.2.tgz11:22
tristanSo interestingly; that tarball gives you an exact project state from which GNOME was released from BuildStream11:23
* tristan will write up how he did this release, and what needs taking care of, in a blog post tomorrow I guess11:23
tristanAlso, since this release: https://gitlab.com/BuildStream/buildstream/issues/15511:24
tristanThe above is a pretty serious bug11:24
tristanIt's not technically blocker to 1.0, but it's a blocker for GNOME to seriously use BuildStream - And I worry that it is in fact a symptom of python's subpar tarball handling11:25
tristanIt may mean we need to override some of python's tar internals; because fixing that upstream and waiting years for a fix to trickle down is not reasonable11:25
ssam2wow, i didn't realise you were actually doing that release :-)11:26
tristanAha !11:26
tristanYou thought I was all talk and no walk !11:26
tristan:)11:26
ssam2i didn't even hear much talk :-)11:26
tlaterThe gnome-release ninjas strike again!11:27
tristanwell, there was admittedly only this: https://mail.gnome.org/archives/desktop-devel-list/2017-November/msg00032.html11:27
tristanssam2, you would have heard more talk, if people were actively resisting the change11:27
ssam2true !11:28
tristanBut, looks like we're on track :D11:28
ssam2building that snapshot project seems to happily pulling everything from the cache for me11:28
inigomartinezcongrats tristan for the successful .2 release :)11:35
tristaninigomartinez, :)11:37
tristanthanks !11:37
tristanIts my first; I was a bit worried but luckily https://wiki.gnome.org/ReleasePlanning/MakingARelease didnt present issues which take hours to figure out :D11:37
tristanwhat I did not do though, is run around and fix upstream things in modules11:38
tristanI dont think really the current approach is reasonable for that work, which is why I feel like we should be moving to releasing from git11:39
tristanEither that, or we need to be running some CI on the tarball conversion yada yada thing11:39
tristancause you just never know until the last moment what's going to happen; building from released tarballs is different11:40
tlaterssam2: This is the issue I found when googling the error I get on my machine: https://github.com/projectatomic/bubblewrap/issues/13411:55
tlaterIt's possible your machine is a bit different because it has selinux enabled11:55
tlaterRunning the suggested test: `bwrap --ro-bind / / --unshare-user --unshare-pid --proc /proc /bin/bash` *does* result in a permission denied inside docker11:57
tlaterBut there is no trace of a /proc/xen or anything11:57
ssam2I get: bash: /dev/null: Permission denied11:57
* tlater also doesn't know what /proc/xen even is supposed to be11:57
ssam2that's irrelevant here11:57
tlaterssam2: That's outside the container11:58
tlaterRun that command in a docker container11:58
ssam2no, this is in a container11:58
tlaterHow did you launch that?11:58
ssam2I started it on that VM with: sudo docker run --privileged --volume /home/fedora/src/baserock/definitions/.cache/:/root/.cache  --volume /home/fedora/src/:/src -i -t docker.io/buildstream/buildstream-fedora /bin/bash11:58
tlaterHuh11:59
tlaterThat works11:59
tlaterAh, got it12:01
tlaterbst-here doesn't run with --privileged12:01
ssam2oh12:01
tlaterBut just with --cap-add SYS_ADMIN12:01
ssam2hmmm, right12:01
tlaterLooks like that isn't enough, perhaps anymore12:01
ssam2i wonder how we work out what else is needed12:03
ssam2`man capabilities` is the first stop i guess12:04
tlaterCAP_SYS_CHROOT?12:07
ssam2oh, is this with the UNIX backend  ?12:07
ssam2perhaps the issue is we only tested bst-here with the normal backend!12:07
tlaterNo, this is the normal backend12:08
ssam2ah12:08
tlaterBut maybe bubblewrap requires that for some reason?12:08
tlaterActually, I suppose the question is what bubblewrap needs12:08
ssam2true. its code is pretty simple12:08
*** tristan has quit IRC12:16
tlaterbubblewrap seems to need these: (CAP_SYS_ADMIN) | (CAP_SYS_CHROOT) | (CAP_NET_ADMIN) | (CAP_SETUID) | (CAP_SETGID)12:17
ssam2wow, so how did this ever work12:18
ssam2i'm sure i ran builds through bst-here. but i am really bad at testing stuff thoroughly, so maybe i didn't12:18
* tlater tries setting those caps and runs the command again12:19
tlaterOn selinux it also needs to mount the user directory with :Z12:21
tlaterNope, still not enough :|12:23
ssam2maybe selinux is the issue ?12:42
ssam2i've double checked if bst-here used to have the --privileged flag, but it never did12:42
*** anahuelamo has quit IRC12:47
tlaterssam2: selinux isn't the issue, same thing happens on my local machine which definitely doesn't have it enabled13:20
*** jonathanmaw has quit IRC13:32
*** jonathanmaw has joined #buildstream13:35
*** jonathanmaw has quit IRC14:01
*** jude has quit IRC14:02
*** jude has joined #buildstream14:04
gitlab-br-botpush on buildstream@except_intersections (by Tristan Maat): 7 commits (last: Refactor, remove some unused imports) https://gitlab.com/BuildStream/buildstream/commit/cc6e09ce63c7576bd3f258515946e38a945903f414:09
gitlab-br-botpush on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 6 commits (last: Refactor, remove some unused imports) https://gitlab.com/BuildStream/buildstream/commit/cc6e09ce63c7576bd3f258515946e38a945903f414:09
gitlab-br-botbuildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14714:09
gitlab-br-botpush on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 1 commit (last: Disable coverage temporarily) https://gitlab.com/BuildStream/buildstream/commit/8879768a05d4c8ed213c1b0527f6b376d26e2f9c14:33
gitlab-br-botbuildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14714:33
tlaterWell, it turns out that the segfault is caused by coverage15:04
tlaterNo wonder I can't reproduce it15:05
* tlater wonders if we are misusing coverage15:05
gitlab-br-botpush on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 1 commit (last: Maybe this fixes it) https://gitlab.com/BuildStream/buildstream/commit/69faaec4756c9c4715d7a23e8e85caa8826b7a0c15:12
gitlab-br-botbuildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14715:12
gitlab-br-botpush on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 1 commit (last: Maybe this fixes it) https://gitlab.com/BuildStream/buildstream/commit/777dc820dcbe187d8c9b3edb708c09a943080c5c15:17
gitlab-br-botbuildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14715:17
*** tristan has joined #buildstream15:31
* tlater puts cache management commands on his christmas wish list15:40
nexustlater: what do you want to manage about your cache?15:42
tlaternexus: I'd like to remove individual artifacts without needing to find my way through ostree - only really useful to buildstream developers though ;)15:43
tristanlike this https://gitlab.com/BuildStream/buildstream/issues/135 ?15:43
* nexus is working on that issue ;-;15:43
tlaterYeah, that would already be pretty handy :)15:43
*** mcatanzaro has joined #buildstream15:58
*** semanticdesign has joined #buildstream16:00
gitlab-br-botpush on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 1 commit (last: Well, maybe if we just run the cmake-test...) https://gitlab.com/BuildStream/buildstream/commit/23604f38f6f70dc514852a92d83ddbe4b0a3d4d016:00
gitlab-br-botbuildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14716:00
tlaterSo, coverage segfaults... But only in the GitLab CI16:28
tlaterLocally I can't get it to crash, even when running the exact same test :|16:28
ssam2bah16:31
ssam2out of memory ? pure guess16:32
ssam2probably wouldn't lead to a segfault, either16:32
tlaterssam2: It continues running other tests just fine after16:32
ssam2we've never seen this outside your branch, right? so we should be able to work out what change has caused this, at least16:32
tlaterI suppose, yeah. I just have no idea what would effect this, since it wasn't even related to the test that causes it16:33
tlaterHm, I guess I can start rolling back commits16:33
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 4 commits (last: main.py: Fix app initialization) https://gitlab.com/BuildStream/buildstream/commit/60307b9b2096eeb5a3f221af2f58e38b7d7e915316:39
*** jonathanmaw has joined #buildstream16:44
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 1 commit (last: Well, maybe if we just run the cmake-test...) https://gitlab.com/BuildStream/buildstream/commit/70f2e355731fe955857c36f9e30b43c6bff2ee2a16:46
gitlab-br-botbuildstream: merge request (provenance_fmt->master: WIP: De-dup brackets around provenance in error messages) #134 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/13416:47
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 1 commit (last: Well, maybe if we just run the cmake-test...) https://gitlab.com/BuildStream/buildstream/commit/4c4b18902bb5faeb6289f3b7dbab74fcc3d87bb616:48
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 1 commit (last: Well, maybe if we just run the cmake-test...) https://gitlab.com/BuildStream/buildstream/commit/858a0c6ab639f59e6be2a53cf0442163682684b316:48
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 1 commit (last: Well, maybe if we just run the cmake-test...) https://gitlab.com/BuildStream/buildstream/commit/1f868ba4b2a14652a25ffed9eb4a9d39afd8772017:04
*** jude has quit IRC17:18
gitlab-br-botpush on buildstream@test_coverage_segfault (by Tristan Maat): 1 commit (last: Fix tests) https://gitlab.com/BuildStream/buildstream/commit/76730dcb20ceff348f9f629b1aa29825eb6775ee17:20
ssam2would anyone miss these push notifications if i disabled them, and just had notifications for merge requests and issue updates ?17:21
* tlater definitely wouldn't17:21
tlaterAlthough I suppose I really should be doing this on a separate repo17:23
tristanssam2, what I really always wanted, was notifications of push to *master*17:24
ssam2oh yeah. seems we can either have all or nothing17:24
tristanssam2, couldnt it take like < 5 min if we just added hard code to the script to ignore pushes to not master ?17:25
tristanwithout messing with the config or anything ?17:25
tristanif someone is like, already there...17:25
ssam2the script serves a few different projects though17:25
ssam2https://gitlab.com/palvarez89/gitlab-to-irc17:25
ssam2maybe we could add a push-master condition17:25
tristannone of which enable the notifications for pushes, except buildstream17:25
ssam2right17:26
tristanwell, if it's too troublesome, just disable it17:27
tristanI'm also annoyed, but would like to have them for master17:27
*** tpollard has quit IRC17:27
ssam2ok17:28
ssam2i can file a bug :-)17:28
tristanheh17:28
tristanthat might be better than a hack, I think ironfoot wants to upstream some of the changes to the original project17:29
tristanwhich was the most featurefull gitlab bot I could find at the time17:29
tristanbut there are a lot of other ones, I dont think anyone is really taking gitlab irc bots to the serious level of considering them "project worthy"17:29
tristanjust rather an afternoon hack that joe random publishes on their gitlab17:30
ironfootI started looking at it, but lack of time :S17:32
ironfootalso, javascript :)17:33
ironfootI still want to finish it17:33
tlaterThis commit somehow causes coverage to crash: https://gitlab.com/tlater/buildstream/commit/6af10543455272c28da12d8538b4eed4b3d25cf217:34
tlaterNow just to find what actually causes it...17:34
ssam2heh, nothing jumps out of that to say "crash me!!"17:38
tlaterIt's a fluke in coverage that gets triggered specifically while building something with cmake after this change17:39
* tlater has no clue how any of those things are related x)17:40
*** bethw has quit IRC17:53
tristanironfoot, javascript is ridiculously just like python, they are both very lispy17:54
*** jonathanmaw has quit IRC18:02
csorianotristan: I'll try that, doesn't sounds too complex18:05
csoriano(too late for the presentation though, jhbuild failed and I didn't read your message in time :( )18:05
csorianoin any case, congrats for the 3.27.2 release 👏18:06
gitlab-br-botbuildstream: issue #156 ("`bst-here` capabilities are too narrow") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/15618:08
*** jude has joined #buildstream18:22
*** valentind has joined #buildstream18:34
*** ssam2 has quit IRC18:49
gitlab-br-botbuildstream: merge request (compose-integration-delete->master: Handle removed files from integration in compose plugin) #142 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/14221:17
*** givascu has quit IRC21:25
*** valentind has quit IRC22:00
*** valentind has joined #buildstream22:00
persiatristan: Apologies for the miscommunication: the period I was talking about was release -> feature proposal freeze, not feature submission freeze -> code freeze.  1 month for the latter seems fine.  The other project uses the equivalent of one month for the former as well, as a means to ensure features are well understood when development begins.22:26
persiaActually, thinking about it more, that might be uncomfortable, as sometimes one has a great idea for something that can be implemented safely and quickly, and such a freeze would force delay: it might make more sense for projects that release more often.22:26
*** valentind has quit IRC22:36
*** jude has quit IRC23:21

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!