| *** tristan has joined #buildstream | 05:35 | |
| nexus | python3 python3-dev python3-pip git \ | 09:04 |
|---|---|---|
| nexus | python3-gi gir1.2-ostree-1.0 ostree \ | 09:04 |
| nexus | oops | 09:04 |
| *** tpollard has joined #buildstream | 09:23 | |
| *** jonathanmaw has joined #buildstream | 09:33 | |
| tristan | tlater, so how do you feel about the https://gitlab.com/BuildStream/buildstream/merge_requests/145 ? | 09:39 |
| tristan | confident ? | 09:39 |
| tristan | tlater, I've got a dinner date and will be stepping out presently... took a quick look and it looks alright, I'm glad for the `yield from` changes, I'm curious if we really need the `recurse` and `recursed` still is needed with the new approach | 09:41 |
| tristan | but I think it's good | 09:41 |
| tristan | ok well, I think I'll merge this, it looks sane, and fixes the regression, which is a good start | 09:42 |
| tristan | might not be completely perfect, I wonder if non recursive Scope.RUN (is that even a use case ?) succeeds to yield the toplevel `self` | 09:43 |
| gitlab-br-bot | push on buildstream@migrate_pipeline_load (by Tristan Van Berkom): 3 commits (last: git.py source plugin: Prune remote-tracking branches when fetching) https://gitlab.com/BuildStream/buildstream/commit/794e73cb4469c30bd830b333597a6932da1254f1 | 09:44 |
| gitlab-br-bot | buildstream: merge request (migrate_pipeline_load->master: Migrate `tests/pipeline/load.py`) #145 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/145 | 09:44 |
| *** tristan has quit IRC | 09:48 | |
| *** jonathanmaw has quit IRC | 09:48 | |
| *** valentind has joined #buildstream | 09:48 | |
| *** tristan has joined #buildstream | 10:00 | |
| tlater | tristan: Well, I struggled trying to get recurse=False to work with just the visited dict for a while, and it seems impossible | 10:02 |
| tlater | At least not without changing the old behavior that the root element is *not* included. | 10:02 |
| *** jonathanmaw has joined #buildstream | 10:04 | |
| *** ssam2 has joined #buildstream | 10:07 | |
| gitlab-br-bot | buildstream: merge request (migrate_pipeline_load->master: Migrate `tests/pipeline/load.py`) #145 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/145 | 10:19 |
| gitlab-br-bot | push on buildstream@master (by Tristan Van Berkom): 2 commits (last: load.py: Migrate to new test style) https://gitlab.com/BuildStream/buildstream/commit/25f6bec66a742cf96e45ed4f2e16bbcde972174b | 10:19 |
| gitlab-br-bot | buildstream: Tristan Van Berkom deleted branch migrate_pipeline_load | 10:19 |
| tristan | tlater, right, I think in 90% cases we recurse, I dont recall where we dont, maybe in compose | 10:20 |
| tristan | tlater, point being in Scope.RUN, `self` is in scope | 10:21 |
| tlater | tristan: The planner uses it too, among others - it's quite handy to have recurse=False for some things | 10:21 |
| tristan | that should anyway effect `bst shell` and `bst checkout`, which I think are well tested anyway | 10:21 |
| tristan | I see | 10:21 |
| tristan | yes it is, I recall now I was able to refactor out some duplicate code by adding that param | 10:21 |
| gitlab-br-bot | push on buildstream@except_intersections (by Tristan Maat): 8 commits (last: git.py source plugin: Prune remote-tracking branches when fetching) https://gitlab.com/BuildStream/buildstream/commit/794e73cb4469c30bd830b333597a6932da1254f1 | 10:39 |
| *** tristan has quit IRC | 10:41 | |
| *** tristan has joined #buildstream | 10:43 | |
| gitlab-br-bot | buildstream: issue #150 ("Network retries configuration seems to not apply to pushing artifacts") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/150 | 10:48 |
| gitlab-br-bot | buildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/147 | 10:51 |
| gitlab-br-bot | buildstream: Tristan Maat created branch 131-behavior-of-except-argument-is-frustrating-and-confusing | 10:51 |
| tlater | I can't delete MRs, can I? :/ | 10:52 |
| tlater | Hm, I suppose I can just rebase my actual branch onto this one... | 10:52 |
| gitlab-br-bot | push on buildstream@131-behavior-of-except-argument-is-frustrating-and-confusing (by Tristan Maat): 5 commits (last: main.py: Fix app initialization) https://gitlab.com/BuildStream/buildstream/commit/1056422838629f605df7cbfd076ab18e73686554 | 10:54 |
| gitlab-br-bot | buildstream: merge request (131-behavior-of-except-argument-is-frustrating-and-confusing->master: WIP: Resolve "Behavior of --except argument is frustrating and confusing") #147 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/147 | 10:54 |
| ssam2 | jonathanmaw, tristan : does https://gitlab.com/BuildStream/bst-external/merge_requests/5 look ok? | 11:00 |
| ssam2 | last night i got a minimal VM image built with buildstream | 11:01 |
| ssam2 | the disk image ends up being 53MB | 11:01 |
| ssam2 | which is not the best, but will have to do for now :-) | 11:01 |
| tlater | 53MB isn't huge | 11:03 |
| ssam2 | i also wrestled with python asyncio to produce a simple script that boots the VM in qemu and checks that `uname -a`works | 11:04 |
| ssam2 | if that script works in GitLab CI, i will be *very* happy | 11:04 |
| *** valentind has quit IRC | 11:06 | |
| *** adds68__ has quit IRC | 11:11 | |
| ssam2 | i'm going to merge https://gitlab.com/BuildStream/bst-external/merge_requests/5 as obvious unless anyone speaks up in the next few minutes | 11:16 |
| tlater | Hmm... I don't think `build --track-except` can have the exact same functionality as `track --except` | 11:24 |
| tlater | Since we now actually load excepted elements as part of the pipeline, we can't track with different exceptions than we build. | 11:25 |
| tlater | Unless I somehow conservatively purge track-excepted elements, but that feels ugly :/ | 11:26 |
| *** tpollard has quit IRC | 11:44 | |
| WSalmon | 10:30 | 13:28 |
| WSalmon | sorry | 13:28 |
| WSalmon | fat fingers | 13:28 |
| WSalmon | wrong tab | 13:29 |
| *** sstriker has joined #buildstream | 14:08 | |
| *** jude has quit IRC | 14:18 | |
| *** jude has joined #buildstream | 14:22 | |
| *** adds68 has joined #buildstream | 14:25 | |
| adds68 | Hey, on the bst https://people.gnome.org/~tvb/buildstreamdocs/format.html?highlight=source#sources documentation, it tells me to view the specific sources documentation, but i can't seem to find it, could someone point me to it? | 14:29 |
| adds68 | I'm trying to find specific documentation on each supported source type | 14:29 |
| ssam2 | that page is out of date | 14:29 |
| ssam2 | tristan should probably remove it | 14:29 |
| ssam2 | https://buildstream.gitlab.io/buildstream/ is the correct URL for the docs | 14:30 |
| ssam2 | and list of sources is here: https://buildstream.gitlab.io/buildstream/pluginindex.html#plugins-sources | 14:30 |
| ssam2 | did you find that page through a link or through a search engine ? if it's a link, we need to update it | 14:30 |
| adds68 | ssam2, ah! Top git from my google search | 14:32 |
| adds68 | ssam2, thanks for the links :) | 14:32 |
| adds68 | May be of use to knock a website up in order to try and get google to index that instead of gnome/gitlab links? | 14:32 |
| ssam2 | buildstream.org | 14:33 |
| ssam2 | bah, it's domain squatted already | 14:33 |
| ssam2 | actually it's not squatted, seems to be a Russian construction company :-) | 14:34 |
| tlater | Hopefully that doesn't cause any future issues | 14:35 |
| ssam2 | BuildStream - российская компания ! | 14:35 |
| tlater | bst.org also (unsurprisingly) exists ;P | 14:35 |
| ssam2 | there's also an australian company called BuildStream Homes : http://www.buildstreamhomes.com.au/ | 14:38 |
| gitlab-br-bot | buildstream: issue #151 ("Link from https://people.gnome.org/~tvb/buildstreamdocs/ to https://buildstream.gitlab.io/buildstream/") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/151 | 14:39 |
| gitlab-br-bot | push on buildstream@tracking-changes (by Tristan Maat): 14 commits (last: git.py source plugin: Prune remote-tracking branches when fetching) https://gitlab.com/BuildStream/buildstream/commit/794e73cb4469c30bd830b333597a6932da1254f1 | 14:46 |
| gitlab-br-bot | buildstream: merge request (tracking-changes->master: WIP: Tracking changes) #119 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/119 | 14:47 |
| adds68 | ssam2, haha ace! | 15:00 |
| adds68 | What about .io ? ;) | 15:00 |
| adds68 | build.stream is not taken, but does cost £1,300 per year | 15:02 |
| gitlab-br-bot | push on buildstream@tracking-changes (by Tristan Maat): 5 commits (last: Issue #117: Add individual-element tracking to `bst build --track`) https://gitlab.com/BuildStream/buildstream/commit/db40c210fa62779d9c1ac2c0618b5a499552b278 | 15:20 |
| gitlab-br-bot | buildstream: merge request (tracking-changes->master: WIP: Tracking changes) #119 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/119 | 15:20 |
| jonathanmaw | tristan: should utils.safe_copy get the same treatment as Element.dependencies (i.e. override the documented function signature to hide an arg)? safe_copy has a "result" arg which seems to exist solely to collect the results of copy_files | 15:37 |
| jonathanmaw | apart from that, it's only ever called as a keyword arg and my gut tells me it's a good idea to make invoking such an esoteric feature require passing in the keyword | 15:40 |
| *** bochecha has joined #buildstream | 15:44 | |
| gitlab-br-bot | buildstream: merge request (tracking-changes->master: WIP: Tracking changes) #119 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/119 | 15:48 |
| *** WSalmon has quit IRC | 15:48 | |
| tlater | Hm, I can't reproduce that segfault from earlier offline :/ | 15:48 |
| *** jonathanmaw has quit IRC | 15:49 | |
| *** jonathanmaw has joined #buildstream | 15:49 | |
| tlater | Running the test locally in the fedora container, I get: "fuse: device not found, try 'modprobe fuse' first" | 16:25 |
| tlater | No actual segfault though | 16:26 |
| ssam2 | perhaps your host kernel doesn't have fuse loaded | 16:27 |
| ssam2 | could be that libfuse is trying to load it for you, but it can't because it's inside a container | 16:27 |
| tlater | I doubt it, since I have been running buildstream outside as well, but it can't hurt to modprobe I suppose | 16:28 |
| *** noah has joined #buildstream | 16:34 | |
| tlater | Hm, interesting, still the same issue after modprobing outside the container... Do I have to share something odd? | 16:37 |
| * tlater checks the interwebs | 16:37 | |
| *** tpollard has joined #buildstream | 16:39 | |
| tlater | Looks like I need to run the container in privileged mode | 16:39 |
| * tlater wonders if this should be documented somewhere | 16:40 | |
| ssam2 | hmm, it kind of is | 16:43 |
| ssam2 | https://buildstream.gitlab.io/buildstream/docker.html#docker | 16:43 |
| ssam2 | doesn't mention privileged mode though | 16:43 |
| ssam2 | also the formatting is messed up! | 16:43 |
| ssam2 | probably me confusing .rst with .mdwn | 16:44 |
| *** noah is now known as notaviable | 16:44 | |
| *** notaviable is now known as maurice | 16:44 | |
| gitlab-br-bot | push on buildstream@master (by Sam Thursfield): 1 commit (last: doc/source/docker.rst: Fix formatting) https://gitlab.com/BuildStream/buildstream/commit/5530bab052c25fe2c16f8f2116ca468b6a895174 | 16:45 |
| tlater | ssam2: It's very possible this is only necessary for the special unix mode | 16:45 |
| tlater | Though for debugging it's probably nice to add a note | 16:45 |
| gitlab-br-bot | push on buildstream@97-apply-pep-3102-to-all-public-api-surfaces (by Jonathan Maw): 2 commits (last: plugin.py: Make timed_activity enforce keyword args) https://gitlab.com/BuildStream/buildstream/commit/cda748c8de40edbe860434ea5e5d4ddfe0ea5c07 | 16:46 |
| gitlab-br-bot | buildstream: merge request (97-apply-pep-3102-to-all-public-api-surfaces->master: WIP: Resolve "Apply pep 3102 to all public API surfaces") #127 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/127 | 16:46 |
| ssam2 | more promo :-) https://samthursfield.wordpress.com/2017/11/10/using-buildstream-through-docker/ | 16:49 |
| tlater | ssam2: Gah, typo in the second sentence! | 16:49 |
| tlater | but it depends *in* a modern version of OSTree | 16:49 |
| *** WSalmon has joined #buildstream | 16:52 | |
| *** ssam2 has quit IRC | 16:53 | |
| gitlab-br-bot | push on buildstream@97-apply-pep-3102-to-all-public-api-surfaces (by Jonathan Maw): 2 commits (last: compose.py: Use keyword args for utils.move_files) https://gitlab.com/BuildStream/buildstream/commit/9aa72da9bb47698b92a78bda924a5469d1a6017f | 16:54 |
| gitlab-br-bot | buildstream: merge request (97-apply-pep-3102-to-all-public-api-surfaces->master: WIP: Resolve "Apply pep 3102 to all public API surfaces") #127 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/127 | 16:54 |
| *** ssam2 has joined #buildstream | 16:58 | |
| *** maurice has quit IRC | 17:00 | |
| *** WSalmon has quit IRC | 17:02 | |
| *** adds68 has quit IRC | 17:03 | |
| *** noah has joined #buildstream | 17:04 | |
| *** tpollard has quit IRC | 17:09 | |
| *** cs_shadow has quit IRC | 17:26 | |
| *** valentind has joined #buildstream | 17:30 | |
| *** bochecha has quit IRC | 17:34 | |
| gitlab-br-bot | push on buildstream@97-apply-pep-3102-to-all-public-api-surfaces (by Jonathan Maw): 2 commits (last: sandbox: Make sandbox.run use keyword args) https://gitlab.com/BuildStream/buildstream/commit/c1a6c43b581cf0a7c76ed27460285a4617ef6594 | 17:35 |
| gitlab-br-bot | buildstream: merge request (97-apply-pep-3102-to-all-public-api-surfaces->master: WIP: Resolve "Apply pep 3102 to all public API surfaces") #127 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/127 | 17:35 |
| *** tiagogomes has quit IRC | 17:49 | |
| *** tiagogomes has joined #buildstream | 17:52 | |
| *** tiagogomes has quit IRC | 17:55 | |
| *** jonathanmaw has quit IRC | 17:59 | |
| *** ssam2 has quit IRC | 18:02 | |
| *** noah has quit IRC | 18:14 | |
| *** noah_ has joined #buildstream | 18:14 | |
| *** noah_ is now known as noah | 18:24 | |
| *** jude has quit IRC | 18:48 | |
| *** valentind has quit IRC | 19:19 | |
| *** valentind has joined #buildstream | 19:19 | |
| *** jude has joined #buildstream | 19:37 | |
| *** sstriker has quit IRC | 19:45 | |
| *** jude has quit IRC | 20:09 | |
| *** noah has quit IRC | 20:38 | |
| *** noah has joined #buildstream | 21:21 | |
| *** bochecha has joined #buildstream | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!