*** givascu has joined #buildstream | 02:46 | |
*** juergbi has quit IRC | 03:24 | |
*** juergbi has joined #buildstream | 03:30 | |
*** tristan has joined #buildstream | 04:32 | |
gitlab-br-bot | buildstream: issue #100 ("Avoid package upgrades during CI") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/100 | 05:27 |
---|---|---|
gitlab-br-bot | push on buildstream@master (by Tristan Van Berkom): 1 commit (last: .gitlab-ci.yml: Use `pip3 install --no-index` when installing BuildStream) https://gitlab.com/BuildStream/buildstream/commit/fd91491a7619964e01d1fc8dede1c07cb68a433f | 05:27 |
gitlab-br-bot | buildstream: merge request (sam/no-install-python-deps->master: .gitlab-ci.yml: Use `pip3 install --no-index` when installing BuildStream) #110 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/110 | 05:27 |
gitlab-br-bot | buildstream: merge request (jonathan/all-elements-need-yaml->master: Make all element loading require a yaml file) #108 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/108 | 05:31 |
gitlab-br-bot | push on buildstream@74-prevent-artifacts-from-containing-files-in-buildstream-build (by Tristan Van Berkom): 11 commits (last: _options/optionpool.py: Use _yaml.composite() instead of _yaml.composite_dict()) https://gitlab.com/BuildStream/buildstream/commit/24efda780d0843591ac592ebfc7b028f5dccf557 | 05:46 |
gitlab-br-bot | buildstream: merge request (74-prevent-artifacts-from-containing-files-in-buildstream-build->master: Add warnings when staging to /buildstream/build) #93 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/93 | 05:46 |
*** givascu has quit IRC | 06:36 | |
gitlab-br-bot | push on buildstream@no-install-test-requires (by Tristan Van Berkom): 1 commit (last: .gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires) https://gitlab.com/BuildStream/buildstream/commit/0d4d88a9cef7a00fcb49a594ec6b4d56f54c1e84 | 06:39 |
gitlab-br-bot | buildstream: merge request (no-install-test-requires->master: .gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires) #114 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/114 | 06:39 |
*** semanticdesign has joined #buildstream | 07:33 | |
*** semanticdesign_ has joined #buildstream | 07:34 | |
*** semanticdesign_ has quit IRC | 07:36 | |
*** semanticdesign_ has joined #buildstream | 07:36 | |
*** jude has joined #buildstream | 08:34 | |
*** bochecha has joined #buildstream | 08:52 | |
*** jonathanmaw has joined #buildstream | 09:04 | |
*** givascu has joined #buildstream | 09:15 | |
tristan | bochecha, your pet feature has landed yesterday btw; see: http://buildstream.gitlab.io/buildstream/formatintro.html#format-directives | 09:16 |
tristan | still ironing out kinks for ^C though | 09:16 |
*** ssam2 has joined #buildstream | 09:18 | |
*** tlater has joined #buildstream | 09:29 | |
*** bochecha has quit IRC | 09:41 | |
ssam2 | tristan, I got a bit confused in the meeting about errors on overlaps vs. warnings on overlaps | 09:50 |
ssam2 | https://gitlab.com/BuildStream/buildstream/issues/114 is about better *warnings* on overlaps | 09:50 |
ssam2 | the thing that would be a blocker is *errors* on overlaps, i.e. any overlap causes a build to fail unless it's explicitly white listed | 09:50 |
ssam2 | i got the impression you don't like that feature and didn't have the energy to bring it up yet, but if we're going to do it, it should be a blocker for 1.0 | 09:51 |
ssam2 | bring it up as a feature proposal, i mean | 09:52 |
gitlab-br-bot | buildstream: issue #117 ("bst build --track doesnt allow granular selection of elements to track") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/117 | 09:56 |
tristan | Ahhh | 09:57 |
tristan | ssam2, right - that makes more sense | 09:57 |
tristan | ssam2, So, what do you think it would look like ? | 09:58 |
tristan | I can wait for a proposal, but if it's all clear in your mind and straight forward enough, maybe we can save some effort | 09:58 |
tristan | ssam2, also maybe it does not break API | 09:59 |
ssam2 | basically, (a) any overlaps raise an error | 09:59 |
ssam2 | (b) under the 'depends' section, you can say 'ignore: /usr/bin/awk' or something, to not warn when /usr/bin/awk is overridden | 10:00 |
ssam2 | or /usr/bin/*, I guess | 10:00 |
ssam2 | i've not given that a lot of thought though | 10:00 |
tristan | Right, I would posit that there are going to be projects which will not care | 10:00 |
ssam2 | right. making it optional is fine by me | 10:00 |
ssam2 | and that would make it no longer a blocker | 10:01 |
tristan | And the decision of making this an error explicitly is better anyway, yeah | 10:01 |
tristan | I dont think it will land in `depends:` | 10:01 |
ssam2 | ok, that removes one blocker :-) | 10:01 |
tristan | But we can find an amenable solution for sure | 10:02 |
tristan | Perhaps public data is a decent place, or a new toplevel element attribute | 10:02 |
tristan | (mostly because depends: is very early parse, core stuff) | 10:02 |
ssam2 | right | 10:02 |
ssam2 | that would be fine, I guess the only advantage of 'depends' is it might save typing | 10:03 |
tristan | ssam2, also, your raising the idea that this should be per-element, also indicates that any proposal should also consider reducing verbosity (only to say: The part where a reverse dependency need not mention it, because it's indicated by the dependency, and how that is resolved, should be a part of the thinking here) | 10:04 |
ssam2 | you mean, an element should be able to say "these files can be overwritten and it's fine by me" ? | 10:04 |
tristan | probably this is a detail of resolving stuff while considering build vs not-build dependencies | 10:04 |
tristan | I mean, some things no longer land in build context because of dependency models, but these whitelist declarations on elements must be propagated automatically forward in the correct way | 10:05 |
tristan | and, that correct way should be thought out before implementing :D | 10:06 |
tristan | that's all | 10:06 |
ssam2 | yeah... i think a prototype would be needed before agreeing on the actual user experience for this one | 10:06 |
tristan | (not every element which produces a /bin/bash overlap error, needs to declare that) | 10:06 |
tristan | probably the decision of whether it's an error initially belongs in the project.conf, unless possibly later overridden by the user | 10:07 |
ssam2 | yeah I think project.conf is the right place | 10:07 |
tristan | ssam2, random idea also; you might consider A.) What an element puts into it's artifact, and B.) What that element depends on | 10:08 |
tristan | And catch the error much earlier | 10:09 |
tristan | At artifact-which-produces-overlap-error artifact creation time | 10:09 |
ssam2 | yes that's a thought | 10:09 |
tristan | needs some extra thought as to whether that really works, with build vs run dependencies; I guess it's with runtime dependencies it would need to be checked | 10:10 |
tlater | tristan: Upon further testing, it seems that just passing on the error works fine | 10:16 |
tlater | The issue is raising exceptions on a non-zero error code | 10:16 |
tlater | Any exception somehow keeps some threads alive | 10:17 |
tlater | I'm guessing this only happens in interactive shells, since those don't go through the pipeline. | 10:17 |
tlater | But I'm not really sure where those threads are even launched in the first place. | 10:17 |
tristan | When executing in the pipeline, there is not a problem, I believe that is primarily because we run bwrap in a separate session | 10:34 |
tristan | Examining exit status worries me | 10:34 |
tristan | tlater, i.e. we are doing something differently based on what an untrusted software tells us to do; unless, we can rely on bwrap to produce consistent results for us ? | 10:35 |
tlater | tristan: The exit status of mount and umount are monitored, this is exclusive to the unix platform | 10:36 |
tristan | Oh wait; we are talking about ^C right ? | 10:36 |
tlater | Yup, sorry | 10:36 |
tristan | And, wasnt this also an issue with bwrap ? | 10:36 |
tlater | tristan: I thought so, but it doesn't seem to be. Might have confused something./ | 10:37 |
tristan | Also, how can we inspect exit status, when we are working around something by brutal murder of a process before it has a chance to exit ? | 10:37 |
tlater | Although it is an issue when bwrap's cleanup fails | 10:37 |
tlater | tristan: This is when we pass instead of killing the process in the exception - so it isn't brutally murdered. | 10:38 |
tristan | Ok, so you mean killing potential zombies | 10:38 |
tristan | explicitly | 10:39 |
tristan | So we do manage to join() the child process, but if it had an error (non zero exit), we may have to explicitly kill ? | 10:39 |
tristan | tlater, this all sounds reasonable; albeit fiddly with high level python stuff rather than C | 10:39 |
tlater | tristan: It's possible with a few exception handlers | 10:40 |
tristan | tlater, I would think though; we dont need to inspect exit status, and can safely try killing the child after join, and ignoring a failure to kill a non-existing process | 10:40 |
tristan | this way we dont rely on an untrusted process telling us it's exit status, and behaving a way we expect it to | 10:41 |
tlater | Right, that seems sensible. | 10:41 |
* tlater is still unsure how a process can survive after returning an exit code | 10:41 | |
tristan | with regular low level system calls, we'd use stuff like WIFEXITED on the waitpid() return | 10:42 |
tristan | tlater, what happens is buildstream receives SIGCHILD | 10:42 |
tristan | in real life, under python distortions | 10:42 |
tristan | and we call waitpid() | 10:42 |
tristan | and then there is a correct course of action, it's usually the parent's responsibility to "reap" a child | 10:43 |
tristan | tlater, ah so what is *probably* happening, is that you think there is an exit code; because of some python in between buildstream and the child | 10:44 |
tristan | tlater, also note that with --unshare-pid, our controlling bwrap process is a grandchild | 10:45 |
tristan | this also causes some distortion, that is why terminate_proc() is the way it is | 10:45 |
tlater | tristan: Not in the chroot case - though I suppose perhaps the controlling python process is killed by the C-c first, and that that somehow doesn't kill its subprocess. | 10:46 |
tristan | (direct bwrap child in fact, we are not allowed to kill, due to regular setuid'ness of bwrap) | 10:46 |
tristan | Mmmm I would personally prefer to not cross subjects here; lets fix bwrap the right way first; and then move on to chroot/unix fallback | 10:47 |
tristan | The "right way" well, lets really fix it :) | 10:48 |
tlater | tristan: The bwrap process seems to be working perfectly atm | 10:49 |
tristan | Ok, lets land a fix for that first, and then a separate one for chroot | 10:49 |
tristan | I'd like to see the patch before moving on, and; lets make sure we're disregarding the exit status | 10:50 |
* tristan checks python docs for a sec | 10:50 | |
* tristan wonders if we get the waitpid macros | 10:50 | |
tristan | seems not... | 10:51 |
* tlater thinks the current patch is pretty much ready then - I'll just push my fixes to the bwrap part :) | 10:52 | |
tristan | tlater, ... | 10:55 |
tristan | tlater, https://docs.python.org/3/library/os.html#os.waitpid | 10:55 |
tristan | that looks like the low level way to handle that exit properly | 10:56 |
tristan | tlater, if you could try that; that would be appreciated | 10:56 |
tlater | Oh, sweet | 10:56 |
tristan | I.e., keep using subprocess to spawn, but call os.waitpid() on the pid | 10:56 |
tristan | inspect to see if WIFEXITED | 10:57 |
tristan | if not, brutal murder | 10:57 |
tlater | Poor subprocess | 10:57 |
tlater | Looks like there is actually a specific function for WIFEXITED: https://docs.python.org/3.5/library/os.html#os.WIFEXITED | 10:58 |
tristan | tlater, tip: we probably dont want to remove subprocess.poll() for this either; let the subprocess module do it's thing, inspect after | 11:07 |
tristan | I hope that works | 11:07 |
tristan | and probably can be applied to chroot stuff as well | 11:08 |
tlater | Yup, that was my intention | 11:08 |
tlater | tristan: I think the issue may not be in the subprocess handling, actually | 11:11 |
tlater | Yeah, i just raised an exception without ever calling subprocess.Popen and it still happens | 11:12 |
tlater | There's another issue independent of the subprocess handling, which also causes a lingering zombie process. | 11:13 |
tristan | tlater, if the buildstream process itself dies without ever reaping the child, it will naturally become orphaned | 11:16 |
tristan | also, if you never called subprocess.Popen, there is no process to orphan :-/ | 11:17 |
tristan | So I wonder what you're saying; maybe you're looking at a previously orphaned zombie | 11:18 |
gitlab-br-bot | buildstream: merge request (sam/use-via-docker-2->master: Add `bst-here` script and document it) #113 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/113 | 11:19 |
gitlab-br-bot | push on buildstream@sam/use-via-docker-2 (by Sam Thursfield): 2 commits (last: contrib/bst-here: Set a fixed shell prompt) https://gitlab.com/BuildStream/buildstream/commit/a6ea86eb3778b5635324e768670dc45d2ed66570 | 11:19 |
gitlab-br-bot | buildstream: issue #118 ("BuildStream fails to timeout in network activities") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/118 | 11:38 |
tristan | ssam2, fwiw I feel like having completions is important enough by itself to recommend using the shell rather than multiple bst-here invocations without completions, man pages are rather less important | 11:45 |
ssam2 | makes sense | 11:45 |
ssam2 | in which case i think that branch is ready | 11:45 |
tristan | nice to have, but not a big deal, they are after all generated from `bst --help` commands | 11:45 |
ssam2 | i updated the docs to recommend the interactive shell approach | 11:45 |
tristan | sweet | 11:47 |
tristan | ssam2, just looked it over, it needs a rebase but ready to land IMO :) | 11:48 |
ssam2 | great | 11:48 |
* tristan has been trying rebase from gitlab UI but it's not always working | 11:48 | |
ssam2 | yeah i've never had much luck with that | 11:48 |
* ssam2 tries | 11:48 | |
gitlab-br-bot | buildstream: merge request (sam/use-via-docker-2->master: Add `bst-here` script and document it) #113 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/113 | 11:48 |
gitlab-br-bot | push on buildstream@sam/use-via-docker-2 (by Sam Thursfield): 13 commits (last: _options/optionpool.py: Use _yaml.composite() instead of _yaml.composite_dict()) https://gitlab.com/BuildStream/buildstream/commit/24efda780d0843591ac592ebfc7b028f5dccf557 | 11:48 |
tristan | nice | 11:49 |
ssam2 | seems to have worked, i'll set it to merge when the CI succeeds | 11:49 |
* tristan beat you to it haha | 11:49 | |
ssam2 | damnit! | 11:49 |
tristan | my page was all open on it and everything ! | 11:49 |
tristan | heh | 11:49 |
gitlab-br-bot | buildstream: issue #101 ("Improve convenience for users running BuildStream through `docker`") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/101 | 11:57 |
gitlab-br-bot | buildstream: issue #101 ("Improve convenience for users running BuildStream through `docker`") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/101 | 11:57 |
gitlab-br-bot | push on buildstream@sam/no-install-python-test-deps (by Sam Thursfield): 1 commit (last: .gitlab-ci.yml: Prevent installing test dependencies) https://gitlab.com/BuildStream/buildstream/commit/fc2644267d11613b81294ef8be6a014b9db55c09 | 12:07 |
gitlab-br-bot | buildstream: merge request (sam/no-install-python-test-deps->master: .gitlab-ci.yml: Prevent installing test dependencies) #115 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/115 | 12:08 |
tristan | ssam2, umm, dont I have an MR for that already ? is --allow-hosts=NONE better, and have you locally tested that it works ? | 12:09 |
ssam2 | oh sorry, i missed your MR completely | 12:09 |
tristan | https://gitlab.com/BuildStream/buildstream/merge_requests/114/diffs | 12:09 |
ssam2 | either way should work fine | 12:09 |
ssam2 | I already updated the docker image so your branch should pass CI now, i'll restart it | 12:10 |
* tristan had to have a fist fight in #python because, yet another person started on the "dont use setup.py for anything" and "bla bla pip bla bla virtual env" thing again, when asking a simple question about how to ensure random downloads dont happen when doing `setup.py test` | 12:11 | |
* tristan is getting tired of that whole song and dance | 12:11 | |
tristan | so yeah; lets go with my MR, I paid for it in blood :) | 12:12 |
tristan | heh | 12:12 |
gitlab-br-bot | buildstream: merge request (sam/no-install-python-test-deps->master: .gitlab-ci.yml: Prevent installing test dependencies) #115 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/115 | 12:13 |
tlater | #python seems like a fun and welcoming community. | 12:21 |
tristan | tlater, myeah - its somewhere in the middle of serious dev channels and ##javascript | 12:24 |
tristan | but I've managed to get a lot out of it, still | 12:24 |
tristan | ewwww | 12:56 |
tristan | jonathanmaw, did you ever submit an MR about those KeyError exceptions being raised with del dict[key] ? | 12:57 |
tristan | Or I think we merged it right ? | 12:57 |
tristan | I suspect it is due to a behavioral change in ruamel.yaml | 12:57 |
tristan | doesnt seem to trigger on test cases | 12:58 |
jonathanmaw | tristan: I'm having trouble finding it, unfortunately :/ | 13:08 |
gitlab-br-bot | push on buildstream@master (by Tristan Van Berkom): 3 commits (last: Add `bst-here` script and document it) https://gitlab.com/BuildStream/buildstream/commit/aeda7a62e6f93754a4442973086c7e9b66118331 | 13:13 |
gitlab-br-bot | buildstream: merge request (sam/use-via-docker-2->master: Add `bst-here` script and document it) #113 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/113 | 13:13 |
gitlab-br-bot | buildstream: Sam Thursfield deleted branch sam/use-via-docker-2 | 13:13 |
jonathanmaw | Shall I put together a merge requests for the parts I'm sure caused problems before? | 13:16 |
jonathanmaw | hmm, I'll just check whether I had the branch on another machine, first... | 13:16 |
jonathanmaw | nope, can't find it. | 13:19 |
tristan | jonathanmaw, dont worry about it, I'll reproduce in test case since it's happening here, and fix it | 13:20 |
jonathanmaw | okie doke. ta tristan :) | 13:20 |
tristan | jonathanmaw, It seems that this is python saying; a type can behave however it damn well pleases :) | 13:20 |
tristan | So I suppose what happens is that ruamel.yaml has been deciding for a long time that deleting keys that dont exist was okie dokie | 13:20 |
tristan | and then changed it's mind | 13:21 |
*** tristan has quit IRC | 13:25 | |
ssam2 | gitlab ci seems pretty broken | 14:07 |
ssam2 | my job just failed halfway thru (after waiting about 2 hours to start) due to not being able to connect to the docker daemon | 14:08 |
* ssam2 things we should seriously consider our own CI runners | 14:08 | |
* tlater agrees, has had several such issues | 14:10 | |
tlater | 29 lines of edge case handling around os.waitpid :/ | 14:18 |
gitlab-br-bot | buildstream: merge request (98-ctrl-c-doesn-t-properly-kill-a-non-interactive-shell->master: Fix keyboardinterrupts caused by subprocesses) #106 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/106 | 14:39 |
gitlab-br-bot | push on buildstream@98-ctrl-c-doesn-t-properly-kill-a-non-interactive-shell (by Tristan Maat): 17 commits (last: Ensure that artifact file permissions are set in the right order) https://gitlab.com/BuildStream/buildstream/commit/a968bab76201856a67c876be25745fee912c136b | 14:39 |
gitlab-br-bot | push on buildstream@98-ctrl-c-doesn-t-properly-kill-a-non-interactive-shell (by Tristan Maat): 15 commits (last: _options/optionpool.py: Use _yaml.composite() instead of _yaml.composite_dict()) https://gitlab.com/BuildStream/buildstream/commit/24efda780d0843591ac592ebfc7b028f5dccf557 | 14:40 |
gitlab-br-bot | buildstream: merge request (98-ctrl-c-doesn-t-properly-kill-a-non-interactive-shell->master: Fix keyboardinterrupts caused by subprocesses) #106 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/106 | 14:40 |
jonathanmaw | hrm, my wrestling with sphinx is leading me to believe that the doctrees are being cached somewhere, because the doctrees I get after building are trying to literalinclude from a completely different path to the ones in the files as they currently exist. | 14:54 |
jonathanmaw | i.e. elements/dpkg_build.py has ".. literalinclude:: dpkg_build.yaml", but looking at the contents of doc/build/doctrees/elements.dpkg_build.doctree, it's saying ".. literalinclude:: ../../../buildstream/plugins/elements/dpkg_build.yaml" | 14:57 |
gitlab-br-bot | push on buildstream@no-install-test-requires (by Sam Thursfield): 4 commits (last: Add `bst-here` script and document it) https://gitlab.com/BuildStream/buildstream/commit/aeda7a62e6f93754a4442973086c7e9b66118331 | 15:11 |
gitlab-br-bot | buildstream: merge request (no-install-test-requires->master: .gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires) #114 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/114 | 15:11 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/474721becc1a8602b67b4a3b0a4d36098d19be7f | 15:13 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 15:13 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 14 commits (last: _options/optionpool.py: Use _yaml.composite() instead of _yaml.composite_dict()) https://gitlab.com/BuildStream/buildstream/commit/24efda780d0843591ac592ebfc7b028f5dccf557 | 15:15 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 15:15 |
gitlab-br-bot | push on buildstream@74-prevent-artifacts-from-containing-files-in-buildstream-build (by Tristan Maat): 4 commits (last: Add `bst-here` script and document it) https://gitlab.com/BuildStream/buildstream/commit/aeda7a62e6f93754a4442973086c7e9b66118331 | 15:23 |
gitlab-br-bot | buildstream: merge request (74-prevent-artifacts-from-containing-files-in-buildstream-build->master: Add warnings when staging to /buildstream/build) #93 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/93 | 15:23 |
tlater | We really need to calm down gitlab-br-bot | 15:23 |
tlater | x) | 15:23 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/57dc66a8fd8b6fef8c7bc51a56892fbb987d370a | 15:25 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 15:25 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/3362a02b6bbfff429936909db8a0a6a206f2b470 | 15:31 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 15:31 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/e69c5f46ea73fe7b1973764f912e2acdb646af75 | 15:38 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 15:38 |
adds68 | could anyone explain what the use of this setting is? | 16:11 |
adds68 | https://buildstream.gitlab.io/buildstream/projectconf.html#architecture | 16:11 |
adds68 | I'm trying to convert these definitions https://github.com/flatpak/freedesktop-sdk-images/blob/344108d97b33f95a39f0d8aae801714515d29362/org.freedesktop.Sdk.json.in#L1099 into bst defintions, but i'm not sure if the bst architecture option is what i'm looking for | 16:12 |
tlater | adds68: bst architecture options specify different instructions for different architectures - I believe this is what you're looking for in this case. | 16:14 |
tlater | There were a few changes to them recently though, I'm not up to date on it | 16:14 |
ssam2 | the docs are up to date | 16:15 |
ssam2 | it's all freshly baked though | 16:15 |
tlater | So still very chewy and you may burn your tongue? | 16:15 |
ssam2 | i suggest just assuming x86_64 for now, and keeping proper architecture support as a TODO | 16:16 |
adds68 | ssam2, ok :) TODO it is | 16:16 |
tlater | Oh. | 16:23 |
tlater | Umm... I ran into the KeyError bug tristan mentioned earlier | 16:24 |
tlater | Is there a branch/fix at all for that yet? | 16:25 |
*** anthonywilliams has quit IRC | 16:25 | |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/e669a1c929a53120c494a687bb5cbdc6616a2c8e | 16:38 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 16:38 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/4872aa4c3c1c19a1343ec157170b2b807cf31eaa | 16:41 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 16:41 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/02357e387bdb53876744860c907a575c42cbb382 | 16:55 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 16:56 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/29eab5b51c8f160f4ad92d39443827697e42e39c | 17:00 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 17:00 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/f766a8a36e644a55e1009a146e4964c29d992b3a | 17:02 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 17:02 |
gitlab-br-bot | push on buildstream@102-run-ci-as-non-root-user (by Tristan Maat): 1 commit (last: .gitlab-ci.yml: Drop root privileges for some tests) https://gitlab.com/BuildStream/buildstream/commit/50de94dc0246a8d8194e2fb6b9ce16f038e3cf31 | 17:04 |
gitlab-br-bot | buildstream: merge request (102-run-ci-as-non-root-user->master: Resolve "Run CI as non-root user") #104 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/104 | 17:04 |
gitlab-br-bot | buildstream: Sam Thursfield deleted branch sam/no-install-python-test-deps | 17:08 |
*** tlater has quit IRC | 17:08 | |
*** jonathanmaw has quit IRC | 17:19 | |
*** ltu has quit IRC | 17:33 | |
*** jude has quit IRC | 18:07 | |
*** jude has joined #buildstream | 18:07 | |
*** jude has quit IRC | 18:11 | |
*** ssam2 has quit IRC | 18:11 | |
*** tristan has joined #buildstream | 18:40 | |
gitlab-br-bot | push on buildstream@master (by Sam Thursfield): 1 commit (last: .gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires) https://gitlab.com/BuildStream/buildstream/commit/a243a3335b7c113a49b1d5f0daa2c11efe2299bd | 18:56 |
gitlab-br-bot | buildstream: merge request (no-install-test-requires->master: .gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires) #114 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/114 | 18:56 |
gitlab-br-bot | buildstream: Tristan Van Berkom deleted branch no-install-test-requires | 18:56 |
*** ironfoot has quit IRC | 20:39 | |
*** ironfoot has joined #buildstream | 20:40 | |
*** givascu has quit IRC | 21:31 | |
*** benbrown has quit IRC | 21:34 | |
*** benbrown has joined #buildstream | 21:34 | |
*** tristan has quit IRC | 21:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!