| *** xjuan has joined #buildstream | 01:14 | |
| *** tristan has joined #buildstream | 01:43 | |
| *** xjuan has quit IRC | 02:11 | |
| tristan | eek /me didnt see that message here at all (good thing for logs) | 02:25 |
|---|---|---|
| * tristan a bit abhorred by anything setuptools, but a way to share testing code with plugin packages (if that's the idea) is a sensible one | 02:26 | |
| *** jude has joined #buildstream | 07:20 | |
| *** bochecha has joined #buildstream | 07:49 | |
| *** bochecha has quit IRC | 08:20 | |
| *** bochecha_ has joined #buildstream | 08:20 | |
| *** bochecha has joined #buildstream | 08:21 | |
| *** bochecha_ has quit IRC | 08:23 | |
| *** jonathanmaw has joined #buildstream | 08:43 | |
| gitlab-br-bot | push on buildstream@70-third-party-plugin-sharing (by Tristan Maat): 13 commits (last: Generating man pages) https://gitlab.com/BuildStream/buildstream/commit/7bc2e070182fc45b9e6d630e95d5e90d97fc910e | 09:22 |
| gitlab-br-bot | buildstream: merge request (70-third-party-plugin-sharing->master: Resolve "Third party plugin sharing") #90 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/90 | 09:22 |
| gitlab-br-bot | push on buildstream@24-better-validation-for-loaded-yaml (by Tristan Maat): 15 commits (last: Generating man pages) https://gitlab.com/BuildStream/buildstream/commit/7bc2e070182fc45b9e6d630e95d5e90d97fc910e | 09:22 |
| gitlab-br-bot | buildstream: merge request (24-better-validation-for-loaded-yaml->master: Resolve "Better validation for loaded YAML") #87 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/87 | 09:22 |
| *** tlater has joined #buildstream | 09:56 | |
| gitlab-br-bot | push on buildstream@70-third-party-plugin-sharing (by Tristan Maat): 1 commit (last: Add tests) https://gitlab.com/BuildStream/buildstream/commit/dbf4848a948b6d9305991387dc6b5d98a47ea9eb | 10:20 |
| gitlab-br-bot | buildstream: merge request (70-third-party-plugin-sharing->master: Resolve "Third party plugin sharing") #90 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/90 | 10:20 |
| gitlab-br-bot | push on buildstream@70-third-party-plugin-sharing (by Tristan Maat): 1 commit (last: Add tests) https://gitlab.com/BuildStream/buildstream/commit/930f11d10387bafdcbb9e7e5a823c64474a7b557 | 11:05 |
| gitlab-br-bot | buildstream: merge request (70-third-party-plugin-sharing->master: Resolve "Third party plugin sharing") #90 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/90 | 11:05 |
| gitlab-br-bot | buildstream: merge request (70-third-party-plugin-sharing->master: Resolve "Third party plugin sharing") #90 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/90 | 11:10 |
| gitlab-br-bot | buildstream: merge request (70-third-party-plugin-sharing->master: Resolve "Third party plugin sharing") #90 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/90 | 11:11 |
| *** tlater has quit IRC | 11:27 | |
| *** tlater has joined #buildstream | 12:42 | |
| *** xjuan has joined #buildstream | 12:45 | |
| *** tlater has left #buildstream | 12:57 | |
| *** tlater has joined #buildstream | 12:58 | |
| *** xjuan has quit IRC | 13:31 | |
| *** xjuan has joined #buildstream | 15:25 | |
| tristan | tlater, what does buildstream-tests being behind mean, regarding the yaml validation branch ? | 15:32 |
| tlater | tristan: To merge buildstream#24 we should first merge buildstream-tests!15 | 15:33 |
| tristan | Oh there are MRs there ? | 15:33 |
| tlater | Yup | 15:33 |
| tlater | I also fixed !10 which still relates to workspaces at some point | 15:33 |
| tristan | ahh I see | 15:34 |
| tristan | Merged | 15:34 |
| tlater | Awesome, I think we should re-run integration for buildstream!87 then, and if that succeeds merge that too - if you're fine with the branch, of course | 15:34 |
| * tristan creates: https://gitlab.com/BuildStream/buildstream/pipelines/11728147 | 15:35 | |
| tristan | Am doing :) | 15:35 |
| tlater | :) | 15:35 |
| tlater | Then third party plugin sharing? | 15:35 |
| tristan | tlater, I was a bit worried that we had a bug in the provenance at dictionary composition time | 15:35 |
| tristan | looking at how you had the validations split up | 15:35 |
| tristan | that wasnt an issue in the end ? | 15:36 |
| tlater | tristan: Ah, no, I simply copied that from somewhere else assuming it was necessary | 15:36 |
| tlater | There is the one attribute thing called "choice" though | 15:36 |
| tristan | does it exist ? | 15:36 |
| tlater | It comes up in the unit tests, something related to variants | 15:36 |
| tristan | I dont recall it existing | 15:36 |
| tlater | It's not documented though, and I did not really read into the tests | 15:36 |
| tristan | Ah well, the tests, especially the loader tests, are expected to have to change in order to adapt to your validation | 15:36 |
| tristan | I.e. the tests are known to break validation with whacky stuff that is not part of the format | 15:37 |
| tlater | Most of those tests were fine, actually. It's just that choice keyword, and I'm not sure what it means :/ | 15:37 |
| tristan | they were written in a very early time, when plugins and their configs didnt exist really | 15:37 |
| tristan | It means: Please put this data in the 'choice' member so I can maybe assert it in a test case | 15:37 |
| tlater | Heh | 15:38 |
| tlater | Well, I'll have a look at those then before we merge this | 15:38 |
| tristan | Because I have no idea what kindof stuff is really gonna go here | 15:38 |
| tristan | yes | 15:38 |
| tlater | Would you look over the new changes anyway just to make sure we don't need to run through this again? | 15:38 |
| tlater | Especially docs | 15:38 |
| tlater | Man docs are weird | 15:38 |
| tristan | Ok so it looks like there are a few things missing validation, would be worth getting in | 15:40 |
| tristan | looks like we dont validate dependency dicts (when they are written in dict form) | 15:40 |
| tlater | Ah, right, I forgot that's a possibility | 15:41 |
| tristan | you said about docs | 15:50 |
| tristan | you mean the Plugin.node_validate() docs ? | 15:50 |
| tlater | I meant the third party plugin docs :) | 15:51 |
| gitlab-br-bot | push on buildstream@24-better-validation-for-loaded-yaml (by Tristan Maat): 1 commit (last: Add dependency node validations) https://gitlab.com/BuildStream/buildstream/commit/70d664819a8165f69c80d544ab78cb260baf049c | 15:53 |
| gitlab-br-bot | buildstream: merge request (24-better-validation-for-loaded-yaml->master: Resolve "Better validation for loaded YAML") #87 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/87 | 15:53 |
| tlater | tristan: Hm, so the only really big issue with !87 is the potentially missing validation. Sources already verify themselves, so that is validated fine, element plugins verify config and all other non-top level nodes seem to have arbitrary keys - but well, I might be missing more. | 16:01 |
| tristan | Ok so what are we gonna call the things | 16:02 |
| tristan | that are on elements and sources | 16:02 |
| tristan | which elements and sources read to decide how they are configured | 16:02 |
| tristan | i.e. the configurations | 16:02 |
| * tristan just finished dumping a commend on this... | 16:02 | |
| tristan | I dont like the idea of suddenly calling them "attributes", and we're not going to call things by multiple names in the same project please | 16:03 |
| tlater | Yeah, I spent a while thinking about it, I found "attributes" to sound most correct :/ | 16:04 |
| gitlab-br-bot | push on buildstream@24-better-validation-for-loaded-yaml (by Tristan Maat): 8 commits (last: Add _yaml.validate_node) https://gitlab.com/BuildStream/buildstream/commit/06b4d3aeae88a30d922cd044feaf9f255946fe55 | 16:10 |
| gitlab-br-bot | buildstream: merge request (24-better-validation-for-loaded-yaml->master: Resolve "Better validation for loaded YAML") #87 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/87 | 16:10 |
| tristan | I think that's all for the validation, the only really tricky one is this attributes thing | 16:11 |
| tristan | configuration has attributes I guess | 16:12 |
| * tristan hates this part sometimes | 16:12 | |
| tlater | We could call it something fancy, like ponies | 16:12 |
| tristan | Yes | 16:12 |
| *** tlater has quit IRC | 16:16 | |
| *** jude has quit IRC | 16:30 | |
| *** xjuan has quit IRC | 16:33 | |
| *** jonathanmaw has quit IRC | 16:37 | |
| *** xjuan has joined #buildstream | 17:03 | |
| *** tlater has joined #buildstream | 17:03 | |
| *** tlater has quit IRC | 17:22 | |
| *** bochecha has quit IRC | 21:03 | |
| *** bochecha has joined #buildstream | 21:07 | |
| *** xjuan has quit IRC | 21:23 | |
| *** jude has joined #buildstream | 21:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!