IRC logs for #buildstream for Thursday, 2017-08-17

*** tristan has joined #buildstream03:40
*** gitlab-br-bot has quit IRC04:42
*** gitlab-br-bot has joined #buildstream04:42
*** gitlab-br-bot has joined #buildstream04:42
*** gitlab-br-bot has joined #buildstream04:44
*** palasso has quit IRC05:27
*** palasso has joined #buildstream05:30
*** jude has joined #buildstream06:52
*** bochecha has joined #buildstream07:21
*** jonathanmaw has joined #buildstream07:58
*** bochecha has quit IRC08:03
*** bochecha has joined #buildstream08:04
*** ssam2 has joined #buildstream08:59
*** tlater has joined #buildstream09:11
gitlab-br-botpush on buildstream@shell-command (by Jürg Billeter): 2 commits (last: element.py: Add optional command argument to _shell()) https://gitlab.com/BuildStream/buildstream/commit/7de843dd17f79bf6d4c1fb7213a198fea77cc83f09:49
gitlab-br-botbuildstream: merge request (shell-command->master: Add -c / --command option to `bst shell`) #80 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/8009:50
*** bochecha_ has joined #buildstream10:24
*** bochecha has quit IRC10:26
gitlab-br-botbuildstream: issue #66 ("Crash if element filename contains '@'") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/6610:34
ssam2do we have any policy on doing code review ?10:40
ssam2I think https://gitlab.com/BuildStream/buildstream/merge_requests/80 is good to merge, but not sure if I should merge, or wait for juergbi10:40
ssam2in baserock repos I'd use the 'approvals' feature to give an approval and merge if it now had enough approvals, but that feature isn't on for the BuildStream repo which is throwing me slightly10:41
juergbissam2: we don't have any formal policy at this point. if it's not marked WIP and a non-author with sufficient permissions is fine with it, i expect it to be ok to merge10:51
ssam2makes sense10:52
juergbishould we address the extra output after merge?10:52
ssam2I think it's a separate change, yeah10:52
juergbiit's a bit tricky as buildstream might actually perform some fetching, so we might want output10:52
gitlab-br-botbuildstream: issue #65 ("Please add a `--command` / `-c` option to `bst shell`, or similar") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/6510:52
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 2 commits (last: element.py: Add optional command argument to _shell()) https://gitlab.com/BuildStream/buildstream/commit/7de843dd17f79bf6d4c1fb7213a198fea77cc83f10:52
gitlab-br-botbuildstream: merge request (shell-command->master: Add -c / --command option to `bst shell`) #80 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/8010:52
gitlab-br-botbuildstream: Jürg Billeter deleted branch shell-command10:52
juergbithanks for the review10:52
ssam2no problem :-) I think a `--quiet` flag might be the best option10:53
juergbicould make sense. not completely sure, though10:54
ssam2it's pretty hard to use `-c` from scripting otherwise10:55
ssam2although i'm not sure why `--log-file /dev/null` didn't do anything10:56
juergbiyes, i agree that we should have something, just not sure what the best approach is10:58
*** tlater has quit IRC11:47
*** tlater has joined #buildstream12:27
*** xjuan has joined #buildstream13:30
*** bochecha_ has quit IRC14:22
*** bochecha has joined #buildstream14:24
*** palasso has quit IRC14:28
*** palasso has joined #buildstream14:31
*** jude has quit IRC14:36
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 8 commits (last: _sandboxchroot.py: Improve mount interface) https://gitlab.com/BuildStream/buildstream/commit/2aba443172c666167f89123393c4554344369b5814:44
*** bochecha has quit IRC14:45
*** bochecha has joined #buildstream14:46
*** bochecha has quit IRC14:48
*** bochecha has joined #buildstream14:50
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: WIP: Let staging copy when a chroot sandbox is used) https://gitlab.com/BuildStream/buildstream/commit/21082d2f321bad25942f17f0623ef97c7604a49114:59
*** jude has joined #buildstream15:00
*** jude has quit IRC15:08
*** jude has joined #buildstream15:10
*** jude has quit IRC15:12
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 20 commits (last: _frontend/main.py: Use click.INT type for bst workspace --source) https://gitlab.com/BuildStream/buildstream/commit/52807a865840d776171eaab795e4220bb99bd3e415:15
*** bochecha_ has joined #buildstream15:22
*** bochecha has quit IRC15:22
*** jude has joined #buildstream15:35
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 2 commits (last: Fix sh argument ordering) https://gitlab.com/BuildStream/buildstream/commit/2f721493253a17c9e995bfbe6cc4715f705f9cba16:02
*** bochecha_ has quit IRC16:22
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 3 commits (last: WIP: Make staging copy when a chroot sandbox is used) https://gitlab.com/BuildStream/buildstream/commit/36012b3a698509755e1324f5daf5baaaf4b0842716:23
*** bochecha has joined #buildstream16:24
tlater I think I'm seriously misunderstanding how a read-only root is supposed to work - should /buildstream/{build,install}/ be mounted separately to allow writing?16:29
tlaterAh, nevermind, the answer to that is yes, I just had a few commented lines.16:30
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Mount marked directories) https://gitlab.com/BuildStream/buildstream/commit/5fb017e5b4a56e8d0f2fabce2e26e486b7b413b416:42
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/c2b4a8137fc978a4799f585effecbd64b9b57bd116:54
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/78fdb9836e30b4fcfa60017e15ccbeed1d3f8b2317:02
*** ssam2 has quit IRC17:04
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/b46e9146215b022a9ff14e5a5dac7504b5cf9ad917:05
*** tlater has quit IRC17:08
*** jonathanmaw has quit IRC17:08
*** jude has quit IRC17:29
*** bochecha has quit IRC17:47
*** bochecha has joined #buildstream17:49
*** bochecha has quit IRC17:56
*** bochecha has joined #buildstream17:57
*** bochecha has joined #buildstream18:00
*** bochecha has quit IRC18:03
*** bochecha has joined #buildstream18:05
*** bochecha has quit IRC18:08
*** bochecha has joined #buildstream18:09
*** bochecha has quit IRC18:19
*** bochecha has joined #buildstream18:22
*** xjuan has quit IRC18:43
*** bochecha has quit IRC19:33
*** bochecha has joined #buildstream19:35
*** bochecha has quit IRC19:51
*** ptomato[m] has joined #buildstream23:21
ptomato[m]sup23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!