*** tristan has joined #buildstream | 03:40 | |
*** gitlab-br-bot has quit IRC | 04:42 | |
*** gitlab-br-bot has joined #buildstream | 04:42 | |
*** gitlab-br-bot has joined #buildstream | 04:42 | |
*** gitlab-br-bot has joined #buildstream | 04:44 | |
*** palasso has quit IRC | 05:27 | |
*** palasso has joined #buildstream | 05:30 | |
*** jude has joined #buildstream | 06:52 | |
*** bochecha has joined #buildstream | 07:21 | |
*** jonathanmaw has joined #buildstream | 07:58 | |
*** bochecha has quit IRC | 08:03 | |
*** bochecha has joined #buildstream | 08:04 | |
*** ssam2 has joined #buildstream | 08:59 | |
*** tlater has joined #buildstream | 09:11 | |
gitlab-br-bot | push on buildstream@shell-command (by Jürg Billeter): 2 commits (last: element.py: Add optional command argument to _shell()) https://gitlab.com/BuildStream/buildstream/commit/7de843dd17f79bf6d4c1fb7213a198fea77cc83f | 09:49 |
---|---|---|
gitlab-br-bot | buildstream: merge request (shell-command->master: Add -c / --command option to `bst shell`) #80 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/80 | 09:50 |
*** bochecha_ has joined #buildstream | 10:24 | |
*** bochecha has quit IRC | 10:26 | |
gitlab-br-bot | buildstream: issue #66 ("Crash if element filename contains '@'") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/66 | 10:34 |
ssam2 | do we have any policy on doing code review ? | 10:40 |
ssam2 | I think https://gitlab.com/BuildStream/buildstream/merge_requests/80 is good to merge, but not sure if I should merge, or wait for juergbi | 10:40 |
ssam2 | in baserock repos I'd use the 'approvals' feature to give an approval and merge if it now had enough approvals, but that feature isn't on for the BuildStream repo which is throwing me slightly | 10:41 |
juergbi | ssam2: we don't have any formal policy at this point. if it's not marked WIP and a non-author with sufficient permissions is fine with it, i expect it to be ok to merge | 10:51 |
ssam2 | makes sense | 10:52 |
juergbi | should we address the extra output after merge? | 10:52 |
ssam2 | I think it's a separate change, yeah | 10:52 |
juergbi | it's a bit tricky as buildstream might actually perform some fetching, so we might want output | 10:52 |
gitlab-br-bot | buildstream: issue #65 ("Please add a `--command` / `-c` option to `bst shell`, or similar") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/65 | 10:52 |
gitlab-br-bot | push on buildstream@master (by Jürg Billeter): 2 commits (last: element.py: Add optional command argument to _shell()) https://gitlab.com/BuildStream/buildstream/commit/7de843dd17f79bf6d4c1fb7213a198fea77cc83f | 10:52 |
gitlab-br-bot | buildstream: merge request (shell-command->master: Add -c / --command option to `bst shell`) #80 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/80 | 10:52 |
gitlab-br-bot | buildstream: Jürg Billeter deleted branch shell-command | 10:52 |
juergbi | thanks for the review | 10:52 |
ssam2 | no problem :-) I think a `--quiet` flag might be the best option | 10:53 |
juergbi | could make sense. not completely sure, though | 10:54 |
ssam2 | it's pretty hard to use `-c` from scripting otherwise | 10:55 |
ssam2 | although i'm not sure why `--log-file /dev/null` didn't do anything | 10:56 |
juergbi | yes, i agree that we should have something, just not sure what the best approach is | 10:58 |
*** tlater has quit IRC | 11:47 | |
*** tlater has joined #buildstream | 12:27 | |
*** xjuan has joined #buildstream | 13:30 | |
*** bochecha_ has quit IRC | 14:22 | |
*** bochecha has joined #buildstream | 14:24 | |
*** palasso has quit IRC | 14:28 | |
*** palasso has joined #buildstream | 14:31 | |
*** jude has quit IRC | 14:36 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 8 commits (last: _sandboxchroot.py: Improve mount interface) https://gitlab.com/BuildStream/buildstream/commit/2aba443172c666167f89123393c4554344369b58 | 14:44 |
*** bochecha has quit IRC | 14:45 | |
*** bochecha has joined #buildstream | 14:46 | |
*** bochecha has quit IRC | 14:48 | |
*** bochecha has joined #buildstream | 14:50 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 1 commit (last: WIP: Let staging copy when a chroot sandbox is used) https://gitlab.com/BuildStream/buildstream/commit/21082d2f321bad25942f17f0623ef97c7604a491 | 14:59 |
*** jude has joined #buildstream | 15:00 | |
*** jude has quit IRC | 15:08 | |
*** jude has joined #buildstream | 15:10 | |
*** jude has quit IRC | 15:12 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 20 commits (last: _frontend/main.py: Use click.INT type for bst workspace --source) https://gitlab.com/BuildStream/buildstream/commit/52807a865840d776171eaab795e4220bb99bd3e4 | 15:15 |
*** bochecha_ has joined #buildstream | 15:22 | |
*** bochecha has quit IRC | 15:22 | |
*** jude has joined #buildstream | 15:35 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 2 commits (last: Fix sh argument ordering) https://gitlab.com/BuildStream/buildstream/commit/2f721493253a17c9e995bfbe6cc4715f705f9cba | 16:02 |
*** bochecha_ has quit IRC | 16:22 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 3 commits (last: WIP: Make staging copy when a chroot sandbox is used) https://gitlab.com/BuildStream/buildstream/commit/36012b3a698509755e1324f5daf5baaaf4b08427 | 16:23 |
*** bochecha has joined #buildstream | 16:24 | |
tlater | I think I'm seriously misunderstanding how a read-only root is supposed to work - should /buildstream/{build,install}/ be mounted separately to allow writing? | 16:29 |
tlater | Ah, nevermind, the answer to that is yes, I just had a few commented lines. | 16:30 |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Mount marked directories) https://gitlab.com/BuildStream/buildstream/commit/5fb017e5b4a56e8d0f2fabce2e26e486b7b413b4 | 16:42 |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/c2b4a8137fc978a4799f585effecbd64b9b57bd1 | 16:54 |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/78fdb9836e30b4fcfa60017e15ccbeed1d3f8b23 | 17:02 |
*** ssam2 has quit IRC | 17:04 | |
gitlab-br-bot | push on buildstream@cross_platform (by Tristan Maat): 1 commit (last: _sandboxchroot.py: Fix mount locations) https://gitlab.com/BuildStream/buildstream/commit/b46e9146215b022a9ff14e5a5dac7504b5cf9ad9 | 17:05 |
*** tlater has quit IRC | 17:08 | |
*** jonathanmaw has quit IRC | 17:08 | |
*** jude has quit IRC | 17:29 | |
*** bochecha has quit IRC | 17:47 | |
*** bochecha has joined #buildstream | 17:49 | |
*** bochecha has quit IRC | 17:56 | |
*** bochecha has joined #buildstream | 17:57 | |
*** bochecha has joined #buildstream | 18:00 | |
*** bochecha has quit IRC | 18:03 | |
*** bochecha has joined #buildstream | 18:05 | |
*** bochecha has quit IRC | 18:08 | |
*** bochecha has joined #buildstream | 18:09 | |
*** bochecha has quit IRC | 18:19 | |
*** bochecha has joined #buildstream | 18:22 | |
*** xjuan has quit IRC | 18:43 | |
*** bochecha has quit IRC | 19:33 | |
*** bochecha has joined #buildstream | 19:35 | |
*** bochecha has quit IRC | 19:51 | |
*** ptomato[m] has joined #buildstream | 23:21 | |
ptomato[m] | sup | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!