IRC logs for #buildstream for Thursday, 2017-08-10

*** bochecha has joined #buildstream01:00
*** bochecha has quit IRC01:02
*** bochecha has joined #buildstream01:02
*** bochecha has quit IRC01:06
*** bochecha has joined #buildstream01:07
*** bochecha has quit IRC01:12
*** bochecha has joined #buildstream01:22
*** bochecha has quit IRC01:27
*** bochecha has joined #buildstream01:27
*** bochecha has quit IRC01:31
*** bochecha has joined #buildstream01:52
*** bochecha has quit IRC01:56
*** bochecha has joined #buildstream02:11
*** bochecha has joined #buildstream02:12
*** bochecha has quit IRC02:16
*** bochecha has joined #buildstream02:17
*** bochecha has quit IRC02:27
*** bochecha has joined #buildstream02:32
*** bochecha has quit IRC02:53
*** bochecha has joined #buildstream03:41
*** bochecha has quit IRC03:42
*** palasso has joined #buildstream05:22
gitlab-br-botpush on buildstream@deptype (by Jürg Billeter): 1 commit (last: _loader.py: Support dependency type 'all') https://gitlab.com/BuildStream/buildstream/commit/db49248dcc3480eb9f89cea84e6000cea763cbf205:57
gitlab-br-botpush on buildstream@deptype (by Jürg Billeter): 1 commit (last: tests/loader: Test dependency type 'all') https://gitlab.com/BuildStream/buildstream/commit/8260d0f5086bce840b1cb52c1675ac6038dc722406:08
gitlab-br-botbuildstream: issue #61 ("Add `all` value to depends `type`") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/6106:15
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 2 commits (last: _loader.py: Support dependency type 'all') https://gitlab.com/BuildStream/buildstream/commit/db49248dcc3480eb9f89cea84e6000cea763cbf206:15
gitlab-br-botbuildstream: Jürg Billeter deleted branch deptype06:16
gitlab-br-botbuildstream: issue #58 ("Catch exceptions when using OSTree version tracking in old OSTree versions") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/5806:24
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 1 commit (last: setup.py: Catch exception with OSTree < 2017.4) https://gitlab.com/BuildStream/buildstream/commit/67af5967041242a0392192aad285fbad6d0b44bb06:24
*** bochecha has joined #buildstream07:04
*** bochecha has quit IRC07:09
*** bochecha has joined #buildstream07:09
*** bochecha_ has joined #buildstream07:17
*** bochecha_ has quit IRC07:18
*** bochecha_ has joined #buildstream07:19
*** bochecha has quit IRC07:19
*** bochecha_ is now known as bochecha07:19
*** anahuelamo has joined #buildstream07:41
gitlab-br-botpush on buildstream@summary-status (by Jürg Billeter): 2 commits (last: _pipeline.py: Add remote_ticker for artifact list fetching) https://gitlab.com/BuildStream/buildstream/commit/df8b5a7d6a4a426cfd43d79bbf1cd10565442b2b07:46
gitlab-br-botbuildstream: merge request (summary-status->master: Print status message when fetching artifact list) #74 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/7407:48
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 1 commit (last: _pipeline.py: Fix --deps run) https://gitlab.com/BuildStream/buildstream/commit/1c2a884125092ef0bf9c53fc662de75099f77ec308:22
gitlab-br-botbuildstream: merge request (pip->master: Add a pip element) #75 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/7509:07
gitlab-br-botbuildstream: merge request (pip->master: Add a pip element) #75 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/7509:09
*** ssam2 has joined #buildstream09:10
*** tlater has joined #buildstream09:20
*** anahuelamo has quit IRC09:30
*** palasso has quit IRC09:37
*** palasso has joined #buildstream09:39
*** bochecha_ has joined #buildstream09:54
*** bochecha has quit IRC09:56
*** bochecha_ is now known as bochecha09:57
*** bochecha has quit IRC10:02
*** bochecha has joined #buildstream10:04
*** anahuelamo has joined #buildstream10:11
*** anahuelamo has quit IRC10:31
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 3 commits (last: Clean _platform.py) https://gitlab.com/BuildStream/buildstream/commit/0b90c645baf3334338602957d850959510c873ab10:36
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 3 commits (last: Clean _platform.py) https://gitlab.com/BuildStream/buildstream/commit/2b666e5bb17938f72ee4ff38e74d883005bf693410:41
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 3 commits (last: Clean _platform.py) https://gitlab.com/BuildStream/buildstream/commit/a764c68cf18bae768e7716ac3dafdee48f2813b810:48
*** anahuelamo has joined #buildstream10:49
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 3 commits (last: Clean _platform.py) https://gitlab.com/BuildStream/buildstream/commit/7b282a4fa7ac277cf6391e6012da5a76d0d9383e10:52
*** anahuelamo has quit IRC11:48
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 1 commit (last: main.py: Fix crash with `bst workspace list` in bad directory) https://gitlab.com/BuildStream/buildstream/commit/ba71e3b96ea62124bfe248aabeb9c4922f0a4e3a11:58
gitlab-br-botbuildstream: issue #57 ("`bst workspace list` crashes in bad directory") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/5711:58
*** tlater has quit IRC12:18
*** anahuelamo has joined #buildstream12:21
*** anahuelamo has quit IRC12:24
*** anahuelamo has joined #buildstream12:29
*** tlater has joined #buildstream12:54
*** anahuelamo has quit IRC14:02
*** anahuelamo has joined #buildstream14:07
juergbitlater: source bundle is somewhat broken right now. see #59 but it looks like there are further issues14:14
juergbii thought the idea was to generate a tarball that contains all build + their runtime dependencies + the source of the target package + a script to build the target package14:15
juergbihowever, it seems to currently include sources+scripts for all build dependencies of the target package and their runtime packages. but not the target package itself, at least with default --deps build mode14:16
juergbiwould you be able to shed some light on this?14:17
tlaterHm14:26
tlaterNot sure, it should definitely include the target package, at least as far as I remember.14:27
tlaterI'll have a look14:27
juergbithanks14:27
juergbiadded comment to #59 for the described issue. not pushing a fix before the whole feature makes sense to me14:31
tlaterYeah, that's alright. It's been a while, and I didn't understand exactly what build and run dependencies were back then, so it's entirely possible that the default is just wrong.14:32
juergbidefault deps = 'build' actually makes sense to me, if we were to collect the artifacts instead of the sources of all dependencies14:34
juergbimy primary question is whether the goal is to build only the target element or whether the goal is to build a whole stack14:34
tlaterThe goal was to build a whole stack - this is designed to bootstrap from a stage214:35
ssam2yeah the idea is the target element would be something like build-system.bst14:35
juergbiok, in that case we actually need more than Scope.BUILD dependencies14:36
tlaterIt asks for Scope.ALL in the actual pipeline14:36
juergbiwe also need the build dependencies of the build dependencies14:36
tlaterI think the default for --deps is just wrong14:36
tlaterOr rather, --deps makes no sense for this command14:36
juergbiright, i guess all would work fine14:37
tlaterHmm14:37
tlaterThere was something about script dependencies14:37
*** ssam2 has quit IRC14:39
juergbiright, need a way to execute the first script before the bootstrap element is assembled14:39
tlaterNo, Scope.ALL should work. Script dependencies were excluded completely from a source bundle14:39
tlaterI don't quite recall the reasoning behind that, but that's how it's implemented. The deps flag should just be removed, otherwise it should be fine.14:40
juergbii'm not sure whether the master build script is all fine yet but dependency wise Scope.ALL should be fine, yes14:42
*** anahuelamo has quit IRC14:42
juergbijust also need to cover ImportElement.generate_script to actually fix #5914:42
tlaterWhat's the problem with the master build script?14:42
juergbii'm not aware of a specific issue, just haven't looked at it more closely. don't know whether it properly handles staging paths for dependencies and build outputs etc.14:43
tlaterI think it does, but it could use some testing. Should I check that while I wait for AIX builds or are you already on it?14:44
juergbii can take a look now that i know how it's supposed to work14:45
tlaterAlright, thanks :)14:45
*** ssam2 has joined #buildstream14:55
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 1 commit (last: main.py: Include all dependencies in source bundle) https://gitlab.com/BuildStream/buildstream/commit/084b50420c27c28291ea110466bf0de8b18073f714:57
*** anahuelamo has joined #buildstream15:05
juergbiwith #59 fixed (ImportElement) i expect it to basically work, however, as it is, there will definitely be corner cases where build may fail or differ from buildstream-driven build15:09
*** anahuelamo has quit IRC15:09
*** anahuelamo has joined #buildstream15:09
juergbiit copies the install-root of every built element into /15:09
juergbii.e., it doesn't necessarily stage them the same way as bst15:10
juergbicould be an issue with conflicting elements or with configure scripts that autodetect libraries (so it behaves differently when additional libraries are staged)15:11
juergbiand the use of some external 'stage2' as bootstrap can also influence the build, though. and that simply gets overwritten more and more15:12
tlaterjuergbi: Tristan decided we didn't want to focus too much on that, and that that was good enough, but yeah, this was a discussion. Perhaps leave an issue?15:12
tlaterThe stage2 is intentionally overwritten though - The stage2 binaries are supposed to be replaced by natively built elements.15:13
juergbiit would be nice to get closer to regular bst behavior but there might well be more pressing matters15:13
juergbiyes, just mentioning it as potential difference15:13
juergbii'm wondering whether we couldn't simply place the source of the lowest level element of the stack (pretty much has to be an import element) in the root of the tarball15:14
juergbiideally, we would probably even use chroot in the script for each element15:14
juergbiand stage dependencies the same way as regular bst15:14
juergbiintegration commands also appear to be missing15:15
tlaterThe scripts call ldconfig after each build instead15:15
juergbiyes, i saw that. may or may not be sufficient15:16
juergbiif it's just meant for bootstrapping a new system, it might be ok15:16
tlaterYup, definitely.15:16
tlaterAs in, might not be sufficient15:17
tlaterx)15:17
tlaterjuergbi: Can the build cache key and the WEAK cache key ever overlap?15:26
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 1 commit (last: tarcache.py: Add tarfile fallbacks) https://gitlab.com/BuildStream/buildstream/commit/ba35d0d940713952329365f1a1ad52749eff4b4316:02
*** ssam2 has quit IRC17:00
gitlab-br-botpush on buildstream@cross_platform (by Tristan Maat): 20 commits (last: Add `bst pull` command) https://gitlab.com/BuildStream/buildstream/commit/39696b17ec1410f0110e5c3c7a0510a8151b57ac17:06
*** anahuelamo has quit IRC17:38
bochechahopefully I've got the pip element tests working now :)17:55
bochecharunning the complete set of tests, just to make sure I didn't break anything17:55
juergbitlater: yes, mainly when there are no build dependencies, the two cache keys are the same18:04
juergbibochecha: sorry about the misleading comment, i forgot that it was auto-generated18:05
gitlab-br-botbuildstream: merge request (pip->master: Add a pip element) #75 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/7518:05
bochechajuergbi: no problem :)18:05
bochechajust figured it out while the tests are running18:05
bochechajuergbi: I just pushed to the branch, it should have all your comments fixed18:06
bochechajuergbi: and thanks for having reviewed so quickly :)18:06
*** tlater has quit IRC18:08
*** bochecha_ has joined #buildstream18:10
*** bochecha has quit IRC18:12
*** bochecha_ is now known as bochecha18:12
gitlab-br-botpush on buildstream@master (by Jürg Billeter): 2 commits (last: makemaker.py: Fix typo in comment) https://gitlab.com/BuildStream/buildstream/commit/5e70714f963013c3ccab8e084ca7adda781f361818:50
gitlab-br-botbuildstream: merge request (pip->master: Add a pip element) #75 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/7518:51
*** bochecha_ has joined #buildstream19:01
*** bochecha has quit IRC19:01
*** bochecha_ is now known as bochecha19:02

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!