| *** tristan has joined #buildstream | 04:14 | |
| *** jude has joined #buildstream | 07:10 | |
| *** jonathanmaw has joined #buildstream | 08:11 | |
| jonathanmaw | morning tristan, I'm liking these specific issues in the review. Just gotten as far as rewriting the docstring for scriptelement.py | 08:28 |
|---|---|---|
| tristan | jonathanmaw, yeah almost every comment I think was docs related, code is pretty great :) | 08:29 |
| tristan | I think I just finished adding comments only 5 minutes ago haha | 08:29 |
| jonathanmaw | hmm, gitlab seems to be eating my replies to your comments :/ | 08:31 |
| jonathanmaw | I was just saying I'm making validate_layout() private, but calling it in scriptelement.py's preflight. | 08:32 |
| tristan | nod :) | 08:32 |
| tristan | I dont know whats up with gitlab, I think I had an issue and page refresh fixed it | 08:33 |
| tristan | jonathanmaw, it's possible the comment reply was submitted but just not updated in your local view | 08:33 |
| jonathanmaw | tristan: refreshing the page hasn't made it appear | 08:33 |
| jonathanmaw | I'm sure it'll eventually appear. maybe the backend is being sluggish. | 08:34 |
| *** jude has quit IRC | 08:37 | |
| *** jude has joined #buildstream | 08:37 | |
| *** ssam2 has joined #buildstream | 08:37 | |
| tristan | oh thats possible | 08:38 |
| jonathanmaw | tristan: in x86image.py, perhaps I should move the explanation of "base" and "input" into the yaml | 09:14 |
| tristan | jonathanmaw, agreed :) | 09:18 |
| tristan | Since they are all this way | 09:19 |
| gitlab-br-bot | buildstream: merge request (jonathan/enhance-script-element->master: Jonathan/enhance script element) #22 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/22 | 09:44 |
| gitlab-br-bot | buildstream: merge request (jonathan/enhance-script-element->master: Jonathan/enhance script element) #22 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/22 | 09:47 |
| gitlab-br-bot | buildstream: merge request (jonathan/enhance-script-element->master: Jonathan/enhance script element) #22 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/22 | 10:03 |
| gitlab-br-bot | push on buildstream@master (by Tristan Van Berkom): 1 commit (last: Jonathan/enhance script element) https://gitlab.com/BuildStream/buildstream/commit/d39122416192c94fa1deef5053b5e288f8bbf826 | 10:41 |
| tristan | Oh crap | 10:41 |
| gitlab-br-bot | buildstream: merge request (jonathan/enhance-script-element->master: Jonathan/enhance script element) #22 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/22 | 10:41 |
| tristan | gitlab added a "feature" and enabled it ! | 10:41 |
| tristan | not a huge deal this time, but let me see if I can disable it | 10:41 |
| tristan | damn, well I better just be careful when hitting the "Merge" button and uncheck the obnoxiously horrible "squash commits" checkbox every time | 10:45 |
| tristan | on the bright side | 10:46 |
| tristan | The eagle has landed \o/ !!! | 10:46 |
| tristan | Great work jonathanmaw :) | 10:46 |
| *** tristan has quit IRC | 10:52 | |
| *** tristan has joined #buildstream | 11:45 | |
| *** ChanServ sets mode: +o tristan | 11:50 | |
| gitlab-br-bot | push on buildstream@master (by Tristan Van Berkom): 3 commits (last: x86image.yaml: Removed root-read-only configuration) https://gitlab.com/BuildStream/buildstream/commit/4a60a6c3fd877dbaedd132c74cee15f630cb3e99 | 11:50 |
| jonathanmaw | thanks tristan | 11:50 |
| jonathanmaw | I'll look into https://gitlab.com/BuildStream/buildstream/issues/10 next | 11:51 |
| *** tristan has quit IRC | 12:01 | |
| *** tristan has joined #buildstream | 12:03 | |
| gitlab-br-bot | buildstream: issue #16 ("Enhanced Script Base Element") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/16 | 12:03 |
| *** ChanServ sets mode: +o tristan | 12:03 | |
| * tristan had a sudden reboot :-S | 12:04 | |
| gitlab-br-bot | buildstream: issue #17 ("Reusable Image Deployment Element") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/17 | 12:04 |
| tristan | jonathanmaw, ok so dont do that | 12:05 |
| tristan | jonathanmaw, that is a huge pain and not relevant really | 12:05 |
| tristan | it would be great to have but we dont have budget for it | 12:05 |
| jonathanmaw | ah, ok | 12:06 |
| tristan | as we discussed yesterday... we want to start with a build element that does like other build elements, but uses the dpkg stuff to get a build done (the building part of creating a package, via it's rules file) | 12:07 |
| jonathanmaw | shall I create an issue for dpkg build element? | 12:08 |
| tristan | jonathanmaw, I'm ambivalent, but sure :) | 12:45 |
| jonathanmaw | tristan: I've created https://gitlab.com/BuildStream/buildstream/issues/37. I'd add the enhancement tag, but I'm not sure how to add tags to issues | 12:49 |
| tristan | jonathanmaw, there is a tags thingy in the right hand pane when looking at the issue iirc | 12:50 |
| jonathanmaw | tristan: there's a Labels section in the sidebar, but that doesn't give me an option of adding one | 12:54 |
| jonathanmaw | must be a permissions thing | 12:54 |
| gitlab-br-bot | buildstream: issue #37 ("dpkg build element") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/37 | 12:58 |
| tristan | jonathanmaw, sure ? | 13:09 |
| tristan | maaaybe | 13:09 |
| tristan | jonathanmaw, when you click the labels icon and the sidebar slides in, no "Assign Labels" box appears there ? | 13:10 |
| tristan | Ok, strange | 13:10 |
| tristan | jonathanmaw, I just added you as a developer to the BuildStream group | 13:11 |
| tristan | that should change that permissions I think | 13:12 |
| jonathanmaw | tristan: yep, I can now assign labels! | 13:13 |
| tristan | :) | 13:13 |
| *** tristan has quit IRC | 13:29 | |
| *** tristan has joined #buildstream | 13:52 | |
| *** ChanServ sets mode: +o tristan | 13:55 | |
| *** jonathanmaw has quit IRC | 17:01 | |
| *** ssam2 has quit IRC | 17:39 | |
| *** JJ has joined #buildstream | 17:45 | |
| *** JJ has quit IRC | 17:46 | |
| *** jude has quit IRC | 17:48 | |
| *** jude has joined #buildstream | 18:27 | |
| *** jude has quit IRC | 19:07 | |
| *** tristan has quit IRC | 19:42 | |
| *** jude has joined #buildstream | 20:21 | |
| *** jude has quit IRC | 21:15 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!